[PATCH 059/107] staging: comedi: ni_stc.h: tidy up AO_Mode_3_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 20 ++-- drivers/staging/comedi/drivers/ni_stc.h| 22 +++--- 2

[PATCH 068/107] staging: comedi: ni_stc.h: tidy up RTSI_Board_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 10 +- drivers/staging/comedi/drivers/ni_stc.h| 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 095/107] staging: comedi: ni_stc.h: tidy up DAC_FIFO_Data register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- drivers/staging/comedi/drivers/ni_stc.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 075/107] staging: comedi: ni_stc.h: tidy up AI_Status_2_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- drivers/staging/comedi/drivers/ni_stc.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 085/107] staging: comedi: ni_stc.h: remove unused GPCT register bit defines

2015-05-01 Thread H Hartley Sweeten
The bit defines in this header for the GPCT registers are not used. The ones in ni_tio_internal.h are used instead. Remove them from this header. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_stc.h | 68

[PATCH 079/107] staging: comedi: ni_stc.h: tidy up G_Save_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and define the G0 and G1 registers to add clarity to the mio_regmap tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 8 drivers/staging/comedi/drivers/ni_stc.h| 7

[PATCH 086/107] staging: comedi: ni_stc.h: tidy up Window_{Address, Data} defines

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 8 drivers/staging/comedi/drivers/ni_stc.h| 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 097/107] staging: comedi: ni_mio_common: remove BUG_ON(gpct_index ...) checks

2015-05-01 Thread H Hartley Sweeten
The gpct_index will always be 0 or 1. Remove the unnecessary BUG_ON() checks. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 -- drivers/staging/comedi/drivers/ni_stc.h| 2 -- 2 files changed, 4 deletions

[PATCH 087/107] staging: comedi: ni_stc.h: tidy up XXX_Status register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 7 --- drivers/staging/comedi/drivers/ni_stc.h| 10 +++--- 2 files changed, 7 insertions

[PATCH 092/107] staging: comedi: ni_stc.h: tidy up Configuration_Memory_Low register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 9 + drivers/staging/comedi/drivers/ni_stc.h| 12 ++-- 2 files changed, 11

[PATCH 105/107] staging: comedi: ni_stc.h: tidy up the cs5529_command_bits

2015-05-01 Thread H Hartley Sweeten
For aesthetics, convert the enum into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 12 ++-- drivers/staging/comedi/drivers/ni_stc.h| 25

[PATCH 078/107] staging: comedi: ni_stc.h: tidy up G_HW_Save_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and define the G0 and G1 registers to add clarity to the mio_regmap tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 8 drivers/staging/comedi/drivers/ni_stc.h| 6 +++--- 2

[PATCH 083/107] staging: comedi: ni_stc.h: tidy up Joint_Status_2_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 8 drivers/staging/comedi/drivers/ni_stc.h| 8 +++- 2 files changed, 7 insertions

[PATCH 089/107] staging: comedi: ni_stc.h: tidy up Misc_Command register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- drivers/staging/comedi/drivers/ni_stc.h| 6 +- 2 files changed, 6 insertions(+), 2

[PATCH 091/107] staging: comedi: ni_stc.h: tidy up ADC_FIFO_Data_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++--- drivers/staging/comedi/drivers/ni_stc.h| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 088/107] staging: comedi: ni_stc.h: tidy up Serial_Command register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 34 +++--- drivers/staging/comedi/drivers/ni_stc.h| 8 -- 2 files changed

[PATCH 096/107] staging: comedi: ni_stc.h: tidy up DAC[01]_Direct_Data registers

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the defines into a macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- drivers/staging/comedi/drivers/ni_stc.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

[PATCH 093/107] staging: comedi: ni_stc.h: tidy up Configuration_Memory_High register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 10 +- drivers/staging/comedi/drivers/ni_stc.h| 18 +++--- 2 files changed, 12

[PATCH 100/107] staging: comedi: ni_mio_common: move ni_stc_dma_channel_select_bitfield()

2015-05-01 Thread H Hartley Sweeten
Move this inline helper function from ni_stc.h. It does not need to be exposed outside of this file. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 11 +++ drivers/staging/comedi/drivers/ni_stc.h| 12

[PATCH 107/107] staging: comedi: ni_stc.h: final cleanup

2015-05-01 Thread H Hartley Sweeten
1) Move the enum's to a better location and tidy up the whitespace. 2) Tidy up the defines used for some array sizes in the private data. 3) Add comments for the spinlock_t variables in the private data. 4) Move the forward declaration to the end of the file. Signed-off-by: H Hartley Sweete

[PATCH 094/107] staging: comedi: ni_stc.h: tidy up AO_Configuration register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 16 drivers/staging/comedi/drivers/ni_stc.h| 14 +++--- 2 files changed

[PATCH 101/107] staging: comedi: ni_stc.h: remove unused _bit* defines

2015-05-01 Thread H Hartley Sweeten
Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_stc.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_stc.h b/drivers/staging/comedi/drivers/ni_stc.h index dc95e6a..4f4a902

[PATCH 099/107] staging: comedi: ni_stc.h: tidy up G0_G1_Select register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Convert the inline helper functions into macros. Tidy up the driver code to use the new macros. For consistency, make the ni_set_gpct_dma_channel() helper follow the same style as the ni_set_ai_dma_channel() and ni_set_ao_dma_channel() helpers. Signed-off-by: H Hartley

[PATCH 098/107] staging: comedi: ni_stc.h: tidy up AI_AO_Select register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into macros. Tidy up the driver code to use the new macros. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 28 +++--- drivers/staging/comedi/drivers

[PATCH 080/107] staging: comedi: ni_stc.h: tidy up AO_*_Save_Registers

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++--- drivers/staging/comedi/drivers/ni_stc.h| 8 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 102/107] staging: comedi: ni_stc.h: rename the NI-611x register defines

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 34 ++ drivers/staging/comedi/drivers/ni_stc.h| 23 - 2 files changed, 30 insertions(+), 27

[PATCH 103/107] staging: comedi: ni_stc.h: rename the NI-6143 register defines

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 54 --- drivers/staging/comedi/drivers/ni_pcimio.c | 15 +++ drivers/staging/comedi/drivers/ni_stc.h| 60

[PATCH 090/107] staging: comedi: ni_stc.h: tidy up 8255 register defines

2015-05-01 Thread H Hartley Sweeten
Only the 'Port_A' define is used. Rename the CamelCase and remove the unused defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++- drivers/staging/comedi/drivers/ni_stc.h| 10 ++---

[PATCH 104/107] staging: comedi: ni_stc.h: tidy up the cs5529_configuration_bits

2015-05-01 Thread H Hartley Sweeten
For aesthetics, convert the enum into defines and the inline functions into macros. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 8 ++-- drivers/staging/comedi/drivers

[PATCH 106/107] staging: comedi: ni_stc.h: tidy up the windowed_regs_67xx_61xx

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. For aesthetics, convert the enum into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 51 + drivers/staging/comedi/drivers

[PATCH] staging: comedi: ni_mio_common: fix build warning

2015-05-11 Thread H Hartley Sweeten
ine removed. Not sure why it even builds on my test system... Reported-by: kbuild test robot Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

[PATCH 10/47 v2] staging: comedi: pcmad: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmad.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH 19/47 v2] staging: comedi: das08: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das08.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 14/47 v2] staging: comedi: aio_aio12_8: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_aio12_8.c | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a

[PATCH 02/47 v2] staging: comedi: skel: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Since this is the sample skeleton driver, add comments about how the callback function works with comedi_timeout(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 16/47 v2] staging: comedi: cb_pcidas: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 33/47 v2] staging: comedi: dyna_pci10xx: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Also, remove some unnecessary comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 40 --- 1 file changed, 24

[PATCH 25/47 v2] staging: comedi: addi_apci_3xx: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input and output end-of- conversions. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers

[PATCH 20/47 v2] staging: comedi: das16m1: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16m1.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 07/47 v2] staging: comedi: mf6x4: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mf6x4.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/staging

[PATCH 01/47 v2] staging: comedi: introduce comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
It also creates a common errno for comedi to detect when a timeout occurs. ADC/DAC conversion times are typically pretty fast, usually around 100K samples/sec (10 usec). A conservative timeout of 1 second is used in comedi_timeout(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 08/47 v2] staging: comedi: ni_labpc: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/staging

[PATCH 29/47 v2] staging: comedi: adl_pci9118: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 34 ++-- 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a

[PATCH 03/47 v2] staging: comedi: adl_pci6208x: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci6208.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 09/47 v2] staging: comedi: pcl711: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl711.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH 21/47 v2] staging: comedi: dt2811: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2811.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH 17/47 v2] staging: comedi: cb_pcidas64: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 44 +--- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a

[PATCH 06/47 v2] staging: comedi: ii_pci20kc: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ii_pci20kc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH 23/47 v2] staging: comedi: mpc624: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 00/47 v2] staging: comedi: cleanup the "timeout" loops

2014-02-10 Thread H Hartley Sweeten
drop the patch to das1800 4) add subdevice number to dev_dbg() timeout messages H Hartley Sweeten (47): staging: comedi: introduce comedi_timeout() staging: comedi: skel: use comedi_timeout() staging: comedi: adl_pci6208x: use comedi_timeout() staging: comedi: das16: use comedi_timeout()

[PATCH 31/47 v2] staging: comedi: adq12b: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. This also fixes a possible bug where invalid data is returned if the conversion did not complete. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 31

[PATCH 35/47 v2] staging: comedi: multiq3: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 38 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a

[PATCH 12/47 v2] staging: comedi: dt2815: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2815.c | 39 ++--- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a

[PATCH 38/47 v2] staging: comedi: s626: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi

[PATCH 28/47 v2] staging: comedi: adl_pci9111: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 36 +++- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a

[PATCH 11/47 v2] staging: comedi: pcmmio: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 42 +++-- 1 file changed, 24 insertions(+), 18 deletions(-) diff

[PATCH 04/47 v2] staging: comedi: das16: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH 13/47 v2] staging: comedi: rti800: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned for an overrun from -EIO to -EOVERFLOW. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti800.c | 29 + 1 file

[PATCH 36/47 v2] staging: comedi: ni_daq_700: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_daq_700.c | 53 ++--- 1 file changed, 33 insertions(+), 20 deletions(-) diff --git a

[PATCH 30/47 v2] staging: comedi: adv_pci1710: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 38 +--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a

[PATCH 26/47 v2] staging: comedi: ni_at_a2150: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 42 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a

[PATCH 22/47 v2] staging: comedi: me_daq: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 35 ++--- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a

[PATCH 15/47 v2] staging: comedi: cb_das16_cs: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_das16_cs.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 24/47 v2] staging: comedi: s526: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/s526.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 34/47 v2] staging: comedi: icp_multi: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input and output end-of- conversion. Use break to exit the loop when a timeout occurs during the analog input read so that common code can be used to disable the device. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 47/47 v2] staging: comedi: don't clear 'data' on (*insn_read) timeout

2014-02-10 Thread H Hartley Sweeten
It's not necessary to clear the returned data pointer when an (*insn_read) times out. For aesthetics, remove all of these in the drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 1 - drivers/staging/c

[PATCH 05/47 v2] staging: comedi: das800: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das800.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 41/47 v2] staging: comedi: pcl812: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Combine the logic for the pcl812 and acl812 end-of-conversion in the helper function to simplify the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c

[PATCH 18/47 v2] staging: comedi: cb_pcimdas: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Remove the unnecessary comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 35 - 1 file changed, 19 insertions

[PATCH 37/47 v2] staging: comedi: rtd520: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 84 +++-- 1 file changed, 38 insertions(+), 46 deletions(-) diff

[PATCH 46/47 v2] staging: comedi: move (*insn_{read, write}) timeout debug messages to core

2014-02-10 Thread H Hartley Sweeten
Have the comedi core display a standard dev_dbg() message when a timeout occurs and remove all the driver specific messages. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi_fops.c | 13 - drivers/staging/comedi

[PATCH 32/47 v2] staging: comedi: amplc_pci230: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci230.c | 32 +++ 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a

[PATCH 27/47 v2] staging: comedi: ni_atmio16d: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned when the conversion overflows from -ETIME to -EOVERFLOW. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio16d.c | 52

[PATCH 42/47 v2] staging: comedi: pcl816: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 45 - 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a

[PATCH 44/47 v2] staging: comedi: dt2814: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2814.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 43/47 v2] staging: comedi: pcl818: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 35 +++-- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a

[PATCH 39/47 v2] staging: comedi: dt282x: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
27;insn' is not available here but passing NULL is safe because nothing uses it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 68 - 1 file changed, 42 insertions(+), 26 deletions(-)

[PATCH 45/47 v2] staging: comedi: dmm32at: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
e test function, and comedi_timeout() don't use it. Use comedi_timout() to wait for the analog output end-of-conversion. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 83 +++- 1 file chan

[PATCH 40/47 v2] staging: comedi: daqboard2000: use comedi_timeout()

2014-02-10 Thread H Hartley Sweeten
id data is returned for the analog input read if the conversion did not complete, The analog output has a similar possible bug where the cached readback value is incorrect if the conversion times out. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/come

[PATCH 8/9] staging: comedi: pcl812: trigger sources were validated in (*do_cmdtest)

2014-02-10 Thread H Hartley Sweeten
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Remove the unnecessary checks in pcl812_ai_cmd(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 18 -- 1 file

[PATCH 0/9] staging: comedi: remove some async command cruft

2014-02-10 Thread H Hartley Sweeten
cb_das16_cs driver has a (*do_cmdtest) but it's (*do_cmd) just returns -EINVAL and the interrupt handler does nothing. Remove the async command support from this driver. H Hartley Sweeten (9): staging: comedi: usbduxfast: 'cmd->chanlist_len' was already validataed staging: comedi:

[PATCH 7/9] staging: comedi: das800: trigger sources are validated in (*do_cmdtest)

2014-02-10 Thread H Hartley Sweeten
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in das800_ai_do_cmd() to use if/else instead of the switch since the default cases can never be reached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 2/9] staging: comedi: usbduxfast: remove TRIG_TIMER from scan_begin_src

2014-02-10 Thread H Hartley Sweeten
Currently the (*do_cmdtest) indicates that TRIG_TIMER is a valid scan_begin_src but later this source is tested as -EINVAL. To simplify the code a bit just remove the TRIG_TIMER source. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 3/9] staging: comedi: adl_pci9111: trigger sources are validated in (*do_cmdtest)

2014-02-10 Thread H Hartley Sweeten
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in pci9111_ai_do_cmd() to use if/else instead of the switch since the default cases can never be reached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 6/9] staging: comedi: comedi_test: trigger sources are validated in (*do_cmdtest)

2014-02-10 Thread H Hartley Sweeten
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in waveform_ai_cmd() to remove the final else which can never be reached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi

[PATCH 4/9] staging: comedi: cb_das16_cs: remove incomplete async command support

2014-02-10 Thread H Hartley Sweeten
This driver has a (*do_cmdtest) function for analog input async command support but the (*do_cmd) function just returns -EINVAL. Remove the incomplete async command support. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers

[PATCH 5/9] staging: comedi: cb_pcidas: trigger sources are validated in (*do_cmdtest)

2014-02-10 Thread H Hartley Sweeten
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Refactor the code in cb_pcidas_ai_cmd() to remove the final else which can never be reached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi

[PATCH 1/9] staging: comedi: usbduxfast: 'cmd->chanlist_len' was already validataed

2014-02-10 Thread H Hartley Sweeten
Remove the unnecessary check of 'cmd->chanlist_len > 0'. The (*do_cmdtest) already validated this before the (*do_cmd) was called. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 40 ++---

[PATCH 9/9] staging: comedi: pcl816: trigger sources were validated in (*do_cmdtest)

2014-02-10 Thread H Hartley Sweeten
The trigger sources were already validataed in the (*do_cmdtest) before the (*do_cmd) is called. Remove the unnecessary checks in pcl816_ai_cmd(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 9 - 1 file changed

[PATCH 10/87] staging: comedi: pcl816: remove 'i8254_osc_base' from boardinfo

2014-02-17 Thread H Hartley Sweeten
The 'i8254_osc_base' is the same for all board types. Remove this data from the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 27/87] staging: comedi: pcl812: tidy up differential ai user option

2014-02-17 Thread H Hartley Sweeten
flag to determine if the ai is single-ended or differential and set the subdev_flags and n_chan. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 77 + 1 file changed, 29 insertions(+), 48 deleti

[PATCH 43/87] staging: comedi: pcl812: remove 'ai_is16b' from private data

2014-02-17 Thread H Hartley Sweeten
We can check the subdevice 'maxdata' to determine if the analog input data is 12 or 16-bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 19/87] staging: comedi: pcl812: tidy up digital subdevice boardinfo

2014-02-17 Thread H Hartley Sweeten
w boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 60 - 1 file changed, 21 insertions(+), 39 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging

[PATCH 38/87] staging: comedi: pcl818: remove 'ao_maxdata' from boardinfo

2014-02-17 Thread H Hartley Sweeten
All the board types have 12-bit analog outputs. Remove this data from the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH 29/87] staging: comedi: pcl818: remove 'n_ranges' from boardinfo

2014-02-17 Thread H Hartley Sweeten
This member in the boardinfo is not used. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi

[PATCH 36/87] staging: comedi: pcl818: clarify irq request in pcl818_attach()

2014-02-17 Thread H Hartley Sweeten
All the board types can use IRQ 2-7 for async command support. Remove the 'IRQbits', which is a mask of the valid IRQs, from the boardinfo and refactor pcl818_attach(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl

[PATCH 18/87] staging: comedi: pcl818: change 'is_818' in boardinfo to a bit-field

2014-02-17 Thread H Hartley Sweeten
Change this flag in the boardinfo into a bit-field. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging

[PATCH 07/87] staging: comedi: pcl816: remove 'io_range' from boardinfo

2014-02-17 Thread H Hartley Sweeten
The 'io_range' is the same for all board types. Remove this data from the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drive

[PATCH 21/87] staging: comedi: pcl816: all board types have digital inputs and outputs

2014-02-17 Thread H Hartley Sweeten
All the board types have 16 digital inputs and 16 digital outputs. Remove the 'n_dichan' and 'n_dochan' members in the boardinfo. The subdevice support code is currently incomplete in this driver. For now just tidy up the incomplete subdevice code in pcl816_attach(). Sign

[PATCH 06/87] staging: comedi: pcl812: remove 'io_range' from boardinfo

2014-02-17 Thread H Hartley Sweeten
The 'io_range' is the same for all board types. Remove this data from the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) di

<    4   5   6   7   8   9   10   11   12   13   >