On Tuesday, November 26, 2013 4:42 PM, H Hartley Sweeten wrote:
> Tidy up the code that does the request_irq().
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ian Abbott
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/comedi/drivers/pcl816.c | 33
> ++-
On Tuesday, December 03, 2013 10:18 AM, gre...@linuxfoundation.org wrote:
> On Wed, Nov 27, 2013 at 05:33:40PM +0000, Hartley Sweeten wrote:
>> Can I just fix this patch (51/60) and repost it or would you prefer to
>> take patches 1-50 and have me repost 51-60 after fixing this one
On Wednesday, December 04, 2013 4:47 AM, Ian Abbott wrote:
> On 2013-12-03 19:07, H Hartley Sweeten wrote:
>> The comedi subsystem only requires the drivers to support interrupts if one
>> or more of the subdevices support async commands. Since this is optional:
>>
>>
On Thursday, December 05, 2013 4:54 PM, H Hartley Sweeten wrote:
> Subject: [PATCH 10/13] staging: comedi: pcmuio: fix types of some private
> data variables
Oops.. This one got posted twice. Sorry about that.
Hartley
___
devel mailing l
On Friday, December 06, 2013 1:19 AM, Dan Carpenter wrote:
>
> Signed-off-by is missing.
Oops... Just reposted that patch with the sign off.
Sorry about that,
Hartley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproje
On Friday, December 06, 2013 3:34 AM, Ian Abbott wrote:
> On 2013-12-05 20:43, H Hartley Sweeten wrote:
[snip]
>> +irq = mite_irq(devpriv->mite);
>> +if (irq) {
>> +ret = request_irq(irq, nidio_interrupt, IRQF_SHARED,
>> +
On Tuesday, December 10, 2013 4:48 AM, Bernd Porr wrote:
> I've just checked out after a while the newest RC kernel and the
> usb-auto config/attach is broken. Seems so that the driver specific usb
> attach is no longer called and no firmware is loaded. Hartly, can you
> point me to the code bit
(ret < 0)
> dev_err(dev->class_dev, "can not start firmware\n");
> + ret = 0;
>
> done:
> kfree(tmp);
This would only fix the usbduxfast driver.
I think Ian's comment about fixing comedi_load_firmware() is the correct
one. This should do it:
On Tuesday, December 10, 2013 4:29 PM, Bernd Porr wrote:
>
> Agree with your comments. Let's just do the
>
> return ret < 0 ? ret : 0;
>
> and it's sorted. Thanks for the quick reply.
Ok. I'll post this as a proper patch in a sec.
Hartley
___
devel mai
_pci.c | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Thanks,
Acked-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tuesday, December 17, 2013 10:58 AM, gre...@linuxfoundation.org wrote:
> On Tue, Dec 10, 2013 at 10:58:59AM +, Ian Abbott wrote:
>> On 2013-12-09 22:30, H Hartley Sweeten wrote:
>>>There is only one ai subdevice in this driver so there is no reason
>>>to hold the
On Sunday, December 22, 2013 1:30 PM, Bernd Porr wrote:
>
> Hi all,
>
> I've added a success / fail message to comedi autoconfig. That's badly
> needed to see which driver has been associated with which comedi dev in
> udev. Also, as far as I know an error in the USB probe callback won't
> caus
On Monday, December 23, 2013 9:51 AM, Bernd Porr wrote:
> Hi Hartley,
Please don't top-post. ;-)
> it's essentially what I've also written within the patch but I can make
> the comment in the patch a bit meatier if you want. However, I'm
> travelling now and won't be able to work on it till ne
s/staging/comedi/drivers/pcmmio.c | 23 +--
> 1 file changed, 13 insertions(+), 10 deletions(-)
Hello Chase,
This was already fixed, and merged into linux-next, by
commit 4bb82d647dad7be06341ffdb9f07a56a387e213f
Author: H Hartley Sweeten
Date: Tue Nov 26 10:21:23 2013 -0700
On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
>
> create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
Hello Rostislav,
As pointed out by Dan Carpenter, you need to add a change log and
Signed-off-by lines to this patch.
Overall this looks pretty good. Comments below.
> di
On Tuesday, January 14, 2014 8:59 PM, Greg KH wrote:
> Sleep for at least 10, as I think that's the smallest time delay you can
> sleep for anyway (meaning it will be that long no matter what number you
> put there less than 10, depending on the hardware used of course.)
A bit off topic here but I
On Wednesday, January 15, 2014 10:52 AM, Chase Southwood wrote:
> This patch for ni_mio_common.c changes out a while loop for a timeout,
> which is preferred.
>
> Signed-off-by: Chase Southwood
> ---
>
> 2: Changed from simple clean-up to swapping a timeout in for a while loop.
>
> 3: Removed extr
On Monday, January 20, 2014 11:06 AM, Greg KH wrote:
> On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote:
>> On Thu, Jan 16, 2014 at 1:41 PM, Greg KH wrote:
>>> On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote:
>> There is no way to detect FPGA until it is programmed.
>>
Hello all,
I'm in the process of cleaning up all the "timeout" code in the
comedi drivers. The general form of the timeout code in all
the drivers is:
static int foo_eoc(struct comedi_device *dev, unsigned long timeout)
{
unsigned int status;
while (timeout--) {
s
On Wednesday, February 05, 2014 10:40 AM, Greg KH wrote:
> On Tue, Feb 04, 2014 at 06:59:43PM +0000, Hartley Sweeten wrote:
>> I'm in the process of cleaning up all the "timeout" code in the
>> comedi drivers. The general form of the timeout code in all
>&g
On Saturday, April 26, 2014 7:04 AM, Christian Engelmayer wrote:
> Some board pointer are assigned twice via comedi_board() in the comedi low
> level driver attach functions. Remove the duplicate assignment from the
> variable definition where the pointer is not used anyway until assigned later
> i
On Tuesday, April 29, 2014 7:52 AM, Ian Abbott wrote:
> On 2014-04-28 19:53, H Hartley Sweeten wrote:
>> The analog input async command can use the pacer for the scan_bagin_src
>> or the convert_src. The (*do_cmdtest) validates that only one of these
>> sources has the TR
On Tuesday, April 29, 2014 12:59 PM, H Hartley Sweeten wrote:
> Remove some unnecessary pacer divisor calculations. The divisors are
> calculated
> as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
>
> Remove the older, unused, divisor calc functions in
y: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> ---
> 2: Incorrect patch title fixed.
>
> Ian and Hartley,
>
> The auto_attach() function is starting to look much better now. My next
> patchset
> will be geared towards only allocating subdevices which
On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote:
> On 2014-04-29 20:59, H Hartley Sweeten wrote:
>> Remove some unnecessary pacer divisor calculations. The divisors are
>> calculated
>> as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
>&g
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
> Thanks so much, I greatly appreciate the review. I'll fix the
> changelog for patch 4 and send once more (as I assume that's easier
> for Greg). Also, I should know better about the cover letter as
> well...I was once told not to sen
On Thursday, May 01, 2014 2:46 AM, Ian Abbott wrote:
> On 2014-04-30 17:46, Hartley Sweeten wrote:
>> On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote:
>>> As a side node, I wonder if it's worth stripping out those `|
>>> I8254_BINARY` bits as it's basica
/8253.h| 4 ++--
> drivers/staging/comedi/drivers/amplc_dio200_common.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
gt; 18) staging: comedi: pass subdevice to comedi_buf_write_n_available()
> 19) staging: comedi: mite: pass subdevice to mite_buf_change()
> 20) staging: comedi: mite: pass subdevice to mite_sync_input_dma()
> 21) staging: comedi: mite: pass subdevice to mite_sync_output_dma()
> 22) staging: c
--
> 2 files changed, 45 insertions(+), 85 deletions(-)
Looks good.
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tuesday, May 06, 2014 2:59 AM, Ian Abbott wrote:
> On 2014-05-05 17:48, H Hartley Sweeten wrote:
>> This member of the subdevice private data can be determined from the
>> cmd->stop_src. Do that instead.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: I
On Tuesday, May 06, 2014 3:46 AM, Ian Abbott wrote:
> On 2014-05-05 17:59, H Hartley Sweeten wrote:
>> Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
>> scan_begin_arg when the scan_begin_src is TRIG_TIMER.
>>
>> For aesthetics reasons, rename the l
be removed.
>
> v2: Rebased to current staging-next due to merge conflicts. The first
> two patches from v1 have already been applied, so the ordinals of
> the remaining patches have been shuffled down two places.
Reviewed-by: H Hartley Sweeten
__
-
> 1 file changed, 10 insertions(+), 30 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
e on it.
>
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> Signed-off-by: Chase Southwood
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
e on it.
>
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> Signed-off-by: Chase Southwood
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wednesday, May 28, 2014 3:22 AM, Ian Abbott wrote:
> On 2014-05-27 18:31, H Hartley Sweeten wrote:
>> THe comedi core ensures that the chanlist will be valid for any async
>> operation
>> other than Step 1 of the (*do_cmdtest) to get the trigger source masks.
>>
drivers/staging/comedi/drivers/ni_daq_700.c | 53
> +++--
> 1 file changed, 43 insertions(+), 10 deletions(-)
Ian,
I couple nitpicks on this patch but nothing big. Ignore all of these
comments if you wish.
Reviewed-by: H Hartley Sweeten
> diff --git a/drivers/stagin
he "Description:" line as it also
> supports analog inputs.
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers/ni_daq_700.c | 51
> ++---
> 1 file changed, 25 insertions(+), 26 deletions(-)
Reviewed-by: H Hartley Sweeten
_
On Thursday, May 29, 2014 2:58 AM, Ian Abbott wrote:
> On 2014-05-29 00:26, H Hartley Sweeten wrote:
>> Remove all the forward declarations and do a bit of cleanup to this
>> file.
[snip]
>> drivers/staging/comedi/drivers/ni_mio_common.c | 4536
>> -
use comedi_event() to signal the user.
>
> Remove the send_sig() usage in this driver.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> ---
> .../comedi/drivers/addi-data/hwdrv_apci1564.c | 23
> --
> 1 file c
gt; Cc: H Hartley Sweeeten
> ---
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5 -
> 1 file changed, 5 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linu
_common.h, we can create a private data struct specifically for
> addi_apci_1564 containing only the fields it will actually use.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> ---
> .../comedi/drivers/addi-data/hwdrv_apci1564.c | 164
>
DI_SUBD_DI;
> + s->subdev_flags = SDF_READABLE | SDF_CMD_READ;
> + s->n_chan = 1;
> + s->maxdata = 1;
> + s->range_table = &range_digital;
> + s->len_chanlist = 1;
> + } else {
>
async commands.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> ---
>
> The structure of _much_ of this code was taken from/based on the similar
> code found in addi_apci_1032.c. As such, I would appreciate as much
> review I can get to m
ename the variable ui_InterruptStatus_1564 to ctrl, and change the return
> from IRQ_RETVAL(1) to IRQ_HANDLED.
>
> We also check the device is asserting the shared interrupt line and check
> that interrupts have been enabled.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc:
On Wednesday, June 04, 2014 11:17 AM, Ian Abbott wrote:
> On 2014-05-29 18:38, H Hartley Sweeten wrote:
>> Introduce a helper function to return the number of bytes that are
>> ready to read/write from/to the comedi_async buffer. The "write to"
>> use doesn't r
ion I will
rebase
it and repost after Greg opens the staging tree.
---
>From 2a0130631a70cf27195cb1b6bffd0af455dbe5dd Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten
Date: Mon, 5 May 2014 10:23:32 -0700
Subject: [PATCH] staging: comedi: ni_stc.h: cleanup dma channel select
There are a numb
On Tuesday, June 10, 2014 11:56 PM, Dan Carpenter wrote:
> On Tue, Jun 10, 2014 at 10:36:13PM +0000, Hartley Sweeten wrote:
>> On Monday, June 09, 2014 10:48 PM, Dan Carpenter wrote:
>>> On Mon, Jun 09, 2014 at 09:24:35PM -0400, Marcos A. Di Pietro wrote:
>>>> Fixes w
On Friday, June 20, 2014 4:20 AM, Geert Uytterhoeven wrote:
> On Fri, Jun 20, 2014 at 1:12 PM, Ian Abbott wrote:
>>> drivers/staging/comedi/drivers/ni_atmio.c:318:38: error: macro
>>> "writew" passed 3 arguments, but takes just 2
>
>> Thanks, but Hartley has already fixed it and Greg has applied i
On Monday, June 23, 2014 4:57 AM, Ian Abbott wrote:
> On 2014-06-20 20:01, H Hartley Sweeten wrote:
>> On the PCI-1720 board, bipolar analog output ranges use two's
>> complement data. Use comedi_offset_munge() to munge the comedi
>> offset binary values before wr
On Monday, June 23, 2014 8:10 AM, Ian Abbott wrote:
> On 2014-06-20 21:13, H Hartley Sweeten wrote:
>> The DT2821 series board have jumpers that set the output range for
>> the two Analog Output channels. The range_table for the Analog Output
>> subdevice provides all possib
On Wednesday, August 27, 2014 11:00 AM, Ian Abbott wrote:
> On 26/08/14 00:04, H Hartley Sweeten wrote:
>> The comedi core does the sanity checking of the comedi_insn before
>> calling the (*insn_write). Remove the unnecessary checks.
>>
>> Signed-off-by: H Hartley
On Wednesday, August 27, 2014 11:07 AM, Ian Abbott wrote:
> On 27/08/14 19:04, Hartley Sweeten wrote:
>> On Wednesday, August 27, 2014 11:00 AM, Ian Abbott wrote:
>>> On 26/08/14 00:04, H Hartley Sweeten wrote:
>>>> The comedi core does the sanity checking of the c
On Monday, September 01, 2014 4:04 AM, Ian Abbott wrote:
> Continue to clean up the amplc_pci230 driver code and remove the legacy
> attach mechanism, since it isn't very useful for this driver (see PATCH
> 05/28).
Reviewed-by: H H
_boards[]`) only has 2 entries. Return an error from the
> Comedi driver "attach" handler `a2150_attach()` if the probed board
> index is beyond the end of the array.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
_
ibrary may still be trying to
> use them, so hang onto them for now.
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
calls in
> this driver to use dev->class_dev as well, for consistency.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
Hmm.. I thought I caught all of these.
Thanks
Reviewed-by: H Hartley Sweeten
On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote:
> On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote:
>> Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi:
>> amplc_pci230: refactor iobase addresses") removed some parentheses
>> (presumably to keep the line
On Tuesday, September 09, 2014 3:08 AM, Ian Abbott wrote:
> On 2014-09-09 00:18, H Hartley Sweeten wrote:
>> In order for DMA to work we also need an interrupt. Refactor the code
>> so that the DMA allocation is only done if the interrupt is available.
>>
>> Signe
acros
or access functions. The 'board(dev)->foo' ones really made the drivers
hard to read...
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wednesday, September 10, 2014 4:27 AM, Ian Abbott wrote:
> On 2014-09-10 00:15, H Hartley Sweeten wrote:
>> The cmd->stop_src is used to determine how an async command is terminated.
>> Typically the following sources are used:
>>
>>TRIG_NONE: command m
On Wednesday, September 10, 2014 3:56 AM, Ian Abbott wrote:
> On 2014-09-10 00:15, H Hartley Sweeten wrote:
>> The validation of the cmd->stop_arg when the cmd->stop_src == TRIG_EXT
>> is a bit over thought. The comments state that the stop_arg is validated
>> to force a
On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote:
> The `comedi_board` inline function takes a single parameter of type
> `struct comedi_device *` and merely returns the value of the `board_ptr`
> member therein. This is somewhat superfluous as the member can be
> accessed directly.
>
> Re
On Thursday, September 11, 2014 2:38 PM, Greg Kroah-Hartman wrote:
> On Thu, Sep 11, 2014 at 05:57:34PM +0000, Hartley Sweeten wrote:
>> Just wanted to give you a heads up on this series and the ones I have
>> posted. The series are:
>>
>>> From Ian, [PATCH 00/48
ns(+), 21 deletions(-)
Thanks. Know I don't need to look into how to remove the
virt_to_bus()... ;-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ce {
> void (*close)(struct comedi_device *dev);
> };
>
> -static inline const void *comedi_board(const struct comedi_device *dev)
> -{
> - return dev->board_ptr;
> -}
> -
> /*
> * function prototypes
> */
Reviewed-by: H Hartley Sweeten
___
comedi/drivers/addi-data/addi_common.h | 3 +-
> drivers/staging/comedi/drivers/addi_apci_3120.c| 44
> ++++++----
> 3 files changed, 22 insertions(+), 27 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
> All the exported functions in the "comedi_fc" module have been migrated
> to the core "comedi" module and renamed, so it is now just a dummy
> module. Remove it.
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/Kconfig
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
> The "comedi_fc" module contains a few functions useful to Comedi
> drivers. Their functionality is being migrated to the core "comedi"
> module and renamed to start with the prefix `comedi_`. As part of this
> migration, move `cfc_bytes_p
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
> The "comedi_fc" module contains a few functions useful to Comedi
> drivers. Their functionality is being migrated to the core "comedi"
> module and renamed to start with the prefix `comedi_`. As part of this
> migration, move `cfc_inc_sca
On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote:
> The "comedi_fc" module contains a few functions useful to Comedi
> drivers. Their functionality is being migrated to the core "comedi"
> module and renamed to start with the prefix `comedi_`. As part of this
> migration, move `cfc_handle_
-
> drivers/staging/comedi/drivers/comedi_fc.h | 40 ++---
> 7 files changed, 201 insertions(+), 175 deletions(-)
Ian,
Other than I think the comedi_fc.c functions should be migrated to
comedi_buf.c instead of drivers.c I have not problems with this.
And, p
On Tuesday, September 16, 2014 12:44 AM, Ian Abbott wrote:
> On 15/09/14 19:21, Hartley Sweeten wrote:
>> Other than I think the comedi_fc.c functions should be migrated to
>> comedi_buf.c instead of drivers.c I have not problems with this.
>
> I think it's debatable.
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> This series of patches add counter support for NI USB-6501. I tested it on my
> device and it works fine.
I have not taken a good look at this driver yet. I'll try to do it today and
respond to this series.
Thanks,
Hartley
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Rename ni6501_send_command to ni6501_port_command
>
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/comedi/drivers/ni_usb6501.c |8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/com
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/comedi/drivers/ni_usb6501.c | 110
> +++
> 1 file changed, 110 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c
> b/drivers/staging/
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Add function for counter subdevice configuration.
>
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/comedi/drivers/ni_usb6501.c | 28
> +++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/stag
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Add function for reading from counter subdevice.
>
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/comedi/drivers/ni_usb6501.c | 17 +
> 1 file changed, 17 insertions(+)
Ian already addressed my concerns with thi
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Add function for writing to counter subdevice.
>
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/comedi/drivers/ni_usb6501.c | 14 ++
> 1 file changed, 14 insertions(+)
Again, Ian addressed my concerns with this pat
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/comedi/drivers/ni_usb6501.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c
> b/drivers/staging/come
edi/drivers/ni_usb6501.c | 260
> +++
> 1 file changed, 228 insertions(+), 32 deletions(-)
Looks good. Thanks for doing this.
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thursday, September 18, 2014 11:11 AM, H Hartley Sweeten wrote:
> The inline function cfc_handle_events() is just a wrapper around the
> comedi core function comedi_handle_events(). Convert all the drivers
> to use the core function directly and remove the wrapper.
>
> This serie
On Tuesday, September 23, 2014 2:36 AM, abbo...@mev.co.uk wrote:
>
> I will when I get a chance. Having some technical difficulties as
> our office burnt down at the weekend!
Ouch… Sorry to hear that.
Take your time. If it doesn’t make it before Greg closes his tree I will
make sure to either re-
ments PCI-20001C carrier support"
> + depends on HAS_IOMEM
> ---help---
> Enable support for Intelligent Instruments PCI-20001C carrier
> PCI-20001, PCI-20006 and PCI-20341
This seems appropriate.
Reviewed-by: H Hartley Sweeten
_
On Thursday, October 02, 2014 10:26 AM, Rostislav Lisovy wrote:
>
> Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l"
> shows "39" does it mean that this should be added to all the other
> drivers as well?
The others are actually pci_ioremap_bar() and those drivers depend on PCI
On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote:
> `do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly
> call the Comedi subdevice's `do_cmd()` handler with a NULL channel list
> pointer. This is a regression as the `do_cmd()` handler has never been
> expected to deal
On Friday, October 10, 2014 12:33 PM, Bernd Porr wrote:
>
> I've updated my contact details of the driver. I've also tested it
> thoroughly and it works perfectly. I've changed the status to stable.
>
> Signed-off-by: Bernd Porr
On Friday, October 10, 2014 12:34 PM, Bernd Porr wrote:
>
> I've updated my contact details and removed obsolete comments.
>
> Signed-off-by: Bernd Porr
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdrive
On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote:
>
> Updated the range of years, e-mail and added driver desription as
> usually done in comedi.
>
> Signed-off-by: Bernd Porr
Reviewed-by: H Hartley Sweeten
___
devel
On Thursday, October 09, 2014 2:03 AM, Ian Abbott wrote:
> On 09/10/14 00:13, Hartley Sweeten wrote:
>> On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote:
>>> `do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly
>>> call the Comedi subdevice&
On Tuesday, October 14, 2014 9:51 AM, Hartley Sweeten wrote:
> On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote:
>>
>> Updated the range of years, e-mail and added driver desription as
>> usually done in comedi.
>>
>> Signed-off-by: Bernd Porr
>
>
medi/drivers/cb_pcimdas.c | 82
> -
> 2 files changed, 46 insertions(+), 40 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
buf[sizeof(buf) - 1] = 0;
>- strncat(devpriv->name, buf, left);
> + strlcat(devpriv->name, buf,
> + sizeof(devpriv->name));
> }
>
> }
Reviewed-by: H
On Monday, October 20, 2014 7:11 AM, Ian Abbott wrote:
> As a follow-up to commit 6cab7a37f5c04 ("staging: comedi: (regression)
> channel list must be set for COMEDI_CMD ioctl"), Hartley Sweeten pointed
> out another couple of bugs stemming from commit 6cab7a37f5c04
On Tuesday, October 21, 2014 9:29 AM, Ian Abbott wrote:
> On 20/10/14 18:57, H Hartley Sweeten wrote:
>> This driver currently passes the timer "channel" in a manner that violates
>> the comedi API. Fix the timer subdevice so that the timers "channels" are
>&g
On Tuesday, October 21, 2014 9:29 AM, Ian Abbott wrote:
> On 20/10/14 18:57, H Hartley Sweeten wrote:
>> This driver currently passes the timer "channel" in a manner that violates
>> the comedi API. Fix the timer subdevice so that the timers "channels" are
>&g
On Tuesday, October 21, 2014 8:14 AM, Ian Abbott wrote:
> On 20/10/14 18:37, H Hartley Sweeten wrote:
>> According to ADDI-DATA, this board was discontinued last year and they
>> feel that no further development is needed for this driver. Remove the
>> driver from comedi to he
On Wednesday, October 22, 2014 8:18 AM, Ian Abbott wrote:
> On 20/10/14 19:52, H Hartley Sweeten wrote:
>> Introduce a generic method to read samples from the async buffer.
>>
>> The size of each sample is detected automatically using the
>> bytes_per_sample()
>>
On Thursday, October 23, 2014 4:28 AM, Ian Abbott wrote:
> On 22/10/14 23:37, H Hartley Sweeten wrote:
>> Subdevices that set the SDF_PACKED flag return all the scan data in a single
>> sample. The cmd->chanlist_len is used to pass the DIO channel information to
>>
201 - 300 of 4787 matches
Mail list logo
