On Tuesday, October 30, 2018 7:17 AM, Ian Abbott wrote:
> The `insn_read` handler for the EEPROM subdevice (`eeprom_insn_read()`)
> currently
> ignores `insn->n` (the number of samples to be read) and assumes a single
> sample is
> to be read. But `insn->n` could be 0, meaning no samples should
96 insertions(+), 25 deletions(-)
Ian,
If I understand this correctly, the user can now open the "comediX"
device which will give then access to the default dev->read_subdev
and dev->write_subdev. They can then use the new ioctls to change
the read/write subdevice and use
On Wednesday, November 05, 2014 4:25 AM, Ian Abbott wrote:
> On 04/11/14 16:50, H Hartley Sweeten wrote:
>> Introduce a new member to comedi_async to count the number of scans
>> completed.
>> This member is cleared by comedi_buf_reset() along with the other
>> com
On Wednesday, November 05, 2014 7:48 AM, Ian Abbott wrote:
> On 04/11/14 17:53, H Hartley Sweeten wrote:
>> Following is the big cleanup series for the ADDI-DATA APCI-3120 driver.
>>
>> Quick summary of the cleanup:
>>
>>* Removes all the CamelCase
>>
On Wednesday, November 05, 2014 4:08 AM, Ian Abbott wrote:
> On 04/11/14 16:50, H Hartley Sweeten wrote:
>> Remove the private data member 'ai_sample_count' and use the comedi_async
>> 'scans_done' member to detect the end-of-acquisition.
>>
>> Also,
ot; header into their own
>> headers, which obviously means small edits to most of the low-level drivers
>> to #include different headers. (But then, "comedi_pci.h" could #include
>> for example.)
>
> Hartley, any objection t
On Tuesday, November 11, 2014 4:35 AM, Ian Abbott wrote:
> On 11/11/14 00:57, H Hartley Sweeten wrote:
>> Currently the DMA buffers are switched before writing the current samples to
>> the async buffer. This works but when the EOA event happens we end up with an
>> outstan
On Wednesday, November 12, 2014 3:12 AM, Ian Abbott wrote:
> On 11/11/14 23:55, H Hartley Sweeten wrote:
>> The Dimond-MM-32-AT board uses an internal 82C55-type digital I/O circuit to
>> provide the 24 digital I/O lines. The only quirk is the need to set the page
>> selectio
ctual sample position in the scan.
> (Unfortunately we only have the current scan position in bytes currently,
> so convert that to a sample position.)
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers.c | 8 +---
> 1 file changed, 5 inserti
On Wednesday, November 12, 2014 9:20 AM, Ian Abbott wrote:
> On 12/11/14 16:07, Hartley Sweeten wrote:
>> The write to the Miscellaneous Control register (DMM32AT_CTRL_REG) in
>> the ISR routine is actually safe. According to the user manual:
>>
>> INTRST Writing
On Friday, November 21, 2014 3:59 AM, Ian Abbott wrote:
> On 20/11/14 22:07, H Hartley Sweeten wrote:
>> Most of the comedi drivers that provide readback for write only subdevices
>> now
>> use the comedi core comedi_alloc_subdev_readback() helper to allocate the
>> su
that still need the comedi comment block
converted to the normal CodingStyle format for multi-line comments.
And, as you mentioned to me before, all of the ADDI-DATA drivers
are missing the comedi comment block:
But, this is a great start to getting them cleaned up.
Reviewed-by:
On Thursday, January 08, 2015 3:52 AM, Ian Abbott wrote:
> On 08/01/15 00:19, H Hartley Sweeten wrote:
>> Tidy up this driver and add async command support for change-of-state
>> detection of the digital inputs.
>>
>> H Hartley Sweeten (8):
>>staging: comedi: a
On Tuesday, January 13, 2015 5:54 AM, Ian Abbott wrote:
> On 12/01/15 17:55, H Hartley Sweeten wrote:
>> This series removes all the VIRT_TO_BUS dependancies from the legacy comedi
>> drivers. It also tidies up the allocation and freeing of the DMA and the
>> buffers used for
On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote:
> On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
>> +const struct comedi_lrange *lrange;
>
> NAK. The following lines of source code allocate memory pointed to by
> 'lrange' and modify it, so 'const' is not appropriate here.
On Tuesday, April 21, 2015 6:35 AM, Dan Carpenter wrote:
> On Tue, Apr 21, 2015 at 01:52:09PM +0100, Ian Abbott wrote:
>>>Is that really an improvement? The original code was actually defined.
>>>
>>>1U << 32 is actually defined. It is zero. Which works for us.
>>
>> According to the C standard
nternal.h | 1 +
> drivers/staging/comedi/comedidev.h | 18 +-
> drivers/staging/comedi/drivers.c | 2 +-
> .../staging/comedi/drivers/amplc_dio200_common.c | 6 ++--
> 5 files changed, 45 insertions(+), 23 deletions(-)
Revie
xported functions in "mite.c".
>
> drivers/staging/comedi/drivers/mite.c | 110
> +-
> drivers/staging/comedi/drivers/mite.h | 88 ++-
> 2 files changed, 101 insertions(+), 97 deletions(-)
Reviewed-by: H Hartley Swe
On Wednesday, May 06, 2015 7:06 AM, nick wrote:
> On 2015-05-06 05:10 AM, Ian Abbott wrote:
>> On 06/05/15 01:22, nick wrote:
>>> Greetings All,
>>> I am wondering if in the function,ni_stc_dma_channel_select_bitfield the
>>> line:
>>> return 1 << channel;
>>> is guaranteed to be below the thresho
comedi: gsc_hpdi: use a better MODULE_DESCRIPTION()
>
> drivers/staging/comedi/drivers/gsc_hpdi.c | 184 +-
> 1 file changed, 80 insertions(+), 104 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing
On Saturday, May 09, 2015 10:07 AM, Greg KH wrote:
> On Fri, May 01, 2015 at 02:58:25PM -0700, H Hartley Sweeten wrote:
>> The ni_stc.h header contains the DAQ-STC and board specific register
>> information used by ni_mio_common.c to provide the "guts" for the
>> N
On Monday, May 11, 2015 12:04 PM, Ian Abbott wrote:
>>
>> Cc: Ian Abbott
>
> Minor niggle: that email address is malformed (comma instead of dot).
I noticed that when I got a bounce. Fat fingered it, need more coffee...
Thanks,
Hartley
___
devel maili
s
> the `dma_addr_t` type, so include to declare it. (Also,
> that indirectly takes care of the use of `NULL`.) It uses `struct
> comedi_device *` in various function prototypes, so add an incomplete
> declaration of `struct comedi_device`.
>
> Signed-off-
y by including .
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ng/comedi/drivers/8255.h| 19 +-
> drivers/staging/comedi/drivers/Makefile | 3 +-
> drivers/staging/comedi/drivers/comedi_8255.c | 285
> +++
> 5 files changed, 322 insertions(+), 235 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
gt; function prototype. Just declare the structure type incompletely and
> don't bother including the header file.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http:
vers/amplc_dio200_pci.c | 35 +++---
> 4 files changed, 91 insertions(+), 80 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
.h | 48 ++---
> 2 files changed, 188 insertions(+), 193 deletions(-)
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Friday, February 07, 2014 7:52 AM, Ian Abbott wrote:
> On 2014-02-06 23:48, H Hartley Sweeten wrote:
>> Introduce a comedi core helper function to handle the boilerplate
>> needed by the drivers to wait for a condition to occur. Typically
>> this condition is the analo
On Friday, February 07, 2014 8:34 AM, Ian Abbott wrote:
> On 2014-02-06 23:49, H Hartley Sweeten wrote:
>> Use comedi_timeout() to wait for the analog input end-of-conversion.
>>
>> Combine the logic for the pcl812 and acl812 end-of-conversion in the
>> helper func
On Wednesday, February 12, 2014 10:15 AM, Greg KH wrote:
> On Mon, Feb 10, 2014 at 11:49:33AM -0700, H Hartley Sweeten wrote:
>> Use comedi_timeout() to wait for the analog input and output end-of-
>> conversion.
>>
>> Use break to exit the loop when a timeout occurs
On Wednesday, February 12, 2014 8:29 PM, Chase Southwood wrote:
> In this if-else conditional statement, if (chan < 16), but
> (data[0] == INSN_CONFIG_DIO_QUERY), the function does not return early,
> but the else-branch does not get executed either. As a result, mask
> would be used uninitialized
On Friday, February 14, 2014 4:50 AM, Ian Abbott wrote:
> On 2014-02-13 18:25, Hartley Sweeten wrote:
>> On Wednesday, February 12, 2014 8:29 PM, Chase Southwood wrote:
>>> In this if-else conditional statement, if (chan < 16), but
>>> (data[0] == INSN_CONFIG_DIO
On Tuesday, February 18, 2014 4:36 AM, Ian Abbott wrote:
> On 2014-02-17 21:27, H Hartley Sweeten wrote:
>> The maximum chanlist that this hardware can handle is 16 (the number of
>> input channels).
>>
>> Remove this incorrect data from the boardinfo and just
On Tuesday, February 18, 2014 12:59 PM, Greg KH wrote:
> On Tue, Feb 18, 2014 at 12:06:51PM +, Ian Abbott wrote:
>> On 2014-02-17 21:26, H Hartley Sweeten wrote:
> >These comedi drivers are all very similar so it made sense to clean them
>>>up together.
>>>
On Saturday, March 01, 2014 3:28 AM, Chase Southwood wrote:
> Subject: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_*
> helper functions in hwdrv_apci1564.c
>
> This patch introduces a handful of outl and inl helper functions with the
> ultimate goal of improving code readabilit
On Monday, March 03, 2014 11:17 AM, Ian Abbott wrote:
> On 2014-02-28 23:23, H Hartley Sweeten wrote:
>> This series continues the cleanup of the pcl812/816/818 drivers.
>>
>> H Hartley Sweeten (66):
>
> I've looked through them all now. I have noted likely pr
On Tuesday, March 04, 2014 2:44 AM, Ian Abbott wrote:
> On 03/03/14 21:19, Hartley Sweeten wrote:
>> On Monday, March 03, 2014 11:17 AM, Ian Abbott wrote:
>>> On 2014-02-28 23:23, H Hartley Sweeten wrote:
>>>> This series continues the cleanup of the pcl812/816/81
ions(-)
FWIW, I'm ok with this..
Reviewed-by: H Hartley Sweeten
But, it appears that this sanity check is really unnecessary:
> + if (!s->range_table && !s->range_table_list) {
> dev_err(dev->class_dev, "(bug) no range type lis
On Wednesday, March 05, 2014 11:57 PM, Fred Akers wrote:
>
> Refactor this function to remove an extra indent level
>
> Signed-off-by: Fred Akers
Reviewed-by: H Hartley Sweeten
Thanks
___
devel mailing list
de...@linuxdriverproj
Reviewed-by: H Hartley Sweeten
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thursday, March 06, 2014 12:25 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> digital input registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
> Additionally,
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> digital output registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
> Additionally,
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> timer registers such that they are all the real offsets to each register,
> rather than a mix of real offsets and adders to those offsets.
> Additionally, the defi
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> watchdog registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
> Additionally, the d
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> digital input registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
>
> Signed-off-b
On Friday, March 07, 2014 1:32 AM, Chase Southwood wrote:
>>On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten
>> wrote:
>> This one is incomplete and breaks the build.
>> Be sure to do a build after each patch to make sure it works.
>
> Hartley,
> I'm sorr
On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
> This patch fixes the register map defines for the counter registers such
> that they are all the real offsets to each register, rather than a mix of
> real offsets and adders to those offsets.
>
> Signed-off-by: Chase Southwood
> ---
>
>
of the old defines were being used incorrectly in the
> i_APCI1564_Reset() function. Upon swapping the old defines out for the
> new ones in this function, their use has been corrected.
>
> Signed-off-by: Chase Southwood
> ---
Much better, thanks!
For the 5 patch serie
On Tuesday, March 11, 2014 4:18 AM, Ian Abbott wrote:
> On 2014-03-07 20:41, H Hartley Sweeten wrote:
>> Create an enum for the boards supported by this driver and pass that enum in
>> the pci_driver id_table as the driver_data.
>>
>> Introduce a boardinfo struct to h
On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote:
> This patch fixes a few function names that are very long and are
> not in the correct naming style
>
> Signed-off-by: Fred Akers
> ---
> This is v2 of "[PATCH] Staging: comedi: apci_1564: Fix long CamelCase
> function names"
> Changed subje
On Tuesday, March 11, 2014 10:49 AM, Joe Perches wrote:
> On Tue, 2014-03-11 at 17:42 +0000, Hartley Sweeten wrote:
>> On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote:
>>> This patch fixes a few function names that are very long and are
>>> not in the correct namin
On Tuesday, March 11, 2014 2:38 PM, gre...@linuxfoundation.org wrote:
> On Tue, Mar 11, 2014 at 04:48:42PM +0000, Hartley Sweeten wrote:
>> On Tuesday, March 11, 2014 4:18 AM, Ian Abbott wrote:
>>> That's initializing the `class` member instead of the `driver_data`
&
h 2/2 to apply...
Assuming it applies cleanly to Greg's tree and you compile tested it,
for both patches:
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote:
> This patch fixes a few function names that are very long and are
> not in the correct naming style
>
> Signed-off-by: Fred Akers
Fred,
I pulled Greg's staging tree to see if your patches apply.
Patch 1/2 is ok but patch 2/2 does not apply:
On Monday, March 17, 2014 2:14 PM, Greg KH wrote:
> On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
>> From: H Hartley Sweeten
>>
>> The DAC02 board, which is the only board supported by this driver, now
>> has its own comedi driver (dac02).
>>
On Monday, March 17, 2014 2:14 PM, Greg KH wrote:
> On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
>> From: H Hartley Sweeten
>>
>> The DAC02 board, which is the only board supported by this driver, now
>> has its own comedi driver (dac02).
>>
On Wednesday, April 16, 2014 8:57 AM, Ian Abbott wrote:
> On 2014-04-15 18:37, H Hartley Sweeten wrote:
>> The only time the chanlist can be NULL and chanlist_len < 1 is when a
>> COMEDI_CMDTEST ioctl is done, usually for the comedilib function
>> comedi_get_cmd_src_mask().
On Wednesday, April 16, 2014 10:52 AM, Ian Abbott wrote:
>>> NAK. This will break existing libcomedi library function
>>> comedi_get_generic_timed(), which will call the COMEDI_CMDTEST ioctl
>>> with a NULL chanlist (but with chanlist_len > 1) and with start_src etc.
>>> set to values other than T
is to
> decrease the driver's use of the struct addi_private, so that it may
> eventually use a much slimmer specialized private struct instead, as the
> other addi_apci_* drivers do.
>
> Signed-off-by: Chase Southwood
> Cc: H Hartley Sweeten
> ---
> This is a (smal
On Tuesday, April 15, 2014 11:58 PM, Chase Southwood wrote:
> We can remove this function from the boardinfo and move the code from
> hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function
> used by the driver. The function was also messy and failed to reset a few
> registers, t
On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote:
>
> Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c. The
> function was very messy and failed to reset a couple registers, these
> issues were fixed on the move.
The commit message needs updated. You are no longer moving
On Wednesday, April 16, 2014 4:53 PM, Chase Southwood wrote:
>>On Wednesday, April 16, 2014 6:36 PM, Hartley Sweeten
>> wrote:
>>>On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote:
>>>Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c. The
ands before I work on separating this driver from
> addi_common.c.
> I'd be happy to make any more changes that are desired, or if it's just
> better to
> drop the patch for now, that's ok too. Just want to make sure it's taken
> care of
> before I move on!
Sor
On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote:
> This board does not have analog inputs. Remove the subdevice init for
> them.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
Looks good.
Reviewed-by: H Hartley Sweeten
As Ian mention
On Friday, April 25, 2014 1:18 AM, Chase Southwood wrote:
> The board supported by this driver does not have analog outputs. Remove
> the subdevice init for it.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
Looks good.
Reviewed-by:
y: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
Chase,
The subject does not match the patch.
Regards,
Hartley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
; Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
The subject does not match the patch.
Hartley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
> This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2
> (dev->iobase) doon't bother reading the unused PCI bars.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweet
use the
> data directly in the subdevice init.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> ---
> drivers/staging/comedi/drivers/addi_apci_1564.c | 26
> +
> 1 file changed, 9 insertions(+), 17 deletions(-)
L
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
> This include is no longer needed.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeten
> ---
> drivers/staging/comedi/drivers/addi_apci_1564.c | 1 -
> 1 file changed, 1 deletion(-)
: Ian Abbott
> Cc: H Hartley Sweeten
> ---
> drivers/staging/comedi/drivers/addi_apci_1564.c | 46
> +
> 1 file changed, 1 insertion(+), 45 deletions(-)
Looks good.
Reviewed-by: H Hartley Sweeten
___
devel mailing li
On Friday, November 06, 2015 10:30 AM, Ian Abbott wrote:
> On 05/11/15 19:03, Hartley Sweeten wrote:
>> On Thursday, November 05, 2015 5:43 AM, Ian Abbott wrote:
>>> On 04/11/15 16:55, H Hartley Sweeten wrote:
>>>> The analog outputs can use an external refe
On Monday, November 09, 2015 9:26 AM, Ranjith wote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
This has already been fixed in by:
commit c98f4011ebd41ab9ff15e1c52acc446e1ee7e191
staging: comedi: ii_pci20kc: prefer
On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
> ---
> drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On Monday, November 09, 2015 8:09 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
> ---
> drivers/staging/comedi/drivers/pcmmio.c | 44
> +++
> 1 file changed, 22 inserti
On Monday, November 09, 2015 10:14 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
This has already been fixed. Please base your patches on linux-next
or Greg Kroah-Hartman's staging-next tree.
Also,
On Friday, November 06, 2015 10:22 AM, Ian Abbott wrote:
> Just so we're on the same page, I downloaded the user manual from
> http://support.advantech.com/support/SearchResult.aspx?keyword=PCI-1710&searchtabs=Manual
>
> Strangely, the date on the download page is 2015-10-28 which seems a bit
> re
On Friday, November 13, 2015 2:39 PM, kbuild test robot wrote:
> Hi Hartley,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.3 next-20151113]
>
> url:
> https://github.com/0day-ci/linux/commits/H-Hartley-Sweeten/staging-comedi-adv_pci
On Friday, November 13, 2015 2:39 PM, kbuild test robot wrote:
> Hi Hartley,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.3 next-20151113]
>
> url:
> https://github.com/0day-ci/linux/commits/H-Hartley-Sweeten/staging-comedi-adv_pci
On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
> drivers/staging/comedi/drivers/dmm32at.c |4 +
On Wednesday, November 18, 2015 3:33 AM, Ian Abbott wrote:
> On 13/11/15 18:11, H Hartley Sweeten wrote:
>> For aesthetics, define some macros to set the bits in the mux control
>> register. Also, rename the 'mux_ext' member of the private data.
>>
>> Signed-
On Wednesday, November 18, 2015 9:42 AM, Ian Abbott wrote:
> On 16/11/15 17:18, Ranjith Thangavel wrote:
[snip]
>> -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4)
>> -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4)
>> -#define DMM32AT_AI_CFG_SCINT_10US (2 << 4)
>> -#define DMM32AT_AI_CFG_SCINT_5US
On Wednesday, November 18, 2015 11:34 AM, Ian Abbott wrote:
> On 18/11/15 17:07, H Hartley Sweeten wrote:
>> These defines are only used to initialize the diosubd_data 'addr' members
>> in the boardinfo. For aesthetics, just open-code the values and remove the
>>
On Wednesday, November 18, 2015 10:55 AM, Ian Abbott wrote:
> Rearrange the code in `comedi_write()` to reduce the amount of
> indentation. The code never reiterates the `while` loop once `count`
> has become non-zero, so we can check that in the `while` condition to
> save an indentation level.
letions(-)
Ian,
Other than the minor nit-pick in patch 1 about the 'count == 0'
when becoming non-busy (the same situation is in comedi_read),
this looks good to me. It also makes the 'write' look more like the
'read'.
Thanks,
Reviewed-by: H Hartley Sweet
replace counter mode bitfield struct
> 2) staging: comedi: s526: add macros for counter control reg values
>
> drivers/staging/comedi/drivers/s526.c | 197
> ++
> 1 file changed, 130 insertions(+), 67 deletions(-)
Thanks! This one has bugged me.
vement.
>
> Reviewed-by: Ian Abbott
There are still a couple block comments that don't follow the kernel
CodingStyle and some minor alignment issues but these can be fixed
later. Overall it looks a lot better and removes most of the che
On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote:
> gcc-6 warns about passing negative signed integer into swab16()
> in the dt282x driver:
> The warning makes sense, though the code is correct as far as I
> can tell.
>
> This disambiguates the operation by making the constant expressions
On Tuesday, March 15, 2016 2:50 PM, Arnd Bergmann wrote:
> On Tuesday 15 March 2016 21:35:40 Hartley Sweeten wrote:
>> On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote:
>>> gcc-6 warns about passing negative signed integer into swab16()
>>> in the dt282x driver:
hough the code is correct as far as I
> can tell.
>
> This disambiguates the operation by making the constant expressions
> we pass here explicitly 'unsigned', which helps to avoid the warning.
>
> As pointed out by Hartley Sweeten, scripts/checkpatch.pl notices that
> th
On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote:
> On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote:
>> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>>
>> Is this a gcc-6 specific issue? Seems line this warning should be showing
>> up in a
On Wednesday, March 16, 2016 3:22 AM, Ian Abbott wrote:
> On 15/03/16 21:48, H Hartley Sweeten wrote:
>> Memory mapped io (dev->mmio) should not also be writing to the ioport
>> (dev->iobase) registers. Add the missing 'else' to these functions.
>>
>> S
On Monday, March 21, 2016 8:39 AM, Ian Abbott wrote:
> On 18/03/16 19:38, H Hartley Sweeten wrote:
>> This driver has a lot of checkpatch.pl issues:
>> total: 0 errors, 71 warnings, 27 checks, 1222 lines checked
>>
>> There is also a lot of cruft that bloats the drive
On Tuesday, March 22, 2016 10:51 AM, H Hartley Sweeten wrote:
> Fix the checkpatch.pl issues:
> WARNING: Block comments use a trailing */ on a separate line
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ian Abbott
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/comedi/d
On Wednesday, March 23, 2016 3:47 AM, Ian Abbott wrote:
> On 22/03/16 17:01, H Hartley Sweeten wrote:
>> Step 4 of the (*do_cmdtest) calls dt282x_ns_to_timer() to work out the
>> divisor needed to generate the 'convert_arg' timing. If the 'convert_arg'
>>
io_c_common.c
> deleted file mode 100644
> index e69de29..000
Weird. Good catch.
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wednesday, March 30, 2016 11:50 AM, Ian Abbott wrote:
> On 30/03/16 19:45, H Hartley Sweeten wrote:
>> Fix the checkpatch.pl issues and tidy up some aesthetic issues.
>>
>> H Hartley Sweeten (3):
>>staging: comedi: amplc_pci263: fix block comments
>>st
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
> The variable unipolar was never used.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> There may be a chance that reading from DAS1800_CONTROL_C is necessary
> before reading from DAS1800_STATUS. If that is true then please discard
> this pa
On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote:
> On 06/04/16 02:21, Hartley Sweeten wrote:
>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>>> The variable unipolar was never used.
>>>
>>> Signed-off-by: Sudip Mukherjee
>>> -
1 - 100 of 4787 matches
Mail list logo
