Re: [PATCH] staging: vt6655: tag data as __user in struct tagSCmdRequest

2014-07-25 Thread Guillaume CLÉMENT
On Fri, Jul 25, 2014 at 02:52:34PM +0300, Dan Carpenter wrote: > On Fri, Jul 25, 2014 at 01:07:40AM +0200, Guillaume Clement wrote: > > diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c > > index 501cd64..9291259 100644 > > --- a/drivers/staging/vt6655/iwctl.c > > +++ b/d

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Guillaume CLÉMENT
Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: > Hi Guillaume > > On 25/07/14 13:47, Guillaume Clement wrote: > > Sparse reported that the data from tagSCmdRequest is given by > > userspace, so it should be tagged as such. > extra is not in user space > All right.

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Guillaume CLÉMENT
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: > Hi Malcolm, > > On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: > > Hi Guillaume > > > > On 25/07/14 13:47, Guillaume Clement wrote: > > > Sparse reported that the