Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Junhao He > Signed-off-by: Yicong Yang Wh

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Guenter Roeck
On 2/5/21 12:08 PM, Bjorn Helgaas wrote: > On Fri, Feb 05, 2021 at 10:28:32AM -0800, Guenter Roeck wrote: >> On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: >>> From: Junhao He >>> >>> Use subdir-ccflags-* instead of ccflags-* to inherit the

Re: [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-09 Thread Guenter Roeck
On Tue, Feb 09, 2021 at 07:08:17PM +0800, Yicong Yang wrote: > From: Junhao He > > We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug > message in drivers/hwmon, but the DEBUG flag will not pass to > the subdirectory. > > Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG > recursive

Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

2018-12-21 Thread Guenter Roeck
On Fri, Dec 21, 2018 at 09:57:26PM +0100, Florian Westphal wrote: > skb->sp doesn't exist anymore in the next-next tree, so mips defconfig > no longer builds. Use helper instead to reset the secpath. > > Not even compile tested. > It does fix the build error. Tested-b

[PATCH] staging/octeon: Fix test build on MIPS

2019-11-10 Thread Guenter Roeck
s enabled. Since the driver uses those defines, we have to use the dummy defines if this flag is not enabled. Cc: Matthew Wilcox (Oracle) Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") Signed-off-by: Guenter Roeck --- drivers/staging/octeon/octeon-ethernet.h | 2 +- 1 f

Re: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital Power Monitor driver

2019-11-12 Thread Guenter Roeck
On Tue, Nov 12, 2019 at 05:37:57PM +, Jonathan Cameron wrote: > On Tue, 12 Nov 2019 17:35:50 +0200 > Beniamin Bia wrote: > > > From: Michael Hennerich > > > > ADM1177 is a Hot Swap Controller and Digital Power Monitor with > > Soft Start Pin. > > > > Datasheet: > > Link: > > https://www.a

Re: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital Power Monitor driver

2019-11-13 Thread Guenter Roeck
On Wed, Nov 13, 2019 at 08:10:50AM +, Hennerich, Michael wrote: > > > > -Original Message- > > From: Guenter Roeck On Behalf Of Guenter Roeck > > Sent: Dienstag, 12. November 2019 20:18 > > To: Jonathan Cameron > > Cc: Bia, Beniamin ; j

[PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode Cc: Marc Dietrich Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman Signed-off-by: Guenter Roeck --- v5: - Rebase to

Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
On 11/09/2014 01:41 PM, Marc Dietrich wrote: Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck: Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode Cc:

[PATCH v6 33/48] staging: nvec: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode Cc: Marc Dietrich Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman Acked-by: Marc Dietrich Signed-off-by: Guenter

[PATCH] staging: kpc2000: Fix build failure caused by wrong include file

2019-05-30 Thread Guenter Roeck
Fixes: 7df95299b94a ("staging: kpc2000: Add DMA driver") Cc: Matt Sickler Signed-off-by: Guenter Roeck --- drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/k

[PATCH 1/5] staging: typec: tcpm: Drop commented out code

2017-09-10 Thread Guenter Roeck
Commented out code can be added as needed. Drop it. Also drop TODO and an obsolete XXX comment. Signed-off-by: Guenter Roeck --- drivers/staging/typec/tcpm.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/drivers/staging/typec/tcpm.c b

[PATCH 2/5] staging: typec: tcpm: Document data structures

2017-09-10 Thread Guenter Roeck
Document struct tcpc_config and struct tcpc_dev. Drop unused TCPC_USB_SWITCH_RESTORE. Signed-off-by: Guenter Roeck --- drivers/staging/typec/tcpm.h | 57 ++-- 1 file changed, 50 insertions(+), 7 deletions(-) diff --git a/drivers/staging/typec/tcpm.h b

[PATCH 3/5] staging: typec: pd: Document struct pd_message

2017-09-10 Thread Guenter Roeck
struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h b/drivers/staging/typec/pd.h index 30b32ad72acd..42a10883a2cb 100644 --- a/drivers

Re: [PATCH 4/5] typec: tcpm: Move out of staging

2017-09-10 Thread Guenter Roeck
On 09/10/2017 01:46 PM, Joe Perches wrote: On Sun, 2017-09-10 at 13:37 -0700, Guenter Roeck wrote: Move tcpm (USB Type-C Port Manager) out of staging. git format-patch -M Thanks - I'll resend but wait a bit for additional comments before I do. Gu

Re: [PATCH v2 08/11] staging: typec: tcpm: Set mux to device mode when configured as such

2017-09-10 Thread Guenter Roeck
the mux to TYPEC_MUX_NONE, TCPC_USB_SWITCH_DISCONNECT so that it does not and up staying in host (and with this commit also device) mode after a detach. This sentence is hard to understand. Signed-off-by: Hans de Goede Otherwise Reviewed-by: Guenter Roeck --- drivers/staging/typec

[PATCH v2 1/5] staging: typec: tcpm: Drop commented out code

2017-09-10 Thread Guenter Roeck
Commented out code can be added as needed. Drop it. Also drop TODO and an obsolete XXX comment. Signed-off-by: Guenter Roeck --- v2: No change drivers/staging/typec/tcpm.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/drivers/staging

[PATCH v2 3/5] staging: typec: pd: Document struct pd_message

2017-09-10 Thread Guenter Roeck
struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- v2: No change drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h b/drivers/staging/typec/pd.h index 30b32ad72acd..42a10883a2cb

[PATCH v2 2/5] staging: typec: tcpm: Document data structures

2017-09-10 Thread Guenter Roeck
Document struct tcpc_config and struct tcpc_dev. Drop unused TCPC_USB_SWITCH_RESTORE. Signed-off-by: Guenter Roeck --- v2: No change drivers/staging/typec/tcpm.h | 57 ++-- 1 file changed, 50 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH v2 4/5] typec: tcpm: Move out of staging

2017-09-10 Thread Guenter Roeck
Move tcpm (USB Type-C Port Manager) out of staging. Signed-off-by: Guenter Roeck --- v2: Use format-patch -M drivers/staging/typec/Kconfig | 8 drivers/staging/typec/Makefile| 1 - drivers/staging/typec/TODO

[PATCH v2 5/5] usb: typec: fusb302: Move out of staging

2017-09-10 Thread Guenter Roeck
The driver is in good enough shape to be moved out of staging. Do it. Signed-off-by: Guenter Roeck --- v2: Use format-patch -M drivers/staging/typec/Kconfig| 2 -- drivers/staging/typec/Makefile | 1 - drivers/staging/typec/fusb302/TODO

Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code

2017-09-11 Thread Guenter Roeck
On Mon, Sep 11, 2017 at 09:23:34AM -0700, Greg Kroah-Hartman wrote: > On Sun, Sep 10, 2017 at 01:37:01PM -0700, Guenter Roeck wrote: > > Commented out code can be added as needed. Drop it. > > Also drop TODO and an obsolete XXX comment. > > > > Signed-off-by: Guenter

Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code

2017-09-11 Thread Guenter Roeck
On Mon, Sep 11, 2017 at 11:26:01AM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 11, 2017 at 10:37:11AM -0700, Guenter Roeck wrote: > > On Mon, Sep 11, 2017 at 09:23:34AM -0700, Greg Kroah-Hartman wrote: > > > On Sun, Sep 10, 2017 at 01:37:01PM -0700, Guenter Roeck wrote: >

[PATCH v3 4/5] typec: tcpm: Move out of staging

2017-09-11 Thread Guenter Roeck
Move tcpm (USB Type-C Port Manager) out of staging. Signed-off-by: Guenter Roeck --- v2: Use format-patch -M v3: No change drivers/staging/typec/Kconfig | 8 drivers/staging/typec/Makefile| 1 - drivers/staging/typec/TODO

[PATCH v3 2/5] staging: typec: tcpm: Document data structures

2017-09-11 Thread Guenter Roeck
Document struct tcpc_config and struct tcpc_dev. Drop unused TCPC_USB_SWITCH_RESTORE. Signed-off-by: Guenter Roeck --- v2, v3: No change drivers/staging/typec/tcpm.h | 57 ++-- 1 file changed, 50 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH v3 3/5] staging: typec: pd: Document struct pd_message

2017-09-11 Thread Guenter Roeck
struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- v2: No change v3: Fix document tag drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h b/drivers/staging/typec/pd.h index

[PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

2017-09-11 Thread Guenter Roeck
Commented out code can be added as needed. Drop it. Also drop TODO and an obsolete XXX comment. Signed-off-by: Guenter Roeck --- v2, v3: No change drivers/staging/typec/tcpm.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/drivers

[PATCH v3 5/5] usb: typec: fusb302: Move out of staging

2017-09-11 Thread Guenter Roeck
The driver is in good enough shape to be moved out of staging. Do it. Signed-off-by: Guenter Roeck --- v2: Use format-patch -M v3: No change drivers/staging/typec/Kconfig| 2 -- drivers/staging/typec/Makefile | 1 - drivers/staging/typec/fusb302

Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

2017-09-12 Thread Guenter Roeck
On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote: > On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote: > > Commented out code can be added as needed. Drop it. > > Also drop TODO and an obsolete XXX comment. > > > > Signed-off-by: Guenter Ro

Re: [PATCH v2 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support

2017-09-13 Thread Guenter Roeck
On Wed, Sep 13, 2017 at 05:48:25PM +0200, Hans de Goede wrote: > Hi, > > On 13-09-17 17:07, Rob Herring wrote: > >On Wed, Sep 13, 2017 at 9:06 AM, Hans de Goede wrote: > >>Hi, > >> > >> > >>On 13-09-17 15:38, Rob Herring wrote: > >>> > >>>On Wed, Sep 13, 2017 at 3:56 AM, Hans de Goede > >>>wrote

[PATCH] staging: speakup: Replace strncpy with memcpy

2018-07-01 Thread Guenter Roeck
ng as its length drivers/staging/speakup/kobjects.c:388:8: note: length computed here Using strncpy() is indeed less than perfect since the length of data to be copied has already been determined with strlen(). Replace strncpy() with memcpy() to address the warning and optimize the code

[PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-23 Thread Guenter Roeck
4l: omap4iss: Add support for OMAP4 camera interface - Video devices") Suggested-by: Linus Torvalds Cc: David Miller Cc: Randy Dunlap Signed-off-by: Guenter Roeck --- drivers/staging/media/omap4iss/iss_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[PATCH] android: binder: Include asm/cacheflush.h after linux/ include files

2018-07-23 Thread Guenter Roeck
red inside parameter list will not be visible outside of this definition or declaration Moving the asm/ include after linux/ includes solves the problem. Suggested-by: Linus Torvalds Signed-off-by: Guenter Roeck --- drivers/android/binder.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH] android: binder_alloc: Include asm/cacheflush.h after linux/ include files

2018-07-23 Thread Guenter Roeck
page' declared inside parameter list Moving the asm/ include after linux/ includes fixes the problem. Suggested-by: Linus Torvalds Signed-off-by: Guenter Roeck --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c

Re: [PATCH 1/3] staging: hwmon: Fix SPACING errors

2018-06-12 Thread Guenter Roeck
On Tue, Jun 12, 2018 at 08:56:58PM +0200, Jakob Albert wrote: > Fix SPACING errors in drivers/hwmon/nct7904.c reported by checkpatch.pl > Subject for all patches in this series should be hwmon: (nct7904) There is no need to reference the file name in the patch description. It is obvious from b

Re: [PATCH v2 0/3] hwmon: (nct7904) Fix style issues

2018-06-13 Thread Guenter Roeck
On Wed, Jun 13, 2018 at 05:13:22PM +0200, Jakob Albert wrote: > This set of patches fixes style errors reported by checkpatch.pl. This > adapts the code to the coding style. > > Changes since v1: > * Changed patch subjects and descriptions > > > > Jakob Albert (3): > hwmon: (nct7904) Fix SPAC

[PATCH -next] staging: wilc1000: Include linux/gpio.h instead of asm/gpio.h

2015-05-27 Thread Guenter Roeck
Fix: drivers/staging/wilc1000/linux_wlan.c:18:22: fatal error: asm/gpio.h: No such file or directory Not every architecture has asm/gpio.h. Include linux/gpio.h instead. Signed-off-by: Guenter Roeck --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] staging: wilc1000: Disable for S390

2015-05-27 Thread Guenter Roeck
The wilc1000 driver uses definitions such as DEBUG_LEVEL, DEBUG, and PRINT_INFO. This causes compile errors on S390 which has similar definitions in its core code. Disable the driver for S390 instead of giving the non-standard messaging code credit by trying to fix it. Signed-off-by: Guenter

[PATCH] staging/octeon: Mark Ethernet driver as BROKEN

2019-12-02 Thread Guenter Roeck
ges pointless and wrong. Reflect reality and mark the driver as BROKEN. Fixes: ef1fe6b7369a ("staging: octeon: remove typedef declaration for cvmx_wqe") Fixes: 73aef0c9d2c6 ("staging: octeon: remove typedef declaration for cvmx_helper_link_info") Cc: Wambui Karuga Cc: Julia

Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN

2019-12-02 Thread Guenter Roeck
On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > The code doesn't compile due to incompatible pointer errors such as > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: >

Re: [PATCH 1/2] staging: octeon: delete driver

2019-12-10 Thread Guenter Roeck
here, just delete the module entirely. Reported-by: Guenter Roeck Cc: David Daney Cc: "David S. Miller" Cc: "Matthew Wilcox (Oracle)" Cc: Guenter Roeck Cc: YueHaibing Cc: Aaro Koskinen Cc: Wambui Karuga Cc: Julia Lawall Cc: Florian Westphal Cc: Geert Uytterhoeven Cc

Re: [PATCH 1/2] staging: octeon: delete driver

2019-12-10 Thread Guenter Roeck
On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote: > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote: > > > Doesn't octeon have drivers out of staging already? > > > What is this module for? > > > > I

Re: [PATCH 1/2] staging: octeon: delete driver

2019-12-10 Thread Guenter Roeck
On Tue, Dec 10, 2019 at 11:48:49PM +0200, Aaro Koskinen wrote: > On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote: > > On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote: > > > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote: >

Re: [SPAM] Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-04 Thread Guenter Roeck
cause build issues and other problems > > > > > for > > > > > people who want to fix coding style problems, but can not actually > > > > > build > > > > > it. > > > > > > > > > > As nothing is happeni

Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-04 Thread Guenter Roeck
On 2/4/20 7:34 PM, Dan Carpenter wrote: On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote: On Tue, Feb 04, 2020 at 08:06:14PM +, Chris Packham wrote: On Tue, 2020-02-04 at 07:09 +, gre...@linuxfoundation.org wrote: On Tue, Feb 04, 2020 at 04:02:15AM +, Chris Packham wr

Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-05 Thread Guenter Roeck
On 2/5/20 1:03 AM, Geert Uytterhoeven wrote: On Wed, Feb 5, 2020 at 4:57 AM Guenter Roeck wrote: On 2/4/20 7:34 PM, Dan Carpenter wrote: On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote: On Tue, Feb 04, 2020 at 08:06:14PM +, Chris Packham wrote: On Tue, 2020-02-04 at 07:09

[PATCH v6 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2017-04-26 Thread Guenter Roeck
From: Guenter Roeck This driver implements the USB Type-C Power Delivery state machine for both source and sink ports. Alternate mode support is not fully implemented. The driver attaches to the USB Type-C class code implemented in the following patches. usb: typec: add driver for

[PATCH v6 2/2] usb: typec: Type-C Port Controller Interface driver (tcpci)

2017-04-26 Thread Guenter Roeck
From: Guenter Roeck The port controller interface driver interconnects the Type-C Port Manager with a Type-C Port Controller Interface (TCPCI) compliant port controller. Signed-off-by: Guenter Roeck Signed-off-by: Guenter Roeck --- v6: - Move to drivers/staging - Use PTR_ERR_OR_ZERO() v5

Re: [PATCH v6 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2017-04-26 Thread Guenter Roeck
On Wed, Apr 26, 2017 at 03:26:11PM -0700, Guenter Roeck wrote: > From: Guenter Roeck > > This driver implements the USB Type-C Power Delivery state machine > for both source and sink ports. Alternate mode support is not > fully implemented. > > The driver attaches to the

[PATCH v7 2/3] staging: typec: Type-C Port Controller Interface driver (tcpci)

2017-04-27 Thread Guenter Roeck
From: Guenter Roeck The port controller interface driver interconnects the Type-C Port Manager with a Type-C Port Controller Interface (TCPCI) compliant port controller. Signed-off-by: Guenter Roeck Signed-off-by: Guenter Roeck --- v7: - Adjust subject to indicate that this is a staging

[PATCH v7 3/3] staging: typec: Fairchild FUSB302 Type-c chip driver

2017-04-27 Thread Guenter Roeck
From: Yueyao Zhu Fairchild FUSB302 Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Signed-off-by: Yueyao Zhu Signed-off-by: Guenter Roeck --- v7: Added patch to series drivers/staging/typec/Kconfig |2

[PATCH v7 1/3] staging: typec: USB Type-C Port Manager (tcpm)

2017-04-27 Thread Guenter Roeck
From: Guenter Roeck This driver implements the USB Type-C Power Delivery state machine for both source and sink ports. Alternate mode support is not fully implemented. The driver attaches to the USB Type-C class code implemented in the following patches. usb: typec: add driver for

Re: [PATCH v7 1/3] staging: typec: USB Type-C Port Manager (tcpm)

2017-04-28 Thread Guenter Roeck
On 04/28/2017 12:28 AM, Greg Kroah-Hartman wrote: On Thu, Apr 27, 2017 at 02:09:56PM -0700, Guenter Roeck wrote: --- /dev/null +++ b/drivers/staging/typec/pd.h @@ -0,0 +1,281 @@ +/* + * Copyright 2015-2017 Google, Inc + * + * This program is free software; you can redistribute it and/or modify

Re: [PATCH] staging: typec: fusb302: Fix module autoload

2017-05-04 Thread Guenter Roeck
On Thu, May 04, 2017 at 08:33:45AM +0200, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the OF and I2C devic

[PATCH 1/7] staging: typec: tcpci: declare private structure as static

2017-05-09 Thread Guenter Roeck
From: Olivier Leveque This fixes a sparse warning regarding an undeclared symbol. Since the structure tcpci_tcpc_config is private to tcpci.c, it should be declared as static. Signed-off-by: Olivier Leveque Signed-off-by: Guenter Roeck --- drivers/staging/typec/tcpci.c | 2 +- 1 file changed

Re: [PATCH] staging: typec: Make undeclared symbol static

2017-05-09 Thread Guenter Roeck
On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote: > Fix sparse warning: > drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config' > was not declared. Should it be static? > > Signed-off-by: Guru Das Srinagesh Olivier Leveque already sent a similar patch la

[PATCH 5/7] staging: typec: tcpm: Set correct flags in PD request messages

2017-05-09 Thread Guenter Roeck
We do support USB PD communication, and devices supported by this driver typically use USB power for purposes other than USB communication. Originally-from: Puma Hsu Cc: Yueyao Zhu Signed-off-by: Guenter Roeck --- drivers/staging/typec/tcpm.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 4/7] staging: typec: tcpm: Drop duplicate PD messages

2017-05-09 Thread Guenter Roeck
Per USB PD standard, we have to drop duplicate PD messages. We can not expect lower protocol layers to drop such messages, since lower layers don't know if a message was dropped somewhere else in the stack. Originally-from: Puma Hsu Cc: Yueyao Zhu Signed-off-by: Guenter Roeck --- dr

[PATCH 7/7] staging: typec: tcpm: Fix Port Power Role field in PS_RDY messages

2017-05-09 Thread Guenter Roeck
PS_RDY messages sent during power swap sequences are expected to reflect the new power role. Signed-off-by: Guenter Roeck --- drivers/staging/typec/tcpm.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec

[PATCH 2/7] staging: typec: fusb302: Fix module autoload

2017-05-09 Thread Guenter Roeck
b302 alias: i2c:typec_fusb302 Signed-off-by: Javier Martinez Canillas Signed-off-by: Guenter Roeck --- drivers/staging/typec/fusb302/fusb302.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c index 2cee9a952c9b..aa460f93a

[PATCH 3/7] staging: typec: fusb302: Fix chip->vbus_present init value

2017-05-09 Thread Guenter Roeck
From: Yueyao Zhu FUSB_REG_STATUS0 & FUSB_REG_STATUS0_VBUSOK = 0x40 & 0x80 is always zero. Fix the code to what it is intended to be: check the VBUSOK bit of the value read from address FUSB_REG_STATUS0. Reported-by: Dan Carpenter Cc: Guenter Roeck Signed-off-by: Yueyao Zhu Signe

[PATCH 6/7] staging: typec: tcpm: Respond to Discover Identity commands

2017-05-09 Thread Guenter Roeck
If the lower level driver provided a list of VDOs in its configuration data, send it to the partner as response to a Discover Identity command if in device mode (UFP). Cc: Yueyao Zhu Originally-from: Puma Hsu Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd_vdo.h | 4 +++- drivers

Re: [PATCH 1/7] staging: typec: tcpci: declare private structure as static

2017-05-09 Thread Guenter Roeck
On Tue, May 09, 2017 at 07:46:17PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 09, 2017 at 09:04:53AM -0700, Guenter Roeck wrote: > > From: Olivier Leveque > > > > This fixes a sparse warning regarding an undeclared symbol. Since the > > structure tcpci_tcpc_confi

Re: [PATCH 2/4] staging: typec: fusb302: cleanup logging and error messages

2017-05-11 Thread Guenter Roeck
On Thu, May 11, 2017 at 03:20:21PM +0100, Rui Miguel Silva wrote: > This driver was using debugfs as a logging mechanism instead of the normal > dev_* > helpers. This patch changes this and move all calls to fusb302_log function to > the correspondent dev_{err,dbg,info}. > > Since the debugfs int

Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types

2017-05-11 Thread Guenter Roeck
icted __le16 [usertype] header > > Signed-off-by: Guru Das Srinagesh Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/fusb302/fusb302.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/typec/fusb302/fusb302.c > b/d

Re: [PATCH 1/4] staging: typec: fusb302: do not free gpio from managed resource

2017-05-11 Thread Guenter Roeck
; > Signed-off-by: Rui Miguel Silva Nice catch. Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/fusb302/fusb302.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/typec/fusb302/fusb302.c > b/drivers/staging/typec/fusb302/fusb302.c &g

Re: [PATCH 3/4] staging: typec: fusb302: refactor resume retry mechanism

2017-05-11 Thread Guenter Roeck
On Thu, May 11, 2017 at 03:20:22PM +0100, Rui Miguel Silva wrote: > The i2c functions need to test the pm_suspend state and do, if needed, some > retry before i2c operations. This code was repeated 4x. > > The isolate this create a new function to check suspend state and call it in > every need pl

Re: [PATCH 2/4] staging: typec: fusb302: cleanup logging and error messages

2017-05-11 Thread Guenter Roeck
On Thu, May 11, 2017 at 10:19:30PM +0100, Rui Miguel Silva wrote: > Hi Guenter, > On Thu, May 11, 2017 at 10:14:15AM -0700, Guenter Roeck wrote: > >On Thu, May 11, 2017 at 03:20:21PM +0100, Rui Miguel Silva wrote: > >>This driver was using debugfs as a logging mechanism

Re: [PATCH v2 1/3] staging: typec: fusb302: do not free gpio from managed resource

2017-05-12 Thread Guenter Roeck
; > Signed-off-by: Rui Miguel Silva Reviewed-by: Guenter Roeck In general, please apply any received tags if you resend a patch without changing it. Thanks, Guenter > --- > drivers/staging/typec/fusb302/fusb302.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/dri

Re: [PATCH v3 2/3] staging: typec: fusb302: reset i2c_busy state in error

2017-05-15 Thread Guenter Roeck
On 05/12/2017 01:16 PM, Rui Miguel Silva wrote: Fix reset of i2c_busy flag if an error occurs during the i2c block read. Signed-off-by: Rui Miguel Silva Reviewed-by: Guenter Roeck --- drivers/staging/typec/fusb302/fusb302.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

Re: [PATCH v3 3/3] staging: typec: fusb302: refactor resume retry mechanism

2017-05-15 Thread Guenter Roeck
error message from pr_err to dev_err. Signed-off-by: Rui Miguel Silva Reviewed-by: Guenter Roeck --- drivers/staging/typec/fusb302/fusb302.c | 70 + 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/drivers/staging/typec/fusb302/fusb302.c b

Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in argument.

2017-06-01 Thread Guenter Roeck
On Thu, Jun 01, 2017 at 05:57:14PM +0300, Dan Carpenter wrote: > On Thu, Jun 01, 2017 at 07:21:00AM +, ? ? wrote: > > From: Pan Li > > > > Convert type le16 to cpu of argument 1 in function pd_header_cnt. > > > > Signed-off-by: Pan Li > > --- > > drivers/staging/typec/tcpci.c | 2 +- >

Re: [PATCH 0/3] staging:typec: Fix 3 defect of incorrect type

2017-06-02 Thread Guenter Roeck
On 06/01/2017 12:20 AM, ? ? wrote: From: Pan Li Pan Li (3): Fix one defect of incorrect type in argument. Fix one defect of incorrect type assignment. Fix one defect of incorrect type assignment. drivers/staging/typec/tcpci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH 3/4] staging: typec: Clean endianness of pd_message header assignment.

2017-06-11 Thread Guenter Roeck
On 06/11/2017 03:54 AM, ? ? wrote: From: Pan Li Makes header assignmen happy by shared the memory between __le16 and u16. Signed-off-by: Pan Li --- drivers/staging/typec/pd.h| 10 +- drivers/staging/typec/tcpci.c | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-)

Re: [PATCH 1/4] staging: typec: Replace pd_header_cnt with pd_header_cnt_le

2017-06-11 Thread Guenter Roeck
On 06/11/2017 03:53 AM, ? ? wrote: From: Pan Li Convertn __le to cpu type when access pd_header count. Signed-off-by: Pan Li Reviewed-by: Guenter Roeck --- drivers/staging/typec/tcpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec

Re: [PATCH 2/4] staging: typec: Restrict read pointer to 16 bit of tcpci_read16.

2017-06-11 Thread Guenter Roeck
On 06/11/2017 03:53 AM, ? ? wrote: From: Pan Li Restricted tcpci_read16 argument to 16 bit variable pointer, in accord with the function name. Signed-off-by: Pan Li --- drivers/staging/typec/tcpci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue

2017-06-12 Thread Guenter Roeck
On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote: > Fixed WARNING: line over 80 characters > > Signed-off-by: Jaya Durga > --- > drivers/staging/rtl8712/ieee80211.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 1.9.1 > > diff --git a/drivers/staging/rtl8712/iee

Re: [PATCH] staging: fusb302: don't bitshift __le16 type

2017-06-16 Thread Guenter Roeck
27;re > filling the buffer, we can just copy the contents right away. As an > added benefit we don't get fishy results on big endian systems anymore. > > Signed-off-by: Frans Klaver Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/fusb302/fusb302.c | 4 ++-- >

Re: [PATCH 2/3] staging: typec: add tcpci_read16_le.

2017-06-19 Thread Guenter Roeck
On 06/19/2017 03:11 AM, ? ? wrote: From: Pan Li Add tcpci_read16_le for pd_message header type __le16. > Signed-off-by: Pan Li --- drivers/staging/typec/tcpci.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/typec/tcpci.c b/drivers/stagi

[PATCH] Staging: fsl-mc: Fix up bad parameters to dev_err and dev_dbg

2016-03-18 Thread Guenter Roeck
The first parameter to dev_dbg() and dev_err() is struct device *, not struct device **. Fixes: de71daf5c839 ("Staging: fsl-mc: Replace pr_debug with dev_dbg") Fixes: 454b0ec8bf99 ("Staging: fsl-mc: Replace pr_err with dev_err") Cc: Bhumika Goyal Signed-off-by: Guenter

Re: [PATCH 01/44] kernel: Add support for poweroff handler call chain

2015-06-18 Thread Guenter Roeck
On 06/17/2015 11:53 PM, Frans Klaver wrote: On Thu, Jun 18, 2015 at 3:04 AM, Stephen Boyd wrote: On 10/06/2014 10:28 PM, Guenter Roeck wrote: Various drivers implement architecture and/or device specific means to remove power from the system. For the most part, those drivers set the global

Re: [PATCH 01/44] kernel: Add support for poweroff handler call chain

2015-06-18 Thread Guenter Roeck
On Wed, Jun 17, 2015 at 06:04:54PM -0700, Stephen Boyd wrote: [ ... ] > > What happened to this series? I want to add shutdown support to my > platform and I need to write a register on the PMIC in one driver to > configure it for shutdown instead of restart and then write an MMIO > register to te

Re: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into socklnd.h

2015-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2015 at 02:37:51PM +0200, Geert Uytterhoeven wrote: > Hi James, > > On Thu, Jun 11, 2015 at 9:18 PM, James Simmons wrote: > > From: John L. Hammond > > > > Originally socklnd_lib-linux.h contained linux specific > > wrappers and defines but since the linux kernel is the > > only

[PATCH] staging: board: Add dependency on CLKDEV_LOOKUP

2015-06-26 Thread Guenter Roeck
ed reference to `.clk_add_alias' Fixes: 225d68d852f1 ("staging: board: Add support for devices with complex dependencies") Cc: Geert Uytterhoeven Signed-off-by: Guenter Roeck --- drivers/staging/board/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH] staging:lustre: remove irq.h from socklnd.h

2015-06-26 Thread Guenter Roeck
t; Signed-off-by: James Simmons The m68k build problem is now seen in mainline, and this patch fixes it. Tested-by: Guenter Roeck Guenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: Replace strtoul with simple_strtoul

2015-07-24 Thread Guenter Roeck
22:0: note: this is the location of the previous definition #define strtoul simple_strtoul Remove the definition and use simple_strtoul() directly. Note that we can not replace simple_strtoul with kstrtoul since the end pointer is used by the code. Signed-off-by: Gue

[PATCH] lustre: Include unaligned.h instead of access_ok.h

2015-08-01 Thread Guenter Roeck
315 ("Staging: lustre: Use put_unaligned_le64") Cc: Vaishali Thakkar Signed-off-by: Guenter Roeck --- drivers/staging/lustre/lustre/obdclass/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/debug.c b/drivers/staging/lustre

[PATCH] staging: Remove slicoss driver

2016-12-12 Thread Guenter Roeck
driver in staging is obsolete and can be removed. Cc: Tobias Klauser Cc: David S. Miller Cc: Lino Sanfilippo Cc: Lior Dotan Cc: Christopher Harrer Signed-off-by: Guenter Roeck --- MAINTAINERS |6 - drivers/staging/Kconfig |2 - drivers/staging/Makefile

Re: [PATCH] staging: Remove slicoss driver

2016-12-13 Thread Guenter Roeck
On Tue, Dec 13, 2016 at 04:16:56AM -0800, Greg Kroah-Hartman wrote: > On Mon, Dec 12, 2016 at 07:32:07PM -0800, Guenter Roeck wrote: > > There is now a different driver for the slicoss devices in > > drivers/net/ethernet/alacritech/. That driver supports the same PCI > > dev

[PATCH 12/13] Input: serio - drop unnecessary calls to device_init_wakeup

2017-01-21 Thread Guenter Roeck
..+> } Signed-off-by: Guenter Roeck --- drivers/input/serio/hyperv-keyboard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c index c948866edf87..25151d9214e0 100644 --- a/drivers/input/serio/hyperv-keyboard.c ++

Re: Drivers: staging: speakup: spk_priv.h - style fix

2017-02-03 Thread Guenter Roeck
On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote: > Changed function definition argument to have identifier name. > found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/speakup/spk_priv.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: Staging: speakup - syle fix permissions to octal

2017-02-03 Thread Guenter Roeck
On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > A style fix across whole driver. > changed permissions to octal style, found using checkpatch > > Signed-off-by: Derek Robson FWIW, I think changes like this are best done using coccinelle. That ensures that the results can be repro

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Guenter Roeck
On 02/03/2017 11:27 PM, Joe Perches wrote: (adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Guenter Roeck
On 02/04/2017 06:29 AM, Julia Lawall wrote: On Sat, 4 Feb 2017, Guenter Roeck wrote: On 02/03/2017 11:27 PM, Joe Perches wrote: (adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: A style fix across

Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver)

2015-01-26 Thread Guenter Roeck
On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote: On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): mul

Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver)

2015-01-27 Thread Guenter Roeck
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: > make ARCH=i386 allyesconfig fails with > > drivers/staging/built-in.o: In function `reset': > (.text+0x2ae89d): multiple definition of `reset' > drivers/isdn/built-in.o:(.text+0x185dc2): first defined here > make[1]: *** [drivers/built-i

Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

2016-09-14 Thread Guenter Roeck
; drivers/built-in.o: In function `ion_parse_dt': > (.text+0x11aa2c): undefined reference to `of_platform_device_create' > > Add a dependency on OF_ADDRESS > > Reported-by: Guenter Roeck > Signed-off-by: Laura Abbott Tested-by: Guenter Roeck > --- > Based on

Re: [PATCH] staging: typec: Fix type mismatch found with sparse

2017-07-05 Thread Guenter Roeck
On 07/05/2017 07:00 AM, Thomas Gardner wrote: The warning below is resolved by casting the LHS to __le32. typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types) typec/tcpm.c:1019:49:expected unsigned int [unsigned] [usertype] typec/tcpm.c:1019:49:got restric

Re: [PATCH] staging: typec: Fix type mismatch found with sparse

2017-07-06 Thread Guenter Roeck
On 07/05/2017 07:57 PM, Thomas Gardner wrote: Guenter Roeck / 2017-07-05T07:25-0700 On 07/05/2017 07:00 AM, Thomas Gardner wrote: The warning below is resolved by casting the LHS to __le32. typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types) typec/tcpm.c:1019

Re: [PATCH v2] staging: typec: Fix endianness warning discovered by sparse

2017-07-06 Thread Guenter Roeck
On 07/06/2017 03:54 PM, Thomas Gardner wrote: The below warning is resolved by removing the cpu_to_le32() call. This call was redundant; vdm_run_state_machine() ensures that SVDM responses have the correct endianness before sending. typec/tcpm.c:1019:49: warning: incorrect type in assignment (di

  1   2   3   >