Re: [PATCH] Staging: rtl8188eu: core: rtw_wlan_util: replaced __inline with inline

2014-11-26 Thread Greg KH
On Thu, Nov 20, 2014 at 04:03:23PM +0100, Abel Moyo wrote: > Changed return type of function get_my_bssid from __inline to inline > > Signed-off-by: Abel Moyo > --- > drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH] Drivers:Staging:rtl8188eu:hal:usb_halinit.c: Added blank lines after declarations

2014-11-26 Thread Greg KH
On Sat, Nov 22, 2014 at 11:36:40AM +0530, Anjana Sasindran wrote: > This patch fixes the five checkpatch.pl warnings: > > WARNING:Missing a blank line after declaration > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++ > 1 file changed,

Re: [PATCH] Drivers:staging:wlan-ng: Fixed checkpatch warning

2014-11-26 Thread Greg KH
On Tue, Nov 25, 2014 at 05:16:40PM +0530, Athira Lekshmi C V wrote: > The following checkpatch warning was fixed > WARNING: line over 80 characters > > Signed-off-by: Athira Lekshmi C V > --- > drivers/staging/wlan-ng/prism2fw.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-

Re: [PATCH] Drivers:staging:comedi:drivers: Fixed checkpatch warning

2014-11-26 Thread Greg KH
On Wed, Nov 26, 2014 at 04:56:55PM +0530, Athira Lekshmi C V wrote: > Fixed the checkpatch warning: > WARNING: please, no space before tabs > > Signed-off-by: Athira Lekshmi C V Same question about the name here as before. Also, be more specific in your subject as to what you are changing. "fix

Re: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

2014-11-26 Thread Greg KH
On Tue, Nov 11, 2014 at 09:03:26PM -0800, Dexuan Cui wrote: > In the case the user-space daemon crashes, hangs or is killed, we > need to down the semaphore, otherwise, after the daemon starts next > time, the obsolete data in fcopy_transaction.message or > fcopy_transaction.fcopy_msg will be used

Re: [PATCH] staging: octeon: Fix checkpatch warning

2014-11-26 Thread Greg KH
On Thu, Nov 27, 2014 at 12:35:23AM +, Luis de Bethencourt wrote: > On Wed, Nov 26, 2014 at 01:45:23PM -0800, Greg KH wrote: > > On Tue, Nov 25, 2014 at 01:26:14PM +, Luis de Bethencourt wrote: > > > This patch fixes the checkpatch.pl warnings: > > > > > &

Re: [PATCH] staging:drivers:rtl8712:drv_types.h: Added blank line after declarations

2014-11-27 Thread Greg KH
On Thu, Nov 27, 2014 at 09:00:03PM +0530, Anjana Sasindran wrote: > This patch fixes the two checkpatch.pl warnings: > > WARNING:Missing a blank line after declaration > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/rtl8712/drv_types.h | 4 +++- > 1 file changed, 3 i

Re: [PATCH] staging: r8188eu: Add new device ID for DLink GO-USB-N150

2014-11-27 Thread Greg KH
On Thu, Nov 27, 2014 at 10:10:21AM -0600, Larry Finger wrote: > The DLink GO-USB-N150 with revision B1 uses this driver. > > Signed-off-by: Larry Finger > --- > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8188eu/os_dep/

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-28 Thread Greg KH
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote: > Hello Greg, > > After some investigation, I think that removing these wrappers is not going > to improve the code readability: > > On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote: > > On Wed, No

[GIT PULL] Staging driver fixes for 3.18-rc7

2014-11-28 Thread Greg KH
The following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108: Linux 3.18-rc4 (2014-11-09 14:55:29 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.18-rc7 for you to fetch changes up to 6d4556fc030

Re: [PATCH] Drivers:staging:clocking-wizard: Added a newline

2014-11-29 Thread Greg KH
On Sat, Nov 29, 2014 at 06:03:06PM +0530, Athira S wrote: > Fixed checkpatch warning: > Missing a newline after declarations > > Signed-off-by: Athira S Is "Athira S" what you use to sign legal documents? If not, please fix and resend. ___ devel maili

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-11-30 Thread Greg KH
On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: > Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 > Linux Version [3.17-rc1] That's a very old kernel version. > Configuration: Default configuration for x86 > > > Function (reserve_range) in file (drivers/pnp/system.c

Re: [PATCH v2] Staging: rtl8188eu: {core, hal, include}: Removed inline function

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 11:48:07AM +0100, Abel Moyo wrote: > Removed inline function get_my_bssid and open coded all its references > > Signed-off-by: Abel Moyo > --- > Changes in v2: > - Remove inline function entirely and open code the > implementation instead of replacing __inlin

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 11:04:00AM +0530, Athira Lekshmi wrote: > Fixed the checkpatch warning: > Missing a blank line after declarations > > Signed-off-by: Athira Lekshmi > --- > drivers/staging/octeon/ethernet-rx.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/oc

Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning > > WARNING:Missing a blank line after declaration > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Greg KH
On Tue, Dec 02, 2014 at 09:11:15AM -0600, Paul Hedman wrote: > This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by > the checkpatch.pl tool. Please wrap your changelog at the correct column. > > Signed-off-by: Paul Hedman > --- > drivers/staging/ft1000/ft1000-usb/ft100

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH
On Mon, Dec 01, 2014 at 09:54:45AM +0800, Fred wrote: > Fixed the following warnings in sparse: > drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: > symbol 'dump_eprom' was not declared. > Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: > symbo

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Greg KH
On Tue, Dec 02, 2014 at 07:10:41PM -0600, Paul H wrote: > A tutorial I read suggested using a different branch for applying the > patches; I named it "fix-spaces". It would appear it is mistaken > then? You have to make your patch against the linux-next tree, not Linus's tree, so as to not duplic

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH
On Wed, Dec 03, 2014 at 10:31:55AM +0800, Fred Chou wrote: > From: Fred One word name, and then: > Signed-off-by: Fred Chou Two word name. Unacceptable, you know this... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdrive

Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:07:28PM +, Sean Cleator wrote: > A patch to fix the rest of the long line warnings in the dgnc_cls.h file > found by the checkpatch.pl tool > > Signed-off-by: Sean Cleator > > --- > drivers/staging/dgnc/dgnc_cls.h | 22 +- > 1 file changed, 17

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-12-03 Thread Greg KH
On Sun, Nov 30, 2014 at 09:49:23PM -0600, Ahmed Tamrawi wrote: > On Sun, Nov 30, 2014 at 8:51 PM, Greg KH wrote: > > On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: > >> Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 > >> Linux Version

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:12:09PM -0800, Arun wrote: > --- > drivers/staging/bcm/CmHost.h |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) That's a really odd subject, don't you agree? :) ___ devel mailing list de...@linuxdriverproj

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote: > Hi Greg, If you turn off HTML email, your message will not get rejected by the mailing lists :) > I completely agree! I thought of keeping the patch summary as the subject, but > I wasn't sure and ending up entering nothing. Git

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Greg KH
On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: > This patch fix a sparse warning in lustre sources > > warning: incorrect type in argument 1 (different address spaces) > expected void [noderef] *to > got char * > > This is done by adding the missing __user attribute on us

Re: [PATCH 1/1] Drivers: hv: vmbus: Implement a clockevent device

2014-12-05 Thread Greg KH
On Fri, Dec 05, 2014 at 07:58:44PM -0800, K. Y. Srinivasan wrote: > Implement a clockevent device based on the timer support available on > Hyper-V. > In this version of the patch I have addressed Jason's review comments. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Jason Wang > --- Why d

Re: [PATCH] comedi: indent checkpatch errors and warnings fixed

2014-12-07 Thread Greg KH
hing, and send this as a series of patches. thanks, greg kh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rts5208: Removed the new typedefs

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 07:24:16PM +0530, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning: > > WARNING: do not add new typedefs > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/rts5208/rtsx_sys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [PATCH] staging: lustre: Fix the warning messages about casting without __user macro

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 07:09:59AM +, Al Viro wrote: > On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote: > > From: Shalin Mehta > > > > This issue is showed up while compiling with sparse. The iov_base in struct > > iovec struct explicitly declares that the assigned value should

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 11:42:43AM -0800, K. Y. Srinivasan wrote: > Fix a bug in vmbus_establish_gpadl(). I would like to > thank Michael Brown for seeing this bug. Then use the "Reported-by:" tag with his name in this patch please. thanks, greg k-h _

Re: Fwd: improve support for usb board camera

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 07:35:48PM -0500, Kristopher Borer wrote: > Hello, > > I am looking to improve support for a USB board camera. It currently > works fairly well, but we occasionally cause kernel panics while using > OpenCV on Ubuntu 14.04. What kernel version is that, and what is the oops

Re: Fwd: improve support for usb board camera

2014-12-11 Thread Greg KH
On Thu, Dec 11, 2014 at 07:43:15AM -0500, Kristopher Borer wrote: > The kernel version is 3.13.0-32-generic Ick, that's 68 thousand patches old (i.e. one year...) Have you tried the 3.18 kernel release to see if it is better, because: > > Here is one example: > > BUG: unable to handle kernel N

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: > On Mon, Dec 15, 2014 at 6:55 PM, Greg KH wrote: > > The following changes since commit 009d0431c3914de64666bec0d350e54fdd59df6a: > > > > Linux 3.18-rc7 (2014-11-30 16:42:27 -0800) > > > > ar

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote: > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: > > I don't understand this kind of logic. > > a) Binder is considered a piece of shite. > > b) Google is working on a (hopefully sane) replacement. > > > > Why

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 07:36:00PM +0100, Richard Weinberger wrote: > > Am 15.12.2014 um 19:30 schrieb Greg KH: > > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: > >> On Mon, Dec 15, 2014 at 6:55 PM, Greg KH > >> wrote: > >&

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 10:41:03AM -0800, Greg KH wrote: > On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote: > > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: > > > I don't understand this kind of logic. > > > a) Binder is cons

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 08:04:53PM +0100, Richard Weinberger wrote: > > Fact is, this is useful code, in this area. In the domain it is used > > in, it works properly, and the abi is sufficient. Yes, it's ugly in > > spaces, and insecure if used outside of Android, but that's ok for the > > users

Re: [PATCH] Staging: bcm: fix spaces before commas in Bcmchar.c

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 11:22:29AM -0800, Jack Wilson wrote: > This is a patch to the Bcmchar.c file that fixes a space before comma warning > found by checkpatch.pl. > Signed-off-by: Jack Wilson > --- > drivers/staging/bcm/Bcmchar.c | 4 ++-- Odd, that file is gone from my tree, I have no idea

Re: [PATCH 1/1] Drivers: hv: vmbus: Support a vmbus API for efficiently sending page arrays

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 12:33:47PM -0800, K. Y. Srinivasan wrote: > Currently, the API for sending a multi-page buffer over VMBUS is limited to > a maximum pfn array of MAX_MULTIPAGE_BUFFER_COUNT. This limitation is > not imposed by the host and unnecessarily limits the maximum payload > that can b

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: > From: Alan Tull > > Enable FPGA manager for Altera socfpga. > > Signed-off-by: Alan Tull > --- > v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_SOCFPGA/ > --- > arch/arm/configs/socfpga_defconfig |4 > 1 file

Re: [PATCH] Staging : lustre : replaced seq_printf() with seq_puts and changed include statement

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 11:04:41PM +0530, Hariharan Rangasamy wrote: > Used seq_puts instead of seq_printf() > Used #include instead of #include That's two different things, which means two different patches are needed. Please only do one-thing-per-patch. thanks, greg k-h

Re: [PATCH 1/1] Drivers: hv: vmbus: Add device and vendor ID to vmbus devices

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 02:52:24PM -0800, K. Y. Srinivasan wrote: > Add vendor and device ID attributes to vmbus devices. This would allow us to > support vmbus based devices that can support guest RDMA. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/vmbus_drv.c | 20 ++

Re: [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue

2014-12-17 Thread Greg KH
On Thu, Dec 18, 2014 at 12:17:54AM -0200, Eduardo Barretto wrote: > Fixed a coding style issue. What coding style issue? Be specific, you have lots of room here. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.or

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2014-12-18 Thread Greg KH
On Thu, Dec 18, 2014 at 05:46:29PM +0100, Robert Nachlinger wrote: > This is a patch to the gdm_mux.c file that fixes a space before comma coding > style issue found by the checkpatch.pl tool. Please line-wrap your changelog text, there's no reason to have lines this long, right? greg k-h _

Re: Subject: [PATCH] Staging: ft1000: ft1000_hw.c: replaced asm header includes with linux headers

2014-12-18 Thread Greg KH
On Fri, Dec 19, 2014 at 12:15:22AM +0530, Hariharan Rangasamy wrote: > > used #include instead of > used #include instead of > > Signed-off-by: Hariharan Rangasamy Your subject line looks crazy, not to mention you used my wrong email address :( Please fix up and resend. thanks, greg k-h

Re: [PATCH v6 0/4] FPGA Manager Framework

2014-12-19 Thread Greg KH
On Fri, Dec 19, 2014 at 03:20:59PM +0100, Michal Simek wrote: > Hi Greg, > > On 12/18/2014 11:29 PM, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > Dropping the changes to socfpga DTS and defconfig from this > > patch set. > > > > Kernel doc fixes and other minor fixes as listed

Re: [PATCH v3] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue

2014-12-19 Thread Greg KH
On Fri, Dec 19, 2014 at 12:18:26AM -0200, Eduardo Barretto wrote: > Checkpatch was complaining about the else statement because the if statement > had a return '1' call. Taking a look at the function which this else > statement belongs, you can see that it has an switch case statement. > The main

Re: [PATCH 544/544] Staging: comedi: fix spacing style issues in ni_stc.h This is a patch to the ni_stc.h file that removes spaces before tabs, and adds blank lines after declarations.

2014-12-19 Thread Greg KH
On Fri, Dec 19, 2014 at 04:19:31AM -0500, Sage Vaillancourt wrote: > --- > drivers/staging/comedi/drivers/ni_stc.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) Odd subject there, don't you think? And where are the 543 other patches you sent out that need to be applied bef

Re: [PATCH v6 0/4] FPGA Manager Framework

2014-12-19 Thread Greg KH
On Fri, Dec 19, 2014 at 09:47:26AM -0600, atull wrote: > Thanks. There is a one line change that the kbuild test robot has > pointed out. I can post v7 with just that change and let that be it. Sure, or wait a week to see if anything else falls out and resend then... ___

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2014-12-19 Thread Greg KH
On Thu, Dec 18, 2014 at 05:46:29PM +0100, Robert Nachlinger wrote: > This is a patch to the gdm_mux.c file that fixes a space before comma coding > style issue found by the checkpatch.pl tool. Can you fix up your line to be line-wrapped at 72 columns so I don't have to do it by hand? thanks, gr

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2014-12-20 Thread Greg KH
On Sat, Dec 20, 2014 at 12:51:00PM +0100, Robert N wrote: > I already sent you the patch line-wrapped at column 69, so it says: > > > This is a patch to the gdm_mux.c file that fixes a space before comma > > coding style issue found by the checkpatch.pl tool. > > Do i have to wrap it exactly at c

Re: [PATCH] staging: skein: Fixing various coding style problems

2014-12-21 Thread Greg KH
On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poir...@linaro.org wrote: > From: Mathieu Poirier > > Fixing errors related to the usage of do {} while (0) loop > in single statement macros, trailing semicolon in macros and > trailing whitespace. That's a lot of things all at once, please brea

Re: [PATCH 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of pr_err insted of printk

2014-12-21 Thread Greg KH
On Mon, Dec 22, 2014 at 02:17:30AM +0100, Simone Weiss wrote: > > Signed-off-by: Simone Weiss > Signed-off-by: Helene Gsaenger > --- > drivers/staging/dgnc/dgnc_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c > b/drivers/s

Re: [PATCH] [PATCH v2 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of dev_err ? instead of printk

2014-12-22 Thread Greg KH
On Mon, Dec 22, 2014 at 07:43:56PM +0100, Simone Weiss wrote: > I originally wanted to replace both of the printk cals in this file with > dev_err(). > But in the function dgnc_create_driver_sysfiles only the struct pci_driver > was given, > sadly I coudn't figure out a way to get a struct devi

Re: [PATCH] staging: lustre: cleanup align switch and case

2014-12-22 Thread Greg KH
On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote: > From: skihahu > > Align switch and case to be at the same indent. > > Signed-off-by: samuel kihahu The "From:" and "Signed-off-by:" names don't match, which doesn't make much sense, right? Please fix and resend. ___

Re: [PATCH] dgnc/digi.h: checkpatch: Changend complex macros (enclosed parantheses)

2014-12-22 Thread Greg KH
On Mon, Dec 22, 2014 at 08:04:02PM +0100, Simone Weiss wrote: > The patch previous in this thread (dgnc/dpacompat.h) defines partly the same > macros as dgnc/digi.h and so it is neccessary tochange the macros in this > file as well, so no macros get redefined > Please wrap your changelog body

Re: [PATCH] Fix a white space coding style problem

2014-12-22 Thread Greg KH
On Tue, Dec 23, 2014 at 05:10:28AM +, Kroderia wrote: > Signed-off-by: Kroderia I doubt that is the name you sign legal documents with, right? Please fix that up, and give a much better subject: and body of the changelog for what you are doing. Look at the archives for how to properly do th

Re: [PATCH] staging: lustre: cleanup align switch and case

2014-12-22 Thread Greg KH
On Tue, Dec 23, 2014 at 07:38:04AM +0300, samuel kihahu wrote: > On Mon, Dec 22, 2014 at 01:18:01PM -0800, Greg KH wrote: > > On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote: > > > From: skihahu > > > > > > Align switch and case to be at the sam

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Greg KH
On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote: > Thanks for your tip. People say this is not a legal name, but I really > use this for all my English profile. I create another name sound like > my real name and it cause this "From" display. So sorry bothering you. > I will really check it a

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Greg KH
On Wed, Dec 24, 2014 at 12:18:53AM +0800, Gmail wrote: > I found no one using the words like Chinese, Japanese here. Not true, feel free to do so, there is no reason not to. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.l

Re: [PATCH v2] Redone: dgnc/digi.h: checkpatch: Macros in enclosed

2014-12-23 Thread Greg KH
On Tue, Dec 23, 2014 at 03:11:11PM +0100, Simone Weiss wrote: > I've redone the previous patch as I have also forgotten a macro. That's a horrible changelog entry, what does it mean? And why the "redone" in the subject, that would force me to edit it by hand, right? Please don't do that, you wan

Re: [PATCH 0/5] *** SUBJECT HERE ***

2015-01-03 Thread Greg KH
On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote: > *** BLURB HERE *** What blurb? What subject? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

2015-01-04 Thread Greg KH
On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote: > This is patch to file pcl812.c that fix up warning line > over 80 character which is found by checkpatch tool. > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/comedi/drivers/pcl812.c | 3 ++- > 1 file cha

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

2015-01-04 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Jan 05, 2015 at 09:34:57AM +0530, jitendra kumar khasdev wrote: > Hello, > Will I have to resubmit by combining all 5 into 1 patch? Please give me > suggestion  so that I can do it in correct

Re: [PATCH] staging: ft1000: Fix code style issue

2015-01-07 Thread Greg KH
On Wed, Jan 07, 2015 at 12:57:05PM +0530, Arjun AK wrote: > Remove unnecessary braces from single statement blocks. > > Signed-off-by: Arjun AK Is that the name you use to sign legal documents? If so, great, otherwise, please resend it with the correct name. thanks, greg k-h _

Re: [PATCH] Fixed line over 80 characters warning

2015-01-07 Thread Greg KH
On Wed, Jan 07, 2015 at 10:37:26PM +0530, sakshi wrote: > Signed-off-by: sakshi Your subject needs to provide a little bit more data, as what part of the kernel you are modifying, and the like. Look at existing patches for examples of this. Also, we need a changelog body, saying what you are do

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-09 Thread Greg KH
On Sun, Jan 04, 2015 at 04:22:35PM +0100, Piotr Kubus wrote: > This is a patch to the dmm32at.c file that fixes up a code indent error found > by the checkpatch.pl tool. > > Signed-off-by: Piotr Kubus > --- > drivers/staging/comedi/drivers/dmm32at.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c

2015-01-09 Thread Greg KH
On Mon, Dec 29, 2014 at 02:42:56PM +0530, jitendra kumar khasdev wrote: > This is a patch to the s626.c file that fixes up a space error > found by the checkpatch.pl tool > > Signed-off-by: Jitendra Kumar Khasdev > Reviewed-by: Ian Abbott > --- > drivers/staging/comedi/drivers/s626.c | 2 +- >

Re: [PATCH v2] Staging: comedi: dmm32at: Fix a code indent issue

2015-01-09 Thread Greg KH
On Tue, Jan 06, 2015 at 11:16:16AM +0100, Piotr Kubus wrote: > Fixed a code indent error found by checkpatch.pl in dmm32at.c. > > Signed-off-by: Piotr Kubus > --- > v2: make the commit message clearer and shorter > > drivers/staging/comedi/drivers/dmm32at.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH v5] Staging: comedi: fix line over 80 characters warning

2015-01-09 Thread Greg KH
On Fri, Jan 09, 2015 at 10:05:56PM +0530, jitendra kumar khasdev wrote: > This is patch to file pcl812.c that fix line over 80 > characters warning which is found by checkpatch.pl tool. You also do something else in here, that you did not document, so I can't accept this patch :(

Re: [PATCH 51/69] staging: unisys: remove ERRDRV and related macros

2015-01-09 Thread Greg KH
On Fri, Dec 05, 2014 at 05:09:26PM -0500, Benjamin Romer wrote: > Remove the ERRDRV() macro family and use pr_err directly everywhere it was > used. > Completely remove any error messages that used the macro but are redundant, > for > example, several of the messages were from memory allocation f

Re: [PATCH 52/69] staging: unisys: remove DBGINF() macros

2015-01-09 Thread Greg KH
On Fri, Dec 05, 2014 at 05:09:27PM -0500, Benjamin Romer wrote: > Remove the DBGINF() group of logging macros and use pr_debug() instead. Fix > places that used the DBGINF() macro so they actually print the expected value, > because they were not being compiled at all before the switchover. > > Si

Re: [PATCH 53/69] staging: unisys: get rid of LOGINFO() macros

2015-01-09 Thread Greg KH
On Fri, Dec 05, 2014 at 05:09:28PM -0500, Benjamin Romer wrote: > Remove the entire set of LOGINFO() macros and replace them with calls to > pr_info() instead. > > Signed-off-by: Ken Depro > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/include/timskmod.h | 5 -- > driv

Re: [PATCH 55/69] staging: unisys: get rid of LOGWRN() macro and uisklog.h

2015-01-09 Thread Greg KH
On Fri, Dec 05, 2014 at 05:09:30PM -0500, Benjamin Romer wrote: > Get rid of LOGWRN() and all related macros, and call pr_warn() directly > instead. Side note, are you setting pr_fmt() properly so that everything is "unified" with these messages? No driver subsystem should ever use a pr_* call u

Re: [PATCH v6] Staging: comedi: patch to fix 80 characters line over warnings

2015-01-09 Thread Greg KH
On Sat, Jan 10, 2015 at 09:54:39AM +0530, jitendra kumar khasdev wrote: > This is the patch to pcl812.c that fix 80 character line over warnings. > These warnings are identified by checkpatch.pl tool. > For this patch I have did following changes, > 1. convert single line comment into multiline com

Re: [PATCH v2 1/4] staging: rtl8192u: fix comments

2015-01-10 Thread Greg KH
On Wed, Dec 31, 2014 at 09:10:40PM +, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c and cleans up existing ANSI C comments. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 811 >

Re: [PATCH 3/3] Staging: nvec: Fixed a typo

2015-01-11 Thread Greg KH
On Sun, Jan 11, 2015 at 03:12:15PM -0600, Gustavo A. R. Silva wrote: > Fixed a typo in nvec.c file > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/nvec/nvec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Where are patches 1/3 and 2/3? __

Re: [PATCH 4/4] Staging: octeon-usb: Fixed a typo

2015-01-11 Thread Greg KH
On Sun, Jan 11, 2015 at 03:23:06PM -0600, Gustavo A. R. Silva wrote: > Fixed a typo in octeon-hcd.c file > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Where are patches 1/4, 2/4, and 3/4? __

Re: [PATCH 3/3] Staging: nvec: Fixed a typo

2015-01-11 Thread Greg KH
On Sun, Jan 11, 2015 at 03:33:01PM -0600, Gustavo A. R. Silva wrote: > > > 2015-01-11 15:27 GMT-06:00 Greg KH : > > On Sun, Jan 11, 2015 at 03:12:15PM -0600, Gustavo A. R. Silva wrote: > > Fixed a typo in nvec.c file > > > > S

Re: [PATCH] Staging: line6: Updated comma spacing to fit within coding style

2015-01-12 Thread Greg KH
On Sat, Dec 27, 2014 at 05:00:10PM +1100, Damon Swayn wrote: > Fixed a coding style issue reported by checkpatch surrounding the > spacing of comma's > > Signed-off-by: Damon Swayn > --- > drivers/staging/line6/pcm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Sorry, someone e

Re: [PATCH] Staging: line6: fix coding style issue in pcm.h

2015-01-12 Thread Greg KH
On Mon, Dec 22, 2014 at 10:45:01PM +0200, Dmitriy Polyanskiy wrote: > This is a patch to pcm.h file that fixes up some space warnings > found by checkpatch.pl > > Signed-off-by: Dmitriy Polyanskiy > --- > drivers/staging/line6/pcm.h |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-

Re: [PATCH 1/1] [PATCH] Staging:vt6655: sparse warning fix

2015-01-12 Thread Greg KH
On Tue, Dec 09, 2014 at 08:58:31PM +0530, Adithya K wrote: > From: Adithya Krishnamurthy > > Fixed sparse warning(symbol was not declared. Should it be static) fix. > > Signed-off-by: Adithya Krishnamurthy > --- > --- > drivers/staging/vt6655/device_main.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH] staging: vt6655: remove unused function in mac.c

2015-01-12 Thread Greg KH
On Wed, Dec 10, 2014 at 01:50:16PM +0800, Fred Chou wrote: > From: Fred Chou > > Removed the unused function MACvGetShortRetryLimit, which also > fixed the following sparse warning: > drivers/staging/vt6655/mac.c:162:6: warning: > symbol 'MACvGetShortRetryLimit' was not declared. Should it be st

Re: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-12 Thread Greg KH
On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote: > On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote: > > This patch fixes the following checkpatch.pl error: > > rxtx.c:588: WARNING: else is not generally useful after a break or return > > was the checkpatch error solve

Re: [PATCH] staging:vt6655 Add extern variable in head file

2015-01-13 Thread Greg KH
On Tue, Jan 13, 2015 at 04:31:14PM +0800, sun wang wrote: > Extern variable must be declared in head file. Compiler can catch the > inconsistency when variable changes. > > Signed-off-by: Sun Wang > --- > drivers/staging/vt6655/ioctl.c | 1 - > drivers/staging/vt6655/ioctl.h | 5 + > 2 fil

Re: [PATCH] Staging: vt6656: Code cleanup: remove unreachable return

2015-01-13 Thread Greg KH
On Wed, Jan 14, 2015 at 04:07:40AM +1100, Emrys Bayliss wrote: > This patch removes an unnecessary return statement that cannot be reached. > > Signed-off-by: Emrys Bayliss > --- > drivers/staging/vt6656/rxtx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vt6656/rxt

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Greg KH
On Wed, Jan 14, 2015 at 04:03:24AM +1100, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement was replaced with a block to avoid the follo

Re: [PATCH] Staging: dgnc: fixed depreciated EXTRA_CFLAGS in MakeFile

2015-01-13 Thread Greg KH
On Tue, Jan 13, 2015 at 06:54:38PM +0900, Joshua James wrote: > Replaced depreciated EXTRA_CFLAGS with ccflags-y as identified by checkpatch: > WARNING: Use of EXTRA_CFLAGS is deprecated, please use `ccflags-y instead. > +EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" > > Signe

[GIT PULL] Staging driver fixes for 3.19-rc5

2015-01-16 Thread Greg KH
The following changes since commit b7392d2247cfe6771f95d256374f1a8e6a6f48d6: Linux 3.19-rc2 (2014-12-28 16:49:37 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.19-rc5 for you to fetch changes up to a307d1d6d4c

Re: [PATCH] Staging: rtl8723au: fix space coding style issue in os_intfs.c

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 03:52:45PM +0100, Peter Poklop wrote: > From: Peter This name doesn't match up with: > > This patch fixes the checkpatch.pl warning: > > WARNING: space prohibited before semicolon > > Signed-off-by: Peter Poklop this name, why? Please fix up and resend. Or better y

Re: [PATCH RESEND 1/4] staging: rtl8192u: fix comments

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 02:19:11PM +, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c, and cleans up existing ANSI C comments. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 811 >

Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote: > This is patch to pcl812.c that fix line over 80 characters warning > which is found by checkpatch.pl tool. Reduce the extra space around > equal sign that fix warning. > > Signed-off-by: Jitendra kumar khasdev > --- > driv

Re: [PATCH v3] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 04:12:58AM +1100, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement was replaced with a block to avoid the follo

Re: [PATCH] Fixed else statement following a return statement in if block in hfa384x_usb.c

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 10:09:04AM +0530, Asheesh Ranjan wrote: > This fixes a else after if block containing return statement warning as found > by checkpatch.pl > > Signed-off-by: Asheesh Ranjan > --- > drivers/staging/wlan-ng/hfa384x_usb.c |9 - > 1 file changed, 4 insertions(+),

Re: [PATCH] Replacing simple_strtoul with kstrtoul

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 12:00:42PM +0530, Asheesh Ranjan wrote: > Added code to move pointer till end of parsed string as being done by > simple_strtoul. Not checking return value of kstrtoul > Signed-off-by: Asheesh Ranjan > --- > drivers/staging/speakup/varhandlers.c | 17 +++-- >

Re: [PATCH] staging: gdm724x: fix space coding style issue in gdm_mux.c

2015-01-17 Thread Greg KH
On Sun, Jan 04, 2015 at 09:23:44AM +0100, Ning Zhou wrote: > This is a patch to fix a space error found by the checkpatch.pl in > file gdm_mux.c. > > Signed-off-by: Ning Zhou > --- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH] Staging : gdm724x: Remove space before , in function arguments

2015-01-17 Thread Greg KH
On Sun, Dec 21, 2014 at 08:18:19AM +0530, Mohammad Jamal wrote: > This patch solves space prohibited before , warning in gdm_mux.c > > Signed-off-by: Mohammad Jamal > --- > drivers/staging/gdm724x/gdm_mux.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stag

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2015-01-17 Thread Greg KH
On Sun, Dec 21, 2014 at 11:44:43AM +0100, Robert Nachlinger wrote: > This is a patch to the gdm_mux.c file that fixes a space before comma > coding style issue found by the checkpatch.pl tool. > > Signed-off-by: Robert Nachlinger > --- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 1 file changed

Re: [PATCH 3/6] dgnc/dpacompat.h: checkpatch: fixed long lines bei moving comments

2015-01-17 Thread Greg KH
On Mon, Dec 22, 2014 at 02:17:31AM +0100, Simone Weiss wrote: > > Signed-off-by: Simone Weiss > Signed-off-by: Helene Gsaenger > --- > drivers/staging/dgnc/dpacompat.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dpacompat.h > b/drivers/s

Re: [PATCH] staging: skein: Fix checkpatch warnings

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote: > Remove do {} while (0) loops around single statements in > skein/skein_block.c > > Signed-off-by: Arno Tiemersma > --- > drivers/staging/skein/skein_block.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-)

Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-17 Thread Greg KH
On Sun, Jan 11, 2015 at 03:41:05PM -0800, Shirish Gajera wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Single statement macros should not use a do {} while (0) loop > > I remove do while from the single statement macro. > > Signed-off-by: Shirish Gajera > --- > drivers/stag

<    3   4   5   6   7   8   9   10   11   12   >