On Tue, Feb 09, 2021 at 01:21:16AM +0530, Mukul Mehar wrote:
> >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001
> From: Mukul Mehar
> Date: Mon, 8 Feb 2021 01:03:06 +0530
> Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue.
>
> This patch fixes a warning, o
On Tue, Feb 09, 2021 at 11:27:04AM +0530, Atul Gopinathan wrote:
> Fix the following types of checkpatch error and warning:
>
> ERROR: code indent should use tabs where possible
> WARNING: struct phy_ops should normally be const
That is 2 different things, which means this should be 2 different
p
On Tue, Feb 09, 2021 at 11:53:11AM +0530, Mukul Mehar wrote:
> >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001
> From: Mukul Mehar
> Date: Mon, 8 Feb 2021 01:03:06 +0530
> Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue.
Why is this still an attached fil
On Tue, Feb 09, 2021 at 06:20:37PM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar
> ---
> drivers/staging/most/sound/sound.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
On Tue, Feb 09, 2021 at 06:36:19PM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar
> ---
> drivers/staging/most/sound/sound.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
On Tue, Feb 09, 2021 at 08:24:15PM +0530, ameynarkhed...@gmail.com wrote:
> From: Amey Narkhede
>
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate usbdev buffer
> using kmalloc().
>
> Signed-off-by: Amey Narkhede
> ---
> drivers/staging/gdm724x/gdm_usb.c | 6
On Wed, Feb 10, 2021 at 01:01:47AM +0530, ameynarkhed...@gmail.com wrote:
> From: Amey Narkhede
>
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate hci_packet buffer
> using kzalloc().
>
> Signed-off-by: Amey Narkhede
> ---
> drivers/staging/gdm724x/gdm_usb.c
On Wed, Feb 10, 2021 at 06:30:45AM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar
> ---
> Changes since v1:
> - Fixed indentation.
> ---
> drivers/staging/most/sound/sound.c | 6 +++---
> 1 file
On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate hci_packet buffer
> using kzalloc().
>
> Signed-off-by: Amey Narkhede
> ---
> Changes in v2:
> - Fixed build warning
> - Fixed memory leak
On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote:
> On 21/02/10 09:06AM, Greg KH wrote:
> > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> > > Stack allocated buffers cannot be used for DMA
> > > on all architectures so allocate hci_packet
On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote:
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate hci_packet buffer
> using kmalloc.
>
> Signed-off-by: Amey Narkhede
> ---
> Changes in v3:
> - Remove superfluous buf pointer
> - Reduce s
On Wed, Feb 10, 2021 at 03:59:52PM +0100, Mairo Paul Rufus wrote:
> Signed-off-by: Mairo Paul Rufus
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 2 +-
> drivers/staging/wlan-ng/prism2mib.c| 2 +-
> drivers/staging/wlan-ng/prism2sta.c| 4 ++--
> 3 files changed, 4 insertions(+), 4 dele
On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also
> fix opening brace placements and trailing single statement layout within
> RT_PRINT_DATA, as well as making newline character placement more
> consistent and removi
On Wed, Feb 10, 2021 at 05:34:38PM +, Phillip Potter wrote:
> On Wed, Feb 10, 2021 at 06:12:54PM +0100, Greg KH wrote:
> > On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also
> > > f
On Wed, Feb 10, 2021 at 06:55:44PM +, Phillip Potter wrote:
> On Wed, Feb 10, 2021 at 09:40:27PM +0300, Dan Carpenter wrote:
> > On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C.
> >
> > I'm pretty hip to checkpa
On Thu, Feb 11, 2021 at 01:14:39AM +0300, Fatih YILDIRIM wrote:
> Signed-off-by: Fatih YILDIRIM
> ---
> drivers/staging/greybus/loopback.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c
> b/drivers/staging/greybus/loopback.
On Thu, Feb 11, 2021 at 09:25:43AM +0300, Fatih YILDIRIM wrote:
> Signed-off-by: Fatih YILDIRIM
> ---
> Hi,
> I have a coding style fix.
> By the way, I'm following the Eudyptula Challenge Linux kernel tasks
> and this is my first patch related to my task no 10.
> I hope I'm doing it the right way
On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
> This patch add fixes an checkpatch error for "Macros with multiple statements
> should be enclosed in a do - while loop"
>
> Signed-off-by: Hemansh Agnihotri
Any reason you didn't test-build your patch before sending it out?
T
On Thu, Feb 11, 2021 at 12:22:39PM +0300, Fatih Yildirim wrote:
> Fix for checkpatch.pl warning:
> Macros with complex values should be enclosed in parentheses.
>
> Signed-off-by: Fatih Yildirim
> ---
> drivers/staging/ks7010/ks_hostif.h | 24
> 1 file changed, 12 insert
On Thu, Feb 11, 2021 at 01:57:04PM +0300, Fatih YILDIRIM wrote:
> On Thu, Feb 11, 2021 at 11:02:51AM +0100, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 12:22:39PM +0300, Fatih Yildirim wrote:
> > > Fix for checkpatch.pl warning:
> > > Macros with complex values should
On Thu, Feb 11, 2021 at 04:26:36PM +0530, Pritthijit Nath wrote:
> kshostif.h
Why is this in the changelog text?
>
> fixed ERROR: Macros with complex values should be enclosed in
> paranthesis
What does that mean?
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/ks7010/ks_hostif.h
On Thu, Feb 11, 2021 at 03:23:24PM +0300, Fatih Yildirim wrote:
> On Thu, Feb 11, 2021 at 12:10:44PM +0100, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 01:57:04PM +0300, Fatih YILDIRIM wrote:
> > > On Thu, Feb 11, 2021 at 11:02:51AM +0100, Greg KH wrote:
> > > > On T
On Thu, Feb 11, 2021 at 09:45:53PM +0530, Hemansh Agnihotri wrote:
> This fixes following warnings and errors as reported by checkpatch.pl:
> 1) WARNING: Missing a blank line after declarations
> 2) WARNING: Block comments use a trailing */ on a separate line
> 3) ERROR: code inde
On Thu, Feb 11, 2021 at 05:55:18PM +0100, Mairo P. Rufus wrote:
> > Hi,
> >
> > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> > a patch that has triggered this response. He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
>
On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match
> open parenthesis".
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/vt6656/rf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Thu, Feb 11, 2021 at 09:00:01PM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match
> open parenthesis".
> In addition the misspelling of "transferred" also has been fixed.
When you say "also" or "in addition" in a changelog, that is a h
On Thu, Feb 11, 2021 at 10:43:20PM +0530, Hemansh Agnihotri wrote:
> This fixes checkpatch errors :- "else should follow close brace '}'",
> "space required before the open parenthesis '('" and "spaces required
> around that '?' (ctx:VxW)" in drivers/staging/wimax/i2400m/rx.c file.
>
> Signed-off-
On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote:
> Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
> function:
>
> wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
> wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=
> wimax/i2400m/fw
On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote:
> On 12/02/21 1:59 am, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
> >> This change fixes a checkpatch CHECK style issue for "Alignment should
> >> match ope
On Fri, Feb 12, 2021 at 02:27:39AM +0530, roz wrote:
> Signed-off-by: roz
> ---
> drivers/staging/ks7010/ks_hostif.h | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.h
> b/drivers/staging/ks7010/ks_hostif.h
> in
On Fri, Feb 12, 2021 at 02:32:51AM +0530, Pritthijit Nath wrote:
> On 12/02/21 2:14 am, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote:
> >> On 12/02/21 1:59 am, Greg KH wrote:
> >>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Prit
On Fri, Feb 12, 2021 at 02:56:47AM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should
> match open parenthesis".
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/vt6656/rf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Fri, Feb 12, 2021 at 01:28:45PM +0530, shivang upadhyay wrote:
> Signed-off-by: shivang upadhyay
> ---
> drivers/staging/ks7010/ks_hostif.h | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.h
> b/drivers/stagi
On Fri, Feb 12, 2021 at 08:43:29AM +0100, Sergio Paracuellos wrote:
> Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml'
> contains 'mediatek' as a valid vendor string. Some nodes in the device
> tree are using an invalid vendor string vfor 'mtk' instead. Fix all of
> them in d
On Fri, Feb 12, 2021 at 08:43:28AM +0100, Sergio Paracuellos wrote:
> Clocks for SoC mt7621 have been properly integrated so there is
> no need to declare fixed clocks at all in the device tree. Remove
> all of them, add new device tree nodes for mt7621-clk and update
> the rest of the nodes to use
On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote:
> On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> > Fixed the spelling of 'transfered' to 'transferred'.
> >
> > Signed-off-by: Pritthijit Nath
> > ---
> > drivers/staging/greybus/hid.c | 2 +-
> > 1 file changed, 1
On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> On 12-02-21, 13:48, Pritthijit Nath wrote:
> > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > open parenthesis".
> >
> > Signed-off-by: Pritthijit Nath
> > ---
> > drivers/staging/greybus/hid.c | 4
On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:17, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > > This change fixes a checkpatch CHECK sty
On Fri, Feb 12, 2021 at 03:20:08PM +0530, Pritthijit Nath wrote:
> Fixed the spelling of 'transfered' to 'transferred'.
>
> Signed-off-by: Pritthijit Nath
> ---
> Fixed the typo in the patch which was meant to fix that very typo.
> Really sorry for last time.
> Hope this does not have any othe
On Fri, Feb 12, 2021 at 08:00:25PM +0530, Anirudh Rayabharam wrote:
> On Thu, Feb 11, 2021 at 09:35:27PM +0100, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote:
> > > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepar
On Fri, Feb 12, 2021 at 04:58:33PM +0200, Alaa Emad wrote:
> This change fixes a checkpatch error for "space prohibited before that close
> parenthesis ')'"
>
> Signed-off-by: Alaa Emad
> ---
> certs/x509_revocation_list| 0
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> 2 files change
On Sun, Feb 14, 2021 at 01:48:06AM +0530, Ashish Vara wrote:
> removed unnecessary out of memory message
>
> Signed-off-by: Ashish Vara
> ---
> drivers/staging/gasket/gasket_page_table.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_page_table.c
> b/dr
On Mon, Feb 15, 2021 at 05:15:34PM +0530, shivang upadhyay wrote:
> checkpatch.pl complains about missing parentheses
> "Macros with complex values should be enclosed in parentheses".
> fixed that
>
>
> Signed-off-by: shivang upadhyay
> ---
> drivers/staging/ks7010/ks_hostif.h | 24
On Mon, Feb 15, 2021 at 04:36:52PM +0200, Alaa Emad wrote:
> This patch fix the following issues in hi6421-spmi-pmic.c file:
>
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space
> before tabs
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space
> b
On Mon, Feb 15, 2021 at 05:02:50PM +0200, Alaa Emad wrote:
> sorry ,i thought it needs to change the description so i resent .
If so, then say what you changed below the --- line and make it a v2
patch, like the Documentation tells you to do, right?
> please guide me how to fix this or it is good
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04:
Linux 5.11-rc5 (2021-01-24 16:47:14 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.12-rc1
for you to fetch changes up to 4eb839aef182
On Tue, Feb 16, 2021 at 08:40:58PM +0530, Selvakumar Elangovan wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/ks7010/ks_hostif.h | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/stag
On Wed, Feb 17, 2021 at 09:28:09AM +0100, Benjamin Gaignard wrote:
>
> Le 17/02/2021 à 09:08, Greg KH a écrit :
> > On Wed, Feb 17, 2021 at 09:02:48AM +0100, Benjamin Gaignard wrote:
> > > The IMX8MQ got two VPUs but until now only G1 has been enabled.
> > > This se
On Wed, Feb 17, 2021 at 06:58:16PM +0530, mayanksu...@live.com wrote:
> From: Mayank Suman
>
> The change was suggested by checkpatch.pl.
What change?
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for a description of how to
wr
On Wed, Feb 17, 2021 at 09:12:55PM +0530, Pritthijit Nath wrote:
> This change fixes a sparse warning "incorrect type in argument 1
> (different address spaces)".
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote:
> Resolve the following warning generated by sparse:
>
> drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in
> assignment (different address spaces)
> drivers/staging//comedi/comedi_fops.c:2956:23:expected
On Wed, Feb 17, 2021 at 11:40:00PM +0530, Atul Gopinathan wrote:
> On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote:
> > On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote:
> > > Resolve the following warning generated by sparse:
> > >
&g
On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote:
> Resolve the following sparse warning:
> drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in
> argument 1 (different address spaces)
> drivers/staging//comedi/comedi_fops.c:2983:41:expected void [noderef]
On Thu, Feb 18, 2021 at 02:40:15PM +0530, Pritthijit Nath wrote:
> This change fixes a sparse address type mismatch warning "incorrect type
> in assignment (different address spaces)".
>
> Signed-off-by: Pritthijit Nath
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +---
On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote:
> It is wrong to change the endianness of a variable which has just one
> byte size.
>
> Sparse warnings fixed:
> drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted
> __le32
> drivers/staging//wimax/i24
On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> > On 18/02/2021 08:44, Atul Gopinathan wrote:
> > > Fix the following warning generated by sparse:
> > >
> > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: in
On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote:
> On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote:
> > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> > > On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> > >
On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo
> ---
>
> Checkpatch complains the constant needs to be on the right side of the
> comparison. The preferred way is:
>
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 in
On Thu, Feb 18, 2021 at 10:50:43PM +0530, Suryashankar Das wrote:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Suryashankar Das
> ---
> drivers/staging/rtl8188eu/cor
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
On Thu, Feb 18, 2021 at 07:50:27PM +, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo
> ---
>
> The preferred coding style is:
> if (!StaAddr)
> return;
>
> thank you mr. dan carpenter
>
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertio
On Thu, Feb 18, 2021 at 11:28:14PM +0300, Nikolay Kyx wrote:
> kpc2000_i2c.c:
> fix WARNING: line length of 124 exceeds 100 columns
> fix CHECK: Alignment should match open parenthesis
>
> kpc2000_spi.c:
> fix CHECK: Alignment should match open parenthesis
This changelog is a bit odd.
Please rea
On Sun, Feb 14, 2021 at 07:44:52PM +0530, Ashish Vara wrote:
> From: Ashish Vara
>
> removed unnecessary out of memory message to fix coding style warning.
>
> Signed-off-by: Ashish Vara
> ---
> drivers/staging/gasket/gasket_page_table.c | 2 --
> 1 file changed, 2 deletions(-)
Your subject l
On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote:
> In hi6421-spmi-pmic.c, there are some warnings and Check:
>
> "WARNING: please, no space before tabs" in lines 51,52,53 and 69.
> "CHECK: Alignment should match open parenthesis" in lines 180 and 238.
>
> Signed-off-by: Alaa Emad
That
On Thu, Feb 18, 2021 at 03:58:51PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 del
On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote:
> fwserial.c:
Why is this here?
> fix CHECK: Alignment should match open parenthesis
What does this mean?
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is ne
On Fri, Feb 19, 2021 at 11:04:51AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: line length of 124 exceeds 100 columns
> CHECK: Alignment should match open parenthesis
That's two different things, please make this two different patches.
thanks,
On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> I was unable to align it right below the opening parenthesis, just by using
> tabs. And when I did that with spaces, the checkpatch yelled at me for
> using spaces. Any suggestions how to do this without using spaces? I am
>
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
> This patch renames CamelCase macros uVar and uModulo into u_var and
> u_module in device.h
>
> This issue was reported by checkpatch.pl
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/vt6656/device.h | 8 +++
On Fri, Feb 19, 2021 at 03:43:39PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations should
> normally be const".
>
> Signed-off-by: Amrit Khera
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations
> should normally be const".
>
> Signed-off-by: Amrit Khera
> ---
> Changes in v2:
> - Wrapped the commit description
> - Build tested
If you tested it, what change
On Fri, Feb 19, 2021 at 04:21:12PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 del
On Fri, Feb 19, 2021 at 02:50:53PM +, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
This all goes below the --- line please.
Please make a v3.
thanks,
greg k-h
___
On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote:
> commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
> Author: Julian Braha
> Date: Fri Feb 19 17:02:24 2021 -0500
>
> staging: rtl8192e: fix kconfig dependency on CRYPTO
>
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is
On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote:
> netdev.c
Why is this here?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Feb 20, 2021 at 05:58:35PM +0530, RajMAIN wrote:
>
> On 20-02-2021 16:42, Greg KH wrote:
> > On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote:
> > > netdev.c
> > Why is this here?
>
> You mean that filename? I thought I should mention it.
On Fri, Feb 19, 2021 at 02:38:51PM +, Lee Gibson wrote:
> This patch fixes the checkpatch warnings such as:
>
> hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs
>
> Signed-off-by: Lee Gibson
> ---
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8
> 1 file changed, 4 in
me style warnings remain valid here and could be fixed by
> another patch.
>
> v2: Edited changelog, as suggested by Greg KH
> v3: Splitted patch in two parts, as suggested by Greg KH
>
You sent 2 different patches, that did different things, yet have the
same exact subject line
On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
>
> Signed-off-by: Amrit Khera
> ---
> drivers/staging/wimax/stack.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> di
On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote:
> netdev.c
>
> fixing style ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Rajesh Kumbhakar
> ---
> Changes in v2:
> - Removed filename from commit message.
filename is still in commit message :(
On Sat, Feb 20, 2021 at 12:22:43PM -0500, Julian Braha wrote:
> >From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001
> From: Julian Braha
> Date: Sat, 20 Feb 2021 12:07:30 -0500
> Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO
Why is this all in the body o
On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote:
> The "CcxRmState" field in struct "rtllib_network" is defined
> as a u16 array of size 2 (so, 4 bytes in total).
>
> But the operations performed on this array throughout the code
> base (in rtl8192e/) are all in byte size 2 indicat
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
That's not all this patch does, please be descriptive of what you really
do and why you are doing it.
thanks,
greg k-h
_
On Sun, Feb 21, 2021 at 10:27:21PM +0530, Atul Gopinathan wrote:
> On Sun, Feb 21, 2021 at 02:08:26PM +0100, Greg KH wrote:
> > On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote:
> > > The "CcxRmState" field in struct "rtllib_network" is defined
On Thu, Feb 25, 2021 at 10:03:51AM +, Lee Gibson wrote:
> Fixes this checkpatch warning
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Lee Gibson
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deleti
On Fri, Feb 26, 2021 at 11:48:29AM +, Lee Gibson wrote:
> Function _rtl92e_wx_set_scan calls memcpy without checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
>
> Signed-off-by: Lee Gibson
> -
On Tue, Mar 02, 2021 at 10:11:02AM +0100, gabriele.mod...@gmail.com wrote:
> From: Gabriele Modena
>
> When running checkpatch.pl on op-msg.c, op-rfkill.c
> and stack.c I noticed that they contained a few style issues
> at warning level of severity. This patch is both an attempt to
> address the
On Tue, Mar 02, 2021 at 06:12:54PM +0530, Vikas Kumar Sharma wrote:
> Disclaimer:This message is intended only for the designated recipient(s).
> It may contain confidential or proprietary information and may be subject
> to other confidentiality protections. If you are not a designated
> recipi
On Sat, Feb 27, 2021 at 07:06:14PM -0600, Darryl T. Agostinelli wrote:
> Undo the flex array in struct ieee80211_info_element. It is used as the flex
> array type in other structs (creating a flex array of flex arrays) making
> sparse unhappy. This change maintains the intent of the code and sati
On Mon, Feb 22, 2021 at 10:53:30PM +0530, Atul Gopinathan wrote:
> On Mon, Feb 22, 2021 at 04:26:33PM +0100, Greg KH wrote:
> > On Sun, Feb 21, 2021 at 10:27:21PM +0530, Atul Gopinathan wrote:
> > > On Sun, Feb 21, 2021 at 02:08:26PM +0100, Greg KH wrote:
> > > > On S
On Sat, Mar 06, 2021 at 12:38:17PM +0600, nabil5352 wrote:
> Fixed a struct without const
>
> Signed-off-by: nabil5352
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
> b/drivers/staging/android/
On Fri, Mar 05, 2021 at 08:55:09PM +0100, gabriele.mod...@gmail.com wrote:
> From: Gabriele Modena
>
> Fix style warnings reported by checkpatch.pl on op-rfkill.c
> by moving */ on a separate line in a block comment,
> adding a missing blank line after declarations,
> and reformatting a quoted st
On Mon, Mar 08, 2021 at 02:59:47PM +0800, zhengxu...@mxic.com.tw wrote:
> CONFIDENTIALITY NOTE:
>
> This e-mail and any attachments may contain confidential information
> and/or personal data, which is protected by applicable laws. Please be
> reminded that duplication, disclosure, distribution,
On Mon, Mar 08, 2021 at 04:54:58PM +0200, Alexandru Ardelean wrote:
> The intent is the removal of the 'delay_usecs' field from the
> spi_transfer struct, as there is a 'delay' field that does the same
> thing.
>
> The spi_delay_to_ns() can be used to get the transfer delay. It works by
> using th
On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote:
> Hello Greg,
>
> On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote:
> > Hello Muhammad,
> >
> > Sorry, I am a bit late for the review of this patch. Thank you for your
> > contribution.
> >
> > On Thursday 11 February 20
On Tue, Mar 09, 2021 at 06:24:45PM +0530, Selvakumar Elangovan wrote:
> Removed additional whitspaces and added space around the binary operator in
> the rtl8712_xmit.h file
Please wrap your changelog at 72 columns.
And you are doing 2 different things in this patch, please only do one
"logical"
On Tue, Mar 09, 2021 at 07:47:21PM +0530, Selvakumar Elangovan wrote:
> Removed additional whitespaces in the rtl8712_xmit.h file.
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/rtl8712/rtl8712_xmit.h | 3 ---
> 1 file changed, 3 deletions(-)
What changed from v1? Always put t
On Tue, Mar 09, 2021 at 02:45:56PM +0100, Jérôme Pouiller wrote:
> On Tuesday 9 March 2021 14:07:43 CET Greg KH wrote:
> > On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote:
> > > Hello Greg,
> > >
> > > On Tuesday 2 March 2021 16:01:25 CET
On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch warnings:
>
> WARNING: Block comments use * on subsequent lines
> + /*
> + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> --
> WARNING: Block comments use * on subsequent lin
On Mon, Feb 22, 2021 at 05:14:09AM +0530, Mahak Gupta wrote:
> This patches fixes the checks- 'Alignment should match open parenthesis'
> of 'checkpatch.pl'.
>
> Signed-off-by: Mahak Gupta
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 32 +
> 1 file changed, 17 insert
101 - 200 of 4990 matches
Mail list logo
