Re: [GIT PULL] Staging/IIO driver patches for 4.19-rc1

2018-09-10 Thread Greg KH
On Tue, Aug 28, 2018 at 02:30:49PM +, Ahmed S. Darwish wrote: > Hi! > > On Tue, Aug 28, 2018 at 02:36:07PM +0200, Greg KH wrote: > > On Tue, Aug 28, 2018 at 10:38:17AM +, Ahmed S. Darwish wrote: > > > [ re-send; forgotten lkml CC added; sorry ] > > > >

Re: [PATCH 1/1] staging:rtl8192u: Rename dot11d_init to fix name clash

2018-09-10 Thread Greg KH
On Tue, Sep 04, 2018 at 11:56:23AM +0100, John Whitmore wrote: > The function dot11d_init() was previously renamed to clear a style > issue. Unfortunately the new name used, dot11d_init(), clashes with > a sybmol which is exported with the same name. To correct this > problem the function has been

Re: [PATCH] staging: android: ion: Add per-heap counters

2018-09-10 Thread Greg KH
On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote: > The heap statistics have been removed and currently even basics statistics > are missing. > > This patch creates per heap debugfs directory /sys/kernel/debug/ > and adds two counters - the number of allocated buffers and number of

Re: [PATCH] staging: clocking-wizard: Add support for dynamic reconfiguration

2018-09-10 Thread Greg KH
On Mon, Sep 10, 2018 at 10:47:28AM +0530, shubhrajyoti.da...@gmail.com wrote: > From: Shubhrajyoti Datta > > The patch adds support for dynamic reconfiguration of clock output rate. > Output clocks are registered as dividers and set rate callback function > is used for dynamic reconfiguration. >

Re: [PATCH 02/12] staging: wlan-ng: avoid use of camel case macro names in p80211metadef.h

2018-09-10 Thread Greg KH
On Thu, Aug 30, 2018 at 11:28:13AM +0100, Tim Collier wrote: > On Wed, Aug 29, 2018 at 02:37:36PM +0300, Dan Carpenter wrote: > > On Tue, Aug 28, 2018 at 08:26:13PM +0100, Tim Collier wrote: > > > checkpatch reported a number of "Avoid CamelCase" issues for macros > > > defined in p80211metadef.h (

Re: [PATCH] staging: android: ion: Add per-heap counters

2018-09-10 Thread Greg KH
On Mon, Sep 10, 2018 at 01:46:13PM +0300, Alexey Skidanov wrote: > > > On 09/10/2018 11:27 AM, Greg KH wrote: > > On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote: > >> The heap statistics have been removed and currently even basics statistics > >

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

2018-09-10 Thread Greg KH
On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > Rename the bit field element AdvCoding, as it causes a checkpatch issue > with CamelCase naming. As the element is not actually used in code it > has been renamed to 'not_used_adv_coding'. > > The single line of code which initialise

Re: [PATCH 20/20] staging:rtl8192u: Rename OWN - Style

2018-09-10 Thread Greg KH
On Sat, Sep 01, 2018 at 12:02:50AM +0100, John Whitmore wrote: > Rename the member variable 'OWN' to 'own', this is to comply with the > coding standard, where variables are named in lowercase. > > This is a simple coding style change which should have no impact on > runtime code execution. > > S

Re: [PATCH 19/20] staging:rtl8192u: Rename LINIP - Style

2018-09-10 Thread Greg KH
On Sat, Sep 01, 2018 at 12:02:49AM +0100, John Whitmore wrote: > Rename the member variable 'LINIP' to 'linip', this change is to > conform to the coding style guidelines, member variables in > lowercase. > > This is a simple coding style change which should not impact runtime > code execution. >

Re: [PATCH 18/20] staging:rtl8192u: Rename FirstSeg - Style

2018-09-10 Thread Greg KH
On Sat, Sep 01, 2018 at 12:02:48AM +0100, John Whitmore wrote: > Rename the member variable 'FirstSeg' to 'first_seg', this change > clears the checkpatch issue with CamelCase naming. > > This is a simple coding style change and as such should not impact > runtime code execution. > > Signed-off-b

Re: [PATCH] erofs: surround fault_injection ralted option parsing using CONFIG_EROFS_FAULT_INJECTION

2018-09-10 Thread Greg KH
On Mon, Sep 10, 2018 at 11:45:51PM +0800, Chengguang Xu wrote: > It's a little bit strange when fault_injection related > option fail with -EINVAL which was already disabled > from config, so surround all fault_injection related option > parsing code using CONFIG_EROFS_FAULT_INJECTION. Meanwhile, >

Re: [PATCH] staging: android: ion: Add per-heap counters

2018-09-10 Thread Greg KH
On Mon, Sep 10, 2018 at 06:51:18PM +0300, Alexey Skidanov wrote: > On 09/10/2018 05:21 PM, Greg KH wrote: > > On Mon, Sep 10, 2018 at 01:46:13PM +0300, Alexey Skidanov wrote: > >> On 09/10/2018 11:27 AM, Greg KH wrote: > > And you also moved debugfs files (you didn&#

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Greg KH
On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: > On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: > > @@ -546,6 +556,38 @@ void ion_device_add_heap(struct ion_heap *heap) > > } > > > > heap->dev = dev; > > + heap->num_of_buffers = 0; > > + heap->num_of_

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Greg KH
On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote: > > > On 09/11/2018 11:59 AM, Greg KH wrote: > > On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: > >> On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: > &g

Re: KASAN: null-ptr-deref Write in binder_update_page_range

2018-09-12 Thread Greg KH
On Fri, Sep 07, 2018 at 12:34:19PM +0900, Minchan Kim wrote: > Thanks, Martijn, > > Greg, could you have a look to pick up? Now queued up, thanks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail

[GIT PULL] Staging/IIO driver fixes for 4.19-rc4

2018-09-14 Thread Greg KH
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-4.19-rc4 for you to fetch changes up to 65aac1742328

Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested

2018-09-16 Thread Greg KH
On Mon, Sep 17, 2018 at 04:14:55AM +, k...@linuxonhyperv.com wrote: > From: Vitaly Kuznetsov > > 'error' variable is left uninitialized in case we see an unknown operation. > As we don't immediately return and proceed to pwrite() we need to set it > to something, HV_E_FAIL sounds good enough.

Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested

2018-09-17 Thread Greg KH
On Mon, Sep 17, 2018 at 02:16:48PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH > > Sent: Sunday, September 16, 2018 9:56 PM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; &g

Re: [PATCH v3] staging: android: ion: Add per-heap counters

2018-09-18 Thread Greg KH
On Tue, Sep 11, 2018 at 02:29:19PM +0300, Alexey Skidanov wrote: > Heap statistics have been removed and currently even basics statistics > are missing. > > This patch creates per heap debugfs directory /sys/kernel/debug/ > and adds the following counters: > - the number of allocated buffers; > -

Re: leaking path in android binder: set_nice

2018-09-25 Thread Greg KH
On Tue, Sep 25, 2018 at 01:27:11PM -0400, Tong Zhang wrote: > Kernel Version: 4.18.5 > > Problem Description: > > When setting nice value, it is checked by LSM function > security_task_setnice(). > see kernel/sched/core.c:3972 SYSCALL_DEFINE1(nice, int, increment) > > We discovered a leaking pa

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

2018-09-26 Thread Greg KH
On Wed, Sep 26, 2018 at 11:28:46AM -0700, Nick Desaulniers wrote: > On Wed, Sep 26, 2018 at 10:55 AM Nick Desaulniers > wrote: > > > > On Wed, Sep 26, 2018 at 12:41 AM Nathan Chancellor > > wrote: > > > > > > On Wed, Sep 26, 2018 at 09:13:59AM +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Sep

Re: [PATCH 06/13] staging:rtl8192u: Remove TxSTBC and RxSTBC - Style

2018-09-28 Thread Greg KH
On Wed, Sep 26, 2018 at 08:16:57PM +0100, John Whitmore wrote: > Remove the member variables TxSTBC and RxSTBC as neither is used in > code. > > This is a coding style change which should not impact runtime code > execution. Same as before, I think this _does_ impact runtime :( I'll stop here in

Re: [PATCH 05/13] staging:rtl8192u: Remove AdvCoding and GreenField - Style

2018-09-28 Thread Greg KH
On Wed, Sep 26, 2018 at 08:16:56PM +0100, John Whitmore wrote: > The member variables AdvCoding and GreenField are unused in code so > have been removed from the structure and associated initialisation > function. > > This is a coding style change which should have no impact on runtime > code exec

Re: [PATCH] staging: rtlwifi: coding style fixes

2018-09-29 Thread Greg KH
On Sat, Sep 29, 2018 at 11:47:47AM +0800, spring full wrote: > According to Documentation/process/coding-style.rst, > ``13) Printing kernel messages .. > Do not use crippled words like ``dont``; use ``do not`` or ``don't`` > instead``, > the word dont is changed to don't. > > Signed-off-by: Ch

Re: [PATCH] Staging: rts5208: rtsx_card: Fixed multiple coding style issues

2018-09-29 Thread Greg KH
On Fri, Sep 28, 2018 at 10:03:00PM -0400, Maxime Desroches wrote: > Fixed multiple coding style issues > > Signed-off-by: Maxime Desroches > --- > drivers/staging/rts5208/rtsx_card.c | 96 +++-- > 1 file changed, 37 insertions(+), 59 deletions(-) Hi, This is the friendl

Re: [PATCH 6/6] Staging: rts5208: xd.c: Fixed all braces issues of the file

2018-10-02 Thread Greg KH
On Sat, Sep 29, 2018 at 02:00:27PM -0400, Maxime Desroches wrote: > Fixed all the braces issues of the xd.c file > > Signed-off-by: Maxime Desroches > --- > drivers/staging/rts5208/xd.c | 232 ++- > 1 file changed, 92 insertions(+), 140 deletions(-) Again, missin

Re: [PATCH 5/5] Staging: rts5208: spi.c: Fixed all braces issues of the file

2018-10-02 Thread Greg KH
On Sat, Sep 29, 2018 at 12:09:50PM -0400, Maxime Desroches wrote: > Fixed all the braces issues of the spi.c file > > Signed-off-by: Maxime Desroches > --- > drivers/staging/rts5208/spi.c | 153 +- > 1 file changed, 59 insertions(+), 94 deletions(-) where are pat

Re: [PATCH] staging: rtlwifi: coding style fixes

2018-10-02 Thread Greg KH
On Sat, Sep 29, 2018 at 09:09:02PM +0800, Chunguang Wu wrote: > According to Documentation/process/coding-style.rst, > ``13) Printing kernel messages .. > Do not use crippled words like ``dont``; use ``do not`` or ``don't`` > instead``, > the word dont is changed to don't. > > Signed-off-by:

Re: [PATCH 1/6] Staging: rts5208: rtsx_card.c: Fixed all braces issues of the file

2018-10-03 Thread Greg KH
On Tue, Oct 02, 2018 at 07:11:26PM -0400, Maxime Desroches wrote: > Fixed all the braces issues of the rtsx_card.c file > > Signed-off-by: Maxime Desroches > --- > drivers/staging/rts5208/rtsx_card.c | 96 +++-- > 1 file changed, 37 insertions(+), 59 deletions(-) None of

Re: [PATCH] STAGING/EMXX_UDC: emxx_udc.c: Fixed all meaningful sparse errors: 1. Added static to udc_controller 2. Added mising __iomem modifier to handle p_regs 3. Added missing le16_to_cpu

2018-10-05 Thread Greg KH
On Fri, Oct 05, 2018 at 01:04:27PM -0400, Carmeli Tamir wrote: > Signed-off-by: Tamir Carmeli > --- > drivers/staging/emxx_udc/Makefile | 2 +- > drivers/staging/emxx_udc/emxx_udc.c | 69 > +++-- > drivers/staging/emxx_udc/emxx_udc.h | 2 +- > 3 files changed,

Re: [PATCH] staging: emxx_udc: Remove unused device_desc declaration

2018-10-09 Thread Greg KH
On Fri, Oct 05, 2018 at 02:05:45PM -0700, Nick Desaulniers wrote: > On Wed, Oct 3, 2018 at 10:56 PM Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/staging/emxx_udc/emxx_udc.c:1373:37: warning: variable > > 'device_desc' is not needed and will not be emitted > > [-Wunneeded-interna

Re: [PATCH] STAGING/EMXX_UDC: Fixed all meaningful sparse errors.

2018-10-09 Thread Greg KH
On Sat, Oct 06, 2018 at 03:13:39AM -0400, Carmeli Tamir wrote: > Fixed all meaningful sparse errors: > 1. Added static to udc_controller > 2. Added mising __iomem modifier to handle p_regs > 3. Added missing le16_to_cpu > > Signed-off-by: Tamir Carmeli > --- > Hi, This is the friendly patch

Re: [PATCH v4] staging: android: ion: Add per-heap counters

2018-10-09 Thread Greg KH
On Sun, Sep 30, 2018 at 06:24:52PM +0300, Alexey Skidanov wrote: > Heap statistics have been removed and currently even basics statistics > are missing. > > This patch creates per heap debugfs directory /sys/kernel/debug/ > and adds the following counters: > - the number of allocated buffers; > -

Re: [PATCH 02/11] staging:rtl8192u: Removed commented out include - Style

2018-10-09 Thread Greg KH
On Sun, Oct 07, 2018 at 10:40:16PM +0100, John Whitmore wrote: > Remove commented out #include directive. > > Additionally shorted a block comment to clear the checkpatch issue > with line length. You really should only do one type of thing per patch, but I'll let this one go...

Re: [PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style

2018-10-09 Thread Greg KH
On Sun, Oct 07, 2018 at 10:40:20PM +0100, John Whitmore wrote: > Rewrite a test for NULL to comply with the coding style and clear the > checkpatch issue. > > This is a coding style change which should not impact runtime > code execution. > > Signed-off-by: John Whitmore > --- > drivers/staging

Re: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info

2018-10-11 Thread Greg KH
On Thu, Oct 11, 2018 at 08:14:34PM +, Haiyang Zhang wrote: > From: Haiyang Zhang > > The VF device's serial number is saved as a string in PCI slot's > kobj name, not the slot->number. This patch corrects the netvsc > driver, so the VF device can be successfully paired with synthetic > NIC. >

Re: [PATCH 4/5] Drivers: hv: kvp: Use %u to print U32

2018-10-16 Thread Greg KH
On Wed, Oct 17, 2018 at 03:14:05AM +, k...@linuxonhyperv.com wrote: > From: Dexuan Cui > > I didn't find a real issue. Let's just make it consistent with the > next "case REG_U64:" where %llu is used. > > Signed-off-by: Dexuan Cui > Cc: K. Y. Srinivasan > Cc: Haiyang Zhang > Cc: Stephen H

Re: [PATCH 1/5] Drivers: hv: vmbus: Get rid of unnecessary state in hv_context

2018-10-16 Thread Greg KH
On Wed, Oct 17, 2018 at 03:14:02AM +, k...@linuxonhyperv.com wrote: > From: "K. Y. Srinivasan" > > Currently we are replicating state in struct hv_context that is unnecessary - > this state can be retrieved from the hypervisor. Furthermore, this is a > per-cpu > state that is being maintaine

Re: [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-10-16 Thread Greg KH
On Wed, Oct 17, 2018 at 03:14:04AM +, k...@linuxonhyperv.com wrote: > From: Dexuan Cui > > In kvp_send_key(), we do need call process_ib_ipinfo() if > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out > the userland hv_kvp_daemon needs the info of operation, adapter_id an

Re: [PATCH 5/5] Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1

2018-10-16 Thread Greg KH
On Wed, Oct 17, 2018 at 03:14:06AM +, k...@linuxonhyperv.com wrote: > From: Dexuan Cui > > The patch fixes: > > hv_kvp_daemon.c: In function 'kvp_set_ip_info': > hv_kvp_daemon.c:1305:2: note: 'snprintf' output between 41 and 4136 bytes > into a destination of size 4096 > > Signed-off-by: De

[GIT PULL] Staging/IIO driver patches for 4.20-rc1

2018-10-29 Thread Greg KH
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8: Linux 4.19-rc4 (2018-09-16 11:52:37 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-4.20-rc1 for you to fetch changes up to 4ab7e05dd070

Re: [PATCH] staging: fix some typo

2018-11-01 Thread Greg KH
On Thu, Nov 01, 2018 at 11:48:38AM -0400, Yangtao Li wrote: > Signed-off-by: Yangtao Li > --- > drivers/staging/rtl8712/rtl871x_cmd.h | 2 +- > drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) No changelog? _

Re: [PATCH] staging: wilc1000: update wilc1000 driver maintainer ids

2018-11-05 Thread Greg KH
On Tue, Oct 30, 2018 at 05:53:40AM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > We would like to update the maintainer email id's for wilc1000 driver. > > Signed-off-by: Ajay Singh > Signed-off-by: Adham Abozaeid It would be good to get the current maintainer's signed off by

Re: [PATCH v2 1/4] staging: wilc1000: remove unused flags in handle_cfg_param()

2018-11-05 Thread Greg KH
On Tue, Oct 30, 2018 at 04:22:55AM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > handle_cfg_param() receives a bit map that describes what to be changed. > Some of these bits flags aren't referred to from elsewhere and can be > removed. > > Signed-off-by: Adham Abozaeid

Re: [PATCH v2] staging: fix some typo

2018-11-05 Thread Greg KH
On Fri, Nov 02, 2018 at 08:53:32AM -0400, Yangtao Li wrote: > ture->true > > Signed-off-by: Yangtao Li > --- > Change in v2: > -add changelog > --- > drivers/staging/rtl8712/rtl871x_cmd.h | 2 +- > drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +- > 2 files changed, 2 insertions(+), 2 de

Re: [PATCH] staging: vt6655: fix small typo

2018-11-05 Thread Greg KH
On Thu, Nov 01, 2018 at 11:52:51AM -0400, Yangtao Li wrote: > Signed-off-by: Yangtao Li > --- > drivers/staging/vt6655/baseband.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I can not accept patches without any changelog text :( ___ devel m

Re: [PATCH] Staging: vchi: Add license id and change int type

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 10:07:38PM -0200, andrealm...@riseup.net wrote: > From: André Almeida > > Fix the following checkpatch issues: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > CHECK: Prefer kernel type 's32' over 'int32_t' > > Signed-off-by: André Almeida > >

Re: [PATCH v2] staging: wilc1000: update wilc1000 driver maintainer ids

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 05:05:01AM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > We would like to update the maintainer email id's for wilc1000 driver. > > Signed-off-by: Aditya Shankar > Signed-off-by: Ganesh Krishna > Signed-off-by: Adham Abozaeid > Signed-off-by: Ajay Sing

Re: RFC: staging: gasket: re-implement using UIO

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 04:20:49PM -0800, Todd Poynor wrote: > On Mon, Sep 10, 2018 at 8:28 AM Ahmed S. Darwish wrote: > > > > The gasket in-kernel framework, recently introduced under staging, > > re-implements what is already long-time provided by the UIO > > subsystem, with extra PCI BAR remapp

Re: [PATCH] staging: mt7621-mmc: Add blank line after declaration

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 10:42:42PM -0200, nico...@autobyte.com.br wrote: > From: Nícolas F. R. A. Prado > > Correct the following warning from checkpatch.pl: > > WARNING: Missing a blank line after declarations > + struct msdc_host *host = mmc_priv(mmc); > + msdc_pm(state

Re: [PATCH] staging: sm750fb: Add spaces around '+'

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 10:28:04PM -0200, Laís Pessine do Carmo wrote: > Add spaces around '+' to correct the following checkpath.pl warnings: > > WARNING: line over 80 characters > + write_dpPort(accel, *(unsigned int *)(pSrcbuf + > (j * 4))); > > WARNING: line over 80 char

Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller

2018-11-07 Thread Greg KH
On Thu, Nov 01, 2018 at 03:58:57PM -0400, Carmeli Tamir wrote: > Added static modifier to the udc_controller, since it's only > required within emxx_udc.c. > Previously posted without any feedback, now updated according to master. > > Signed-off-by: Carmeli Tamir > --- > drivers/staging/emxx_udc

Re: [PATCH] staging: gasket: Use octal permissions instead of symbolic.

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 05:41:29PM +0530, Rohit Sarkar wrote: > On Tue, Nov 06, 2018 at 09:12:45PM +0100, Greg KH wrote: > > On Tue, Nov 06, 2018 at 04:33:47PM +0530, Rohit Sarkar wrote: > > > Replace S_IRUGO with 0444. Issue found by checkpatch. > > > > &

Re: [PATCH v3 2/4] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-08 Thread Greg KH
On Tue, Nov 06, 2018 at 12:01:18AM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > Validate cfg parameters after being called by cfg80211 in set_wiphy_params > before scheduling the work executed in handle_cfg_param > > Signed-off-by: Adham Abozaeid > --- > drivers/stagin

Re: [PATCH 2/3] staging: wlan-ng: reformatting in hfa384x.h to fit 80 character limit

2018-11-08 Thread Greg KH
On Wed, Nov 07, 2018 at 08:09:19PM +, Tim Collier wrote: > Reformat lines over 80 characters in hfa384x.h to resolve "line over > 80 characters" warnings reported by checkpatch. > > Signed-off-by: Tim Collier > --- > drivers/staging/wlan-ng/hfa384x.h | 26 ++ > 1 file

Re: [PATCH v4 1/3] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-08 Thread Greg KH
On Thu, Nov 08, 2018 at 09:50:25PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > From: Adham Abozaeid Twice? Something went wrong on your side, for all of these patches :( Please fix up and resend. thanks, greg k-h ___ deve

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

2018-11-09 Thread Greg KH
On Fri, Nov 09, 2018 at 09:44:25AM +0530, Brajeswar Ghosh wrote: > Remove binder_trace.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > --- > drivers/android/binder.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder

Re: [PATCH] binder: fix race that allows malicious free of live buffer

2018-11-09 Thread Greg KH
On Tue, Nov 06, 2018 at 03:55:32PM -0800, Todd Kjos wrote: > Malicious code can attempt to free buffers using the > BC_FREE_BUFFER ioctl to binder. There are protections > against a user freeing a buffer while in use by the > kernel, however there was a window where BC_FREE_BUFFER > could be used t

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

2018-11-09 Thread Greg KH
On Fri, Nov 09, 2018 at 10:40:14PM +0800, kbuild test robot wrote: > Hi Brajeswar, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.20-rc1 next-20181109] > [if your patch is applied to the wrong git tree,

Re: [PATCH v6 00/33] staging: mt7621-pci: Parse ports info from DT and other minor cleanups

2018-11-11 Thread Greg KH
On Sun, Nov 04, 2018 at 11:49:26AM +0100, Sergio Paracuellos wrote: > This patch series parse remaining port info from device tree storing > it in mt7621_pcie_port struct created for this. It also performs a lot > of cleanups to get the driver in a good shape to give it a try to get > mainlined. Al

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-20 Thread Greg KH
On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > Hi Nicolas, > > > Nicolas Saenz Julienne hat am 14. November 2018 um > > 13:59 geschrieben: > > > > > > Hi All, > > > > This series was written in parallel with reading and understanding the > > vchiq code. So excuse me for the

Re: [PATCH v2 0/7] staging: mt7621-pci: some fixes after test previous series

2018-11-26 Thread Greg KH
On Sun, Nov 25, 2018 at 07:59:48AM +0100, Sergio Paracuellos wrote: > On Sat, Nov 24, 2018 at 9:05 PM NeilBrown wrote: > > > > On Sat, Nov 24 2018, Sergio Paracuellos wrote: > > > > > Previous cleanup series was added to the staging tree without any > > > testing. After get testing feedback some i

Re: [PATCH 1/4] arm64: hyperv: Add core Hyper-V include files

2018-11-26 Thread Greg KH
On Thu, Nov 22, 2018 at 03:10:56AM +, k...@linuxonhyperv.com wrote: > --- /dev/null > +++ b/arch/arm64/include/asm/hyperv-tlfs.h > @@ -0,0 +1,338 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +/* > + * This file contains definitions from the Hyper-V Hypervisor Top-Level > + * Functional Sp

Re: [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor

2018-11-26 Thread Greg KH
On Thu, Nov 22, 2018 at 03:10:57AM +, k...@linuxonhyperv.com wrote: > --- /dev/null > +++ b/arch/arm64/hyperv/hv_hvc.S > @@ -0,0 +1,54 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Using SPDX is good, but: > + > +/* > + * Microsoft Hyper-V hypervisor invocation routines > + * > + * Copyright (

Re: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-11-26 Thread Greg KH
On Thu, Nov 22, 2018 at 03:10:58AM +, k...@linuxonhyperv.com wrote: > From: Michael Kelley > > Add hooks to enable/disable a per-CPU IRQ for VMbus. These hooks > are in the architecture independent setup and shutdown paths for > Hyper-V, and are needed by Linux guests on Hyper-V on ARM64. Th

Re: [PATCH 2/2] Drivers: hv: vmbus: offload the handling of channels to two workqueues

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 02:29:57AM +, k...@linuxonhyperv.com wrote: > From: Dexuan Cui > > vmbus_process_offer() mustn't call channel->sc_creation_callback() > directly for sub-channels, because sc_creation_callback() -> > vmbus_open() may never get the host's response to the > OPEN_CHANNEL m

Re: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 07:47:41PM +, Michael Kelley wrote: > From: Greg KH Monday, November 26, 2018 11:21 AM > > > > diff --git a/arch/x86/include/asm/mshyperv.h > > > b/arch/x86/include/asm/mshyperv.h > > > index 0d6271cce198..8d97bd3a13a6 100644

Re: [PATCH v2 0/7] staging: mt7621-pci: some fixes after test previous series

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 08:46:10PM +0100, Sergio Paracuellos wrote: > On Mon, Nov 26, 2018 at 4:28 PM Greg KH wrote: > > > > On Sun, Nov 25, 2018 at 07:59:48AM +0100, Sergio Paracuellos wrote: > > > On Sat, Nov 24, 2018 at 9:05 PM NeilBrown wrote: > > > >

Re: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 08:56:50PM +, Michael Kelley wrote: > From: Greg KH Monday, November 26, 2018 11:57 AM > > > > > You created "null" hooks that do nothing, for no one in this patch > > > > series, why? > > > > > > > > &g

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-27 Thread Greg KH
On Mon, Nov 26, 2018 at 08:36:33PM +0100, Stefan Wahren wrote: > > Nicolas Saenz Julienne hat am 20. November 2018 um > > 15:53 geschrieben: > > > > > > Hi All, > > > > This series was written in parallel with reading and understanding the > > vchiq code. So excuse me for the lack of logic in

[GIT PULL] Staging/IIO driver fixes for 4.20-rc5

2018-11-30 Thread Greg KH
The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-4.20-rc5 for you to fetch changes up to c648284f6c96

Re: [PATCH 00/29] staging: wilc1000: avoid deferring of cfg80211 operation callback

2018-12-05 Thread Greg KH
On Sun, Dec 02, 2018 at 06:02:13PM +, ajay.kat...@microchip.com wrote: > 6 files changed, 755 insertions(+), 2012 deletions(-) Nice code removal, patch series all now applied. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driv

Re: [PATCH] binder: fix sparse warnings on locking context

2018-12-05 Thread Greg KH
On Mon, Dec 03, 2018 at 12:24:54PM -0800, Todd Kjos wrote: > Add __acquire()/__release() annnotations to fix warnings > in sparse context checking > > There is one case where the warning was due to a lack of > a "default:" case in a switch statement where a lock was > being released in each of the

Re: [PATCH] binder: fix kerneldoc header for struct binder_buffer

2018-12-05 Thread Greg KH
On Mon, Dec 03, 2018 at 12:24:55PM -0800, Todd Kjos wrote: > Fix the incomplete kerneldoc header for struct binder_buffer. > > Change-Id: If3ca10cf6d90f605a0c078e4cdce28f02a475877 No need for this here :) ___ devel mailing list de...@linuxdriverproject

Re: [PATCH] binder: fix use-after-free due to fdget() optimization

2018-12-05 Thread Greg KH
On Mon, Dec 03, 2018 at 12:24:57PM -0800, Todd Kjos wrote: > 44d8047f1d87a ("binder: use standard functions to allocate fds") > exposed a pre-existing issue in the binder driver. > > fdget() is used in ksys_ioctl() as a performance optimization. > One of the rules associated with fdget() is that k

Re: [PATCH] binder: implement binderfs

2018-12-05 Thread Greg KH
On Tue, Dec 04, 2018 at 02:12:39PM +0100, Christian Brauner wrote: > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > implementation of binderfs. If you want to skip reading and just see how it > works, please go to [2]. First off, thanks for doing this so quickly. I

Re: [PATCH] binder: implement binderfs

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 10:42:06PM +0100, Christian Brauner wrote: > On Wed, Dec 05, 2018 at 09:01:45PM +0100, Greg KH wrote: > > > /* binder-control */ > > > Each new binderfs instance comes with a binder-control device. No other > > > devices will be present at fi

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > Add __acquire()/__release() annnotations to fix warnings > in sparse context checking > > There is one case where the warning was due to a lack of > a "default:" case in a switch statement where a lock was > being released in each of the

Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Greg KH
On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote: > Parts of this work came from contributions of Alexandru Ardelean and > Dragos Bogdan, I and Gabriel would like to thank for the insights > provided by their previous patches. Maybe it would be the case to add > them as co-authors of

[GIT PULL] Staging/IIO driver fixes for 4.20-rc6

2018-12-09 Thread Greg KH
The following changes since commit 2595646791c319cadfdbf271563aac97d0843dc7: Linux 4.20-rc5 (2018-12-02 15:07:55 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-4.20-rc6 for you to fetch changes up to 87e4a5405f08

Re: [PATCH] MAINTAINERS: Patch monkey for the Hyper-V code

2018-12-11 Thread Greg KH
On Tue, Dec 11, 2018 at 12:09:49PM -0500, Sasha Levin wrote: > Now the Hyper-V code has it's own monkey on a tree! > > Make it easier to manage patch flow to upper level maintainers. > > Acked-by: Haiyang Zhang > Acked-by: K. Y. Srinivasan > Signed-off-by: Sasha Levin > --- > MAINTAINERS | 4

Re: [PATCH RFC] staging: comedi: fix coding style issues

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 05:43:37PM +0530, Ayush wrote: > fix IF_0 and IF_1 warnings by checkpatch.pl What is that? > Signed-off-by: Ayush > --- > compile tested only. When you send something with "RFC" that means you do not think it is good enough to be merged, and so I will just delete it. Al

Re: [PATCH] staging: media: atomisp: fix coding style issues in timer.c

2021-02-04 Thread Greg KH
On Sun, Jan 31, 2021 at 11:55:29PM +0530, Ayush wrote: > - Fix unneeded brace in if condition(also, brace was on next line). > - Fix leading space warning before struct ia_css_clock_tick *curr_ts. > > compile tested only (on next-20210129) > > Signed-off-by: Ayush > --- > .../staging/media/atom

Re: [PATCH] staging: fbtft replaced udelay with usleep_range

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 02:41:13PM +0530, Mayank Suman wrote: > According to Documentation/timers/timers-howto.rst, usleep_range is > preffered over udelay for >=10us delay. > > Signed-off-by: Mayank Suman ALWAYS test build your patches before sending them out to the world for review. You don't

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. That says what you do, but not _why_ you are doing it. What does this offer in benefit of the

Re: [PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:15PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. Again, explain _why_. Please read the section entitled "The canonical patch format" in the ke

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-05 Thread Greg KH
On Wed, Feb 03, 2021 at 11:11:57AM -0700, Shuah Khan wrote: > +static inline u32 seqnum32_inc(struct seqnum32 *seq) > +{ > + atomic_t val = ATOMIC_INIT(seq->seqnum); > + > + seq->seqnum = (u32) atomic_inc_return(&val); > + if (seq->seqnum >= UINT_MAX) > + pr_info("Sequence N

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 05:30:31AM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int were defined in the header, > instead put the definitions in the translation unit and add an extern > declaration for consumers of the header (currently only one, which is > perhaps why t

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 01:08:27PM +0530, Kumar Kartikeya Dwivedi wrote: > On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote: > > > > Given that drivers/staging/emxx_udc/emxx_udc.h is only included by > > drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be > > decla

Re: [PATCH] staging: gasket: Align code to match with open parenthesis and fix the lines ending with open parenthesis

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 01:11:36PM +0530, Mahak gupta wrote: > This patch fixes warnings of checkpatch.pl. According to the coding style > of linux, code should be aligned properly to match with open parenthesis > and lines should not end with open parenthesis. > > Signed-off-by: mhk19 > --- > d

Re: [PATCH v2] staging: emxx_udc: Make incorrectly defined global static

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:16:58PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute th

Re: [PATCH v3] staging: emxx_udc: Make incorrectly defined global static

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:29:12PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute th

Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 07:39:28PM +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > > Signed-off-by: Mahak Gupta >

Re: [PATCH] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:48:04PM +, Phillip Potter wrote: > Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function > to strscpy calls. Fixes a style warning. Is it really safe to do this type of conversion here? If so, you need to provide evidence of it in the changelog, oth

Re: [PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 03:03:02PM +, Phillip Potter wrote: > Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function > to strscpy calls. As return values were not checked for these three > calls before, change should be safe as functionality is equivalent. > > Signed-off-by: Ph

Re: [PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

2021-02-07 Thread Greg KH
; Signed-off-by: Phillip Potter > --- > > v2: Modified changelog to take account of feedback from Greg KH. > > drivers/staging/octeon/ethernet-mdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet-mdio.c >

Re: [96e8740] [PATCH 2/2] Staging: wimax: i2400m: some readability improvements.

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 10:11:24PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Hello, developers! > Sorry for the late answer. As you know - i am a newbie and it is my first > kernel patch. > After reading kernelnewbies.or, ./Documentation/process/ files and viewing > FOSDEM's vi

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > Hi Greg, > > On 2021/2/5 17:53, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > >> From: Junhao He > >> > >> Use subdir-ccflags-* instead of ccflags-* to in

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:36:14PM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > Signed-off-by: Mukul Mehar > >

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 11:58:02PM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > > This patch fixes a warning, o

  1   2   3   4   5   6   7   8   9   10   >