Why does ion_cma_allocate need GFP_HIGHUSER | __GFP_ZERO flags?

2014-11-12 Thread Gioh Kim
with __GFP_WAIT is enough. And can I get zero-filled-memory from CMA if I set __GFP_ZERO? -- Thanks, Gioh Kim ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Why does ion_cma_allocate need GFP_HIGHUSER | __GFP_ZERO flags?

2014-11-13 Thread Gioh Kim
2014-11-14 오전 10:24에 Laura Abbott 이(가) 쓴 글: > On 11/12/2014 11:18 PM, Gioh Kim wrote: >> Hi, >> >> I'm wondering why dma_alloc_coherent needs GFP_HIGHUSER | __GFP_ZERO flags >> in ion_cma_allocate(). >> >> I think dma_alloc_coherent can go to _

[PATCH 0/2] staging: wlan-ng: remove Sparse warnings for reading __le16

2017-03-13 Thread Gioh Kim
ng, and convert it into u32 type. I hope this could help. Gioh Kim (2): taging: wlan-ng: introduce a macro read_u16 staging: wlan-ng: prism2sta.c: apply read_u16 macro drivers/staging/wlan-ng/prism2mgmt.h | 3 + drivers/staging/wlan-ng/prism2sta.c | 128 +

[PATCH 1/2] staging: wlan-ng: introduce a macro read_u16

2017-03-13 Thread Gioh Kim
read_u16 is wrapper of le16_to_cpu to read u16 variable, rather than __le16. Signed-off-by: Gioh Kim --- drivers/staging/wlan-ng/prism2mgmt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h index 88b979f

[PATCH 2/2] staging: wlan-ng: prism2sta.c: apply read_u16 macro

2017-03-13 Thread Gioh Kim
Remove Sparse warnings "warning: cast to restricted __le16" Signed-off-by: Gioh Kim --- drivers/staging/wlan-ng/prism2sta.c | 128 ++-- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/stagi

[PATCH] ion: remove duplicated clearing of sg_table initialization

2014-04-22 Thread Gioh Kim
ocate sg_table. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_carveout_heap.c |2 +- drivers/staging/android/ion/ion_chunk_heap.c|2 +- drivers/staging/android/ion/ion_system_heap.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/an

RE: [PATCH] ion: remove duplicated clearing of sg_table initialization

2014-04-22 Thread Gioh Kim
Thank you for your advice. I sent the patch again. > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, April 22, 2014 7:47 PM > To: Gioh Kim > Cc: 'Greg Kroah-Hartman'; 'John Stultz'; 'Rebecca Schultz Zav

[PATCHv3 2/2] staging: ion: debugfs to shrink pool

2015-07-01 Thread Gioh Kim
pages to write zero at the file. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..9327e8a 100644 --- a

[PATCHv3 1/2] staging: ion: shrink page-pool by page unit

2015-07-01 Thread Gioh Kim
then ion_system_heap_shrink() to work on pages. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c | 16 ++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android

[PATCHv3 0/2] staging: ion: enable shrinking of pool

2015-07-01 Thread Gioh Kim
ased on v4.1 Gioh Kim (2): staging: ion: shrink page-pool by page unit staging: ion: debugfs to shrink pool drivers/staging/android/ion/ion.c | 22 +- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_h

[PATCHv4 1/2] staging: ion: shrink page-pool by page unit

2015-07-05 Thread Gioh Kim
then ion_system_heap_shrink() to work on pages. Signed-off-by: Gioh Kim Reviewed-by: Laura Abbott --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c | 16 ++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git

[PATCHv4 0/2] staging: ion: enable shrinking of pool

2015-07-05 Thread Gioh Kim
hrink - Add more description about the reason - Remove a patch to limit pool size This patchset is based on v4.1 Gioh Kim (2): staging: ion: shrink page-pool by page unit staging: ion: debugfs to shrink pool drivers/staging/android/ion/ion.c | 22 +- drivers/sta

[PATCHv4 2/2] staging: ion: debugfs to shrink pool

2015-07-05 Thread Gioh Kim
complete. This patch completes and enables it. Reading the file returns pool size in page unit and writing the number of pages shrinks pool. It flushes all pages to write zero at the file. Signed-off-by: Gioh Kim Reviewed-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 22

[PATCH] staging: fbtft: fix some coding style issues

2017-02-09 Thread Gioh Kim
There are many coding style issues. I fixed only obvious issues. Fixied issues: - Use 4 digit octal (0777) not decimal permissions - line over 80 characters - Avoid unnecessary line continuations I checked all files were built without error. Signed-off-by: Gioh Kim --- drivers/staging/fbtft

[PATCH] staging: greybus: es2.c: fix some coding style issues

2017-02-09 Thread Gioh Kim
Fix two coding style issues: 1. line over 80 characters 2. Octal permissions are preffered than symbolic ones Signed-off-by: Gioh Kim --- drivers/staging/greybus/es2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/es2.c b/drivers/staging

[PATCH 2/2] staging: greybus: fix symbolic permission coding style issues

2017-02-09 Thread Gioh Kim
Fix "Octal permissions are preffered than symbolic ones" issues. Signed-off-by: Gioh Kim --- drivers/staging/greybus/es2.c | 4 ++-- drivers/staging/greybus/loopback.c | 2 +- drivers/staging/greybus/svc.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) di

[PATCH 1/2] staging: greybus: fix "line over 80 characters" coding style issues

2017-02-09 Thread Gioh Kim
This patch fixes only obvious lines. There are still more issues. Signed-off-by: Gioh Kim --- drivers/staging/greybus/arche-apb-ctrl.c | 5 +++- drivers/staging/greybus/arche-platform.c | 43 +--- drivers/staging/greybus/audio_codec.c| 5 +++- drivers/staging

Re: [PATCH 1/1] staging: ion: Fix error handling in ion_buffer_create

2015-09-30 Thread Gioh Kim
return ERR_PTR(ret); Suggested-by: Pintu Kumar Reviewed-by: Pintu Kumar It's nice! Reviewed-by: Gioh Kim ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[RFC 2/2] staging: ion: debugfs to shrink pool

2014-10-23 Thread Gioh Kim
This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, to shrink pool or get pool size. Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 31 --- 1 file

[RFC 0/2] enable pool shrinking in page unit

2014-10-23 Thread Gioh Kim
unit. 2. Patch 2/2: enable debugfs to shrink pool directly This patch enable debugfs to specify shrink amount. Thanks for any feedback. This patchset is based on linux-next-20141023. Gioh Kim (2): staging: ion: shrink page-pool by page unit staging: ion: debugfs to shrink pool drivers

[RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c |7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
2014-10-24 오전 5:36, Devendra Naga 쓴 글: Hello, On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote: This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c |7

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
2014-10-24 오전 8:16, Gioh Kim 쓴 글: 2014-10-24 오전 5:36, Devendra Naga 쓴 글: Hello, On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote: This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android

[RFCv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Gioh Kim
This patch shrink page-pool by page unit. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c |7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion

[RFCv2 0/3] enable pool shrinking in page unit

2014-10-23 Thread Gioh Kim
page unit. 2. Patch 2/3: enable debugfs to shrink page directly This patch enables debugfs to specify shrink amount. 3. Patch 3/3: limit pool size This patch specifies pool size limit. This patchset is based on linux-next-20141023. Gioh Kim (3): staging: ion: shrink page-pool by page unit

[RFCv2 3/3] staging: ion: limit pool size

2014-10-23 Thread Gioh Kim
This patch limits pool size by page unit. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/Kconfig |4 drivers/staging/android/ion/ion_page_pool.c | 26 -- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android

[RFCv2 2/3] staging: ion: debugfs to shrink pool

2014-10-23 Thread Gioh Kim
This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, to shrink pool or get pool size. Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 31 --- 1 file

Re: [RFCv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-26 Thread Gioh Kim
2014-10-25 오전 5:09, Laura Abbott 쓴 글: Hi, On 10/23/2014 11:47 PM, Gioh Kim wrote: This patch shrink page-pool by page unit. Can you explain a bit more about what this patch is fixing? The description in the cover letter would be helpful here. I'm sorry for the lack of explan

Re: [RFCv2 2/3] staging: ion: debugfs to shrink pool

2014-10-26 Thread Gioh Kim
2014-10-25 오전 5:38, Laura Abbott 쓴 글: Hi, On 10/23/2014 11:47 PM, Gioh Kim wrote: This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, to shrink pool or get pool size. Reading the file returns pool size and writing occurs to shrink pool. Can you clarify here that

Re: [RFCv2 3/3] staging: ion: limit pool size

2014-10-26 Thread Gioh Kim
2014-10-25 오전 5:53, Laura Abbott 쓴 글: Hi, On 10/23/2014 11:47 PM, Gioh Kim wrote: This patch limits pool size by page unit. This looks useful. Might be nice to add a debugfs option to change this at runtime as well. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/Kconfig

[PATCH 0/3] enable pool shrinking in page unit

2014-10-27 Thread Gioh Kim
page unit. 2. Patch 2/3: enable debugfs to shrink page directly This patch enables debugfs to specify shrink amount. 3. Patch 3/3: limit pool size This patch specifies pool size limit. This patchset is based on linux-next-20141023. Gioh Kim (3): staging: ion: shrink page-pool by page unit

[PATCH 1/3] staging: ion: shrink page-pool by page unit

2014-10-27 Thread Gioh Kim
This patch shrink page-pool by page unit. Shrinker usually get the pool size with the pool-scanner and pass the size to the pool-counter to shrink entire pool. But the pool-scanner is working in block unit. and pool-counter page unit. So it is confused. Signed-off-by: Gioh Kim --- drivers

[PATCH 3/3] staging: ion: limit pool size

2014-10-27 Thread Gioh Kim
This patch limits pool size by page unit. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/Kconfig |8 drivers/staging/android/ion/ion_page_pool.c | 24 ++-- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH 2/3] staging: ion: debugfs to shrink pool

2014-10-27 Thread Gioh Kim
This patch enables debugfs files /sys/kernel/debug/ion/heaps/system_shrink ,which was commented out, to shrink pool or get pool size Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 31

Re: [PATCH 1/3] staging: ion: shrink page-pool by page unit

2014-10-28 Thread Gioh Kim
2014-10-28 오전 9:36에 Gioh Kim 이(가) 쓴 글: > This patch shrink page-pool by page unit. > > Shrinker usually get the pool size with the pool-scanner > and pass the size to the pool-counter to shrink entire pool. > But the pool-scanner is working in block unit. > and pool-counter

[RFC] stating: ion: use hot page first in pool

2014-10-28 Thread Gioh Kim
g hot page first? -- 8< - >From 14c8455cc80628e56a27ace9603d29e5056835b5 Mon Sep 17 00:00:00 2001 From: Gioh Kim Date: Wed, 29 Oct 2014 13:44:28 +0900 Subject: [PATCH] staging: ion: use hot-page first A page near the head is hot for cache.

[PATCHv2 0/3] staging: ion: enable pool shrinking in page unit

2014-10-28 Thread Gioh Kim
nk And this shrinks 300-pages from entire pool. echo 30 > /sys/kernel/debug/ion/heaps/system_shrink It try to shrink high-order pool first because high-order pages is necessary more than low-order when the system has low memory. This patchset is based on linux-next-20141023. Gioh Kim (3): sta

[PATCHv2 2/3] staging: ion: limit pool size

2014-10-28 Thread Gioh Kim
This patch limits pool size by page unit. And enable a debugfs file to set limit. Change-Id: Idaef4daa69084e8ec0844ecefc6738afeab79ccb Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 31 + drivers/staging/android/ion/ion_page_pool.c | 24

[PATCHv2 3/3] staging: ion: debugfs to shrink pool

2014-10-28 Thread Gioh Kim
This patch enables debugfs files /sys/kernel/debug/ion/heaps/system_shrink ,which was commented out, to shrink pool or get pool size Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 31

[PATCHv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-28 Thread Gioh Kim
: If25c693c09f6ebd14c87809feddb72f9058e8308 Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c | 18 +++--- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging

Re: [PATCHv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-28 Thread Gioh Kim
> diff --git a/drivers/staging/android/ion/ion_system_heap.c > b/drivers/staging/android/ion/ion_system_heap.c > index da2a63c..0ba8aaf 100644 > --- a/drivers/staging/android/ion/ion_system_heap.c > +++ b/drivers/staging/android/ion/ion_system_heap.c > @@ -29,7 +29,7 @@ > static gfp_t high_ord

Re: [PATCHv2 0/3] staging: ion: enable pool shrinking in page unit

2014-10-29 Thread Gioh Kim
2014-10-29 오후 2:35에 Gioh Kim 이(가) 쓴 글: > Hello, > > Current pool shrinking is not page unit, block unit. > But shrinker returns the pool size in page unit, > so it is confused. > > And there is no way to control pool size and shrink pool directly. > > I have 3 patc

Re: [RFC] stating: ion: use hot page first in pool

2014-10-29 Thread Gioh Kim
2014-10-30 오전 2:00에 Laura Abbott 이(가) 쓴 글: > On 10/28/2014 9:57 PM, Gioh Kim wrote: >> >> Hello, >> >> I found that ion insert freed-page at the tail of list >> and extract at the head. >> >> I think it is good for cache to use the most recently