On 05/07/2015 08:03 AM, Dan Carpenter wrote:
On Wed, May 06, 2015 at 04:28:22PM -0500, J. German Rivera wrote:
+/*
+ * FIXME: Enable this code when the GIC-ITS MC support patch is merged
+ */
+#ifdef GIC_ITS_MC_SUPPORT
+static int mc_bus_msi_prepare(struct irq_domain *domain, struct device
fsl_mc_interrupts_supported(), which can be called from DPAA2 object
drivers.
Signed-off-by: J. German Rivera
Change-Id: I881ab2c45c949e55cfafe1d281a7a31560955e5b
Reviewed-on: http://git.am.freescale.net:8181/34712
Tested-by: Review Code-CDREVIEW
Reviewed-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc
This patch series includes new functionality for the Freescale fsl-mc
bus driver.
Patch 1: MC bus IRQ support
Patch 2: add device binding path 'driver_override'
Patch 3: Propagate driver_override for a child DPRC's children
Patch 4: Upgraded MC bus driver to match MC fw 7.0.0
Patch 5: Allow the MC
with it will be
serialized using a mutex. Otherwise, if the fsl_mc_io object is
going to be used in atomic context, mc_semd_command() calls with it
will be serialized using a spinlock.
Signed-off-by: J. German Rivera
Change-Id: Icb770cd36e204ee6a17ad0f81e1d31cc9fe96816
Reviewed-on: http
For most cases, mc_send_command() will wait on this
completion variable, instead of doing polling. This completion
variable will be signaled from the DPMCP IRQ handler.
Signed-off-by: J. German Rivera
Change-Id: Iab294be9c00fb029702cc8625eaf29ba058fa960
Reviewed-on: http://git.am.freescal
sysfs attribute to vfio_fsl_mc driver, for each
of them and rebind them.
Signed-off-by: J. German Rivera
Change-Id: I51e633367b019da1cd45bd4898e46be577b8ce42
Reviewed-on: http://git.am.freescale.net:8181/34567
Tested-by: Review Code-CDREVIEW
Reviewed-by: Stuart Yoder
Tested-by: Stuart Yoder
/destroying DPAA2 objects in
the DPRC, changing the "plugged" state of DPAA2 objects and moving
objects between DPRCs.
Signed-off-by: J. German Rivera
Change-Id: I2a986c465989c3811de19cfe9ed0b77168250cb1
Reviewed-on: http://git.am.freescale.net:8181/33626
Tested-by: Review Code-CDREVIEW
R
(dprc.1) to specifically bind
with driver (vfio-fsl-mc):-
- echo vfio-fsl-mc > /sys/bus/fsl-mc/devices/dprc.1/driver_override
- echo dprc.1 > /sys/bus/fsl-mc/drivers/fsl_mc_dprc/unbind
- echo dprc.1 > /sys/bus/fsl-mc/drivers/vfio-fsl-mc/bind
Signed-off-by: J. German Rivera
- Migrated MC bus driver to use DPRC flib 0.6.
- Changed IRQ setup infrastructure to be able to program MSIs
for MC objects in an object-independent way.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 79
drivers/staging/fsl-mc/bus/dprc-cmd.h
(dprc.1) to specifically bind
with driver (vfio-fsl-mc):-
- echo vfio-fsl-mc > /sys/bus/fsl-mc/devices/dprc.1/driver_override
- echo dprc.1 > /sys/bus/fsl-mc/drivers/fsl_mc_dprc/unbind
- echo dprc.1 > /sys/bus/fsl-mc/drivers/vfio-fsl-mc/bind
Signed-off-by: J. German Rivera
Reviewed-by: Stu
This patch series includes new functionality for the Freescale fsl-mc
bus driver.
Patch 1: MC bus IRQ support
Patch 2: add device binding path 'driver_override'
Patch 3: Propagate driver_override for a child DPRC's children
Patch 4: Upgraded MC bus driver to match MC fw 7.0.0
Patch 5: Allow the MC
For most cases, mc_send_command() will wait on this
completion variable, instead of doing polling. This completion
variable will be signaled from the DPMCP IRQ handler.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v2:
- Use msecs_to_jiffies() instead of HZ in timeo
/destroying DPAA2 objects in
the DPRC, changing the "plugged" state of DPAA2 objects and moving
objects between DPRCs.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v2:
- Addressed comments from Dan Carpenter and Scott Wood:
* Removed unnecessary lines f
sysfs attribute to vfio_fsl_mc driver, for each
of them and rebind them.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
Tested-by: Stuart Yoder
---
Changes in v2:
none
drivers/staging/fsl-mc/bus/dprc-driver.c| 14 ++
drivers/staging/fsl-mc/bus/mc-bus.c | 16
- Migrated MC bus driver to use DPRC API 0.6.
- Changed IRQ setup infrastructure to be able to program MSIs
for MC objects in an object-independent way.
Signed-off-by: J. German Rivera
---
Changes in v2:
- Addressed comments from Dan Carpenter:
* Added #ifdef GIC_ITS_MC_SUPPORT's tha
() calls with it
will be serialized using a spinlock.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v2:
- Relaxed rules for FSL_MC_IO_ATOMIC_CONTEXT_PORTAL.
Some drivers (e.g., DPNI) need to send MC commands with the same
mc_io object, from both atomic and non
fsl_mc_interrupts_supported(), which can be called from DPAA2 object
drivers.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v2:
none
drivers/staging/fsl-mc/bus/dprc-driver.c| 31 +++--
drivers/staging/fsl-mc/bus/mc-allocator.c | 4
drivers
FSL-MC is a bus type different from PCI and platform, so it needs
its own member in the msi_desc's union.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2:
- Addressed comment from Jiang Liu
* Added a dedicated structure for FSL-MC in struct msi
bus object allocator is extended to also provide services
to allocate IRQs to DPAA2 devices, from their parent fsl-mc bus
IRQ pool.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 199
Destroy mc_io in error path in dprc_probe() only if the mc_io was
created in this function.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2:
- Addressed comment from Dan Carpenter:
* Renamed goto error labels to indicate what the goto does
drivers
Created an MSI domain for the fsl-mc bus-- including functions
to create a domain, find a domain, alloc/free domain irqs, and
bus specific overrides for domain and irq_chip ops.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Addressed comments from Marc Zyngier:
* Added
tomic mc_io.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c | 4 +++-
drivers/staging/fsl-mc/bus/mc-bus.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus
*** This is a resend of the last iteration of this patch series ***
This patch series addresses the following item from the TODO list
for the MC bus driver to exit staging:
* Interrupt support. For meaningful driver support we need
interrupts, and thus need message interrupt support by the bus
THE MSI domain associated with a root DPRC object is
obtained form the device tree. Child DPRCs inherit
the parent DPRC MSI domain.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c | 39
Since an FSL-MC bus is a new bus type that is neither PCI nor
PLATFORM, we need a new domain bus token to disambiguate the
IRQ domain for FSL-MC MSIs.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
include/linux/irqdomain.h | 1 +
1 file changed, 1
Added platform-specific MSI support layer for FSL-MC devices.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/Makefile| 1 +
.../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 127
l allocate their necessary MSI IRQs from the DPRC's IRQ pool,
in their driver probe function.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c| 24 ++--
drivers/staging/fsl-mc/include/mc
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver
init/exit time. Associate an MSI domain with each DPAA2 child device.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-bus.c | 12
1 file
-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c | 247 +++
1 file changed, 247 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c
b/drivers/staging/fsl-mc/bus/dprc-driv
Since an FSL-MC bus is a new bus type that is neither PCI nor
PLATFORM, we need a new domain bus token to disambiguate the
IRQ domain for FSL-MC MSIs.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
include/linux/irqdomain.h | 1
Created an MSI domain for the fsl-mc bus-- including functions
to create a domain, find a domain, alloc/free domain irqs, and
bus specific overrides for domain and irq_chip ops.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4:
- Addressed comments from Marc Zyngier:
* Re
-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c | 247 +++
1 file changed, 247 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c
b/drivers/staging/
This patch series addresses the following item from the TODO list
for the MC bus driver to exit staging:
* Interrupt support. For meaningful driver support we need
interrupts, and thus need message interrupt support by the bus
driver.
MC Bus MSI Support Architecture
==
THE MSI domain associated with a root DPRC object is
obtained form the device tree. Child DPRCs inherit
the parent DPRC MSI domain.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4:
- Addressed comments from Marc Zyngier:
* Changed call to fsl_mc_find_msi_domain() to match new
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver
init/exit time. Associate an MSI domain with each DPAA2 child device.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-bus.c | 12
FSL-MC is a bus type different from PCI and platform, so it needs
its own member in the msi_desc's union.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2:
- Addressed comment from Jiang Liu
* Added a dedicated structure for FSL-
tomic mc_io.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c | 4 +++-
drivers/staging/fsl-mc/bus/mc-bus.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/dr
l allocate their necessary MSI IRQs from the DPRC's IRQ pool,
in their driver probe function.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c| 24 ++--
drivers
Added platform-specific MSI support layer for FSL-MC devices.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4:
- Addressed comments from Marc Zyngier:
* Moved bus type check earlier in its_fsl_mc_msi_prepare()
* Removed its_dev_id variable
* Changed some assignments to
bus object allocator is extended to also provide services
to allocate IRQs to DPAA2 devices, from their parent fsl-mc bus
IRQ pool.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 199
Destroy mc_io in error path in dprc_probe() only if the mc_io was
created in this function.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2:
- Addressed comment from Dan Carpenter:
* Renamed goto error labels to indicate what the goto
From: "J. German Rivera"
THE MSI domain associated with a root DPRC object is
obtained form the device tree. Child DPRCs inherit
the parent DPRC MSI domain.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4:
- Addressed comments from Marc Zyngier:
* Chang
From: "J. German Rivera"
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver
init/exit time. Associate an MSI domain with each DPAA2 child device.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2: none
drive
From: "J. German Rivera"
All the IRQs for DPAA2 objects in the same DPRC must use
the ICID of that DPRC, as their device Id in the GIC-ITS.
Thus, all these IRQs must share the same ITT table in the GIC.
As a result, a pool of IRQs with the same device Id must be
preallocated per DPRC (
From: "J. German Rivera"
Destroy mc_io in error path in dprc_probe() only if the mc_io was
created in this function.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2:
- Addressed comment from Dan Carpenter:
* Renamed
From: "J. German Rivera"
Created an MSI domain for the fsl-mc bus-- including functions
to create a domain, find a domain, alloc/free domain irqs, and
bus specific overrides for domain and irq_chip ops.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4:
- Addresse
From: "J. German Rivera"
The interrupt handler for DPRC IRQs is added. DPRC IRQs are
generated for hot plug events related to DPAA2 objects in a given
DPRC. These events include, creating/destroying DPAA2 objects in
the DPRC, changing the "plugged" state of DPAA2 object
From: "J. German Rivera"
Added platform-specific MSI support layer for FSL-MC devices.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4:
- Addressed comments from Marc Zyngier:
* Moved bus type check earlier in its_fsl_mc_msi_prepare()
* Removed its_dev_i
From: "J. German Rivera"
The DPRC built-in portal's mc_io is used to send commands to the MC
to program MSIs for MC objects. This is done by the
fsl_mc_msi_write_msg() callback, which is invoked by the generic MSI
layer with interrupts disabled. As a result, th
From: "J. German Rivera"
Scan the corresponding DPRC container to get total count
of IRQs needed by all its child DPAA2 objects. Then,
preallocate a set of MSI IRQs with the DPRC's ICID
(GIT-ITS device Id) to populate the the DPRC's IRQ pool.
Each child DPAA2 object in t
*** This is a resend of the last iteration of this patch series ***
This patch series addresses the following item from the TODO list
for the MC bus driver to exit staging:
* Interrupt support. For meaningful driver support we need
interrupts, and thus need message interrupt support by the bus
From: "J. German Rivera"
Since an FSL-MC bus is a new bus type that is neither PCI nor
PLATFORM, we need a new domain bus token to disambiguate the
IRQ domain for FSL-MC MSIs.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes i
From: "J. German Rivera"
FSL-MC is a bus type different from PCI and platform, so it needs
its own member in the msi_desc's union.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v4: none
Changes in v3: none
Changes in v2:
- Addressed comment from Jiang
This patch series includes new functionality for the Freescale fsl-mc
bus driver.
Patch 1: MC bus IRQ support
Patch 2: add device binding path 'driver_override'
Patch 3: Propagate driver_override for a child DPRC's children
Patch 4: Upgraded MC bus driver to match MC fw 7.0.0
Patch 5: Allow the MC
() calls with it
will be serialized using a spinlock.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v4:
- Fixed new checkpatch checks
drivers/staging/fsl-mc/bus/mc-sys.c | 40 ++---
drivers/staging/fsl-mc/include/mc-sys.h | 23
sysfs attribute to vfio_fsl_mc driver, for each
of them and rebind them.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
Tested-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c| 14 ++
drivers/staging/fsl-mc/bus/mc-bus.c | 16 +++-
drivers
(dprc.1) to specifically bind
with driver (vfio-fsl-mc):-
- echo vfio-fsl-mc > /sys/bus/fsl-mc/devices/dprc.1/driver_override
- echo dprc.1 > /sys/bus/fsl-mc/drivers/fsl_mc_dprc/unbind
- echo dprc.1 > /sys/bus/fsl-mc/drivers/vfio-fsl-mc/bind
Signed-off-by: J. German Rivera
Reviewed-by: Stu
fsl_mc_interrupts_supported(), which can be called from DPAA2 object
drivers.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c| 31 +++--
drivers/staging/fsl-mc/bus/mc-allocator.c | 4
drivers/staging/fsl-mc/bus/mc-bus.c
For most cases, mc_send_command() will wait on this
completion variable, instead of doing polling. This completion
variable will be signaled from the DPMCP IRQ handler.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v4:
- Fixed new checkpatch warnings and checks
/destroying DPAA2 objects in
the DPRC, changing the "plugged" state of DPAA2 objects and moving
objects between DPRCs.
Signed-off-by: J. German Rivera
Reviewed-by: Stuart Yoder
---
Changes in v4:
- Addressed comments from Dan Carpenter and Greg Kroah-Hartman:
* Removed all #ifdefe
- Migrated MC bus driver to use DPRC API 0.6.
- Changed IRQ setup infrastructure to be able to program MSIs
for MC objects in an object-independent way.
Signed-off-by: J. German Rivera
---
Changes in v4:
- Fixed new checkpatch warnings and checks
- Add missing error handling in dprc_probe
This patch series introduces Linux support for the Freescale
Management Complex (fsl-mc) hardware. This patch series is dependent
on the patch series "ARM64: Add support for FSL's LS2085A SoC"
(http://thread.gmane.org/gmane.linux.ports.arm.kernel/351829)
The fsl-mc is a hardware resource manager t
A DPRC (Data Path Resource Container) is an isolation device
that contains a set of DPAA networking devices to be
assigned to an isolation domain (e.g., a virtual machine).
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
---
Changes in v8:
- Addressed comments from Greg Kroah
APIs to access the Management Complex (MC) hardware
module of Freescale LS2 SoCs. This patch includes
APIs to check the MC firmware version and to manipulate
DPRC objects in the MC.
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
---
Changes in v8:
- Addressed comments from Greg
Platform device driver that sets up the basic bus infrastructure
for the fsl-mc bus type, including support for adding/removing
fsl-mc devices, register/unregister of fsl-mc drivers, and bus
match support to bind devices to drivers.
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
This patch series introduces Linux support for the Freescale
Management Complex (fsl-mc) hardware. This patch series is dependent
on the patch series "ARM64: Add support for FSL's LS2085A SoC"
(http://thread.gmane.org/gmane.linux.ports.arm.kernel/351829)
The fsl-mc is a hardware resource manager t
Platform device driver that sets up the basic bus infrastructure
for the fsl-mc bus type, including support for adding/removing
fsl-mc devices, register/unregister of fsl-mc drivers, and bus
match support to bind devices to drivers.
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
A DPRC (Data Path Resource Container) is an isolation device
that contains a set of DPAA networking devices to be
assigned to an isolation domain (e.g., a virtual machine).
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
---
Changes in v9:
None
Changes in v8:
- Addressed comments
APIs to access the Management Complex (MC) hardware
module of Freescale LS2 SoCs. This patch includes
APIs to check the MC firmware version and to manipulate
DPRC objects in the MC.
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
---
Changes in v9:
- Fixed compilation errors that
The fsl-mc object allocator driver manages "allocatable" fsl-mc
objects such as DPBPs, DPMCPs and DPCONs. It provides services to
other fsl-mc drivers to allocate/deallocate these types of objects.
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
---
Changes in v3:
- Move
This patch series introduces the object allocator driver for the
Freescale Management Complex (fsl-mc) of QorIQ Ls2 SoCs This patch
series is dependent on the patch series drivers/bus: "Freescale
Management Complex bus driver patch series Besides adding the object
allocator functionality".
CHANGE
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/TODO | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/TODO b/drivers/staging/fsl-mc/TODO
index 49ebfd9..d78288b 100644
--- a/drivers/staging/fsl-mc/TODO
+++ b/drivers/staging/fsl-mc/TODO
Only call fsl_mc_io_destroy() if the DPRC being removed
actually had an mc_io object associated with. Child DPRCs
that have not been bound to the DPRC driver or the VFIO driver
will not have an mc_io associated with them.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dprc
-EPROBE_DEFER
if such allocations fail.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c
b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 65de1d75
This patch series includes some cleanup/refactoring and minor correction
patches for the Freescale fsl-mc bus driver.
Patch 1: Name MC object devices using decimal numbers
Patch 2: Removed reordering of MC objects during bus scan
Patch 3: Bind/unbind driver when MC object is plugged/unplugged
Patc
MC object devices were being named using hexadecimaal numbers.
This was not consistent with the object naming conventions used
by MC DPLs and the MC restool.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/mc-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 39 +++-
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c
b/drivers/staging/fsl-mc/bus/dprc-driver.c
index f02e5e4..9568eea 100644
object may decide to run even though it cannot use newer
functionality of the MC object.
As part of this change, the dpmng Flib version was also updated
to match the latest MC firmware version.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/mc-bus.c| 29
want it to happen before any driver that depends on the MC bus
driver gets initialized.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/Makefile | 12 +---
drivers/staging/fsl-mc/bus/mc-allocator.c | 12
drivers/staging/fsl-mc/bus/mc-bus.c | 8
This patch series includes the following code cleanup and
bug fixes for the fsl-mc bus driver:
Patch 1: Naming cleanup in fsl_mc-portal_allocate
Patch 2: fsl_mc_io object refactoring
Patch 3: dpmcp opening/closing refactoring
Patch 4: Changed dev_info() calls to dev_dbg()
Patch 5: Changed types of
mc_adev is a local variable for the allocated dpmcp object.
Renamed mc_adev as dpmcp_dev for clarity.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/staging/fsl-mc
Before, we were opening and closing a mc_io's dpmcp object
in fsl_mc_portal_reset(), since that was the only function that was
calling dpmcp MC operations. However, it is better for maintainability
to open the dpmcp object when it gets associated with an mc_io object,
and close it when this associa
Changed dev_info() calls to dev_dbg() in
fsl_mc_allocator_probe/fsl_mc_allocator_remove, as they
are useful only for debugging.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/dri
When initializing the object attributes for the root dprc, the
irq_count was uninitialized. Initialize it to 1.
---
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/drivers/staging/fsl-mc/bus/mc-bus.c
index fd13053..4ac3
Call fsl_mc_resource_pool_remove_device() only if mc_dev->resource
is not NULL.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/staging/fsl-mc/bus/mc-allocator.c
index 527
Replaced error gotos with direct returns in fsl_mc_allocator_probe()
and fsl_mc_allocator_remove(), since the only error handling done
in those functions is to exit.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 23 +--
1 file changed, 9
The macros were a left-over from a previous implementation
of the dpmcp APIs and are no longer used.
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 79 --
1 file changed, 79 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpmcp-cmd.h
b/drivers/staging/fsl-mc/bu
Changed these two fields from 32-bit integers to 16-bit integers in
struct fsl_mc_io, as 32 bits is too much for these fields. This
change does not affect other components since fsl_mc_io is an opaque
type.
---
drivers/staging/fsl-mc/include/mc-sys.h | 4 ++--
1 file changed, 2 insertions(+), 2 de
Whitespace cleanup-- add missing spaces in column 1 of copyright
---
drivers/staging/fsl-mc/include/dpcon-cmd.h | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/dpcon-cmd.h
b/drivers/staging/fsl-mc/include/dpcon-cm
Each fsl_mc_io object is associated with an fsl_mc_device object
of type "dpmcp" representing the MC portal associated with the
fsl_mc_io object. Before, we were representing this association with
an fsl_mc_resource pointer. To enhance code clarity, it is more
straight forward to use an fsl_mc_devi
owner needs to be initialized as THIS_MOUDLE.
---
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/drivers/staging/fsl-mc/bus/mc-bus.c
index 4ac3d07..84db55b 100644
--- a/drivers/staging/fsl-mc/bus/mc-bus.c
+++ b/drivers
Check that resource is not NULL before de-referencing it.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/staging/fsl-mc/bus/mc-allocator.c
index a45293b..88d1857 100644
--- a/dri
mc_adev is a local variable for the allocated dpmcp object.
Renamed mc_adev as dpmcp_dev for clarity.
---
CHANGE HISTORY
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-
Whitespace cleanup-- add missing spaces in column 1 of copyright
---
CHANGE HISTORY
Changes in v2: none
drivers/staging/fsl-mc/include/dpcon-cmd.h | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/dpcon-cmd.h
b/dr
Call fsl_mc_resource_pool_remove_device() only if mc_dev->resource
is not NULL.
---
CHANGE HISTORY
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/stagin
Before, we were opening and closing a mc_io's dpmcp object
in fsl_mc_portal_reset(), since that was the only function that was
calling dpmcp MC operations. However, it is better for maintainability
to open the dpmcp object when it gets associated with an mc_io object,
and close it when this associa
The macros were a left-over from a previous implementation
of the dpmcp APIs and are no longer used.
---
CHANGE HISTORY
Changes in v2: none
drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 79 --
1 file changed, 79 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpm
Changed these two fields from 32-bit integers to 16-bit integers in
struct fsl_mc_io, as 32 bits is too much for these fields. This
change does not affect other components since fsl_mc_io is an opaque
type.
---
CHANGE HISTORY
Changes in v2: none
drivers/staging/fsl-mc/include/mc-sys.h | 4 ++--
Each fsl_mc_io object is associated with an fsl_mc_device object
of type "dpmcp" representing the MC portal associated with the
fsl_mc_io object. Before, we were representing this association with
an fsl_mc_resource pointer. To enhance code clarity, it is more
straight forward to use an fsl_mc_devi
owner needs to be initialized as THIS_MOUDLE.
---
CHANGE HISTORY
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/drivers/staging/fsl-mc/bus/mc-bus.c
index 4ac3d07..84db55b 100644
--- a/drivers/stag
1 - 100 of 180 matches
Mail list logo
