[PATCH] Staging: rts5139: fix coding style

fix some coding style issues in rts51x.c (from rts5139 module) This is for task 10 of the Eudyptula challenge Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers

[PATCH v2 1/5] Staging: rts5139: Camel case labels replaced

Replace camel case labels with linux coding style compliant names. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index

[PATCH v2 3/5] Staging: rts5139: Splitted one-line multiple assignment

Splitted a multiple assignment on two separate lines. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 28f4631..2be6210 100644 --- a

[PATCH v2 2/5] Staging: rts5139: Fixed multi-line code alignment

Multi-line code aligned with open parenthesis. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 9d9c706..28f4631

[PATCH v2 0/5] Staging: rts5139: Fix coding style

Fix some coding style issues in rts51x.c (from rts5139 module). This is for task 10 of the Eudyptula challenge. Fabio Falzoi (5): Camel case labels replaced Fixed multi-line code alignment Splitted one-line multiple assignment pr_warn(...) in place of printk(KERN_WARNING ...) More

[PATCH v2 4/5] Staging: rts5139: pr_warn(...) in place of printk(KERN_WARNING ...)

All printk(KERN_WARNING ...) replaced with pr_warn(...). Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 2be6210

[PATCH v2 5/5] Staging: rts5139: More appropriate sizeof operand

Use the pointer rts51x to get the size of the struct. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index a55b97e..b732d2a 100644 --- a

[PATCH v3 2/6] Staging: rts5139: Fixed multi-line code alignment

Multi-line code aligned with open parenthesis. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 9d9c706..28f4631

[PATCH v3 0/6] Staging: rts5139: Fix coding style

Fix some coding style issues in rts51x.c (from rts5139 module). Changes in v3: * removed all the Out Of Memory messages * redefined pr_fmt to add a prefix to each pr_. Changes in v2: * patch splitted to have just one specific coding style issue fixed at a time Fabio Falzoi (6): Staging

[PATCH v3 1/6] Staging: rts5139: Camel case labels replaced

Replace camel case labels with linux coding style compliant names. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index

[PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

Define pr_fmt macro to prefix every pr_ function in standard way. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 100 +++ 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging

[PATCH v3 3/6] Staging: rts5139: Splitted one-line multiple assignment

Splitted a multiple assignment on two separate lines. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 28f4631..2be6210 100644 --- a

[PATCH v3 5/6] Staging: rts5139: Removed OOM messages

All allocation Out Of Memory messages removed. We rely on the generic OOM message in dump_stack(). Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers

[PATCH v3 6/6] Staging: rts5139: More appropriate use of sizeof operand

Use the pointer rts51x to get the size of the struct. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 6120410..8529cba 100644 --- a

[PATCH 0/3] Staging: lustre: Fixed sparse complaints

This patchset fixes the following sparse complaints: [1/3]: use of a plain integer as NULL pointer [2/3]: symbols that should declared as static [3/3]: use of an unsigned int as gfp_t Fabio Falzoi (3): Staging: lustre: Avoid using 0 instead of NULL Staging: lustre: ops structs should be

[PATCH 1/3] Staging: lustre: Avoid using 0 instead of NULL

/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:768:9: warning: Using plain integer as NULL pointer Signed-off-by: Fabio Falzoi --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm

[PATCH 3/3] Staging: lustre: gfp_mask should be of gfp_t type

unsigned int [unsigned] gfp_mask got restricted gfp_t [usertype] gfp_mask Signed-off-by: Fabio Falzoi --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 4 ++-- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff

[PATCH 2/3] Staging: lustre: ops structs should be declared static

warning: symbol 'ldlm_pool_rw_atomic_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:714:1: warning: symbol 'lprocfs_grant_speed_fops' was not declared. Should it be static? Signed-off-by: Fabio Falzoi

[PATCH 1/7] Staging: rts5208: helper function to manage sd erase status

Use a helper function to manage SD erase status when SUPPORT_SD_LOCK is defined Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 38 - 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b

[PATCH 4/7] Staging: rts5208: helper function to manage aspm

Use a helper function to manage aspm mode Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 51 ++--- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c

[PATCH 3/7] Staging: rts5208: helper function to manage ss

Use a helper function to manage ss_counter Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 66 ++--- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c

[PATCH 2/7] Staging: rts5208: helper function to manage power off

Use a helper function to check if power off is needed. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208

[PATCH 0/7] Staging: rts5208: rtsx_polling_func function clean up

rtsx_polling_func is a big function that manage a lot of independent tasks. This patch aims to refactor the code using a series of helper functions, to make it more readable. Plus, the following checkpatch warning is corrected: * PARENTHESIS_ALIGNMENT at row 1246 Fabio Falzoi (7): Staging

[PATCH 5/7] Staging: rts5208: helper function to manage idle

Use a helper function to manage idle state Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 45 - 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c

[PATCH 7/7] Staging: rts5208: helper function to manage delink states

Use a helper function to manage delink states Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 141 ++-- 1 file changed, 72 insertions(+), 69 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208

[PATCH 6/7] Staging: rts5208: helper function to manage 1lun and 2lun modes

Use a helper function to manage lun modes when SUPPORT_OCP is defined Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 97 - 1 file changed, 53 insertions(+), 44 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers

[PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value

Fix CHANGE_LINK_STATE value when card_exist is true. This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352 Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b

[PATCH v2] Staging: rts5208: fix CHANGE_LINK_STATE value

Fix CHANGE_LINK_STATE value when card_exist is true. Fixes: a9b693cd77d7 ("Staging: rts5208: helper function to manage delink states") Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH 00/10] Staging: fbtft: flexfb.c file clean up

This patchset aims to refactor the code in flexfb.c, making it more readable and maintanable. Various checkpatch.pl issues are fixed. These patches are created on top of greg-kh's linux-staging tree, staging-testing branch. Fabio Falzoi (10): Staging: fbtft: Remove paragraph about writi

[PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op

Use a helper function to choose which set_addr_win implementation to use, based on the value of the setaddrwin module parameter. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 47 +- 1 file changed, 28 insertions(+), 19 deletions

[PATCH 10/10] Staging: fbtft: Fix spacing coding style issue

This patch fixes the following checkpatch.pl error: CHECK:SPACING at line 318. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index b161050

[PATCH 08/10] Staging: fbtft: Avoid duplicating code to check gpio.dc value

Avoid duplicating code to verify gpios.dc and call flexfb_verify_gpios_dc instead. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index

[PATCH 05/10] Staging: fbtft: Set bus specific ops using separate functions

. CHECK:PARENTHESIS_ALIGNMENT at line 459. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 154 + 1 file changed, 94 insertions(+), 60 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index dae092a..1b833f9 100644

[PATCH 07/10] Staging: fbtft: Remove useless newline

No newline is needed since checkpatch doesn't complain about line longer than 80 characters for string literals. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/st

[PATCH 04/10] Staging: fbtft: Use a helper function to set write_register op

Use a helper function to set the correct write_register function, based on the width of the registers. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/staging/fbtft

[PATCH 03/10] Staging: fbtft: Use a struct to describe each LCD controller

ning a new flexfb_lcd_controller struct. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/fbtft.h | 20 drivers/staging/fbtft/flexfb.c | 212 ++--- 2 files changed, 136 insertions(+), 96 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/sta

[PATCH 09/10] Staging: fbtft: Fix parenthesis alignment coding style issue

This patch fixes the following checkpatch.pl error: CHECK:PARENTHESIS_ALIGNMENT at line 217. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft

[PATCH 02/10] Staging: fbtft: Remove unnecessary multiple blank lines

This patch removes some unnecessary multiple blank lines to fix the following checkpatch errors: CHECK:LINE_SPACING at lines 29, 67, 131, 287, 299, 312, 326, 351 and 364. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 11 --- 1 file changed, 11 deletions(-) diff

[PATCH 01/10] Staging: fbtft: Remove paragraph about writing to FSF

Remove paragraph about writing to the Free Software Foundation's mailing address from GPL notice. This patch fixes the following checkpatch error: CHECK:FSF_MAILING_ADDRESS at line 17. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 4 1 file changed, 4 deletions(-)

[PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

ning a new flexfb_lcd_controller struct. Signed-off-by: Fabio Falzoi Acked-by: Noralf Trønnes --- drivers/staging/fbtft/fbtft.h | 20 drivers/staging/fbtft/flexfb.c | 203 ++--- 2 files changed, 127 insertions(+), 96 deletions(-) diff --git a/drivers/staging/fbt

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

On Sun, Aug 02, 2015 at 07:54:48PM +0200, Noralf Trønnes wrote: > > Seems I wasn't clear enough, you could use my ack if you put > struct flexfb_lcd_controller inside the driver and not in > fbtft.h > > > Noralf. > > Sorry Noralf, I misunderstood your review. I will modify the patch and send a

[PATCH v3] Staging: fbtft: Use a struct to describe each LCD controller

ning a new flexfb_lcd_controller struct. Signed-off-by: Fabio Falzoi Acked-by: Noralf Trønnes --- drivers/staging/fbtft/flexfb.c | 232 - 1 file changed, 136 insertions(+), 96 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flex

[PATCH 0/2] Staging: rts5208: rtsx_reset_chip style clean up

and 351 This patch is inspired by the following post on LKML regarding another clean up for rts5208 module: http://www.spinics.net/lists/linux-driver-devel/msg55038.html Fabio Falzoi (2): Staging: rts5208: helper function to manage aspm during reset Staging: rts5208: helper function to enable

[PATCH 1/2] Staging: rts5208: helper function to manage aspm during reset

Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 72 - 1 file changed, 39 insertions(+), 33 deletions

[PATCH 2/2] Staging: rts5208: helper function to enable interrupts during reset

Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 96 ++--- 1 file changed, 48 insertions(+), 48 deletions

[PATCH v2 0/2] Staging: rts5208: rtsx_reset_chip style clean up

and 351 This patch is inspired by the following post on LKML regarding another clean up for rts5208 module: http://www.spinics.net/lists/linux-driver-devel/msg55038.html Changes in v2: * rebased against staging-testing branch of staging driver development tree Fabio Falzoi (2): Staging: rts5208

[PATCH v2 1/2] Staging: rts5208: helper function to manage aspm during reset

Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 70 + 1 file changed, 39 insertions(+), 31 deletions

[PATCH v2 2/2] Staging: rts5208: helper function to enable interrupts during reset

Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 95 +++-- 1 file changed, 48 insertions(+), 47 deletions

[PATCH RESEND v2 0/2] Staging: rts5208: rtsx_reset_chip style clean up

clean up for rts5208 module: http://www.spinics.net/lists/linux-driver-devel/msg55038.html Changes in v2: * rebased against staging-testing branch of staging driver development tree Fabio Falzoi (2): Staging: rts5208: helper function to manage aspm during reset Staging: rts5208: helper

[PATCH RESEND v2 1/2] Staging: rts5208: helper function to manage aspm during reset

Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi Reviewed-by: Dan Carpenter --- drivers/staging/rts5208/rtsx_chip.c | 70 + 1 file changed, 39

[PATCH RESEND v2 2/2] Staging: rts5208: helper function to enable interrupts during reset

Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi Reviewed-by: Dan Carpenter --- drivers/staging/rts5208/rtsx_chip.c | 95 +++-- 1 file changed, 48

[PATCH v3 0/2] Staging: rts5208: rtsx_reset_chip style clean up

another clean up for rts5208 module: http://www.spinics.net/lists/linux-driver-devel/msg55038.html Changes in v3: * rebased against master branch of linux-next tree Changes in v2: * rebased against staging-testing branch of staging driver development tree Fabio Falzoi (2): Staging: rts5208: helper

[PATCH v3 1/2] Staging: rts5208: helper function to manage aspm during reset

Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the PARENTHESIS_ALIGNMENT checkpatch warnings. Signed-off-by: Fabio Falzoi Reviewed-by: Dan Carpenter --- drivers/staging/rts5208/rtsx_chip.c | 70 + 1 file changed

[PATCH v3 2/2] Staging: rts5208: helper function to enable interrupts

Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code. Signed-off-by: Fabio Falzoi Reviewed-by: Dan Carpenter --- drivers/staging/rts5208/rtsx_chip.c | 95 +++-- 1 file changed, 48 insertions(+), 47 deletions(-) diff --git a

[PATCH 0/4] Staging: rts5208: Use dynamic debug feature

Use standard dynamic debug features instead of relying on the custom configuration option CONFIG_RTS5208_DEBUG and a series of home grown macros. Fabio Falzoi (4): Use standard pr_debug instead of a custom macro Use standard print_hex_dump_debug instead of a custom macro Remove

[PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug

Use print_hex_dump_debug to have memory properly dumped only when dynamic debug is enabled. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 6 -- drivers/staging/rts5208/rtsx_chip.c | 6 -- drivers/staging/rts5208/rtsx_scsi.c | 10 +- drivers/staging

[PATCH 4/4] Staging: rts5208: Fix a format specifier for dev_err

Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 4f5f7a3

[PATCH 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208

Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug

Have I to fix just the commit message or is this behaviour not suitable? In the latter case, could you please suggest a way to fix this? Thank you, Fabio On Sun, Jul 6, 2014 at 6:23 PM, Joe Perches wrote: > On Sun, 2014-07-06 at 18:12 +0200, Fabio Falzoi wrote: >> Use print_hex_dump

[PATCH v2 0/4] Staging: rts5208: Use standard debug features

Use standard debug features instead of relying on the custom configuration option CONFIG_RTS5208_DEBUG and a series of home grown macros. Changes in v2: * defined rtsx_hex_dump macro to produce output only if DEBUG is defined Fabio Falzoi (4): Staging: rts5208: Replace custom macro with

[PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 9 - drivers/staging/rts5208/sd.c

[PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 4f5f7a3

[PATCH v2 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208

Re: [PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

, 2014 at 4:13 AM, micky wrote: > On 07/07/2014 03:10 PM, Fabio Falzoi wrote: >> >> Fix an incorrect use of the %d format specifier in dev_err that caused a >> warning. >> >> Signed-off-by: Fabio Falzoi >> --- >> drivers/staging/rts5208/rtsx.c | 4

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

> > Hi, > here exist some checkpatch errors. > > Best Regards. > micky. Yes, you'are right, I'm gonna fix it, thanks. On Tue, Jul 8, 2014 at 4:12 AM, micky wrote: > On 07/07/2014 03:10 PM, Fabio Falzoi wrote: >> >> Use print_hex_dump_bytes to have m

[PATCH v3 0/4] Staging: rts5208: Use standard debug features

only if DEBUG is defined Fabio Falzoi (4): Staging: rts5208: Replace custom macro with pr_debug Staging: rts5208: Replace custom macro with print_hex_dump_bytes Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Staging: rts5208: Fix a format specifier for dev_err drivers/staging/rts5208

[PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 9 - drivers/staging/rts5208/sd.c

[PATCH v3 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208

[PATCH v3 4/4] Staging: rts5208: Fix a format specifier for dev_err

Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 4f5f7a3

[PATCH v4 2/3] Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory

Use dev_dbg with %*ph format specifier to dump memory instead of relying on custom macro. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 7 +++ drivers/staging/rts5208/sd.c

[PATCH v4 0/3] Staging: rts5208: Use standard debug features

static inline function to avoid checkpatch errors Changes in v2: * defined rtsx_hex_dump macro to produce output only if DEBUG is defined Fabio Falzoi (3): Staging: rts5208: Replace custom macro with dev_dbg Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory Staging: rts5208

[PATCH v4 3/3] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208

[PATCH v5 1/4] Staging: rts5208: Remove useless debug prints

Remove all debug printks used just to mark when we enter a function. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 24 drivers/staging/rts5208/rtsx_scsi.c | 4 2 files changed, 28 deletions(-) diff --git a/drivers/staging/rts5208/ms.c b

[PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory

Use dev_dbg with %*ph format specifier to dump memory instead of relying on custom macro. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 7 +++ drivers/staging/rts5208/sd.c

[PATCH v5 2/4] Staging: rts5208: Replace custom macro with dev_dbg

Use dev_dbg macro to control tracing verbosity through dynamic debug facility. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/debug.h | 43 --- drivers/staging/rts5208/ms.c | 102 + drivers/staging/rts5208/rtsx.c | 6 +- drivers

[PATCH v5 4/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208

[PATCH v5 0/4] Staging: rts5208: Use standard debug features

pr_debug * use dev_dbg with %*ph modifier instead of print_hex_dump_bytes Changes in v3: * defined rtsx_hex_dump as a static inline function to avoid checkpatch errors Changes in v2: * defined rtsx_hex_dump macro to produce output only if DEBUG is defined Fabio Falzoi (4): Staging: rts5208

Re: [PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*ph specifierto dump memory

On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote: > Documentation/printk-formats.txt > > Raw buffer as a hex string: > %*ph00 01 02 ... 3f > %*phC 00:01:02: ... :3f > %*phD 00-01-02- ... -3f > %*phN 000102 ... 3f > > For printing a small buffers (up

[PATCH v6 2/2] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208

[PATCH v6 0/2] Staging: rts5208: Use standard debug features

print_hex_dump_bytes Changes in v3: * defined rtsx_hex_dump as a static inline function to avoid checkpatch errors Changes in v2: * defined rtsx_hex_dump macro to produce output only if DEBUG is defined Fabio Falzoi (2): Staging: rts5208: Use dev_dbg and print_hex_dump_bytes to dump memory Staging: rts5208

[PATCH v6 1/2] Staging: rts5208: Use dev_dbg and print_hex_dump_bytes to dump memory

Use dev_dbg with %*ph format specifier and print_hex_dump_bytes to dump memory instead of relying on custom macro. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 5 +++-- drivers/staging/rts5208/rtsx_chip.c | 6 -- drivers/staging/rts5208/rtsx_scsi.c | 7