Stefan Wahren writes:
> Hi Tuomas,
>
>> Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37
>> geschrieben:
>>
>>
>> Drop various pieces of dead code from here and there to get rid of
>> the remaining users of VCHI_CONNECTION_T. After that we get to drop
>> entire header files worth of unused co
Dan Carpenter writes:
> On Sat, Oct 06, 2018 at 12:18:38PM +0200, Stefan Wahren wrote:
>> Hi Tuomas,
>>
>> > Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37
>> > geschrieben:
>> >
>> >
>> > Drop various pieces of dead code from here and there to get rid of
>> > the remaining users of VCHI_C
Stefan Wahren writes:
> [add Eric]
>
>> Michael Zoran hat am 18. Februar 2017 um 12:59
>> geschrieben:
>>
>>
>> On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote:
>> > The original github source allowed for the cache-line-size property
>> > to be missing. Since recent firmwares also req
T;
> +
> + completion32.reason = completiontemp.reason;
> + completion32.header = ptr_to_compat(completiontemp.header);
> + completion32.service_userdata =
> + ptr_to_compat(completiontemp.service_userdata);
> + completion32.bulk_userdata =
> + ptr_to_compat(completiontemp.bulk_userdata);
> +
> + if (copy_to_user(compat_ptr(args32.buf),
> + &completion32,
> + sizeof(completion32)))
> + return -EFAULT;
> +
> + args32.msgbufcount--;
> +
> + msgbufcount32 =
> + &((struct vchiq_await_completion32 __user *)arg)->msgbufcount;
There seem to be conditions in the real ioctl where msgbufcount doesn't
get decremented. Could we just get_user() the args->msgbufcount and
copy that back out?
With these 3 fixes,
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Mauro Carvalho Chehab writes:
> Em Fri, 27 Jan 2017 13:54:57 -0800
> Eric Anholt escreveu:
>
>> Here's my first pass at importing the camera driver. There's a bunch
>> of TODO left to it, most of which is documented, and the rest being
>> standard checkpat
Greg KH writes:
> On Wed, Mar 15, 2017 at 03:32:56PM +, Dave Stevenson wrote:
>> You've got a reason. It's GPLv2 licenced code so I have no control
>> over what happens to it.
>> Everywhere I have worked, when a patch has issues it is better to "-1"
>> to stop/delay the merge even (or particu
Mauro Carvalho Chehab writes:
> Em Wed, 15 Mar 2017 18:46:24 -0700
> Michael Zoran escreveu:
>
>> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote:
>>
>> > No, I didn't. Thanks! Applied it but, unfortunately, didn't work.
>> > Perhaps I'm missing some other patch. I'm compiling it
Michael Zoran writes:
>> > Since the API is completely documented, I see no reason we or
>> > anybody
>> > couldn't essentially rewrite the driver while it's in staging. I
>> > just
>> > think it would be best for everyone if the new version was a drop
>> > in
>> > replacement for the original v
Michael Zoran writes:
> On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
>> Michael Zoran writes:
>>
>> > > > Since the API is completely documented, I see no reason we or
>> > > > anybody
>> > > > couldn't essentially re
Michael Zoran writes:
> On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote:
>> Michael Zoran writes:
>>
>> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
>> > > Michael Zoran writes:
>> > >
>> > > > > > Since
This allows bcm2835-camera to automatically probe after VCHI has
loaded, rather than only successfully probing if the arbitrary probe
order chooses us after VCHI.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/TODO | 11 ---
.../bcm2835-camera/bcm2835-camera.c
We had the camera driver set up in a module_init function, but that
meant that the camera driver would fail to load if it was initialized
before VCHI. This enforces that it loads after we've successfully set
up.
Signed-off-by: Eric Anholt
---
I'm going to try to get Dave Stevenson&
This allows bcm2835-camera to automatically probe after VCHI has
loaded, rather than only successfully probing if the arbitrary probe
order chooses us after VCHI.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/TODO | 11 ---
.../bcm2835-camera/bcm2835-camera.c
From: Dave Stevenson
mmal-parameters.h didn't have the normal
...
protection to stop it being included multiple times. Add it.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/mmal-parameters.h | 5 +
1 file changed, 5 inser
comes back from the VPU, so we can directly link back to the relevant
V4L2 buffer.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 7 +-
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 109 --
2 files changed, 29
From: Dave Stevenson
Fix a typo flagged by checkpatch, and another in the same line.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
drivers/staging/vc04_services/bcm2835-camera/mmal-msg-port.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Fixes a compiler warning about a set-but-not-used variable. I think
this was just leftover dead code from before set_framerate_params(),
since that also sets up some mmal_parameter_rational structs for fps.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c
The v4l2 uapi uses u8[] for strings, so cast those to char * to avoid
compiler warnings about unsigned vs signed with sprintf() and friends.
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c| 12 ++--
1 file changed, 6 insertions(+), 6 deletions
be scheduled at a
time.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 48 +--
1 file changed, 1 insertion(+), 47 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
b/drivers/staging
From: Dave Stevenson
The error conditions don't warrant taking the kernel down, so remove
BUG_ON.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --
: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 30 +--
.../bcm2835-camera/mmal-common.h | 4 ++
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 38 ++-
.../vc04_services/bcm2835-camera/mmal-vchiq.h | 3 ++
4 files changed, 62 insertions
From: Dave Stevenson
As requested by Mauro Carvalho Chehab in review.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 289 +-
1 file changed, 139 insertions(+), 150 deletions(-)
diff --git a/drivers/staging
: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 6 --
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 21 +--
.../vc04_services/bcm2835-camera/mmal-vchiq.h | 4
3 files changed, 5 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/vc04_services
From: Dave Stevenson
As requested by Mauro Carvalho Chehab in review.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 289 +-
1 file changed, 139 insertions(+), 150 deletions(-)
diff --git a/drivers/staging
mera: Move struct vchiq_mmal_rect
staging: bcm2835-camera: Replace BUG_ON with return error
staging: bcm2835-camera: Fix comment typos.
staging: bcm2835-camera: Fix indentation of tables
Eric Anholt (5):
staging/vc04_services: Register a platform device for the camera
driver.
stagi
The arg is a u32 *, so switch over to that in our declarations.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
b
f that requirement.
v2: Changes by anholt from the downstream driver: Flag two more planar
formats as needing padding removal, and remove broken userspace
workaround.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c
From: Dave Stevenson
struct vchiq_mmal_rect is only referenced from mmal-parameters.h, yet
was defined in mmal-vchiq.h.
Move it to avoid having to include multiple headers for no reason.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/mmal
We had the camera driver set up in a module_init function, but that
meant that the camera driver would fail to load if it was initialized
before VCHI. By attaching to this platform_device, it can get a
defined load order.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/interface
Eric Anholt writes:
> From: Dave Stevenson
>
> As requested by Mauro Carvalho Chehab in review.
>
> Signed-off-by: Dave Stevenson
> Signed-off-by: Eric Anholt
Ignore this one, the other 12/12 is just this with "identation" spelled
right.
signature.as
We just need some integer handles that can map back to our message
struct when we're handling a reply, which struct idr is perfect for.
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 135 --
1 file changed, 31 insertions(+), 104 deletions(-)
Stefan Wahren writes:
> Hi Eric,
>
>> Eric Anholt hat am 11. Mai 2018 um 01:31 geschrieben:
>>
>>
>> We just need some integer handles that can map back to our message
>> struct when we're handling a reply, which struct idr is perfe
We just need some integer handles that can map back to our message
struct when we're handling a reply, which struct idr is perfect for.
v2: Fix error check to look at the right variable.
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 135
Noticed by Stephen Rothwell in -next.
Signed-off-by: Eric Anholt
Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform
driver.")
Cc: Stephen Rothwell
---
Note: only compile tested here.
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 --
Dan Carpenter writes:
> On Thu, May 10, 2018 at 04:31:07PM -0700, Eric Anholt wrote:
>> @@ -258,32 +181,40 @@ get_msg_context(struct vchiq_mmal_instance *instance)
>> if (!msg_context)
>> return ERR_PTR(-ENOMEM);
>>
>> -
debugfs
> calls. This ends up removing a number of lines of code that are not
> needed.
>
> Cc: Eric Anholt
> Cc: Stefan Wahren
> Cc: Kees Cook
> Cc: Dan Carpenter
> Cc: Arnd Bergmann
> Cc: Keerthi Reddy
> Cc: linux-rpi-ker...@lists.infradead.org
> Cc: linu
debugfs
> calls. This ends up removing a number of lines of code that are not
> needed.
This series is:
Reviewed-by: Eric Anholt
Thanks for the cleanups!
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxd
Rabin Vincent writes:
> On Thu, Apr 13, 2017 at 11:29:15PM +0100, Russell King - ARM Linux wrote:
>> > 00a19f3e25c0c40e0ec77f52d4841d23ad269169 is the first bad commit
>> > commit 00a19f3e25c0c40e0ec77f52d4841d23ad269169
>> > Author: Rabin Vincent
>> > Date: Tue Nov 8 09:21:19 2016 +0100
>> >
Rabin Vincent writes:
> On Thu, Apr 20, 2017 at 11:27:38AM -0700, Eric Anholt wrote:
>> I'm confused by what you're saying here. The driver has already been
>> converted to not use dmac_map_area (commit
>> cf9caf1929882b66922aee698e99e6c8f357bee5), and uses dma_
Aaron Moore writes:
> Fix coding style issue caught by checkpatch.pl relating to braces on
> single statement blocks. This issue was corrected in 3 locations.
>
> Signed-off-by: Aaron Moore
Reviewed-by: Eric Anholt
signature.asc
Description: P
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Sat, 31 Dec 2016 22:42:34 +0100
>
> Some update suggestions were taken into account
> from static source code analysis.
This series is:
Reviewed-by: Eric Anholt
signature.asc
Description
Greg Kroah-Hartman writes:
> On Sun, Jan 08, 2017 at 06:15:09PM +, Stefan Wahren wrote:
>> This is a loose bunch of clean up patches for the bcm2835 vchiq driver.
>
> All now applied, thanks.
Thanks! I've been off on vacation and wasn't reviewing anything.
In general, do you want to see R-
Greg KH writes:
> On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
>> On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
>> > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
>> > > Just for clarity, when you mean staging code? Are you talking about
>> > > the
>>
CE_HANDLE_T handle,
> void *data,
> unsigned int size)
>
> int
> vchi_queue_user_message(VCHI_SERVICE_HANDLE_T handle,
> void __user *data,
> unsigned int size)
This is much nicer than the old inter
Signed-off-by: Eric Anholt
---
drivers/staging/media/platform/bcm2835/TODO | 39 +
1 file changed, 39 insertions(+)
create mode 100644 drivers/staging/media/platform/bcm2835/TODO
diff --git a/drivers/staging/media/platform/bcm2835/TODO
b/drivers/staging/media
he driver to the current VCHI API" patch will
conflict with the outstanding "Add vchi_queue_kernel_message and
vchi_queue_user_message" series, but the fix should be pretty obvious
when that lands.
I built this against 4.10-rc1, but a merge with staging-next was clean
and still built fine
Generated with checkpatch.pl --fix-inplace and git add -p out of the
results.
Signed-off-by: Eric Anholt
---
drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++---
drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 12 ++--
2 files changed, 9 insertions(+), 9
49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user")
removed the flags/msg_handle arguments, which were unused, and pushed
the implementation of copying using memcpy vs copy_from_user to the
caller.
Signed-off-by: Eric Anholt
---
drivers/staging/media/platform/bc
: Eric Anholt
---
.../media/platform/bcm2835/bcm2835-camera.c| 90
drivers/staging/media/platform/bcm2835/controls.c | 236 ++---
.../staging/media/platform/bcm2835/mmal-vchiq.c| 13 +-
3 files changed, 167 insertions(+), 172 deletions(-)
diff --git a
This is derived from the downstream tree's build system, but with just
a single Kconfig option.
For now the driver only builds on 32-bit arm -- the aarch64 build
breaks due to the driver using arm-specific cache flushing functions.
Signed-off-by: Eric Anholt
---
drivers/staging/media/Kc
Michael Zoran writes:
> This driver makes no sense outside of ARM or ARM64.
> Add an explicit build dependency on:
> (ARM || ARM64 || COMPILE_TEST)
>
> Also set the default build to n
>
> Signed-off-by: Michael Zoran
> ---
> drivers/staging/bcm2835-audio/Kconfig | 2 ++
> 1 file changed, 2 inse
Joe Perches writes:
> On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
>> Generated with checkpatch.pl --fix-inplace and git add -p out of the
>> results.
>
> Maybe another.
>
>> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
>> b/dr
Joe Perches writes:
> On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote:
>> Joe Perches writes:
>>
>> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
>> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the
>
Dan Carpenter writes:
> There is a bunch of vc04_services that we're still looking to merge in
> the near future. Please hold off deleting these until we are further
> along on that.
Checking the downstream tree, these are actually dead.
signature.asc
Description: PGP signature
__
Greg KH writes:
> On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote:
>> From: Michael Zoran
>>
>> The original arm implementation uses dmac_map_area which is not
>> portable. Replace it with an architecture neutral version
>> which uses dma_map_sg.
>>
>> As you can see that
mzo...@crowfest.net writes:
> From: Michael Zoran
>
> The original arm implementation uses dmac_map_area which is not
> portable. Replace it with an architecture neutral version
> which uses dma_map_sg.
>
> As you can see that for larger page sizes, the dma_map_sg
> implementation is faster then
Michael Zoran writes:
> On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote:
>> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
>> > mzo...@crowfest.net writes:
>> >
>> > > */
>> > >
>> > > static int
>>
; vchiq_test -b 512 1 4372us/iter 4616us/iter 4123us
Reviewed-by: Eric Anholt
Nice work! More portability and better performance at the same time.
A possible future improvement would be to track the pagelist, num_pages,
and pagelist_size in a struct in the bulk->remote_d
odingStyle after a brief search.
Other than this concern, all 5 patches are:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
the magic cookie
> + * is filled if debugging is enabled
> + */
> + sg_init_table(scatterlist, num_pages);
> + /* Now set the pages for each scatterlist */
I feel like the comments don't add much, but either way:
Acked-by: Eric Anholt
> for (i = 0; i <
Michael Zoran writes:
> Setting the DMA mask is optional on 32 bit but
> is mandatory on 64 bit. Set the DMA mask and coherent
> to force all DMA to be in the 32 bit address space.
>
> This is considered a "good practice" and most drivers
> already do this.
>
> Signed-off-by: Michael Zoran
> --
t is expected that a human debugging
> the kernel interpret it.
>
> This change adds a cast to long before the original cast
> to int to silence the warning.
>
> Signed-off-by: Michael Zoran
Thanks for sorting this out.
Reviewed-by: E
o understand and maintain.
>
> Tests Run(Both Pass):
> vchiq_test -p 1
> vchiq_test -f 10
Looks good, and it's a nice cleanup. Thanks!
Reviewed-by: Eric Anholt
I had one style note, which was that you're using an int and 0/1 for a
boolean value, but we like to use proper bo
Michael Zoran writes:
> VCHI messages between the CPU and firmware use 32-bit
> bus addresses. Explicitly set the DMA mask and coherent
> on all platforms.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
devel mailin
occi
>
> Signed-off-by: Fengguang Wu
These 3 are:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nullfree.cocci
>
> Signed-off-by: Fengguang Wu
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Michael Zoran writes:
> On Tue, 2016-11-15 at 22:04 -0500, Vince Weaver wrote:
>> On Tue, 15 Nov 2016, Michael Zoran wrote:
>>
>> > I'm still interested to know more about the MMU statement. I would
>> > think at least some of the RPI models have one because swapping
>> > appears
>> > to be at
Arnd Bergmann writes:
> The driver tries to redefine mutex_lock_interruptible as an open-coded
> mutex_lock_killable, but that definition clashes with the normal
> mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC
> is set:
These two are:
Acked-by: Eric Anholt
s
***/
> +/* Copyright 2011 Broadcom Corporation. All rights reserved. */
The "Notwithstanding..." section feels like something unusual and not
represented by the SPDX identifier. Not sure what to do about that.
The 2 camera patches are:
R
"Tobin C. Harding" writes:
> The kernel would like to have all stack VLA usage removed[1]. The
> array here is fixed (declared with a const variable) but it appears
> like VLA to the compiler. We can use a pre-processor define to quiet
> the compiler.
>
> [1]: https://lkml.org/lkml/2018/3/7/621
table
> +
> +Building this driver with arm/multi_v7_defconfig or arm64/defconfig
> +leads to data corruption during vchiq_test. This should be fixed.
Sounds good, but could you document that it's "vchiq_test -f" for
testing this?
With that, these two get my:
Reviewed-by: Eric
71 matches
Mail list logo
