symbol 'devmajorminor_remove_file' was not declared
warning: symbol 'devmajorminor_remove_all_files' was not declared
warning: symbol 'unregister_devmajorminor_attributes' was not declared
Signed-off-by: Drew Fustini
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2
On Mon, Jun 01, 2015 at 02:34:16PM -0400, Ben Romer wrote:
> Would you mind if I sent a second version of this patch with it
> rebased against my last set of patches, so it will apply?
Please go ahead.
thanks,
drew
___
devel mailing list
de...@linuxdriv
Move extern declartions from fbtft-core.c to fbtft header file. This resovles
the warning from checkpatch.pl that "externs should be avoided in .c files".
Signed-off-by: Drew Fustini
---
drivers/staging/fbtft/fbtft-core.c | 5 -
drivers/staging/fbtft/fbtft.h | 7 ++
On Tue, Mar 03, 2015 at 04:33:01PM +0530, Sudip Mukherjee wrote:
> but now it adds 6 additional warning in checkpatch --strict
> "extern prototypes should be avoided in .h files"
Thanks, Sudip. I did not realize that was an option for checkpatch.
I see now that there are additional warnings as yo
also advised fbtft.h file will eventually live in include/linux/fbtft.h
Suggested-by: Noralf Trønnes
Signed-off-by: Drew Fustini
---
drivers/staging/fbtft/fbtft-core.c | 7 +--
drivers/staging/fbtft/internal.h | 25 +
2 files changed, 26 insertions(+), 6 delet
On Tue, Mar 03, 2015 at 08:04:10PM +0100, Noralf Trønnes wrote:
> These functions are defined in fbtft-sysfs.c and internal to the
> fbtft module.
> I think it's better to put them in an 'internal.h' file.
> The fbtft.h file will eventually live in include/linux/fbtft.h or
> something like that.
T
