Re: HFI1 code duplication todo

2015-11-20 Thread Doug Ledford
ging and moved hfi1 to the rdma tree. I've sent an email to Linus to see if he's ok taking those changes, and if so, I'll get them submitted and then open up my for-4.5 branch early to be able to start taking for-next patches. -- Doug Ledford GPG KeyID: 0E572FDD

Re: HFI1 code duplication todo

2015-11-20 Thread Doug Ledford
On 11/20/2015 11:39 AM, Greg KH wrote: > On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: >> To that end, I've opened my 4.4-rc branch and deleted the three >> deprecated drivers from staging and moved hfi1 to the rdma tree. I've >> sent an email to

Re: HFI1 code duplication todo

2015-11-20 Thread Doug Ledford
gt;> Yes, I know. I've been busy. My apologies for not getting it in prior >> to rc1. > > It's not a problem, life happens (congratulations by the way), Thanks :-) > but don't > rush things now, why not just wait until the next merge window, there > are no d

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-22 Thread Doug Ledford
s the library changes, let me know that public git commit >>>>> and I can pull it into the staging-next branch and you can continue to >>>>> send me staging patches that way. >>>> >>>> Won't this cause a conflict d

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-12 Thread Doug Ledford
drivers/infiniband/ulp/ipoib/ipoib_cm.c| 2 +- > drivers/infiniband/ulp/ipoib/ipoib_ib.c| 2 +- For InfiniBand bits, Acked-by: Doug Ledford -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital si

Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing.

2016-05-13 Thread Doug Ledford
(ppd->cc_state, NULL); > spin_unlock(&ppd->cc_state_lock); > > if (cc_state) > Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailin

Re: [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr()

2016-01-19 Thread Doug Ledford
On 01/08/2016 08:29 AM, Christoph Hellwig wrote: > Looks fine. > > Doug: what's the status of the staged out drivers? I thought we were > going to delete them for 4.5? > I am. They will be going away shortly. -- Doug Ledford GPG KeyID: 0E572FDD signa

Re: [PATCH] staging: amso1100: fix format string for 64-bit phys_addr

2016-02-04 Thread Doug Ledford
s); > pr_debug(" status: 0x%x\n", rxp_hdr->status); > pr_debug("len : %u\n", rxp_hdr->len); > I've sent off a deletion of this file to Linus already, sorry. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] rdma: amso1100: c2_provider: Use netdev_dbg()

2016-02-11 Thread Doug Ledford
for_ifa(ind) { > #ifdef DEBUG > u8 *ip = (u8 *) & ifa->ifa_address; > @@ -684,7 +684,7 @@ static int c2_pseudo_down(struct net_device *netdev) > if (!ind) > return 0; > > - pr_debug("deleting...\n"); > + ne

Re: [PATCH] IB/rxe: fix compare_const_fl.cocci warnings

2016-02-18 Thread Doug Ledford
On 2/18/2016 8:06 AM, Julia Lawall wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > CC: Kamal Heib > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > The constants on the right look a bit nicer.

Re: [PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2016-03-01 Thread Doug Ledford
e_interrupt(sde, status); > write_seqlock(&sde->head_lock); > sdma_set_desc_cnt(sde, sdma_desct_intr); > + if (status & sde->idle_mask) > + sde->idle_int_cnt++; > + else if (status & sde->progress_mask) > + sde->progress_

Re: [PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2016-03-03 Thread Doug Ledford
Would you like us to do a cleanup of this code > in a follow-on patch or rework this patch and resend the series? > > Jubin > Thanks, the code is confusing to read, so a cleanup would be nice. Just send me something I can squash into this patch is good enough. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: staging drivers

2015-07-16 Thread Doug Ledford
eference. There was a recent commit by Al to one of Intel's other drivers that basically said "Drivers should *never* do this...", but it's been working fine for them, so they are looking for alternatives that don't cause Al to want to hunt them down as insult fodder, so

Re: [PATCH 04/38] IB/ehca: fix handling idr_alloc result

2015-09-29 Thread Doug Ledford
> > Signed-off-by: Andrzej Hajda Patch looks fine to me. Acked-by: Doug Ledford > --- > drivers/staging/rdma/ehca/ehca_cq.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rdma/ehca/ehca_cq.c > b/drivers/s

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
ause it’s >50,000 lines of code, so repeated patch submissions to the mailing list were absolutely painful, but it has work that needs done as a result of review comments, and one item of work in particular (converting it to use an RDMA transfer engine library) will take a lot o

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-08-18 Thread Doug Ledford
I haven’t sent any pull requests for this yet. My github repo is in 0day testing, but my k.o repo is the one in linux-next testing and I haven’t pushed this to k.o as of yet. > Doug, can you respond to why staging and get this patch into your repo? I can certainly add this to the hfi1 bra

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
> On Aug 18, 2015, at 4:11 PM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: >> >>> On Aug 18, 2015, at 9:50 AM, Greg KH wrote: >>> >>> On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: >>>

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
> On Aug 18, 2015, at 7:49 PM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: >> >> >>> Are >>> you going to be responsible for all of the patches sent to it and you >>> just want me to ignore them, or will you

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
gt;> the maintainer entry for the directory and redirect it to linux-rdma, >> and delete it when this work has passed. > > That sounds like a good plan to me. I’ll rebase my tree and fix it up. — Doug Ledford GPG Key ID: 0E572FDD signature.asc Descri

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Doug Ledford
rt > IB host channel adapter (model QHT7140), > The ipath driver was moved to staging/rdma/ipath and has proper protection against being built without the InfiniBand subsystem. Where are you seeing this tree? I'm curious because I no longer have this driver in this location in my

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Doug Ledford
On 09/01/2015 12:54 PM, Jim Davis wrote: > On Tue, Sep 1, 2015 at 7:52 AM, Doug Ledford wrote: >> On 09/01/2015 09:01 AM, Sudip Mukherjee wrote: >>> building of ipath depends on infiniband. And if ipath is selected and >>> infiniband is not then build fails with:

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-09-03 Thread Doug Ledford
fi1 > + > STARFIRE/DURALAN NETWORK DRIVER > M: Ion Badulescu > S: Odd Fixes > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailing list de...@linuxdrive

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-09-03 Thread Doug Ledford
;& INFINIBAND && PCI > default m > ---help--- > This is a low-level driver for Intel OPA Gen1 adapter. > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature __

Re: [PATCH] drivers:staging:hfi1: Fix coding style issues

2015-09-03 Thread Doug Ledford
b_wc *in_wc, > + const struct ib_grh *in_grh, > + const struct opa_mad *in_mad, > + struct opa_mad *out_mad, size_t *out_mad_size, > + u16 *out_mad_pkey_index) > { >

Re: [PATCH] IB/hfi1: fix sdma_descq_cnt parameter parsing

2015-09-18 Thread Doug Ledford
On 09/15/2015 10:19 AM, Mike Marciniszyn wrote: > The boolean tests should have been or-ed. > > Reported-by: David Binderman > Reviewed-by: Jubin John > Signed-off-by: Mike Marciniszyn Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.

Re: [patch] IB/hfi1: fix copy_to/from_user() error handling

2015-09-18 Thread Doug Ledford
it to fill /var/log/messages with spam. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailing list de...@l

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-18 Thread Doug Ledford
On 09/16/2015 02:22 AM, Dan Carpenter wrote: > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > oops on failure. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: Ope

Re: [patch] IB/hfi1: fix a locking bug

2015-09-18 Thread Doug Ledford
On 09/16/2015 02:22 AM, Dan Carpenter wrote: > mutex_trylock() returns zero on failure, not EBUSY. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital

Re: [patch v2] IB/hfi1: info leak in get_ctxt_info()

2015-09-18 Thread Doug Ledford
On 09/16/2015 02:42 AM, Dan Carpenter wrote: > The cinfo struct has a hole after the last struct member so we need to > zero it out. Otherwise we disclose some uninitialized stack data. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG Key

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Doug Ledford
On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote: > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: >> On 09/16/2015 02:22 AM, Dan Carpenter wrote: >>> __get_txreq() returns an ERR_PTR() but this checks for NULL so it would >>> oops on failure. >>&

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Doug Ledford
ly > as people will continue to send stuff to me. As you wish. I pulled in a number of patches related to hfi1, but I've already sent the pull request to Linus and they made it as of 4.1-rc2. So, just start from there and you will have all the patches I've taken. -- Doug Ledford