Re: [PATCH] media: staging: tegra-vde: Change from __attribute to __packed.

2018-11-07 Thread Dmitry Osipenko
On 07.11.2018 5:23, rafaelgoncal...@riseup.net wrote: > From: Rafael Goncalves > > Correct the following warnings from checkpatch.pl: > > WARNING: __packed is preferred over __attribute__((packed)) > +} __attribute__((packed)); > > WARNING: __packed is preferred over __attribute__((packed)) > +

Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier

2018-11-08 Thread Dmitry Osipenko
e %d: frame_num = %d B_frame = %d\n", > + "\tFrame %d: frame_num = %d B_frame = %lu\n", > i + 1, frame->frame_num, > (frame->flags & FLAG_B_FRAME)); >

Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier

2018-11-13 Thread Dmitry Osipenko
On 09.11.2018 17:32, Hans Verkuil wrote: > On 11/08/18 12:02, Colin King wrote: >> From: Colin Ian King >> >> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because >> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a >> build warning. Fix this by using the %lu

Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier

2018-11-13 Thread Dmitry Osipenko
On 13.11.2018 19:52, Dmitry Osipenko wrote: > On 09.11.2018 17:32, Hans Verkuil wrote: >> On 11/08/18 12:02, Colin King wrote: >>> From: Colin Ian King >>> >>> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because >>> of the use

[PATCH v3] media: staging: tegra-vde: Replace debug messages with trace points

2018-11-19 Thread Dmitry Osipenko
Trace points are much more efficient than debug messages for intensive tracing and could be conveniently enabled / disabled dynamically, hence let's replace debug messages with the trace points. This also makes code a bit cleaner. Signed-off-by: Dmitry Osipenko --- Changelog

Re: [PATCH 17/78] staging: media: vde: use pm_runtime_resume_and_get()

2021-04-24 Thread Dmitry Osipenko
24.04.2021 09:44, Mauro Carvalho Chehab пишет: > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with > usage counter") > added pm_runtime_resume_and_get() in order to automatically handle > dev->power.usage_count decrement on errors. > > Use the new API, in order to clea

Re: [PATCH v3 25/79] staging: media: vde: use pm_runtime_resume_and_get()

2021-04-27 Thread Dmitry Osipenko
27.04.2021 13:26, Mauro Carvalho Chehab пишет: > @@ -1088,8 +1090,9 @@ static int tegra_vde_remove(struct platform_device > *pdev) > { > struct tegra_vde *vde = platform_get_drvdata(pdev); > struct device *dev = &pdev->dev; > + int ret; > > - pm_runtime_get_sync(dev); > +

Re: [PATCH v3 25/79] staging: media: vde: use pm_runtime_resume_and_get()

2021-04-28 Thread Dmitry Osipenko
28.04.2021 10:20, Mauro Carvalho Chehab пишет: > Em Tue, 27 Apr 2021 14:47:01 +0300 > Dmitry Osipenko escreveu: > >> 27.04.2021 13:26, Mauro Carvalho Chehab пишет: >>> @@ -1088,8 +1090,9 @@ static int tegra_vde_remove(struct platform_device >>> *pdev) >

Re: [PATCH v4 00/79] Address some issues with PM runtime at media subsystem

2021-04-29 Thread Dmitry Osipenko
29.04.2021 13:18, Mauro Carvalho Chehab пишет: >> This is perfectly alright. Take a look at ov7740_remove() for example: >> >> pm_runtime_get_sync(&client->dev); >> pm_runtime_disable(&client->dev); >> pm_runtime_set_suspended(&client->dev); >> pm_runtime_put_noidle(&client->dev

Re: [PATCH v4 25/79] staging: media: tegra-vde: use pm_runtime_resume_and_get()

2021-04-29 Thread Dmitry Osipenko
28.04.2021 17:51, Mauro Carvalho Chehab пишет: > @@ -1069,11 +1071,17 @@ static int tegra_vde_probe(struct platform_device > *pdev) >* power-cycle it in order to put hardware into a predictable lower >* power state. >*/ > - pm_runtime_get_sync(dev); > + if (pm_runti

[PATCH v1 08/30] soc/tegra: regulators: Support Tegra SoC device sync state API

2020-11-04 Thread Dmitry Osipenko
state. Once everything is synced, the voltage of the CORE domain could be scaled without any limitations. Make Tegra20/30 regulator couplers to use the new sync state API. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/regulators-tegra20.c

[PATCH v1 02/30] dt-bindings: mmc: tegra: Document OPP and voltage regulator properties

2020-11-04 Thread Dmitry Osipenko
Document new DVFS OPP table and voltage regulator properties of the SDHCI controller. Signed-off-by: Dmitry Osipenko --- .../devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/nvidia,tegra20

[PATCH v1 03/30] dt-bindings: pwm: tegra: Document OPP and voltage regulator properties

2020-11-04 Thread Dmitry Osipenko
Document new DVFS OPP table and voltage regulator properties of the PWM controller. Signed-off-by: Dmitry Osipenko --- .../devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/nvidia,tegra20

[PATCH v1 05/30] dt-binding: usb: ci-hdrc-usb2: Document OPP and voltage regulator properties

2020-11-04 Thread Dmitry Osipenko
Document new OPP table and NVIDIA Tegra-specific voltage regulator properties. Signed-off-by: Dmitry Osipenko --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b

[PATCH v1 06/30] dt-bindings: usb: tegra-ehci: Document OPP and voltage regulator properties

2020-11-04 Thread Dmitry Osipenko
Document new DVFS OPP table and voltage regulator properties of the Tegra EHCI controller. Signed-off-by: Dmitry Osipenko --- Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20

[PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-04 Thread Dmitry Osipenko
[1] https://patchwork.ozlabs.org/project/linux-tegra/list/?series=212196 Dmitry Osipenko (30): dt-bindings: host1x: Document OPP and voltage regulator properties dt-bindings: mmc: tegra: Document OPP and voltage regulator properties dt-bindings: pwm: tegra: Document OPP and voltage regulator

[PATCH v1 01/30] dt-bindings: host1x: Document OPP and voltage regulator properties

2020-11-04 Thread Dmitry Osipenko
Document new DVFS OPP table and voltage regulator properties of the Host1x bus and devices sitting on the bus. Signed-off-by: Dmitry Osipenko --- .../display/tegra/nvidia,tegra20-host1x.txt | 56 +++ 1 file changed, 56 insertions(+) diff --git a/Documentation/devicetree

[PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the display controller driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra

[PATCH v1 04/30] media: dt: bindings: tegra-vde: Document OPP and voltage regulator properties

2020-11-04 Thread Dmitry Osipenko
Document new DVFS OPP table and voltage regulator properties of the video decoder engine. Signed-off-by: Dmitry Osipenko --- .../devicetree/bindings/media/nvidia,tegra-vde.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/media/nvidia

[PATCH v1 22/30] memory: tegra20-emc: Support Tegra SoC device state syncing

2020-11-04 Thread Dmitry Osipenko
Sync driver state using the Tegra SoC device state syncing API, telling to regulators voltage coupler that EMC state is ready for DVFS. This is required for enabling system-wide DVFS on Tegra20. Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra20-emc.c

[PATCH v1 12/30] drm/tegra: gr2d: Correct swapped device-tree compatibles

2020-11-04 Thread Dmitry Osipenko
The device-tree compatibles are swapped in the code, correct them. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gr2d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers

[PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the Tegra SDHCI driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-tegra.c

[PATCH v1 25/30] ARM: tegra: Add OPP tables for Tegra30 peripheral devices

2020-11-04 Thread Dmitry Osipenko
Add OPP tables for Tegra30 SoC devices. Signed-off-by: Dmitry Osipenko --- .../arm/boot/dts/tegra30-peripherals-opp.dtsi | 415 ++ arch/arm/boot/dts/tegra30.dtsi| 13 + 2 files changed, 428 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-peripherals

[PATCH v1 27/30] ARM: tegra: paz00: Add voltage supplies to DVFS-capable devices

2020-11-04 Thread Dmitry Osipenko
Add voltage supplies to DVFS-capable devices in order to enable system-wide voltage scaling and allow CORE/RTC regulators to go lower. Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra20-paz00.dts | 40 - 1 file changed, 33

[PATCH v1 10/30] regulator: Allow skipping disabled regulators in regulator_check_consumers()

2020-11-04 Thread Dmitry Osipenko
state. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/regulator/core.c | 12 drivers/soc/samsung/exynos-regulator-coupler.c | 2 +- drivers/soc/tegra/regulators-tegra20.c | 6 +++--- drivers/soc/tegra/regul

[PATCH v1 07/30] soc/tegra: Add sync state API

2020-11-04 Thread Dmitry Osipenko
ff-by: Dmitry Osipenko --- drivers/soc/tegra/common.c | 152 - include/soc/tegra/common.h | 22 ++ 2 files changed, 170 insertions(+), 4 deletions(-) diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c index 3dc54f59cafe..f9b2b6f57887 100644

[PATCH v1 24/30] ARM: tegra: Add OPP tables for Tegra20 peripheral devices

2020-11-04 Thread Dmitry Osipenko
Add OPP tables for Tegra20 SoC devices. Signed-off-by: Dmitry Osipenko --- .../arm/boot/dts/tegra20-peripherals-opp.dtsi | 386 ++ arch/arm/boot/dts/tegra20.dtsi| 14 + 2 files changed, 400 insertions(+) diff --git a/arch/arm/boot/dts/tegra20-peripherals

[PATCH v1 19/30] media: staging: tegra-vde: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add initial OPP and SoC core voltage scaling support to the video decoder driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/Kconfig | 1 + drivers

[PATCH v1 21/30] usb: host: ehci-tegra: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add initial OPP and SoC core voltage scaling support to the Tegra EHCI driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/usb/host/Kconfig | 1 + drivers/usb/host/ehci

[PATCH v1 29/30] ARM: tegra: cardhu-a04: Add voltage supplies to DVFS-capable devices

2020-11-04 Thread Dmitry Osipenko
Add voltage supplies to DVFS-capable devices in order to enable system-wide voltage scaling. Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra30-cardhu-a04.dts | 44 1 file changed, 44 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-cardhu-a04.dts b/arch

[PATCH v1 14/30] drm/tegra: gr3d: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the GR3D driver. This is required for enabling system-wide DVFS on Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gr3d.c | 136 +++ 1 file

[PATCH v1 28/30] ARM: tegra: acer-a500: Add voltage supplies to DVFS-capable devices

2020-11-04 Thread Dmitry Osipenko
Add voltage supplies to DVFS-capable devices in order to enable system-wide voltage scaling and allow CORE/RTC regulators to go lower. Signed-off-by: Dmitry Osipenko --- .../boot/dts/tegra20-acer-a500-picasso.dts| 30 +-- 1 file changed, 28 insertions(+), 2 deletions

[PATCH v1 13/30] drm/tegra: gr2d: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the GR2D driver. This is required for enabling system-wide DVFS on Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gr2d.c | 136 +++ 1 file

[PATCH v1 23/30] memory: tegra30-emc: Support Tegra SoC device state syncing

2020-11-04 Thread Dmitry Osipenko
Sync driver state using the Tegra SoC device state syncing API, telling to regulators voltage coupler that EMC state is ready for DVFS. This is required for enabling system-wide DVFS on Tegra30. Tested-by: Peter Geis Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra30-emc.c | 8

[PATCH v1 09/30] soc/tegra: regulators: Fix lockup when voltage-spread is out of range

2020-11-04 Thread Dmitry Osipenko
-tree. Fixes: 783807436f36 ("soc/tegra: regulators: Add regulators coupler for Tegra30") Cc: sta...@vger.kernel.org Tested-by: Peter Geis Reported-by: Peter Geis Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/regulators-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v1 18/30] pwm: tegra: Support OPP and core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the Tegra PWM driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/pwm/Kconfig | 1 + drivers/pwm/pwm-tegra.c | 84

[PATCH v1 26/30] ARM: tegra: ventana: Add voltage supplies to DVFS-capable devices

2020-11-04 Thread Dmitry Osipenko
Add voltage supplies to DVFS-capable devices in order to enable system-wide voltage scaling and allow CORE/RTC regulators to go lower. Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra20-ventana.dts | 65 +++ 1 file changed, 56 insertions(+), 9 deletions

[PATCH v1 16/30] gpu: host1x: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add initial OPP and SoC core voltage scaling support to the Host1x driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/Kconfig | 1 + drivers/gpu/host1x/dev.c | 87

[PATCH v1 20/30] usb: chipidea: tegra: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add initial OPP and SoC CORE voltage scaling support to the Tegra UDC driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Tested-by: Peter Geis Signed-off-by: Dmitry Osipenko --- drivers/usb/chipidea/Kconfig | 1 + drivers/usb/chipidea/ci_hdrc_tegra.c | 79

[PATCH v1 30/30] ARM: tegra: nexus7: Add voltage supplies to DVFS-capable devices

2020-11-04 Thread Dmitry Osipenko
Add voltage supplies to DVFS-capable devices in order to enable system-wide voltage scaling. Signed-off-by: Dmitry Osipenko --- .../tegra30-asus-nexus7-grouper-common.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper

[PATCH v1 15/30] drm/tegra: hdmi: Support OPP and SoC core voltage scaling

2020-11-04 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the HDMI driver. This is required for enabling system-wide DVFS on older Tegra SoCs. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/hdmi.c | 63 +++- 1 file changed, 62 insertions(+), 1 deletion(-) diff

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-05 Thread Dmitry Osipenko
05.11.2020 04:45, Michał Mirosław пишет: > On Thu, Nov 05, 2020 at 02:43:57AM +0300, Dmitry Osipenko wrote: >> Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces >> power consumption and heating of the Tegra chips. Tegra SoC has multiple >> hardware un

Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-11-05 Thread Dmitry Osipenko
05.11.2020 12:58, Viresh Kumar пишет: >> +static void sdhci_tegra_deinit_opp_table(void *data) >> +{ >> + struct device *dev = data; >> + struct opp_table *opp_table; >> + >> + opp_table = dev_pm_opp_get_opp_table(dev); > So you need to get an OPP table to put one :) > You need to

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-05 Thread Dmitry Osipenko
05.11.2020 12:45, Ulf Hansson пишет: ... > I need some more time to review this, but just a quick check found a > few potential issues... Thank you for starting the review! I'm pretty sure it will take a couple revisions until all the questions will be resolved :) > The "core-supply", that you sp

Re: [PATCH v1 21/30] usb: host: ehci-tegra: Support OPP and SoC core voltage scaling

2020-11-05 Thread Dmitry Osipenko
05.11.2020 19:07, Alan Stern пишет: > Do you really want to use the same error unwinding for opp_table values > obtained from dev_pm_opp_set_regulators() as from > dev_pm_opp_get_opp_table()? They both are pointing at the same opp_table, which is refcounted. The dev_pm_opp_set_regulators() is d

Re: [PATCH v1 21/30] usb: host: ehci-tegra: Support OPP and SoC core voltage scaling

2020-11-05 Thread Dmitry Osipenko
05.11.2020 19:07, Alan Stern пишет: >> +err = devm_tegra_ehci_init_opp_table(&pdev->dev); >> +if (err) >> +return dev_err_probe(&pdev->dev, err, >> + "Failed to initialize OPP\n"); > Why log a second error message? Just return err. Indeed, thank

Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-11-06 Thread Dmitry Osipenko
06.11.2020 09:15, Viresh Kumar пишет: > Setting regulators for count as 0 doesn't sound good to me. > > But, I understand that you don't want to have that if (have_regulator) > check, and it is a fair request. What I will instead do is, allow all > dev_pm_opp_put*() API to start accepting a NULL p

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-08 Thread Dmitry Osipenko
05.11.2020 18:22, Dmitry Osipenko пишет: > 05.11.2020 12:45, Ulf Hansson пишет: > ... >> I need some more time to review this, but just a quick check found a >> few potential issues... > > Thank you for starting the review! I'm pretty sure it will take a couple > r

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-08 Thread Dmitry Osipenko
09.11.2020 07:43, Viresh Kumar пишет: > On 08-11-20, 15:19, Dmitry Osipenko wrote: >> I took a detailed look at the GENPD and tried to implement it. Here is >> what was found: >> >> 1. GENPD framework doesn't aggregate performance requests from the >> attach

Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-11-08 Thread Dmitry Osipenko
09.11.2020 08:00, Viresh Kumar пишет: > On 06-11-20, 21:41, Frank Lee wrote: >> On Fri, Nov 6, 2020 at 9:18 PM Dmitry Osipenko wrote: >>> >>> 06.11.2020 09:15, Viresh Kumar пишет: >>>> Setting regulators for count as 0 doesn't sound good to me. >&g

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-08 Thread Dmitry Osipenko
09.11.2020 07:47, Dmitry Osipenko пишет: > 09.11.2020 07:43, Viresh Kumar пишет: >> On 08-11-20, 15:19, Dmitry Osipenko wrote: >>> I took a detailed look at the GENPD and tried to implement it. Here is >>> what was found: >>> >>> 1. GENPD framework do

Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-11-08 Thread Dmitry Osipenko
09.11.2020 08:10, Viresh Kumar пишет: > On 09-11-20, 08:08, Dmitry Osipenko wrote: >> 09.11.2020 08:00, Viresh Kumar пишет: >>> On 06-11-20, 21:41, Frank Lee wrote: >>>> On Fri, Nov 6, 2020 at 9:18 PM Dmitry Osipenko wrote: >>>>> >>>&

Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-11-08 Thread Dmitry Osipenko
09.11.2020 08:35, Viresh Kumar пишет: > On 09-11-20, 08:19, Dmitry Osipenko wrote: >> Thanks, I made it in a different way by simply adding helpers to the >> pm_opp.h which use devm_add_action_or_reset(). This doesn't require to >> add new kernel symbols. > > I

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-10 Thread Dmitry Osipenko
10.11.2020 23:29, Thierry Reding пишет: >> + >> +dc->opp_table = dev_pm_opp_get_opp_table(dc->dev); >> +if (IS_ERR(dc->opp_table)) >> +return dev_err_probe(dc->dev, PTR_ERR(dc->opp_table), >> + "failed to prepare OPP table\n"); >> + >> +if (of

Re: [PATCH v1 18/30] pwm: tegra: Support OPP and core voltage scaling

2020-11-10 Thread Dmitry Osipenko
10.11.2020 23:50, Thierry Reding пишет: > On Thu, Nov 05, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > [...] >> +static void tegra_pwm_deinit_opp_table(void *data) >> +{ >> +struct device *dev = data; >> +struct opp_table *opp_table; >> + >>

Re: [PATCH v1 07/30] soc/tegra: Add sync state API

2020-11-10 Thread Dmitry Osipenko
10.11.2020 23:47, Thierry Reding пишет: ... > tegra_soc_for_each_device > > I wonder if you copy/pasted this or if you got really lucky to mistype > this all three times. Copied of course :) I added a special spell checking rule for this typo, but it does help reliably. ... >> +terga_soc_fo

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-10 Thread Dmitry Osipenko
10.11.2020 23:32, Mark Brown пишет: > On Tue, Nov 10, 2020 at 09:29:45PM +0100, Thierry Reding wrote: >> On Thu, Nov 05, 2020 at 02:44:08AM +0300, Dmitry Osipenko wrote: > >>> + /* >>> +* Voltage scaling is optional and trying to set voltage for a dummy >&

Re: [PATCH v1 07/30] soc/tegra: Add sync state API

2020-11-10 Thread Dmitry Osipenko
11.11.2020 00:22, Dmitry Osipenko пишет: > I added a special spell checking rule for this typo, but it does help > reliably. does *not* ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/li

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-10 Thread Dmitry Osipenko
10.11.2020 23:29, Thierry Reding пишет: >> +/* legacy device-trees don't have OPP table */ >> +if (!device_property_present(dc->dev, "operating-points-v2")) >> +return 0; > "Legacy" is a bit confusing here. For one, no device trees currently > have these tables and secondly, for

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-12 Thread Dmitry Osipenko
11.11.2020 14:55, Mark Brown пишет: > On Wed, Nov 11, 2020 at 12:23:41AM +0300, Dmitry Osipenko wrote: >> 10.11.2020 23:32, Mark Brown пишет: > >>>>> + if (!device_property_present(dc->dev, "core-supply")) >>>>> + return; > >&g

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-12 Thread Dmitry Osipenko
12.11.2020 20:16, Mark Brown пишет: > On Thu, Nov 12, 2020 at 07:59:36PM +0300, Dmitry Osipenko wrote: >> 11.11.2020 14:55, Mark Brown пишет: >>> On Wed, Nov 11, 2020 at 12:23:41AM +0300, Dmitry Osipenko wrote: > >>>> I already changed that code to use regulator_g

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-12 Thread Dmitry Osipenko
11.11.2020 14:38, Ulf Hansson пишет: > On Sun, 8 Nov 2020 at 13:19, Dmitry Osipenko wrote: >> >> 05.11.2020 18:22, Dmitry Osipenko пишет: >>> 05.11.2020 12:45, Ulf Hansson пишет: >>> ... >>>> I need some more time to review this, but just a

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-12 Thread Dmitry Osipenko
12.11.2020 23:43, Thierry Reding пишет: >> The difference in comparison to using voltage regulator directly is >> minimal, basically the core-supply phandle is replaced is replaced with >> a power-domain phandle in a device tree. > These new power-domain handles would have to be added to devices th

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-12 Thread Dmitry Osipenko
12.11.2020 23:01, Mark Brown пишет: >> But it's not allowed to change voltage of a dummy regulator, is it >> intentional? > Of course not, we can't know if the requested new voltage is valid - the > driver would have to have explict support for handling situations where > it's not possible to chang

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-13 Thread Dmitry Osipenko
13.11.2020 17:29, Mark Brown пишет: > On Fri, Nov 13, 2020 at 01:37:01AM +0300, Dmitry Osipenko wrote: >> 12.11.2020 23:01, Mark Brown пишет: >>>> But it's not allowed to change voltage of a dummy regulator, is it >>>> intentional? > >>> Of cour

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-13 Thread Dmitry Osipenko
13.11.2020 17:45, Ulf Hansson пишет: > On Thu, 12 Nov 2020 at 23:14, Dmitry Osipenko wrote: >> >> 12.11.2020 23:43, Thierry Reding пишет: >>>> The difference in comparison to using voltage regulator directly is >>>> minimal, basically the core-supply phan

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-13 Thread Dmitry Osipenko
13.11.2020 19:15, Mark Brown пишет: > On Fri, Nov 13, 2020 at 06:55:27PM +0300, Dmitry Osipenko wrote: >> 13.11.2020 17:29, Mark Brown пишет: > >>> It's not clear if it matters - it's more a policy decision on the part >>> of the driver about what it thi

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-15 Thread Dmitry Osipenko
13.11.2020 19:35, Thierry Reding пишет: > On Fri, Nov 13, 2020 at 01:14:45AM +0300, Dmitry Osipenko wrote: >> 12.11.2020 23:43, Thierry Reding пишет: >>>> The difference in comparison to using voltage regulator directly is >>>> minimal, basically the core-suppl

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-15 Thread Dmitry Osipenko
13.11.2020 20:28, Mark Brown пишет: > On Fri, Nov 13, 2020 at 08:13:49PM +0300, Dmitry Osipenko wrote: >> 13.11.2020 19:15, Mark Brown пишет: > >>> My point here is that the driver shouldn't be checking for a dummy >>> regulator, the driver should be checking th

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-19 Thread Dmitry Osipenko
16.11.2020 16:33, Mark Brown пишет: > On Sun, Nov 15, 2020 at 08:42:10PM +0300, Dmitry Osipenko wrote: >> 13.11.2020 20:28, Mark Brown пишет: > >>>> What should we do? > >>> As I keep saying the consumer driver should be enumerating the voltages >>>

Re: [PATCH v5 2/4] staging: media: Introduce NVIDIA Tegra video decoder driver

2020-11-21 Thread Dmitry Osipenko
22.11.2020 04:02, Ezequiel Garcia пишет: > Hi Dmitry, > ... >> +++ b/drivers/staging/media/tegra-vde/TODO >> @@ -0,0 +1,4 @@ >> +TODO: >> + - Implement V4L2 API once it gains support for stateless decoders. >> + >> +Contact: Dmitry Osipenko > &

Re: [PATCH v5 2/4] staging: media: Introduce NVIDIA Tegra video decoder driver

2020-11-23 Thread Dmitry Osipenko
23.11.2020 06:07, Ezequiel Garcia пишет: > On Sat, 21 Nov 2020 at 23:01, Dmitry Osipenko wrote: >> >> 22.11.2020 04:02, Ezequiel Garcia пишет: >>> Hi Dmitry, >>> >> ... >>>> +++ b/drivers/staging/media/tegra-vde/TODO >>>> @@ -0,0 +1,4

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-01 Thread Dmitry Osipenko
01.12.2020 16:57, Mark Brown пишет: > On Thu, 5 Nov 2020 02:43:57 +0300, Dmitry Osipenko wrote: >> Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces >> power consumption and heating of the Tegra chips. Tegra SoC has multiple >> hardware units which b

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-01 Thread Dmitry Osipenko
01.12.2020 17:34, Mark Brown пишет: > On Tue, Dec 01, 2020 at 05:17:20PM +0300, Dmitry Osipenko wrote: >> 01.12.2020 16:57, Mark Brown пишет: > >>> [1/1] regulator: Allow skipping disabled regulators in >>> regulator_check_consumers() >>> (no comm

[PATCH v2 01/48] dt-bindings: memory: tegra20: emc: Replace core regulator with power domain

2020-12-17 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra20-emc.txt| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt

[PATCH v2 00/48] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-17 Thread Dmitry Osipenko
ions, as it was discussed previously in the comments to v1. - Added new APIs, features and fixed various bugs related to voltage scaling and power management done via GENPD API. Dmitry Osipenko (48): dt-bindings: memory: tegra20: emc: Replace core regulator with power domai

[PATCH v2 02/48] dt-bindings: memory: tegra30: emc: Replace core regulator with power domain

2020-12-17 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra30-emc.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml

[PATCH v2 05/48] media: dt: bindings: tegra-vde: Document OPP and power domain properties

2020-12-17 Thread Dmitry Osipenko
Document new DVFS OPP table and power domain properties of the video decoder engine. Signed-off-by: Dmitry Osipenko --- .../devicetree/bindings/media/nvidia,tegra-vde.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/media/nvidia,tegra

[PATCH v2 03/48] dt-bindings: memory: tegra124: emc: Replace core regulator with power domain

2020-12-17 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra124-emc.yaml| 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml

[PATCH v2 07/48] dt-bindings: arm: tegra: Add binding for core power domain

2020-12-17 Thread Dmitry Osipenko
All NVIDIA Tegra SoCs have a core power domain where majority of hardware blocks reside. Add binding for the core power domain. Signed-off-by: Dmitry Osipenko --- .../arm/tegra/nvidia,tegra20-core-domain.yaml | 48 +++ 1 file changed, 48 insertions(+) create mode 100644

[PATCH v2 10/48] opp: Add dev_pm_opp_set_voltage()

2020-12-17 Thread Dmitry Osipenko
Add dev_pm_opp_set_voltage() which allows OPP table users to set voltage in accordance to a given OPP. In particular this is needed for driving voltage of a generic power domain which uses OPPs and doesn't have a clock. Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c

[PATCH v2 12/48] opp: Add dev_pm_opp_get_required_pstate()

2020-12-17 Thread Dmitry Osipenko
Add dev_pm_opp_get_required_pstate() which allows OPP users to retrieve required performance state of a given OPP. Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 22 ++ include/linux/pm_opp.h | 10 ++ 2 files changed, 32 insertions(+) diff --git a

[PATCH v2 09/48] opp: Add dev_pm_opp_sync_regulators()

2020-12-17 Thread Dmitry Osipenko
Extend OPP API with dev_pm_opp_sync_regulators() function, which syncs voltage state of regulators. Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 42 ++ include/linux/pm_opp.h | 11 +++ 2 files changed, 53 insertions(+) diff --git a

[PATCH v2 04/48] dt-bindings: host1x: Document OPP and power domain properties

2020-12-17 Thread Dmitry Osipenko
Document new DVFS OPP table and power domain properties of the Host1x bus and devices sitting on the bus. Signed-off-by: Dmitry Osipenko --- .../display/tegra/nvidia,tegra20-host1x.txt | 49 +++ 1 file changed, 49 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v2 14/48] opp: Filter out OPPs based on availability of a required-OPP

2020-12-17 Thread Dmitry Osipenko
A required OPP may not be available, and thus, all OPPs which are using this required OPP should be unavailable too. Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c

[PATCH v2 08/48] regulator: Make regulator_sync_voltage() usable by coupled regulators

2020-12-17 Thread Dmitry Osipenko
Make regulator_sync_voltage() to re-balance voltage state of a coupled regulators instead of changing the voltage directly. Signed-off-by: Dmitry Osipenko --- drivers/regulator/core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c

[PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable

2020-12-17 Thread Dmitry Osipenko
Fix adding OPP entries in a wrong (opposite) order if OPP rate is unavailable. The OPP comparison is erroneously skipped if OPP rate is missing, thus OPPs are left unsorted. Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 23 --- drivers/opp/opp.h | 2 +- 2 files

[PATCH v2 06/48] dt-bindings: clock: tegra: Document clocks sub-node

2020-12-17 Thread Dmitry Osipenko
Document "clocks" sub-node which describes Tegra SoC clocks that require a higher voltage of the core power domain in order to operate properly on a higher rates. Signed-off-by: Dmitry Osipenko --- .../bindings/clock/nvidia,tegra20-car.txt | 26 +++ .../bindings/cl

[PATCH v2 21/48] PM: domains: Add "performance" column to debug summary

2020-12-17 Thread Dmitry Osipenko
Add "performance" column to debug summary which shows performance state of all power domains and theirs devices. Signed-off-by: Dmitry Osipenko --- drivers/base/power/domain.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/base/powe

[PATCH v2 11/48] opp: Add dev_pm_opp_find_level_ceil()

2020-12-17 Thread Dmitry Osipenko
Add a ceil version of the dev_pm_opp_find_level(). It's handy to have if levels don't start from 0 in OPP table and zero usually means a minimal level. Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 49 ++ include/linux/pm_

[PATCH v2 23/48] soc/tegra: pmc: Pulse resets after removing power clamp

2020-12-17 Thread Dmitry Osipenko
ower gates are usually ungated after bootloader by default. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index fd2ba3c59178..985373ce52b1 100644 --- a/drivers/soc/tegra/p

[PATCH v2 22/48] soc/tegra: pmc: Fix imbalanced clock disabling in error code path

2020-12-17 Thread Dmitry Osipenko
The tegra_powergate_power_up() has a typo in the error code path where it will try to disable clocks twice, fix it. In practice that error never happens, so this is a minor correction. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 20/48] PM: domains: Make set_performance_state() callback optional

2020-12-17 Thread Dmitry Osipenko
Make set_performance_state() callback optional in order to remove the need from power domain drivers to implement a dummy callback. If callback isn't implemented by a GENPD driver, then the performance state is passed to the parent domain. Signed-off-by: Dmitry Osipenko --- drivers/base/

[PATCH v2 24/48] soc/tegra: pmc: Ensure that clock rates aren't too high

2020-12-17 Thread Dmitry Osipenko
Switch all clocks of a power domain to a safe rate which is suitable for all possible voltages in order to ensure that hardware constraints aren't violated when power domain state toggles. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c

[PATCH v2 27/48] soc/tegra: Add CONFIG_SOC_TEGRA_COMMON and select PM_OPP by default

2020-12-17 Thread Dmitry Osipenko
Add new Kconfig SOC_TEGRA_COMMON option which selects configuration options that are common for all Tegra SoCs. Select PM_OPP by default since from now on OPPs will be used by Tegra drivers which present on all SoC generations, like display controller driver for example. Signed-off-by: Dmitry

[PATCH v2 25/48] soc/tegra: pmc: Print out domain name when reset fails to acquire

2020-12-17 Thread Dmitry Osipenko
Print out domain name when reset fails to acquire for debugging purposes and to make formatting of GENPD errors consistent in the driver. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/tegra/pmc.c b

[PATCH v2 30/48] soc/tegra: regulators: Fix locking up when voltage-spread is out of range

2020-12-17 Thread Dmitry Osipenko
-tree. Fixes: 783807436f36 ("soc/tegra: regulators: Add regulators coupler for Tegra30") Cc: sta...@vger.kernel.org Tested-by: Peter Geis Reported-by: Peter Geis Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/regulators-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 16/48] opp: Handle missing OPP table in dev_pm_opp_xlate_performance_state()

2020-12-17 Thread Dmitry Osipenko
ns to pass performance state to the parent domain if child's domain doesn't have OPP table. The dev_pm_opp_xlate_performance_state() gets src_table=NULL if a child power domain doesn't have OPP table and in this case we should pass the performance state to the parent domain. Signe

[PATCH v2 29/48] soc/tegra: pmc: Link domains to the parent Core domain

2020-12-17 Thread Dmitry Osipenko
erformance change is applied to PMC domain. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index 4f96dc7745c4..1a659d1c06d7 100644 --- a/drivers/soc/tegra/pmc.c +++

[PATCH v2 33/48] gpu: host1x: Add host1x_channel_stop()

2020-12-17 Thread Dmitry Osipenko
: Dmitry Osipenko --- drivers/gpu/host1x/channel.c | 8 include/linux/host1x.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c index 4cd212bb570d..2a9a3a8d5931 100644 --- a/drivers/gpu/host1x/channel.c +++ b/drivers

  1   2   3   4   >