[PATCH 0/3] mmap() for vme_user and CR/CSR fix for master

Also I'm bringing up a bugfix by Martyn Welch that was published on the list, but for some reason didn't make it to the kernel. Cheers, Dmitry Dmitry Kalinkin (2): staging: vme: use image mutex for ioctl() staging: vme: mmap() support for vme_user Martyn Welch (1): vme: tsi148:

[PATCH 3/3] vme: tsi148: Master windows support USERx and CR/CSR accesses, not slaves

_images as supporting these modes and instead register master windows as supporting these modes. Signed-off-by: Martyn Welch Acked-by: Dmitry Kalinkin --- drivers/vme/bridges/vme_tsi148.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/vme/bridges/vme_

[PATCH 2/3] staging: vme: mmap() support for vme_user

We also make sure that user won't be able to reconfigure the window while it is mmap'ed. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 85 ++ drivers/vme/vme.c | 26 +++ inc

[PATCH 1/3] staging: vme: use image mutex for ioctl()

This implements more granular locking in vme_user_ioctl() by using separate locks for each devfs device. This also provides a synchronization between vme_user_read(), vme_user_write() and vme_user_ioctl(). Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices

Re: [PATCH] vme: Fix integer overflow checking in vme_check_window()

d to just U64_MAX. > > Anyway, I put one integer overflow check at the start of the function > and deleted all existing checks. > > Signed-off-by: Dan Carpenter Acked-by: Dmitry Kalinkin > > diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c > index 6a3ead42aba8..5b4c8

[PATCH 0/6] vme: DMA improvements

me_dma_attr's before vme_dma_list_exec() is done. A simple test against AVM16 board displays speeds around 45 MiB/s for A32/D32 reads for both BLT and MBLT (with MBLT being slightly faster). Dmitry Kalinkin (6): Documentation: mention vme_master_mmap() in VME API vme: tsi148: fix DMA lists l

[PATCH 1/6] Documentation: mention vme_master_mmap() in VME API

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- Documentation/vme_api.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt index ffe6e22..ca5b827 100644 --- a/Documentation/vme_api.txt +++ b/Documentation/vme_api.txt @@ -171,6

[PATCH 3/6] vme: tsi148: fix first DMA item mapping

: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index 1be4136..03b0755 100644 --- a/drivers/vme/bridges

[PATCH 5/6] staging: vme_user: refactor llseek to switch(){}

This makes vme_user_llseek ignore all minors that don't have llseek implementation. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vme/de

[PATCH 2/6] vme: tsi148: fix DMA lists longer that one item

DMA lists on tsi148 weren't processed further than the first item because of the broken logic. This regression was introduced in: ac1a4f2caf7b071 "Staging: VME: Ensure TSI148 link list descriptors..." Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/v

[PATCH 4/6] vme: stop DMA transfer on interruption

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 15 +-- drivers/vme/bridges/vme_tsi148.c | 15 +-- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges

[PATCH 6/6] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 174 - drivers/staging/vme/devices

Re: [PATCH 6/6] staging: vme_user: provide DMA functionality

On Tue, May 19, 2015 at 12:18 PM, Dan Carpenter wrote: > On Mon, May 18, 2015 at 09:56:33PM +0300, Dmitry Kalinkin wrote: >> >> + for_each_sg(sgt->sgl, sg, sg_count, i) { >> + struct vme_dma_attr *pci_attr, *vme_attr, *dest, *src; >> +

[PATCHv2 00/16] vme DMA and user space driver improvements

is to go into the kernel. Also, email http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-July/029084.html mentions that we probably can now get rid of this comment: > /* XXX We do not want to push aspace, cycle and width > * to userspace as they are > */ Dmitry

[PATCHv2 01/16] Documentation: mention vme_master_mmap() in VME API

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- Documentation/vme_api.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt index ffe6e22..ca5b827 100644 --- a/Documentation/vme_api.txt +++ b/Documentation/vme_api.txt @@ -171,6

[PATCHv2 06/16] vme: check for A64 overflow in vme_check_window()

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/vme.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 6bab2c4..1b78d27 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c @@ -199,10 +199,8 @@ static int

[PATCHv2 07/16] vme: export vme_check_window()

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/vme.c | 5 +++-- include/linux/vme.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 1b78d27..5670891 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c

[PATCHv2 11/16] staging: vme_user: remove unused counters

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ca7ea6b..ed374d9 100644 --- a

[PATCHv2 08/16] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 201 - drivers/staging/vme/devices

[PATCHv2 03/16] vme: tsi148: fix first DMA item mapping

: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index 1be4136..6562348 100644 --- a/drivers/vme/bridges

[PATCHv2 09/16] vme: ca91cx42: return error code on DMA error

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c index e9bd657..f692efc 100644 --- a/drivers/vme/bridges/vme_ca91cx42.c +++ b

[PATCHv2 04/16] vme: stop DMA transfer on interruption

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 17 ++--- drivers/vme/bridges/vme_tsi148.c | 15 +-- 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges

[PATCHv2 05/16] staging: vme_user: refactor llseek to switch(){}

This makes vme_user_llseek ignore all minors that don't have llseek implementation. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vme/de

[PATCHv2 10/16] vme: ca91cx42: fix LM_CTL address mask

Universe II datasheet defines following address space values for LM_CTL[16:18] 000=A16 001=A24 010=A32 011,100,101=Reserved 110=User1 111=User2 Mask 5<<16 is not the right one for matching [16:18], instead we should use 7<<16. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev Repo

[PATCHv2 02/16] vme: tsi148: fix DMA lists longer that one item

DMA lists on tsi148 weren't processed further than the first item because of the broken logic. This regression was introduced in: ac1a4f2caf7b071 "Staging: VME: Ensure TSI148 link list descriptors..." Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/v

[PATCHv2 15/16] vme: tsi148: depend on HAS_DMA for Kconfig

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vme/bridges/Kconfig b/drivers/vme/bridges/Kconfig index 9331064..f6d8545 100644 --- a/drivers/vme/bridges/Kconfig +++ b/drivers/vme

[PATCHv2 14/16] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 31

[PATCHv2 12/16] staging: vme_user: remove forward declarations

Reorder code so that forward declarations are not needed. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 139 ++--- 1 file changed, 60 insertions(+), 79 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCHv2 16/16] vme: provide uapi header

This separates VME related constants that are a part of both kernel and user space API into a common uapi header. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- include/linux/vme.h | 54 ++--- include/uapi/linux/Kbuild | 1 + include/uapi

[PATCHv2 13/16] staging: vme_user: remove open/release

Checking for image[minor].resource != NULL is not needed since all resources are allocated before device is created. image[minor].users accounting is deleted because it's not being used. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c

[PATCHv3 01/16] Documentation: mention vme_master_mmap() in VME API

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- Documentation/vme_api.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt index ffe6e22..ca5b827 100644 --- a/Documentation/vme_api.txt +++ b/Documentation/vme_api.txt @@ -171,6

[PATCHv3 00/16] vme DMA and user space driver improvements

is to go into the kernel. Also, email http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-July/029084.html mentions that we probably can now get rid of this comment: > /* XXX We do not want to push aspace, cycle and width > * to userspace as they are > */ v3 adres

[PATCHv3 07/16] vme: export vme_check_window()

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/vme.c | 5 +++-- include/linux/vme.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 1b78d27..5670891 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c

[PATCHv3 04/16] vme: stop DMA transfer on interruption

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 17 ++--- drivers/vme/bridges/vme_tsi148.c | 15 +-- 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges

[PATCHv3 02/16] vme: tsi148: fix DMA lists longer that one item

DMA lists on tsi148 weren't processed further than the first item because of the broken logic. This regression was introduced in: ac1a4f2caf7b071 "Staging: VME: Ensure TSI148 link list descriptors..." Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/v

[PATCHv3 10/16] vme: ca91cx42: fix LM_CTL address mask

Universe II datasheet defines following address space values for LM_CTL[16:18] 000=A16 001=A24 010=A32 011,100,101=Reserved 110=User1 111=User2 Mask 5<<16 is not the right one for matching [16:18], instead we should use 7<<16. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev Repo

[PATCHv3 06/16] vme: check for A64 overflow in vme_check_window()

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/vme.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 6bab2c4..1b78d27 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c @@ -199,10 +199,8 @@ static int

[PATCHv3 08/16] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 201 - drivers/staging/vme/devices

[PATCHv3 11/16] staging: vme_user: remove unused counters

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e8a1ca6..cc0d3df 100644 --- a

[PATCHv3 03/16] vme: tsi148: fix first DMA item mapping

: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index 1be4136..6562348 100644 --- a/drivers/vme/bridges

[PATCHv3 09/16] vme: ca91cx42: return error code on DMA error

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c index e9bd657..f692efc 100644 --- a/drivers/vme/bridges/vme_ca91cx42.c +++ b

[PATCHv3 12/16] staging: vme_user: remove forward declarations

Reorder code so that forward declarations are not needed. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 139 ++--- 1 file changed, 60 insertions(+), 79 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCHv3 05/16] staging: vme_user: refactor llseek to switch(){}

This makes vme_user_llseek ignore all minors that don't have llseek implementation. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vme/de

[PATCHv3 14/16] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 31

[PATCHv3 16/16] vme: provide uapi header

This separates VME related constants that are a part of both kernel and user space API into a common uapi header. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- include/linux/vme.h | 54 ++--- include/uapi/linux/Kbuild | 1 + include/uapi

[PATCHv3 13/16] staging: vme_user: remove open/release

Checking for image[minor].resource != NULL is not needed since all resources are allocated before device is created. image[minor].users accounting is deleted because it's not being used. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c

[PATCHv3 15/16] vme: tsi148: depend on HAS_DMA for Kconfig

Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vme/bridges/Kconfig b/drivers/vme/bridges/Kconfig index 9331064..f6d8545 100644 --- a/drivers/vme/bridges/Kconfig +++ b/drivers/vme

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

On Sun, May 31, 2015 at 6:06 AM, Greg Kroah-Hartman wrote: > On Thu, May 28, 2015 at 03:06:57PM +0300, Dmitry Kalinkin wrote: >> The first item in this submission documents previously introduced >> vme_master_mmap() call. Following, there are three fixes for the tsi148 >> dri

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 10, 2015 at 04:09:19PM +0300, Dmitry Kalinkin wrote: >> Also, there are some patches that IMO don't need any special VME >> subsystem expertise, namely: >> Documentation: mention vme_master_

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

> On 13 Jun 2015, at 05:24, Greg Kroah-Hartman > wrote: > > On Sat, Jun 13, 2015 at 05:04:28AM +0300, Dmitry Kalinkin wrote: >> On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman >> wrote: >> I thought 12 was the most harmless out of the whole set. Am I wrong?

[PATCHv4 2/4] staging: vme_user: remove open/release

Checking for image[minor].resource != NULL is not needed since all resources are allocated before device is created. image[minor].users accounting is deleted because it's not being used. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c

[PATCHv4 3/4] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 31

[PATCHv4 4/4] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 201 - drivers/staging/vme/devices

[PATCHv4 1/4] staging: vme_user: remove forward declarations

Reorder code so that forward declarations are not needed. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 139 ++--- 1 file changed, 60 insertions(+), 79 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCHv4 0/4] vme DMA and user space driver improvements

This reorders patches so that Greg can take first three, while fourth awaits maintainer's approval. Dmitry Kalinkin (4): staging: vme_user: remove forward declarations staging: vme_user: remove open/release staging: vme_user: remove buf_unalloc helper staging: vme_user: provid

[PATCH 5/9] staging: vme_user: allow large read()/write()

ned-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 67 -- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index db5f890..52cd638 100644 --- a/drivers/s

[PATCH 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index b6d81e5..db5f890 100644 --- a/drivers/staging/vme/devices

[PATCH 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 5ff44fb..285e00e 100644 --- a

[PATCH 0/9] vme_user checkpatch fixes and read()/write() rework

First four patches are fixes for various checpatch warnings. Next there is a change to drop large read()/write() stub followed by a change to rework user copy error codes. Last three changes are refactorings. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix

[PATCH 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 6f5bbc4..14f9554 100644 --- a/drivers/staging

[PATCH 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 285e00e..1f00ad7 100644 --- a/drivers/staging/vme/devices

[PATCH 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 1f00ad7..b6d81e5 100644 --- a/drivers/staging/vme

[PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 52cd638..85eb6ee 100644 --- a

[PATCH 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 28a70f4..6f5bbc4 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers

[PATCH 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 85eb6ee..28a70f4 100644 --- a/drivers/staging/vme/devices

Re: [PATCH 1/9] staging: vme_user: fix code alignment

> On 23 Jun 2015, at 16:21, Frans Klaver wrote: > > You left one in the function declarations (vme_user_write). If you mean forward declarations, they are already gone in Greg’s tree: https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/vme/devices/vme_user.c?h

Re: [PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 23 Jun 2015, at 16:51, Dan Carpenter wrote: > > On Tue, Jun 23, 2015 at 03:42:30PM +0300, Dmitry Kalinkin wrote: >> @@ -178,38 +167,24 @@ static ssize_t buffer_to_user(unsigned int minor, char >> __user *buf, >>size_t count, loff

[PATCHv2 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 9cca97a..ccf9602 100644 --- a

[PATCHv2 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers/staging/vme/devices

[PATCHv2 0/9] vme_user checkpatch fixes and read()/write() rework

AL instead of EFAULT in a couple of places. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix blank lines staging: vme_user: fix NULL comparison style staging: vme_user: fix kmalloc style staging: vme_user: allow large read()/write() staging: vme_us

[PATCHv2 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644 --- a/drivers/staging/vme

[PATCHv2 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index cf47649..de9eda5 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers

[PATCHv2 5/9] staging: vme_user: allow large read()/write()

ned-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 67 -- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..101f7b9 100644 --- a/drivers/s

[PATCHv2 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers/staging/vme/devices

[PATCHv2 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 070e63f..cf47649 100644 --- a/drivers/staging/vme/devices

[PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 101f7b9..070e63f 100644 --- a

[PATCHv2 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index de9eda5..efed9c7 100644 --- a/drivers/staging

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 25 Jun 2015, at 14:27, Sudip Mukherjee wrote: > > On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: >> Signed-off-by: Dmitry Kalinkin >> --- >> drivers/staging/vme/devices/vme_user.c | 47 >> -- >&g

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 25 Jun 2015, at 15:05, Dmitry Kalinkin wrote: > > >> On 25 Jun 2015, at 14:27, Sudip Mukherjee wrote: >> >> On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: >>> Signed-off-by: Dmitry Kalinkin >>> --- &g

[PATCHv3 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ef876a4..947a38e 100644 --- a/drivers/staging/vme/devices

[PATCHv3 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644 --- a/drivers/staging/vme

[PATCHv3 0/9] vme_user checkpatch fixes and read()/write() rework

AL instead of EFAULT in a couple of places. v3 fixes ("allow large read()/write()") to also remove the comment right above resource_to_user() v3 also renames ("vme_user: return -EFAULT on __copy_*_user errors") to ("switch to returning -EFAULT on __copy_*_user error

[PATCHv3 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 7ca943c..b3e3c2d 100644 --- a/drivers/staging

[PATCHv3 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 9cca97a..ccf9602 100644 --- a

[PATCHv3 5/9] staging: vme_user: allow large read()/write()

ned-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 73 +++--- 1 file changed, 24 insertions(+), 49 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..a2345db 100644 --- a/drivers/s

[PATCHv3 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 947a38e..7ca943c 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers

[PATCHv3 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers/staging/vme/devices

[PATCHv3 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers/staging/vme/devices

[PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index a2345db..ef876a4 100644 --- a

[PATCH 0/3] VME bus error handling overhaul

ep in this direction would be to add error handling support to ca91cx42 and make it unconditional for tsi148. It also makes much sense to add synchronization to error-related list operations (spinlocks, rcu). Dmitry Kalinkin (3): vme: move tsi148 error handling into VME subsystem vme: include ad

[PATCH 1/3] vme: move tsi148 error handling into VME subsystem

in a rare case when err_chk=1 and kmalloc fails. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 93 +++- drivers/vme/vme.c| 86 + drivers/vme/vme_bridge.h

[PATCH 3/3] vme: change bus error handling scheme

them. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 3 +- drivers/vme/bridges/vme_tsi148.c | 83 +- drivers/vme/vme.c | 92 ++ drivers/vme/vme_bridge.h

[PATCH 2/3] vme: include address space in error filtering

Also changes vme_bus_error_handler to take generic address modifier code instead of raw contents of a device-specific attribute register. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 4 ++- drivers/vme/vme.c| 61

Re: [PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch wrote: > On 26/06/15 21:39, Dmitry Kalinkin wrote: >> >> Signed-off-by: Dmitry Kalinkin >> --- >> drivers/staging/vme/devices/vme_user.c | 47 >> -- >> 1 file changed, 11 in

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote: > > Sorry about the *really* late reply, loads of emails some how missed my > periodic search of the mailing list. > > I'm happy with the addition of DMA, just not sure whether it's worth adding > an extra device file just to handle DMA. Could th

Re: [PATCH 0/3] VME bus error handling overhaul

h such errors to the userspace in a more direct way. Not sure how, though. Cheers, Dmitry > > > On 02/07/15 15:11, Dmitry Kalinkin wrote: >> This moves tsi148 error handling into VME subsystem so it can be shared with >> the other bridge driver. Then there is a change to c

[PATCH] vme: print unhandled VME access errors

This will enable error messages for accesses done through mmap. Signed-off-by: Dmitry Kalinkin --- This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset. --- drivers/vme/vme.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/vme/vme.c b/drivers/vme/v

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 5:48 PM, Martyn Welch wrote: > > > On 06/07/15 14:50, Dmitry Kalinkin wrote: >> >> On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote: >>> >>> >>> Sorry about the *really* late reply, loads of emails some how missed my >

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

Hi Alessio, [Sorry for double post] > On 07 Jul 2015, at 10:08, Alessio Igor Bogani > wrote: > > Hi Dmitry, > > On 6 July 2015 at 19:24, Dmitry Kalinkin wrote: > [...] > I'm not a VME expert, but it seems that VME windows are a quiet limited > resource &

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

> On 07 Jul 2015, at 15:51, Alessio Igor Bogani > wrote: > >> Current VME stack links windows not to the boards, but to device drivers. >> Driver >> could potentially minimise window usage within it’s scope (any sort of >> window >> reusing, like mapping whole A16 once to be used with all boar

  1   2   >