As per eudyptula challenge task 10 I had to fix coding styles. Thus I
used checkpatch.pl script and fixed a chunk of warnings and few errors.
Signed-off-by: Dhiraj Sharma
---
.../staging/media/usbvision/usbvision-video.c | 91 +++
1 file changed, 52 insertions(+), 39 deletions
Jul 28, 2020 at 08:00:04PM +0530, Dhiraj Sharma wrote:
> > As per eudyptula challenge task 10 I had to fix coding styles.
>
> That is not needed in a changelog text.
>
> > Thus I
> > used checkpatch.pl script and fixed a chunk of warnings and few errors.
>
> Neither is
Sorry I had committed a mistake by not replying to all.
> Hi Dhiraj,
>
> On 28/07/2020 16:30, Dhiraj Sharma wrote:
> > As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> > used checkpatch.pl script and fixed a chunk of warnings and few errors.
>
&
> As the bot said, only do one type of thing per patch, and "fix all
> checkpatch errors/warnings" is not one type of thing.
So should I send a fresh patch with minimal fixes? instead of replying
to this mail with [PATCH 01]
___
devel mailing list
de...@
Alright sorry, I will ignore this patch and will commit the new patch
in another file.
On Tue, Jul 28, 2020 at 10:28 PM Greg KH wrote:
>
> On Tue, Jul 28, 2020 at 10:13:22PM +0530, Dhiraj Sharma wrote:
> > > As the bot said, only do one type of thing per patch, and "fix
I ran checkpatch.pl script which reported a warning to use const keyword
on line 370.Therefore I made this change.
Signed-off-by: Dhiraj Sharma
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers
Inside function ql_get_dump comment statement had a repition of word
"to" which I removed and checkpatch.pl ouputs zero error or warnings
now.
Signed-off-by: Dhiraj Sharma
---
drivers/staging/qlge/qlge_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
anges now.
I will not commit such foolish mistakes now.
Thank you
Dhiraj Sharma
On Tue, Jul 28, 2020 at 11:55 PM Greg KH wrote:
>
> On Tue, Jul 28, 2020 at 11:29:35PM +0530, Dhiraj Sharma wrote:
> > I ran checkpatch.pl script which reported a warning to use const keyword
> >
Hello,
I know that I should ask for reviews etc after a week but the change
is for my eudyptula task and until it doesn't get merged little
penguin will not pass the task for me so please look at it.
Thank You
Dhiraj Sharma
On Tue, Jul 28, 2020 at 11:56 PM Dhiraj Sharma
wrote:
>
7;t you think?
>
> There are no such things as deadlines when it comes to upstream kernel
> development, sorry.
>
Alright, I will wait and hope it gets accepted before 1st August or
else I have patience.
Thank You
Dhiraj Sharma
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
10 matches
Mail list logo
