Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread David Miller
From: Haiyang Zhang Date: Mon, 27 Jan 2014 15:03:42 -0800 > This will allow us to use bigger receive buffer, and prevent allocation > failure > due to fragmented memory. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

Re: [PATCH 0/2] Drivers: net: hyperv: Cleanup the recive path

2014-02-01 Thread David Miller
From: "K. Y. Srinivasan" Date: Fri, 31 Jan 2014 08:24:38 -0800 > Some minor cleanup of the receive path. Get rid of unnecessary > indirection as well as unnecessary re-establishment of state. It is not appropriate to submit cleanups at this time. Please wait until the net-next tree opens back u

Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread David Miller
From: KY Srinivasan Date: Wed, 30 Apr 2014 14:17:04 + > Please let me know if there is some other issue you want addressed in this > patch. If the patch isn't in patchwork, I'm not going to apply it and you need to simply resubmit it. ___ devel ma

Re: [PATCH V2 net-next 1/1] hyperv: Properly handle checksum offload

2014-04-30 Thread David Miller
n this version of the patch I have addressed comments from > David Miller. > > This patch fixes a bug that is exposed in gateway scenarios. > > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang It does not make any sense to submit a patch for net-next and a

Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread David Miller
st supports > a second mechanism for sending packets that is "copy based". We implement that > mechanism in this patch. > > In this version of the patch I have addressed a comment from David Miller. > > With this patch (and all of the other offload and VRSS patches), we ar

Re: [PATCH V2 net 1/1] hyperv: Properly handle checksum offload

2014-04-30 Thread David Miller
n this version of the patch I have addressed comments from > David Miller. > > This patch fixes a bug that is exposed in gateway scenarios. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang Applied and queued up for -stable, t hanks. _

Re: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-02 Thread David Miller
From: Haiyang Zhang Date: Fri, 2 May 2014 14:42:06 + > real_num_rx_queues is defined in "include/linux/netdevice.h": > It requires CONFIG_SYSFS flag, which is enabled by default, but not set in > your config file. > > Could you use default config and add hyperv drivers, then try again? You

Re: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread David Miller
From: Haiyang Zhang Date: Thu, 8 May 2014 13:41:33 -0700 > +static inline void netvsc_record_rx_queue(struct sk_buff *skb, > + struct hv_netvsc_packet *packet, > + struct net_device *ndev) > +{ > +#ifdef CONFIG_SYSFS > +

Re: [PATCH net-next,v3] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-11 Thread David Miller
From: Haiyang Zhang Date: Thu, 8 May 2014 15:14:10 -0700 > This change ensures the driver can be built successfully without the > CONFIG_SYSFS flag. > MS-TFS: 182270 > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe Date: Sun, 11 May 2014 00:12:32 + > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Mostly done via coccinelle script: > @@ > struct ethtool_ops *ops; > struct net_device *dev; > @@ > - SET_ET

Re: [PATCH net-next] Add hash value into RNDIS Per-packet info

2014-05-23 Thread David Miller
From: Haiyang Zhang Date: Wed, 21 May 2014 12:55:39 -0700 > It passes the hash value as the RNDIS Per-packet info to the Hyper-V host, > so that the send completion notices can be spread across multiple channels. > MS-TFS: 140273 > > Signed-off-by: Haiyang Zhang Applied, but please craft your

Re: [PATCH net-next] hyper-v: make uuid_le const

2014-06-03 Thread David Miller
From: Stephen Hemminger Date: Tue, 3 Jun 2014 08:38:15 -0700 > The uuid structure could be managed as a const in several places. > > Signed-off-by: Stephen Hemminger Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverde

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread David Miller
From: Haiyang Zhang Date: Thu, 19 Jun 2014 18:34:36 -0700 > The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host > sleep or hibernation. We refresh network at this time. > MS-TFS: 135162 > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread David Miller
From: Olaf Hering Date: Mon, 23 Jun 2014 15:17:23 +0200 > On Mon, Jun 23, Haiyang Zhang wrote: > >> > I think its reasonable to expect guest config changes on this new kind >> > of host. Would a link-down/link-up event work? I'm sure it will, there >> > is enough code floating around in the gues

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread David Miller
From: Haiyang Zhang Date: Mon, 23 Jun 2014 16:09:59 + > So, what's the equivalent or similar command to "network restart" on SLES12? > Could > you update the command line for the usermodehelper when porting this patch to > SLES > 12? No, you are not going to keep the usermodehelper invocat

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread David Miller
From: Greg KH Date: Mon, 23 Jun 2014 12:29:11 -0400 > Given that this change will fail on all future distro releases, and > almost all of the community distros today, I don't see how this is > acceptable at all. Nor would it be any better if you switch to a > systemd command line script as well.

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread David Miller
From: Joe Perches Date: Mon, 23 Jun 2014 06:41:28 -0700 > Adding the helper reduces object code size as well as overall > source size line count. > > It's also consistent with all the various zalloc mechanisms > in the kernel. > > Done with a simple cocci script and some typing. For networking

Re: [patch -next] hyperv: NULL dereference on error

2014-09-05 Thread David Miller
From: Dan Carpenter Date: Thu, 4 Sep 2014 14:11:23 +0300 > We try to call free_netvsc_device(net_device) when "net_device" is NULL. > It leads to an Oops. > > Fixes: f90251c8a6d0 ('hyperv: Increase the buffer length for > netvsc_channel_cb()') > Signed-off-by: Dan Carpenter Applied, thanks Da

Re: [PATCH 1/1] Drivers: net-next: hyperv: Fix a bug in netvsc_start_xmit()

2014-09-28 Thread David Miller
From: "K. Y. Srinivasan" Date: Sun, 28 Sep 2014 19:49:51 -0700 > After the packet is successfully sent, we should not touch the skb as it may > have been freed. This patch is based on the work done by > Long Li . > > Signed-off-by: K. Y. Srinivasan > Tested-by: Long Li > Cc: You hyperv guys

Re: [PATCH net 1/1 V2] hyperv: Fix a bug in netvsc_start_xmit()

2014-09-29 Thread David Miller
From: "K. Y. Srinivasan" Date: Sun, 28 Sep 2014 22:16:43 -0700 > After the packet is successfully sent, we should not touch the skb > as it may have been freed. This patch is based on the work done by > Long Li . > > In this version of the patch I have fixed issues pointed out by David. > Davi

Re: [PATCH net 1/1] hyperv: Fix a bug in netvsc_send()

2014-10-05 Thread David Miller
From: "K. Y. Srinivasan" Date: Sun, 5 Oct 2014 10:42:51 -0700 > After the packet is successfully sent, we should not touch the packet > as it may have been freed. This patch is based on the work done by > Long Li . > > David, please queue this up for stable. > > Signed-off-by: K. Y. Srinivasa

Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread David Miller
From: Haiyang Zhang Date: Tue, 14 Oct 2014 15:16:28 -0700 > In case that the IP header has optional field at the end, this patch will > get the port numbers after that field, and compute the hash. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Instead of adding hack after ha

Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread David Miller
From: Haiyang Zhang Date: Tue, 14 Oct 2014 20:05:17 + > In case that the IP header has optional field at the end, this patch will > get the port numbers after that field, and compute the hash. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan This isn't even close to what I

Re: [PATCH net-next,v3] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-17 Thread David Miller
From: Haiyang Zhang Date: Thu, 16 Oct 2014 14:47:58 -0700 > In case that the IP header has optional field at the end, this patch will > get the port numbers after that field, and compute the hash. The general > parser skb_flow_dissect() is used here. > > Signed-off-by: Haiyang Zhang > Reviewed-

Re: [PATCH net] hyperv: Fix the total_data_buflen in send path

2014-10-22 Thread David Miller
From: Haiyang Zhang Date: Wed, 22 Oct 2014 13:47:18 -0700 > total_data_buflen is used by netvsc_send() to decide if a packet can be put > into send buffer. It should also include the size of RNDIS message before the > Ethernet frame. Otherwise, a messge with total size bigger than > send_section

Re: [PATCH net-next] hyperv: Add IPv6 into the hash computation for vRSS

2014-10-30 Thread David Miller
From: Haiyang Zhang Date: Thu, 30 Oct 2014 14:07:17 -0700 > This will allow the workload spreading via vRSS for IPv6. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http:

Re: [PATCH v3] hyperv: Add netpoll support

2014-07-09 Thread David Miller
From: Richard Weinberger Date: Wed, 9 Jul 2014 16:23:59 +0200 > In order to have at least a netconsole to debug kernel issues on > Windows Azure this patch implements netpoll support. > Sending packets is easy, netvsc_start_xmit() does already everything > needed. > > Signed-off-by: Richard Wei

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine Date: Fri, 18 Jul 2014 17:26:47 +0200 > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. > > A simplified version of the semantic patch that makes this change is as >

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread David Miller
From: Olaf Hering Date: Mon, 21 Jul 2014 11:18:51 +0200 > On Mon, Jul 21, Richard Weinberger wrote: > >> My concern is that 10 seconds is maybe not a the right choice. >> (As we cannot know all implementations) > > Until someone reports an issue with it, 10 is fine. Just like 20 or 666. Wrong,

Re: [PATCH] hyperv: Fix error return code in netvsc_init_buf()

2014-07-23 Thread David Miller
From: weiyj...@163.com Date: Wed, 23 Jul 2014 09:00:35 +0800 > From: Wei Yongjun > > Fix to return -ENOMEM from the kalloc error handling > case instead of 0. > > Signed-off-by: Wei Yongjun Applied, thank you. ___ devel mailing list de...@linuxdrive

Re: [PATCH 1/1] Drivers: net-next: hyperv

2014-07-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 30 Jul 2014 18:20:16 -0700 > For forwarding scenarios, it will be useful to allocate larger > sendbuf. Make the necessary adjustments to permit this. > > Signed-off-by: K. Y. Srinivasan Please submit this with a proper Subject line, something like "[PATCH 1/

Re: [PATCH 1/1] Drivers: net-next: hyperv: Increase the size of the sendbuf region

2014-07-31 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 30 Jul 2014 18:35:49 -0700 > For forwarding scenarios, it will be useful to allocate larger > sendbuf. Make the necessary adjustments to permit this. > > Signed-off-by: K. Y. Srinivasan This needs more information. You're increasing the size by 16 times, 1M

Re: [PATCH 1/1] Drivers: net-next: hyperv: Increase the size of the sendbuf region

2014-08-01 Thread David Miller
Don't explain things to me in this thread. Instead, tell the whole world and everyone who would ever see this commit, in the commit log message. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo

Re: [PATCH 1/1 V2] Drivers: net-next: hyperv: Increase the size of the sendbuf region

2014-08-04 Thread David Miller
From: "K. Y. Srinivasan" Date: Sat, 2 Aug 2014 10:42:02 -0700 > Intel did some benchmarking on our network throughput when Linux on Hyper-V > is as used as a gateway. This fix gave us almost a 1 Gbps additional > throughput > on about 5Gbps base throughput we hadi, prior to increasing the sendb

Re: [PATCH net-next] hyperv: Increase the buffer length for netvsc_channel_cb()

2014-08-04 Thread David Miller
From: Haiyang Zhang Date: Mon, 4 Aug 2014 12:33:45 -0700 > When the buffer is too small for a packet from VMBus, a bigger buffer will be > allocated in netvsc_channel_cb() and retry reading the packet from VMBus. > Increasing this buffer size will reduce the retry overhead. > > Signed-off-by: H

Re: [PATCH net-next] hyperv: Increase the buffer length for netvsc_channel_cb()

2014-08-05 Thread David Miller
From: Haiyang Zhang Date: Fri, 1 Aug 2014 15:55:30 + > When the buffer is too small for a packet from VMBus, a bigger buffer will be > allocated in netvsc_channel_cb() and retry reading the packet from VMBus. > Increasing this buffer size will reduce the retry overhead. > > Signed-off-by: H

Re: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2

2014-08-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 6 Aug 2014 11:11:00 -0700 > WS2008R2 is a supported platform and it turns out that the maximum sendbuf > size that ws2008R2 can support is only 15MB. Make the necessary > adjustment. > > Signed-off-by: K. Y. Srinivasan Applied, thanks. _

Re: [PATCH net-next,v2] hyperv: Increase the buffer length for netvsc_channel_cb()

2014-08-14 Thread David Miller
From: Haiyang Zhang Date: Wed, 13 Aug 2014 18:03:44 + > When the buffer is too small for a packet from VMBus, a bigger buffer will be > allocated in netvsc_channel_cb() and retry reading the packet from VMBus. > Increasing this buffer size will reduce the retry overhead. > > Signed-off-by: H

Re: [PATCH net-next] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-08-21 Thread David Miller
From: Haiyang Zhang Date: Tue, 19 Aug 2014 20:53:55 + > @@ -200,12 +202,18 @@ static bool netvsc_set_hash(u32 *hash, struct sk_buff > *skb) > iphdr = ip_hdr(skb); > > if (iphdr->version == 4) { > - if (iphdr->protocol == IPPROTO_TCP) > + data = (u8 *)&ip

Re: [PATCH net-next,v3] hyperv: Increase the buffer length for netvsc_channel_cb()

2014-08-22 Thread David Miller
From: Haiyang Zhang Date: Fri, 15 Aug 2014 19:18:19 + > When the buffer is too small for a packet from VMBus, a bigger buffer will be > allocated in netvsc_channel_cb() and retry reading the packet from VMBus. > Increasing this buffer size will reduce the retry overhead. > > Signed-off-by: H

Re: [PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user()

2017-12-20 Thread David Miller
From: Greg Kroah-Hartman Date: Wed, 20 Dec 2017 08:13:55 +0100 > On Tue, Dec 19, 2017 at 09:14:10PM +0200, Andy Shevchenko wrote: >> Some drivers are getting MAC from user space. Make a helper for them. >> >> Signed-off-by: Andy Shevchenko >> --- >> include/linux/kernel.h | 1 + >> lib/net_ut

Re: [PATCH net-next] hv_netvsc: Use the num_online_cpus() for channel limit

2018-01-22 Thread David Miller
From: Haiyang Zhang Date: Fri, 19 Jan 2018 13:26:43 -0700 > From: Haiyang Zhang > > Since we no longer localize channel/CPU affiliation within one NUMA > node, num_online_cpus() is used as the number of channel cap, instead of > the number of processors in a NUMA node. > > This patch allows a

Re: [PATCH PATCH net v2 0/9] hv_netvsc: minor fixes

2018-03-04 Thread David Miller
From: Stephen Hemminger Date: Fri, 2 Mar 2018 13:49:00 -0800 > These are improvements to netvsc driver. They aren't functionality > changes so not targeting net-next; and they are not show stopper > bugs that need to go to stable either. > > v2 >- drop the irq flags patch, defer it to net-n

Re: [PATCH PATCH net v2 0/4] hv_netvsc: fix multicast flags and sync

2018-03-08 Thread David Miller
From: Stephen Hemminger Date: Wed, 7 Mar 2018 13:49:08 -0800 > This set of patches deals with the handling of multicast flags > and addresses in transparent VF mode. The recent set of patches > (in linux-net) had a couple of bugs. Series applied, thanks Stephen.

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread David Miller
From: Mohammed Gamal Date: Fri, 9 Mar 2018 12:22:22 +0100 > Commit 009f766 intended to filter multicast/broadcast, however > it did cause DHCP timeouts. A closer look showed that the filters > were not set properly causing this issue. > > Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

2018-03-16 Thread David Miller
From: Mohammed Gamal Date: Tue, 13 Mar 2018 20:06:50 +0100 > Dring high network traffic changes to network interface parameters > such as number of channels or MTU can cause a kernel panic with a NULL > pointer dereference. This is due to netvsc_device_remove() being > called and deallocating the

Re: [PATCH net-next 0/2] hv_netvsc: minor enhancements

2018-03-17 Thread David Miller
From: Stephen Hemminger Date: Fri, 16 Mar 2018 15:44:26 -0700 > A couple of small things for net-next Series applied, thanks Stephen. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev

Re: [PATCH PATCH net 0/4] hv_netvsc: fix races during shutdown and changes

2018-03-22 Thread David Miller
From: Stephen Hemminger Date: Tue, 20 Mar 2018 15:03:01 -0700 > This set of patches fixes issues identified by Vitaly Kuznetsov and > Mohammed Gamal related to state changes in Hyper-v network driver. > > A lot of the issues are because setting up the netvsc device requires > a second step (in w

Re: [PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

2018-03-25 Thread David Miller
From: Haiyang Zhang Date: Thu, 22 Mar 2018 12:01:12 -0700 > Fix the status code returned to the host. Also add range > check for rx packet offset and length. Series applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverde

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

2018-03-26 Thread David Miller
From: Joe Perches Date: Fri, 23 Mar 2018 15:54:39 -0700 > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe Perches

Re: [PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

2018-03-31 Thread David Miller
From: Haiyang Zhang Date: Fri, 30 Mar 2018 13:57:59 -0700 > From: Haiyang Zhang > > The variables, msg and data, have the same value. This patch removes > the extra one. > > Signed-off-by: Haiyang Zhang Applied. ___ devel mailing list de...@linuxdr

Re: [PATCH net] hyperv: Fix the NETIF_F_SG flag setting in netvsc

2013-07-16 Thread David Miller
From: Haiyang Zhang Date: Tue, 16 Jul 2013 23:01:20 -0700 > SG mode is not currently supported by netvsc, so remove this flag for now. > Otherwise, it will be unconditionally enabled by commit ec5f0615642 > "Kill link between CSUM and SG features" > Previously, the SG feature is disabled beca

Re: [PATCH net] hyperv: Fix the NETIF_F_SG flag setting in netvsc

2013-07-17 Thread David Miller
From: KY Srinivasan Date: Wed, 17 Jul 2013 11:40:41 + > > >> -Original Message- >> From: Haiyang Zhang [mailto:haiya...@microsoft.com] >> Sent: Wednesday, July 17, 2013 2:01 AM >> To: da...@davemloft.net; net...@vger.kernel.org >> Cc: Haiyang Zhang; KY Srinivasan; o...@aepfle.de; ja

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-08-31 Thread David Miller
From: Bjørn Mork Date: Fri, 30 Aug 2013 18:08:43 +0200 > Copying the dev_addr from a parent device is an operation > common to a number of drivers. The addr_assign_type should > be updated accordingly, either by reusing the value from > the source device or explicitly indicating that the address

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-09-03 Thread David Miller
From: Bjørn Mork Date: Tue, 03 Sep 2013 09:38:10 +0200 > But it doesn't look like it ended up in net-next? Or am I missing > something (again)? I forgot to push it out from my workstation before going away for the holiday weekend, this has now been fixed :-)

<    1   2   3   4