Re: [PATCH] staging: octeon-ethernet: drop multiple NAPI instances

2014-11-07 Thread David Daney
ay decrease performance. David Daney Tested on EdgeRouter Lite. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 109 +++ drivers/staging/octeon/ethernet.c| 6 -- drivers/staging/octeon/octeon-ethernet.h | 1 - 3 files changed

Re: [PATCH] staging: octeon-ethernet: drop multiple NAPI instances

2014-11-07 Thread David Daney
On 11/07/2014 02:32 PM, Aaro Koskinen wrote: Hi, On Fri, Nov 07, 2014 at 01:17:23PM -0800, David Daney wrote: On 11/07/2014 12:44 PM, Aaro Koskinen wrote: Octeon Ethernet driver is currently trying to wake up multiple CPU cores for parallel NAPI processing when needed, to cope with the fact

[PATCH v2 0/8] Cavium OCTEON-III network driver.

2017-11-08 Thread David Daney
dt-bindings: Add Cavium Octeon Common Ethernet Interface. MIPS: Octeon: Enable LMTDMA/LMTST operations. MIPS: Octeon: Add a global resource manager. MIPS: Octeon: Add Free Pointer Unit (FPA) support. netdev: octeon-ethernet: Add Cavium Octeon III support. David Daney (3): MIPS: O

[PATCH v2 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-08 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc

[PATCH v2 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-08 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insertions(+) create mode

[PATCH v2 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-08 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25

[PATCH v2 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-08 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

[PATCH v2 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-08 Thread David Daney
Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/Kconfig | 8 + arch/mips/cavium-octeon/Makefile | 1 + arch/mips/cavium-octeon/octeon-fpa3.c | 364 ++ arch/mips/include/asm/octeon/octeon.h | 1

[PATCH v2 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-08 Thread David Daney
and then return a variable length (up to 128 bytes) response from the IOI device. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/setup.c | 6 ++ arch/mips/include/asm/octeon/octeon.h | 12 ++-- 2 files changed

[PATCH v2 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-08 Thread David Daney
additional lines, defaults to zero. Signed-off-by: David Daney Signed-off-by: Carlos Munoz --- arch/mips/cavium-octeon/Kconfig| 27 arch/mips/cavium-octeon/setup.c| 16 ++-- .../asm/mach-cavium-octeon/kernel-entry-init.h | 20

Re: [PATCH v2 0/8] Cavium OCTEON-III network driver.

2017-11-09 Thread David Daney
I need to send v3. With this v2 set, there is a small bug in the RX initialization that causes failure on little-endian kernels. David. On 11/08/2017 04:51 PM, David Daney wrote: We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is

[PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-09 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insertions(+) create mode

[PATCH v3 0/8] Cavium OCTEON-III network driver.

2017-11-09 Thread David Daney
pport. netdev: octeon-ethernet: Add Cavium Octeon III support. David Daney (3): MIPS: Octeon: Automatically provision CVMSEG space. staging: octeon: Remove USE_ASYNC_IOBDMA macro. MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* .../devicetree/bindings/net/cavium-bg

[PATCH v3 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-09 Thread David Daney
and then return a variable length (up to 128 bytes) response from the IOI device. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/setup.c | 6 ++ arch/mips/include/asm/octeon/octeon.h | 12 ++-- 2 files changed

[PATCH v3 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-09 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

[PATCH v3 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-09 Thread David Daney
Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/Kconfig | 8 + arch/mips/cavium-octeon/Makefile | 1 + arch/mips/cavium-octeon/octeon-fpa3.c | 364 ++ arch/mips/include/asm/octeon/octeon.h | 1

[PATCH v3 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-09 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc

[PATCH v3 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-09 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25

[PATCH v3 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-09 Thread David Daney
additional lines, defaults to zero. Signed-off-by: David Daney Signed-off-by: Carlos Munoz --- arch/mips/cavium-octeon/Kconfig| 27 arch/mips/cavium-octeon/setup.c| 16 ++-- .../asm/mach-cavium-octeon/kernel-entry-init.h | 20

Re: [PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-15 Thread David Daney
On 11/15/2017 11:18 AM, Rob Herring wrote: On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree

[PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-28 Thread David Daney
ernet Interface. MIPS: Octeon: Enable LMTDMA/LMTST operations. MIPS: Octeon: Add a global resource manager. MIPS: Octeon: Add Free Pointer Unit (FPA) support. netdev: octeon-ethernet: Add Cavium Octeon III support. David Daney (3): MIPS: Octeon: Automatically provision CVMSEG space. st

[PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-28 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

[PATCH v4 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-28 Thread David Daney
additional lines, defaults to zero. Signed-off-by: David Daney Signed-off-by: Carlos Munoz --- arch/mips/cavium-octeon/Kconfig| 27 arch/mips/cavium-octeon/setup.c| 16 ++-- .../asm/mach-cavium-octeon/kernel-entry-init.h | 20

[PATCH v4 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-28 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25

[PATCH v4 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-28 Thread David Daney
Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/Kconfig | 8 + arch/mips/cavium-octeon/Makefile | 1 + arch/mips/cavium-octeon/octeon-fpa3.c | 364 ++ arch/mips/include/asm/octeon/octeon.h | 1

[PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-28 Thread David Daney
and then return a variable length (up to 128 bytes) response from the IOI device. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/setup.c | 6 ++ arch/mips/include/asm/octeon/octeon.h | 12 ++-- 2 files changed

[PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61

[PATCH v4 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-28 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..e9239ff3cf05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
On 11/28/2017 06:01 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread David Daney
On 11/29/2017 08:07 AM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: From: Carlos Munoz The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O hardware that is significantly different from

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread David Daney
On 11/29/2017 02:56 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote: +static int bgx_probe(struct platform_device *pdev) +{ + struct mac_platform_data platform_data; + const __be32 *reg; + u32 port; + u64 addr; + struct

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread David Daney
On 11/30/2017 01:36 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread David Daney
On 11/30/2017 02:56 PM, James Hogan wrote: On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote: On 11/30/2017 01:36 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-30 Thread David Daney
On 11/30/2017 02:53 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote: From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: Carlos, On Thu, Nov 30, 2017 at 11:53 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote: From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +// SPDX-License-Identifier: GPL-2.0

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 12/01/2017 12:41 PM, Philippe Ombredanne wrote: David, On Fri, Dec 1, 2017 at 9:01 PM, David Daney wrote: On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote

Re: [PATCH] staging: speakup: Comparison to NULL could be written

2017-03-01 Thread David Daney
On 03/01/2017 11:21 AM, Arushi Singhal wrote: Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup/kobjects.c | 2 +- driv

Re: [PATCH] Staging: octeon-usb: fixed a macro coding style issue

2014-04-25 Thread David Daney
On 04/25/2014 07:21 AM, Greg KH wrote: On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote: Fixed a coding style error, macros with complex values should be enclosed in parentheses. Signed-off-by: Nicolas Del Piano --- drivers/staging/octeon-usb/octeon-hcd.c |2 +- 1 file

Re: [PATCH] staging: octeon: use atomic_long_t

2016-02-18 Thread David Daney
On 02/18/2016 02:20 PM, Aaro Koskinen wrote: Use atomic_long_t, so that we can avoid some 32 vs. 64-bit ifdeffery. Signed-off-by: Aaro Koskinen OCTEON doesn't even support a 32-bit kernel. This is really old legacy B.S. that should be removed... Acked-by: David Daney --- dr

Re: [PATCH] staging: octeon: use atomic_long_t

2016-02-19 Thread David Daney
ry. There is still the possibility of whatever is reading the statistics racing with the update, but perhaps that doesn't matter. David Daney thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdr

Re: [PATCH v2] staging: octeon: drop atomic usage from rx counters

2016-02-19 Thread David Daney
-by: David Daney --- Replaces this patch: http://marc.info/?t=14558340838&r=1&w=2 drivers/staging/octeon/ethernet-rx.c | 23 +++ drivers/staging/octeon/ethernet.c| 13 + 2 files changed, 4 insertions(+), 32 d

Re: [PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

2016-07-14 Thread David Daney
On 07/14/2016 10:06 AM, Javier Martinez Canillas wrote: The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Signed-off-by: Javier Martinez Canillas Acked-by: David Daney --- drivers/staging

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

2016-08-25 Thread David Daney
built-in and module enable details. Signed-off-by: Javier Martinez Canillas Acked-by: David Daney --- Changes since first post: - Added David Daney Acked-by tag. - Rebased on top of latest master. You changed something about the patch. In this case the Subject is not "RESEND", but

Re: Improving OCTEON II 10G Ethernet performance

2016-08-25 Thread David Daney
On 08/25/2016 11:22 AM, Aaro Koskinen wrote: Hi, On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote: Ideally we would configure the packet classifiers on the RX side to create multiple RX queues based on a hash of the TCP 5-tuple, and handle each queue with a single NAPI instance

Re: Improving OCTEON II 10G Ethernet performance

2016-08-25 Thread David Daney
On 08/24/2016 06:29 PM, Ed Swierk wrote: I'm trying to migrate from the Octeon SDK to a vanilla Linux 4.4 kernel for a Cavium OCTEON II (CN6880) board running in 64-bit little-endian mode. So far I've gotten most of the hardware features I need working, including XAUI/RXAUI, USB, boot bus and I2C

Re: Improving OCTEON II 10G Ethernet performance

2016-08-25 Thread David Daney
On 08/25/2016 02:18 PM, Aaro Koskinen wrote: Hi, On Thu, Aug 25, 2016 at 01:11:45PM -0700, David Daney wrote: On 08/25/2016 11:22 AM, Aaro Koskinen wrote: On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote: Ideally we would configure the packet classifiers on the RX side to create

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread David Daney
On 08/31/2016 08:06 AM, Aaro Koskinen wrote: Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: This series implements multiple RX group support that should improve the networking performance on multi-core OCTEONs. Basically w

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-14 Thread David Daney
I can remove them from the patch. They are valid, and I have seen no good reason presented to change them. If you want to churn up the code with white space changes, I cannot prevent it, but at least accurately describe what you are doing, and make sure you don't break the driver. David D

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-14 Thread David Daney
nings. This is not true. On Oct 14, 2015 9:17 PM, "David Daney" mailto:dda...@caviumnetworks.com>> wrote: On 10/14/2015 07:06 AM, Sakshi Bansal wrote: Fixed allignment issues and line over 80 characters Use spell checking on 'allignment'

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-14 Thread David Daney
cases of comparison to NULL need changing before you do it to this driver. David Daney ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-14 Thread David Daney
On 10/14/2015 01:58 PM, Arnd Bergmann wrote: On Wednesday 14 October 2015 08:47:44 David Daney wrote: On 10/14/2015 07:06 AM, Sakshi Bansal wrote: Fixed allignment issues and line over 80 characters Use spell checking on 'allignment' But that is not the main problem with the patc

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-15 Thread David Daney
On 10/15/2015 06:40 AM, Dan Carpenter wrote: On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote: and make sure you don't break the driver. I'm not seeing how this patch breaks anything? What am I missing? Did you apply it and then compile the result? If not, then h

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-30 Thread David Daney
broke the logic for enabling NAPI on more than one CPU. I am not sure which is the case, but I think it would be best if you supplied a fixed patch set that corrects whichever happens to be the case. David Daney } void cvm_oct_rx_shutdown(void

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-30 Thread David Daney
On 09/30/2013 12:35 PM, Aaro Koskinen wrote: Hi, On Mon, Sep 30, 2013 at 10:23:10AM -0700, David Daney wrote: On 09/28/2013 12:50 PM, Aaro Koskinen wrote: Currently the driver assumes that CPU 0 is handling all the hard IRQs. This is wrong in Linux SMP systems where user is allowed to assign

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-30 Thread David Daney
On 09/30/2013 12:56 PM, Aaro Koskinen wrote: Hi, On Mon, Sep 30, 2013 at 12:41:59PM -0700, David Daney wrote: On 09/30/2013 12:35 PM, Aaro Koskinen wrote: No, the original logic was already broken. The code assumed that the NAPI scheduled by the driver init gets executed always on CPU 0. The

Re: [PATCH] staging: octeon: drop redundant mac address check

2013-10-29 Thread David Daney
On 10/28/2013 06:24 PM, Luka Perkov wrote: Checking if MAC address is valid using is_valid_ether_addr() is already done in of_get_mac_address(). Signed-off-by: Luka Perkov Acked-by: David Daney --- drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] gpio: removes all usage of gpiochip_remove retval

2014-05-29 Thread David Daney
On 05/29/2014 02:54 PM, abdoulaye berthe wrote: Did you forget a changelog explaining why this is either needed, or even a good idea? I joined the conversation late and don't know why you are doing this. Thanks, David Daney Signed-off-by: abdoulaye berthe --- arch/arm/common/sc

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread David Daney
("gpio: removing gpiochip with gpios still requested\n"); panic? NACK to the patch for this reason. The strongest thing you should do here is WARN. That said, I am not sure why we need this whole patch set in the first place. David Daney Is this likely to happen? Gr{o

Re: [PATCH 05/44] mfd: as3722: Drop reference to pm_power_off from devicetree bindings

2014-10-07 Thread David Daney
that, although documented in the kernel source tree, cannot be changed in incompatible ways as time progresses. David Daney ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 11/19] staging: octeon: Remove unnecessary externs

2015-08-10 Thread David Daney
On 08/10/2015 02:51 PM, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches Acked-by: David Daney --- drivers/staging/octeon/ethernet-mdio.h | 2 +- drivers/staging/octeon/octeon-ethernet.h | 22 +++---

Re: [PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

2015-08-13 Thread David Daney
CTEON and OCTEON II networking continue to function? There is no SSO provisioning, so there will be limited buffering on packet ingress. For low packet rates, it should be fine though. David Daney A. Aaro Koskinen (2): MIPS/staging: OCTEON: properly enable/disable SSO WQE interrupts

Re: [PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

2015-08-14 Thread David Daney
On 08/14/2015 06:09 AM, Aaro Koskinen wrote: Hi, On Thu, Aug 13, 2015 at 12:16:43PM -0700, David Daney wrote: On 08/13/2015 06:21 AM, Aaro Koskinen wrote: Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to issues in Ethernet driver initialization. Some boards are hanging

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread David Daney
ve had with the DWC2 driver have been fixed, I have no problem with making OCTEON work with that driver. Otherwise, to say that octeon-usb has shortcomings is a bit disingenuous. I haven't been following DWC2 driver development, so I don't really know its

Re: [PATCH 3/3] staging: octeon-ethernet: rgmii: enable interrupts that we can handle

2013-09-05 Thread David Daney
bling IRQ #117 [ 45.038742] Port 0 receive error code 13, packet dropped [ 46.324719] eth0: Link down [ 48.324733] eth0: 1000 Mbps Full duplex, port 0, queue 0 Reported-by: "Jason A. Donenfeld" Signed-off-by: Aaro Koskinen Acked-by: David Daney --- drivers/staging/oct

Re: [PATCH 2/3] staging: octeon-ethernet: remove skb alloc failure warnings

2013-09-05 Thread David Daney
fine. Acked-by: David Daney --- drivers/staging/octeon/ethernet-mem.c | 7 +-- drivers/staging/octeon/ethernet-rx.c | 3 --- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mem.c b/drivers/staging/octeon/ethernet-mem.c index 78b6cb7..199

Re: [PATCH 1/3] staging: octeon-ethernet: make dropped packets to consume NAPI budget

2013-09-05 Thread David Daney
On 09/05/2013 11:43 AM, Aaro Koskinen wrote: We should count also dropped packets, otherwise the NAPI handler may end up running too long. Is this actually a problem? If so ... the patch looks sane and you and add Acked-by me. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ether