[PATCH 42/45] staging: unisys: visorbus: fix comments in vbuschannel.h

2017-09-27 Thread David Kershner
From: Sameer Wadgaonkar This patch fixes some comments in the file vbuschannel.h to make it more uniform. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vbuschannel.h | 9 - 1 file changed, 4 insertions(+), 5

[PATCH 44/45] staging: unisys: visorhba: clean up parenthesis

2017-09-27 Thread David Kershner
Clean up unneeded parenthesis reported by checkpatch.pl. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorhba/visorhba_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b

[PATCH 38/45] staging: unisys: check the whole channel instead of just guid for match

2017-09-27 Thread David Kershner
From: Sameer Wadgaonkar Validate that the channel contents match the channel type that we are matching. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 11 ++- drivers/staging/unisys/visorhba

[PATCH 41/45] staging: unisys: include: fix comments and spacing issues in visorbus.h

2017-09-27 Thread David Kershner
From: Sameer Wadgaonkar This patch fixes some comments and spacings in the file visorbus.h to make it more uniform. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 12 +--- 1 file changed, 5

[PATCH 43/45] staging: unisys: visorbus: Fix extraneous parenthesis

2017-09-27 Thread David Kershner
Clean up unneeded () that are being reported by checkpatch. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH 45/45] staging: unisys: visornic: clean up parenthesis

2017-09-27 Thread David Kershner
Clean up unneeded parenthesis reported by checkpatch.pl. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers

Re: [PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread David Miller
t; Acked-by: Krzysztof Halasa # for wan/hdlc* > Acked-by: Jens Axboe # for amiflop > --- > This should go via the timer/core tree, please. It's been acked by each > of the maintainers. Thanks! For networking bits: Acked-by: David S. Miller __

Re: [PATCH net] hv_sock: add locking in the open/close/release code paths

2017-10-20 Thread David Miller
From: Dexuan Cui Date: Thu, 19 Oct 2017 03:33:14 + > > Without the patch, when hvs_open_connection() hasn't completely established > a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't > inserted the sock into the connected queue), vsock_stream_connect() may see > the

drivers/staging/wilc1000/host_interface.c:: 6 * pointless test ?

2017-10-23 Thread David Binderman
ue due to limited range of data type [-Wtype-limits] Regards David Binderman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next 3/4] hv_netvsc: reset net_device_ctx->nvdev with rcu_assign_pointer()

2017-10-31 Thread David Miller
From: Vitaly Kuznetsov Date: Tue, 31 Oct 2017 15:40:06 +0100 > Eric Dumazet writes: > >> On Tue, 2017-10-31 at 14:42 +0100, Vitaly Kuznetsov wrote: >>> RCU_INIT_POINTER() is not suitable here as it doesn't give us ordering >>> guarantees (see the comment in rcupdate.h). This is also not a hotpa

Re: [PATCH net-next v2 0/2] hv_netvsc: fix a hang on channel/mtu changes

2017-11-07 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 2 Nov 2017 11:35:29 +0100 > It was found that netvsc driver doesn't survive e.g. > > # while true; do ethtool -L eth0 combined 4; ethtool -L eth0 combined 8; done" > > test. I was able to identify a hang in guest/host communication, it is > fixed by PATCH1 of

Re: [PATCH 02/11] staging: greybus: Remove redundant license text

2017-11-07 Thread David Lin
ved. > > Cc: Vaibhav Hiremath > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Signed-off-by: Greg Kroa

Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files

2017-11-07 Thread David Lin
ovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stew

[PATCH v2 0/8] Cavium OCTEON-III network driver.

2017-11-08 Thread David Daney
dt-bindings: Add Cavium Octeon Common Ethernet Interface. MIPS: Octeon: Enable LMTDMA/LMTST operations. MIPS: Octeon: Add a global resource manager. MIPS: Octeon: Add Free Pointer Unit (FPA) support. netdev: octeon-ethernet: Add Cavium Octeon III support. David Daney (3): MIPS: O

[PATCH v2 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-08 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc

[PATCH v2 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-08 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insertions(+) create mode

[PATCH v2 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-08 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25

[PATCH v2 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-08 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

[PATCH v2 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-08 Thread David Daney
Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/Kconfig | 8 + arch/mips/cavium-octeon/Makefile | 1 + arch/mips/cavium-octeon/octeon-fpa3.c | 364 ++ arch/mips/include/asm/octeon/octeon.h | 1

[PATCH v2 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-08 Thread David Daney
and then return a variable length (up to 128 bytes) response from the IOI device. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/setup.c | 6 ++ arch/mips/include/asm/octeon/octeon.h | 12 ++-- 2 files changed

[PATCH v2 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-08 Thread David Daney
additional lines, defaults to zero. Signed-off-by: David Daney Signed-off-by: Carlos Munoz --- arch/mips/cavium-octeon/Kconfig| 27 arch/mips/cavium-octeon/setup.c| 16 ++-- .../asm/mach-cavium-octeon/kernel-entry-init.h | 20

Re: [PATCH v2 0/8] Cavium OCTEON-III network driver.

2017-11-09 Thread David Daney
I need to send v3. With this v2 set, there is a small bug in the RX initialization that causes failure on little-endian kernels. David. On 11/08/2017 04:51 PM, David Daney wrote: We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is

[PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-09 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insertions(+) create mode

[PATCH v3 0/8] Cavium OCTEON-III network driver.

2017-11-09 Thread David Daney
pport. netdev: octeon-ethernet: Add Cavium Octeon III support. David Daney (3): MIPS: Octeon: Automatically provision CVMSEG space. staging: octeon: Remove USE_ASYNC_IOBDMA macro. MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* .../devicetree/bindings/net/cavium-bg

[PATCH v3 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-09 Thread David Daney
and then return a variable length (up to 128 bytes) response from the IOI device. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/setup.c | 6 ++ arch/mips/include/asm/octeon/octeon.h | 12 ++-- 2 files changed

[PATCH v3 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-09 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

[PATCH v3 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-09 Thread David Daney
Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/Kconfig | 8 + arch/mips/cavium-octeon/Makefile | 1 + arch/mips/cavium-octeon/octeon-fpa3.c | 364 ++ arch/mips/include/asm/octeon/octeon.h | 1

[PATCH v3 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-09 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc

[PATCH v3 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-09 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25

[PATCH v3 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-09 Thread David Daney
additional lines, defaults to zero. Signed-off-by: David Daney Signed-off-by: Carlos Munoz --- arch/mips/cavium-octeon/Kconfig| 27 arch/mips/cavium-octeon/setup.c| 16 ++-- .../asm/mach-cavium-octeon/kernel-entry-init.h | 20

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

2017-11-14 Thread David Miller
From: Stephen Hemminger Date: Tue, 14 Nov 2017 08:37:13 -0800 > These are both old decrepit protocols that need to be sent > to pasture. These need to go to gregkh and his staging/ tree, not net-next. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

2017-11-15 Thread David Miller
From: Greg KH Date: Wed, 15 Nov 2017 10:13:18 +0100 > On Wed, Nov 15, 2017 at 09:58:33AM +0900, David Miller wrote: >> From: Stephen Hemminger >> Date: Tue, 14 Nov 2017 08:37:13 -0800 >> >> > These are both old decrepit protocols that need to be sent >> >

Re: [PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-15 Thread David Daney
On 11/15/2017 11:18 AM, Rob Herring wrote: On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree

Re: [PATCH net v2] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-15 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 15 Nov 2017 15:12:55 +0100 > rndis_filter_device_add() is called both from netvsc_probe() when we > initially create the device and from set channels/mtu/ringparam > routines where we basically remove the device and add it back. > > hw_features is reset in rndis

[PATCH 1/2] staging: unisys: visorbus: address theoretical int overflows

2017-11-17 Thread David Kershner
ned long)i+1; printf("adding 1 WITHcast = %lun", il); } [selltc@mac tmp]$ gcc x.c -o x.out [selltc@mac tmp]$ ./x.out sizeof(int) =4 sizeof(long)=8 i = 4294967295 adding 1 withOUT cast = 0 adding 1 WITHcast = 4294967296 Signed-off-by: Tim Sell Reported-

[PATCH 0/2] drivers: Move visorbus from staging to drivers/visorbus

2017-11-17 Thread David Kershner
this state. David Kershner (1): drivers: visorbus: move driver out of staging Tim Sell (1): staging: unisys: visorbus: address theoretical int overflows MAINTAINERS | 2 ++ drivers/Kconfig

[PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-17 Thread David Kershner
over to drives/visorbus/Kconfig to make sure dependencies were met. Visorbus will now just live in the /drivers directory. Signed-off-by: David Kershner Reviewed-by: David Binder Reviewed-by: Tim Sell --- MAINTAINERS | 2 ++ drivers

[PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-28 Thread David Daney
ernet Interface. MIPS: Octeon: Enable LMTDMA/LMTST operations. MIPS: Octeon: Add a global resource manager. MIPS: Octeon: Add Free Pointer Unit (FPA) support. netdev: octeon-ethernet: Add Cavium Octeon III support. David Daney (3): MIPS: Octeon: Automatically provision CVMSEG space. st

[PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-28 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

[PATCH v4 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-28 Thread David Daney
additional lines, defaults to zero. Signed-off-by: David Daney Signed-off-by: Carlos Munoz --- arch/mips/cavium-octeon/Kconfig| 27 arch/mips/cavium-octeon/setup.c| 16 ++-- .../asm/mach-cavium-octeon/kernel-entry-init.h | 20

[PATCH v4 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-28 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25

[PATCH v4 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-28 Thread David Daney
Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/Kconfig | 8 + arch/mips/cavium-octeon/Makefile | 1 + arch/mips/cavium-octeon/octeon-fpa3.c | 364 ++ arch/mips/include/asm/octeon/octeon.h | 1

[PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-28 Thread David Daney
and then return a variable length (up to 128 bytes) response from the IOI device. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- arch/mips/cavium-octeon/setup.c | 6 ++ arch/mips/include/asm/octeon/octeon.h | 12 ++-- 2 files changed

[PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61

[PATCH v4 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-28 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..e9239ff3cf05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
On 11/28/2017 06:01 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney

Re: [PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-29 Thread David Miller
The net-next tree is closed, please resubmit this when the net-next tree opens again. Thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread David Daney
On 11/29/2017 08:07 AM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: From: Carlos Munoz The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O hardware that is significantly different from

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread David Daney
On 11/29/2017 02:56 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote: +static int bgx_probe(struct platform_device *pdev) +{ + struct mac_platform_data platform_data; + const __be32 *reg; + u32 port; + u64 addr; + struct

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread David Daney
On 11/30/2017 01:36 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread David Daney
On 11/30/2017 02:56 PM, James Hogan wrote: On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote: On 11/30/2017 01:36 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-30 Thread David Daney
On 11/30/2017 02:53 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote: From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: Carlos, On Thu, Nov 30, 2017 at 11:53 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote: From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +// SPDX-License-Identifier: GPL-2.0

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 12/01/2017 12:41 PM, Philippe Ombredanne wrote: David, On Fri, Dec 1, 2017 at 9:01 PM, David Daney wrote: On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote

Re: [PATCH net-next 0/6] hv_netvsc: minor optimizations

2017-12-03 Thread David Miller
From: Stephen Hemminger Date: Fri, 1 Dec 2017 11:01:43 -0800 > These are a set of local optimizations the Hyper-V networking driver. > Also include a vmbus patch in this set, because it depends on the > netvsc that last used that function. Series applied. For the ring percentage stuff, I would

[PATCH 0/4] staging: unisys: fix dependency and include issues

2017-12-06 Thread David Kershner
This patch series combines the global include files into a single include and cleans up dependencies that were in the wrong location. We had code dependencies on the UNISYSSPAR Kconfig flag instead of the VISORBUS config flag. UNISYSSPAR is just there for organizational purposes. David Kershner

[PATCH 4/4] staging: unisys: move dependencies from UNISYSSPAR to VISORBUS

2017-12-06 Thread David Kershner
The Kconfig flag UNISYSSPAR depended on ACPI and X86, these dependencies really belong to visorbus, so move them there. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig | 2 -- drivers/staging/unisys/visorbus/Kconfig | 1 + 2 files changed, 1

[PATCH 1/4] staging: unisys: fix dependencies with UNISYSSPAR Kconfig flag

2017-12-06 Thread David Kershner
The Kconfig file for UNISYSSPAR uses select ACPI and select PCI instead of depends on ACPI. This patch fixes the problem. Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH 2/4] staging: unisys: remove !UML flag

2017-12-06 Thread David Kershner
Remove the dependency that the drivers are not built during UML. Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b/drivers

[PATCH 3/4] staging: unisys: combine visorchannel.h and visorbus.h

2017-12-06 Thread David Kershner
Combine the include files visorchannel.h and visorbus.h so that only one include file is needed for the .c files. Reported-by: Christoph Hellwig Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/iochannel.h | 2 +- drivers/staging/unisys/include

[PATCH v2] drivers: visorbus: move driver out of staging

2017-12-07 Thread David Kershner
-by: David Kershner Reviewed-by: Tim Sell --- The files are based off the latest revision in the staging-next tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Changes from v1: -- Simplified to one single patch -- Combined include files into a single file

Re: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

2017-12-08 Thread David Miller
From: Dan Carpenter Date: Fri, 8 Dec 2017 13:33:25 +0300 > On Thu, Dec 07, 2017 at 04:10:53PM -0800, Stephen Hemminger wrote: >> From: Haiyang Zhang >> >> It should be 31 MB on recent host versions. >> >> Signed-off-by: Haiyang Zhang >> Signed-off-by: Stephen Hemminger > > This is very vagu

Re: [PATCH net-next 0/2] hv_netvsc: Fix default and limit of recv buffe

2017-12-13 Thread David Miller
From: Stephen Hemminger Date: Mon, 11 Dec 2017 08:56:56 -0800 > The default for receive buffer descriptors is not correct, it should > match the default receive buffer size and the upper limit of receive > buffer size is too low. Also, for older versions of Window servers > hosts, different lowe

Re: [PATCH net-next 0/6] hv_netvsc: minor changes

2017-12-13 Thread David Miller
From: Stephen Hemminger Date: Tue, 12 Dec 2017 16:48:34 -0800 > This includes minor cleanup of code in send and receive path and > also a new statistic to check for allocation failures. This also > eliminates some of the extra RCU when not needed. > > There is a theoritical bug where buffered da

Re: [PATCH net] hv_netvsc: split sub-channel setup into async and sync

2018-06-30 Thread David Miller
From: Haiyang Zhang Date: Fri, 29 Jun 2018 14:07:16 -0700 > From: Stephen Hemminger > > When doing device hotplug the sub channel must be async to avoid > deadlock issues because device is discovered in softirq context. > > When doing changes to MTU and number of channels, the setup > must be

Re: [PATCH net,v2] hv_netvsc: Fix napi reschedule while receive completion is busy

2018-07-18 Thread David Miller
From: Haiyang Zhang Date: Tue, 17 Jul 2018 17:11:13 + > From: Haiyang Zhang > > If out ring is full temporarily and receive completion cannot go out, > we may still need to reschedule napi if certain conditions are met. > Otherwise the napi poll might be stopped forever, and cause network >

Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-23 Thread David Miller
] v4l: omap4iss: Add support for OMAP4 camera > interface - Video devices") > Suggested-by: Linus Torvalds > Cc: David Miller > Cc: Randy Dunlap > Signed-off-by: Guenter Roeck Acked-by: David S. Miller ___ devel mailin

Re: [PATCH v4 net-next] hv_netvsc: Add per-cpu ethtool stats for netvsc

2018-07-30 Thread David Miller
From: Yidong Ren Date: Mon, 30 Jul 2018 17:09:45 + > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters already exist in current code. Exposing > these counters will

linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289: dead code block ?

2018-08-06 Thread David Binderman
i].key, key_size)) continue; /* * Found a match; just move the remaining * entries up. */ if (i == num_records) { Regards David Binderman ___ devel

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread David Miller
From: Takashi Iwai Date: Tue, 14 Aug 2018 19:10:50 +0200 > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > to single queue mode") tried to fix the fallback behavior to a single > queue mode, but it changed the function to return zero incorrectly, > while the function should

[PATCH RFC 2/2] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock

2018-08-17 Thread David Hildenbrand
patch is partly based on a patch by Vitaly Kuznetsov. Signed-off-by: David Hildenbrand --- arch/powerpc/platforms/powernv/memtrace.c | 3 ++ drivers/acpi/acpi_memhotplug.c| 1 + drivers/base/memory.c | 18 +- drivers/hv/hv_balloon.c |

[PATCH RFC 0/2] mm: online/offline_pages called w.o. mem_hotplug_lock

2018-08-17 Thread David Hildenbrand
natural. Second patch could maybe split up. But let's first hear if this is actually a problem and if there migh be alternatives (or cleanups). Only tested with DIMM-based hotplug. David Hildenbrand (1): mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_loc

[PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread David Hildenbrand
patch description] Signed-off-by: David Hildenbrand --- drivers/base/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 04bbcd779e11..9010b9e942b5 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -700,11 +700,13 @@ void

Re: [PATCH RFC 2/2] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock

2018-08-17 Thread David Hildenbrand
On 17.08.2018 10:20, Rafael J. Wysocki wrote: > On Fri, Aug 17, 2018 at 9:59 AM David Hildenbrand wrote: >> >> There seem to be some problems as result of 30467e0b3be ("mm, hotplug: >> fix concurrent memory hot-add deadlock"), which tried to fix a possible >>

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread David Hildenbrand
On 17.08.2018 10:41, Greg Kroah-Hartman wrote: > On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote: >> From: Vitaly Kuznetsov >> >> Well require to call add_memory()/add_memory_resource() with >> device_hotplug_lock held, to avoid a lock inversion. All

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread David Hildenbrand
On 17.08.2018 11:03, Rafael J. Wysocki wrote: > On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote: >> >> On 17.08.2018 10:41, Greg Kroah-Hartman wrote: >>> On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote: >>>> From: Vitaly Kuzne

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread David Hildenbrand
On 17.08.2018 12:06, Greg Kroah-Hartman wrote: > On Fri, Aug 17, 2018 at 11:41:24AM +0200, David Hildenbrand wrote: >> On 17.08.2018 11:03, Rafael J. Wysocki wrote: >>> On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote: >>>> >>>> On 17.08.2018 10:

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread David Hildenbrand
On 17.08.2018 13:28, Heiko Carstens wrote: > On Fri, Aug 17, 2018 at 01:04:58PM +0200, David Hildenbrand wrote: >>>> If there are no objections, I'll go into that direction. But I'll wait >>>> for more comments regarding the general concept first. >>>

[PATCH RFCv2 0/6] mm: online/offline_pages called w.o. mem_hotplug_lock

2018-08-21 Thread David Hildenbrand
atches a bit. - Try to improve powernv memtrace locking - Add some documentation for locking that matches my knowledge David Hildenbrand (6): mm/memory_hotplug: make remove_memory() take the device_hotplug_lock mm/memory_hotplug: make add_memory() take the device_hotplug_lock mm/memory_hot

[PATCH RFCv2 2/6] mm/memory_hotplug: make add_memory() take the device_hotplug_lock

2018-08-21 Thread David Hildenbrand
: Boris Ostrovsky Cc: Juergen Gross Cc: Nathan Fontenot Cc: John Allen Cc: Andrew Morton Cc: Michal Hocko Cc: Dan Williams Cc: Joonsoo Kim Cc: Vlastimil Babka Cc: Oscar Salvador Cc: Mathieu Malaterre Cc: Pavel Tatashin Cc: YASUAKI ISHIMATSU Signed-off-by: David Hildenbrand --- .../plat

[PATCH RFCv2 1/6] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock

2018-08-21 Thread David Hildenbrand
car Salvador Cc: YASUAKI ISHIMATSU Cc: Mathieu Malaterre Signed-off-by: David Hildenbrand --- arch/powerpc/platforms/powernv/memtrace.c | 2 -- arch/powerpc/platforms/pseries/hotplug-memory.c | 6 +++--- drivers/acpi/acpi_memhotplug.c | 2 +- include/linux/memory_hotpl

[PATCH RFCv2 3/6] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock

2018-08-21 Thread David Hildenbrand
: Michael Neuling Cc: Balbir Singh Cc: Kate Stewart Cc: Thomas Gleixner Cc: Philippe Ombredanne Cc: Andrew Morton Cc: Michal Hocko Cc: Pavel Tatashin Cc: Vlastimil Babka Cc: Dan Williams Cc: Oscar Salvador Cc: YASUAKI ISHIMATSU Cc: Mathieu Malaterre Signed-off-by: David Hildenbra

[PATCH RFCv2 4/6] powerpc/powernv: hold device_hotplug_lock when calling device_online()

2018-08-21 Thread David Hildenbrand
device_online() should be called with device_hotplug_lock() held. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Rashmica Gupta Cc: Balbir Singh Cc: Michael Neuling Signed-off-by: David Hildenbrand --- arch/powerpc/platforms/powernv/memtrace.c | 2 ++ 1 file

[PATCH RFCv2 6/6] memory-hotplug.txt: Add some details about locking internals

2018-08-21 Thread David Hildenbrand
Let's document the magic a bit, especially why device_hotplug_lock is required when adding/removing memory and how it all play together with requests to online/offline memory from user space. Cc: Jonathan Corbet Cc: Michal Hocko Cc: Andrew Morton Signed-off-by: David Hilden

[PATCH RFCv2 5/6] powerpc/powernv: hold device_hotplug_lock in memtrace_offline_pages()

2018-08-21 Thread David Hildenbrand
Let's perform all checking + offlining + removing under device_hotplug_lock, so nobody can mess with these devices via sysfs concurrently. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Rashmica Gupta Cc: Balbir Singh Cc: Michael Neuling Signed-off-by:

RE: [PATCH 1/2] staging: rtl8192e: Fix compiler warning about strncpy

2018-08-21 Thread David Laight
>current_network.ssid, tmp_ssid, > + strlcpy(ieee->current_network.ssid, tmp_ssid, > IW_ESSID_MAX_SIZE); > ieee->current_network.ssid_len = tmp_ssid_len; Hmmm... this looks like it is restor

Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe()

2018-08-29 Thread David Miller
From: Dexuan Cui Date: Wed, 22 Aug 2018 21:20:03 + > --- > drivers/net/hyperv/netvsc_drv.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > > FYI: these are the related 3 paths which show the deadlock: This incredibly useful information belongs in the commit log mes

Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe()

2018-08-29 Thread David Miller
From: Dexuan Cui Date: Thu, 30 Aug 2018 00:58:48 + >> From: David Miller >> Sent: Wednesday, August 29, 2018 17:49 >> >> From: Dexuan Cui >> Date: Wed, 22 Aug 2018 21:20:03 + >> >> > --- >> > drivers/net/hyperv/netvsc_drv.c | 11

Re: [PATCH RFCv2 0/6] mm: online/offline_pages called w.o. mem_hotplug_lock

2018-08-30 Thread David Hildenbrand
On 21.08.2018 12:44, David Hildenbrand wrote: > This is the same approach as in the first RFC, but this time without > exporting device_hotplug_lock (requested by Greg) and with some more > details and documentation regarding locking. Tested only on x86 so far. > I'll be on

RE: [PATCH v5 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-08-30 Thread David Laight
is better. Maybe there ought to be a define so you can do: DEFINE_BITMAP(value_bitmap, 32); While it might just generate an unsigned long [] there is probably scope for stronger typing. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK

Re: [PATCH RFCv2 1/6] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock

2018-08-31 Thread David Hildenbrand
; Reviewed-by: Pavel Tatashin > >> +{ >> +lock_device_hotplug(); >> +__remove_memory(nid, start, size); >> +unlock_device_hotplug(); >> +} >> EXPORT_SYMBOL_GPL(remove_memory); >> #endif /* CONFIG_MEMORY_HOTREMOVE */ -- Thanks, David / dhil

Re: [PATCH v2] hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()

2018-08-31 Thread David Miller
From: Dexuan Cui Date: Thu, 30 Aug 2018 05:42:13 + > > This patch fixes the race between netvsc_probe() and > rndis_set_subchannel(), which can cause a deadlock. > > These are the related 3 paths which show the deadlock: ... > Before path #1 finishes, path #2 can start to run, because just

Re: [PATCH RFCv2 0/6] mm: online/offline_pages called w.o. mem_hotplug_lock

2018-09-01 Thread David Hildenbrand
On 31.08.2018 22:54, Oscar Salvador wrote: > On Tue, Aug 21, 2018 at 12:44:12PM +0200, David Hildenbrand wrote: >> This is the same approach as in the first RFC, but this time without >> exporting device_hotplug_lock (requested by Greg) and with some more >> details and do

Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

2018-09-01 Thread David Miller
From: Ioana Radulescu Date: Wed, 29 Aug 2018 04:42:38 -0500 > The Freescale/NXP DPAA2 Ethernet driver was first included in > drivers/staging, due to its dependencies on two components located > there at the time of its initial submission: > * the fsl-mc bus driver, which was moved to drivers/bus

Re: [PATCH net-next 1/2] PCI: hv: support reporting serial number as slot information

2018-09-01 Thread David Miller
From: Stephen Hemminger Date: Wed, 29 Aug 2018 09:24:51 -0700 > + spin_lock_irqsave(&hbus->device_list_lock, flags); > + list_for_each_entry(hpdev, &hbus->children, list_entry) { > + if (hpdev->pci_slot) > + continue; > + > + slot_nr = PCI_SLOT(

Re: [PATCH 1/2 dhowells/mount-api] staging: erofs: rename superblock flags (MS_xyz -> SB_xyz)

2018-09-06 Thread David Howells
> > Reported-by: Stephen Rothwell > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang I recommend pushing this one to Linus now. It's trivial enough. Reviewed-by: David Howells ___ devel mailing list de...@linuxdriverproject.org http://driverd

Re: [PATCH 2/2 dhowells/mount-api] staging: erofs: update .mount and .remount_sb

2018-09-06 Thread David Howells
iang I've folded this into my patch. David ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 1/7] staging: rtl8712: Fix some Sparse endian messages

2017-02-13 Thread David Laight
e changes that are only annotations and those that actually change the code. The latter need a proper patch description. David. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 6/7] staging: r8712u: Fix Sparse warnings in rtl871x_ioctl_linux.c

2017-02-13 Thread David Laight
(IEEE80211_HT_CAP_SGI_20 | > IEEE80211_HT_CAP_SGI_40)) ? 1 : 0; You've added a byteswap on le systems - so the title is wrong. You need to sort out whether the byteswap is needed or not. Also it is best to byteswap the

<    1   2   3   4   5   6   7   8   9   10   >