The function visorchipset_bus_create just called visorbus_create_instance,
we should just combine it with visorbus_create_instance.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 19
From: Sameer Wadgaonkar
The function visorchipset_device_destroy just called remove_visor_device,
we can just combine it with remove_visor_device.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 9
From: Sameer Wadgaonkar
The function visorchipset_device_create just called create_visor_device,
we can just combine it with create_visor_device.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 18
From: David Binder
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
From: David Binder
Fixes two sprintf invocations where we attempt to format an unsigned
integer as a signed integer.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions
Remove unnecessary blank line from channel.h #defines.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers/staging
Visorbus.h had comments that did not have /* on its own line, this patch
makes it uniform.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff
A comment in channel.h was referencing windows guests, in reality the OS
of the guest is agnostic and the comment should reflect that.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 9 -
1 file changed
From: Zohaib Javed
Removed unused #define GPI_ENTRIES_PER_PAGE
Signed-off-by: Zohaib Javed
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging
The SIOVM guid is only used by visorchipset. So define it there instead
of a global header file.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 6 --
drivers/staging/unisys/visorbus/visorchipset.c | 7
From: Stephen Hemminger
Date: Mon, 31 Jul 2017 16:45:21 -0700
> This patch set changes how SR-IOV Virtual Function devices are managed
> in the Hyper-V network driver. It was part of earlier bundle, but
> is now updated.
I think you need to do a rebase. I just merged net into net-next and
this
Declare fiemap_for_stripe as static to fix sparse warnings:
> warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> static?
Signed-off-by: David Wittman
---
drivers/staging/lustre/lustre/lov/lov_object.c | 10 +-
1 file changed, 5 insertions(+), 5 de
From: Joe Perches
Date: Mon, 31 Jul 2017 10:30:54 -0700
> Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be
> shortened by using a temporary. Do so.
>
> No change in object code.
>
> Miscellanea:
>
> o Use * const for rpkt and nvchan
>
> Signed-off-by: Joe Perches
Applied to n
From: Stephen Hemminger
Date: Tue, 1 Aug 2017 19:58:52 -0700
> This patch set changes how SR-IOV Virtual Function devices are managed
> in the Hyper-V network driver. This version is rebased onto current net-next.
...
Series applied, thanks Stephen.
From: Stephen Hemminger
Date: Thu, 3 Aug 2017 17:13:54 -0700
> The existing sub channel code did not wait for all the sub-channels
> to completely initialize. This could lead to race causing crash
> in napi_netif_del() from bad list. The existing code would send
> an init message, then wait only
From: Stephen Hemminger
Date: Fri, 4 Aug 2017 12:14:00 -0700
> With new transparent VF support, it is possible to get a deadlock
> when some of the deferred work is running and the unregister_vf
> is trying to cancel the work element. The solution is to use
> trylock and reschedule (similar to b
From: Stephen Hemminger
Date: Mon, 7 Aug 2017 11:30:00 -0700
> Go back to switching datapath directly in the notifier callback.
> Otherwise datapath might not get switched on unregister.
>
> No need for calling the NOTIFY_PEERS notifier since that is only for
> a gratitious ARP/ND packet; but t
From: Eduardo Otubo
Date: Tue, 8 Aug 2017 15:53:45 +0200
> This patch fixes the behavior of the hv_set_ifconfig script when setting
> the interface ip. Sometimes the interface has already been configured by
> network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> exists error"; i
From: Eduardo Otubo
Date: Thu, 10 Aug 2017 09:40:27 +0200
> On 08/09/2017 11:02 AM, Eduardo Otubo wrote:
>> On 08/09/2017 06:11 AM, David Miller wrote:
>>> From: Eduardo Otubo
>>> Date: Tue, 8 Aug 2017 15:53:45 +0200
>>>
>>>> This patch fixes
From: Stephen Hemminger
Date: Wed, 9 Aug 2017 17:46:02 -0700
> These are non-critical bug fixes, related to functionality now in net-next.
> 1. delaying the automatic bring up of VF device to allow udev to change name.
> 2. performance improvement
> 3. handle MAC address change with VF; mostl
From: Dexuan Cui
Date: Tue, 15 Aug 2017 22:13:29 +
> + /*
> + * Check if we are running on VMware's hypervisor and bail out
> + * if we are not.
> + */
> + if (x86_hyper != &x86_hyper_vmware)
> + return -ENODEV;
This symbol is only available when CONFIG_HYP
From: Dexuan Cui
Date: Wed, 16 Aug 2017 18:51:36 +
> It looks typically modern Linux distros have CONFIG_HYPERVISOR_GUEST=y
> by default
It doesn't matter what any distribution does or does not do.
People are going to do 'randconfig' builds over thousands and
thousands of configuration comb
From: Stephen Hemminger
Date: Wed, 16 Aug 2017 08:56:23 -0700
> These patches remove and consolidate vmbus_sendpacket functions.
>
> They should go through the net-next tree since these API's
> were only used by the netvsc driver.
Series applied, thanks.
From: Dexuan Cui
Date: Thu, 17 Aug 2017 08:00:29 +
> @@ -73,6 +74,10 @@ struct vmci_transport_recv_pkt_info {
> struct vmci_transport_packet pkt;
> };
>
> +static bool skip_hypervisor_check;
> +module_param(skip_hypervisor_check, bool, 0444);
> +MODULE_PARM_DESC(hot_add, "If set, att
generic UUID API
Charles Daniels (1):
staging: unisys: visorbus: fix multi-line function definition
David Binder (10):
staging: unisys: visorbus: Merge vmcallinterface.h into visorchipset.c
staging: unisys: visorbus: Remove unnecessary comments
staging: unisys: visorbus: visorchipset.c
Cleaned up some #defines to make the beginning of the file read easier.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers
From: Sameer Wadgaonkar
Cleaned up the in-line comments in the structure and added a single block
comment for the structure.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c
From: Sameer Wadgaonkar
This patch fixes two checkpatch warnings in the visornic_main.c
file to avoid multiline dereference.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 9 -
1 file
: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 10 ++--
drivers/staging/unisys/visorbus/visorbus_private.h | 5 +--
drivers/staging/unisys/visorbus/visorchipset.c | 41 +--
3 files changed, 10 insertions
From: Mark Foresta
Remove the filename in the comment at the beginning of the file.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 3 +--
1 file changed, 1 insertion(+), 2
From: Mark Foresta
Moved blocked comment on to own line at beginning of struct to follow
standard. Since this is an internal structure, the block comment isn't
actually a kernel-doc so we only start the block with one asterisk.
Signed-off-by: Mark Foresta
Signed-off-by: David Ker
From: Zohaib Javed
Removed unused #define GPI_ENTRIES_PER_PAGE
Signed-off-by: Zohaib Javed
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging
The vdisk task management commands are no longer used by s-Par, this
patch removes the definitions for them.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 32 +---
1 file changed, 32
, and so using the standard version creates an
unnecessary dependency between the kernel and s-Par.
Signed-off-by: Steven Matthews
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 15 --
drivers/staging/unisys/visorhba
From: Andy Shevchenko
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
While here, re-indent couple of lines to increase readability.
Cc: David Kershner
Cc: Greg Kroah-Hartman
Cc
From: David Binder
Removes comments that do not provide any valuable information.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff
A comment in channel.h was referencing windows guests, in reality the OS
of the guest is agnostic and the comment should reflect that.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 9 -
1 file changed
Visorbus.h had comments that did not have /* on its own line, this patch
makes it uniform.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff
From: Sameer Wadgaonkar
The functions viosrbus_device_pause_response() and
viosrbus_device_resume_response() are functionally similar.
Merging these functions into a single function called
visorbus_device_changestate_response().
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
A bunch of code churn has caused the following include files to not be
needed by visorbus.h:
linux/poll.h
linux/kernel.h
linux/uuid.h
linux/seq_file.h
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 4
1
From: Charles Daniels
Fixed incorrectly styled function definitions in visorbus/visorchipset.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging
From: Zohaib Javed
Added a new line before issue_vmcall_io_controlvm_addr() function
definition.
Signed-off-by: Zohaib Javed
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 1 +
1 file changed, 1 insertion
-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/visorbus/visorbus_private.h
b/drivers/staging/unisys/visorbus/visorbus_private.h
index 6af9f7c..1895035 100644
--- a/drivers
From: David Binder
Fixes two sprintf invocations where we attempt to format an unsigned
integer as a signed integer.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions
The function visorchipset_bus_create just called visorbus_create_instance,
we should just combine it with visorbus_create_instance.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 19
Remove unnecessary blank line from channel.h #defines.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers/staging
The struct visor_device had a forward declaration that was not needed.
Remove it.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include
Cleanups caused us to not need to include a bunch of headers, got rid of
them.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys
The iochannel.h header file references ETH_HLEN which is defined in
skbuff. Removed it from visorhba since it was no longer needed.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 1 +
drivers/staging
From: David Binder
The contents of vmcallinterface.h are better placed within
visorchipset.c from an organizational perspective. The values are only
used in that file.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus
We no longer send messages directly to the s-Par event log, so we do not
need the throttling defines anymore.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 17 -
1 file changed, 17 deletions
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
The kernel already provides a min function, we should be using that
instead of creating our own MINNUM.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 3 ---
drivers/staging/unisys/visornic
Instead of including it in the global channel.h, move the VNIC GUID to the
visornic module.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h| 6 --
drivers/staging/unisys/visornic/visornic_main.c | 7
From: Zohaib Javed
The filename was in a comment at the beginning of the file. It is not
needed.
Signed-off-by: Zohaib Javed
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file changed, 1 insertion
Visorchipset.c was including unnecessary include files, either included by
other headers or not needed at all.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1 file changed, 2 deletions(-)
diff
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
The SIOVM guid is only used by visorchipset. So define it there instead
of a global header file.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 5 -
drivers/staging/unisys/visorbus/visorchipset.c | 5
The MAXNUM #define was not being used, and it shouldn't be used.
Remove it.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/in
Do the check with the values in the structure instead of copying them to
local variables.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include
From: David Binder
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
Referencing a SegmentIndex doesn't make sense in the Linux drivers, get rid
of the comment.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/dr
From: David Binder
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
From: Sameer Wadgaonkar
The function visorchipset_device_destroy just called remove_visor_device,
we can just combine it with remove_visor_device.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 9
Don't store it in a local variable but reference it from the
visor_device.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/dr
From: Sameer Wadgaonkar
The function visorchipset_device_create just called create_visor_device,
we can just combine it with create_visor_device.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 18
From: Sameer Wadgaonkar
The function visorchipset_bus_destroy just called viosrbus_remove_instance,
we can just combine it with visorbus_remove_instance.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c
From: David Binder
Adds the proper Unisys copyright statement to the top of iochannel.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 18 --
1 file changed, 16 insertions(+), 2 deletions
Greg noticed that we were creating our own attribute groups, instead of
using the ATTRIBUTE_GROUPS macro, this patch fixes our mistake.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 33
On Fri, 2017-07-28 at 08:59 -0700, Stephen Hemminger wrote:
> This includes a bunch of fixups for issues reported by
> lockdep.
> * ethtool routines can assume RTNL
> * send is done with RCU lock (and BH disable)
> * avoid refetching internal device struct (netvsc)
> instead pass it a
From: Dexuan Cui
Date: Wed, 23 Aug 2017 04:52:14 +
> +#define VMBUS_PKT_TRAILER(sizeof(u64))
This is not the packet trailer, it's the size of the packet trailer.
Please make this macro name match more accurately what it is.
> + /* Have we sent the zero-length packet (FIN)? */
> +
From: Dexuan Cui
Date: Sat, 26 Aug 2017 04:52:43 +
>
> Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
> mechanism between the host and the guest. It uses VMBus ringbuffer as the
> transportation layer.
>
> With hv_sock, applications between the host (Windows 10, Window
From: Greg Kroah-Hartman
Date: Sun, 27 Aug 2017 17:03:30 +0200
> The IRDA code has long been obsolete and broken. So, to keep people
> from trying to use it, and to prevent people from having to maintain it,
> let's move it to drivers/staging/ so that we can delete it entirely from
> the kernel
From: Greg Kroah-Hartman
Date: Tue, 29 Aug 2017 09:09:29 +0200
> Now that the IRDA code has moved under drivers/staging/irda/, update the
> MAINTAINERS file with the new location.
>
> Reported-by: Joe Perches
> Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org
Applied.
_
From: Greg Kroah-Hartman
Date: Tue, 29 Aug 2017 11:14:17 +0200
> Now that the IRDA networking code has moved into drivers/staging/, the
> link order is changed for when it is initialized if built into the
> system. This can cause a crash when initializing as the netfilter core
> hasn't been init
From: Geert Uytterhoeven
Date: Tue, 29 Aug 2017 12:59:00 +0200
> Hi Greg,
>
> On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman
> wrote:
>> The IRDA code has long been obsolete and broken. So, to keep people
>> from trying to use it, and to prevent people from having to maintain it,
>> let's
From: Greg Kroah-Hartman
Date: Tue, 29 Aug 2017 16:48:50 +0200
> On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote:
>> Hi Greg,
>>
>> On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman
>> wrote:
>> > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote:
>> >> On Tue,
From: Greg KH
Date: Tue, 29 Aug 2017 19:26:08 +0200
> On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote:
>> From: Greg Kroah-Hartman
>> Date: Tue, 29 Aug 2017 11:14:17 +0200
>>
>> > Now that the IRDA networking code has moved into drivers/staging/, the
From: Greg KH
Date: Tue, 29 Aug 2017 19:46:22 +0200
> When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> link order changes when IRDA is built into the kernel. That causes a
> kernel crash at boot time as netfilter isn't initialized yet.
>
> To fix this, build and link t
From: Greg KH
Date: Wed, 30 Aug 2017 13:16:49 +0200
> When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> link order changes when IRDA is built into the kernel. That causes a
> kernel crash at boot time as netfilter isn't initialized yet.
>
> To fix this, move the init ca
The kernel already provides a min function, we should be using that
instead of creating our own MINNUM.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 3 ---
drivers/staging/unisys/visornic
off-by: Sameer Wadgaonkar
Reported-by: Dan Carpenter
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/uni
From: Sameer Wadgaonkar
The error return values for the drv->probe, drv->remove, drv->pause
and drv->resume checks should be -EINVAL instead of -ENODEV.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
dri
, it helped
clean up the formatting of the function.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b
Checkpatch cleanups and other misc cleanups.
David Binder (3):
staging: unisys: visornic: Fix up existing function comments.
staging: unisys: visornic: Fix miscellaneous block comment format issues.
staging: unisys: visornic: Remove unnecessary return values
David Kershner (21):
staging
Several macros in visorchannel.c were doing complex arithmetic, converted
them to functions so that valid type checking could be done.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 25 +++
1 file changed, 15 insertions
From: David Binder
Refactors existing static function comments to increase code readability.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 417 +++--
1 file changed, 190 insertions(+), 227
The variable parm_addr will never be null, so no need to check for it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b
Visorbus_configure had a block of "else if" clauses at the beginning of the
function. Simplify this to just being "if" clauses since each code block
ended with a goto.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.
The function visorutil_spar_detect had an if clause that returns from the
function, no need to do the rest of the code in an else clause.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 23 +++
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus
The functions to create the controlvm channel were disjointed and ignoring
information that was available. This patch consolidates it so it clearer
what is happening.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 47
Checkpatch reports an error that no comment was next to the mutex lock.
Add an appropriate message for the lock.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
Fixed the following checkpatch warning:
visorchannel.c:443: CHECK: Alignment should match open parenthesis
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 3 +--
drivers/staging/unisys/visorbus/visorbus_main.c | 8
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging
From: David Binder
Fixes miscellaneous formatting issues with several block comments
throughout visornic_main.c.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 14 ++
1 file changed, 6
1501 - 1600 of 1855 matches
Mail list logo
