From: David Binder
Adjusts spacing and removes unnecessary blank lines to create a more
uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/channel.h | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a
From: David Binder
Fixes minor spelling mistake: stired -> stored.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/iochannel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/include/iochannel.h
From: Zachary Dremann
Several structure initializations all had their members indented with 2
tabs instead of one. Remove the extra tabs.
Signed-off-by: Zachary Dremann
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 42 +-
1 file changed
From: Sameer Wadgaonkar
Removed comments from the right side of the lines.
Added kernel-doc like comments and cleaned up the inline comments in the
structures.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/iochannel.h | 492
From: David Binder
Adjusts presence of blank lines to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/include
From: David Binder
Removes unused MYDRVNAME define.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys
From: Sameer Wadgaonkar
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorhba/visorhba_main.c | 33 --
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers
From: Sameer Wadgaonkar
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 98 +++---
1 file changed, 61 insertions(+), 37 deletions(-)
diff --git a/drivers
From: Sameer Wadgaonkar
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 20 +++
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers
From: Steve Wilson
Removed extra tabs in visorbus_get_device_by_id function.
Signed-off-by: Steve Wilson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
From: David Binder
Renames MYDRVNAME to better fit with the surrounding driver namespace.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
From: David Binder
Removes unnecessary blank lines to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/unisys
From: David Binder
Refactors existing static function comments to increase code readability.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorhba/visorhba_main.c | 325 -
1 file changed, 170 insertions(+), 155 deletions(-)
diff --git
From: Erik Arfvidson
This patch fixes visorbus_main.c improper function brackets.
for the following functions:
partition_handle_show
partition_guid_show
partition_name_show
channel_addr_show
channel_bytes_show
channel_id_show
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
From: Sameer Wadgaonkar
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys
: visornic: fix multi-line function definition
David Binder (6):
staging: unisys: visorbus: visorchipset.c: Adjust code layout
staging: unisys: visorbus: visorbus_main.c: Adjust code layout
staging: unisys: visorhba: visorhba_main.c: Adjust whitespace usage
staging: unisys: visorinput
From: David Binder
Adjusts the ordering of function statements, as well as modifies whitespace
usage, in order to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 30
From: David Binder
Adjusts whitespace usage in order to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visornic/visornic_main.c | 14 ++
1 file changed, 2 insertions(+), 12
From: David Binder
Adjusts whitespace usage in order to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorinput/visorinput.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions
From: David Binder
Removes unnecessary blank lines to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorhba/visorhba_main.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers
From: Erik Arfvidson
This patch fixes space and tab aligned comments in
controlvmchannel.h.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 8
1 file changed, 4 insertions(+), 4 deletions
From: David Binder
Removes unnecessary checks for a NULL pointer in a non-API function.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorhba/visorhba_main.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
From: Zachary Dremann
As reported by checkpatch.pl, replace hard-coded usage of the current
function's name in format string with usage of __func__.
Signed-off-by: Zachary Dremann
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.
From: Alex Curtin
VISOR_CONTROLVM_CHANNEL_SIGNATURE points to VISOR_CHANNEL_SIGNATURE, so
this replaces the redundant definition with VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus
From: Sameer Wadgaonkar
VMCALL_CONTROLVM_ADDR is the only element left in enum
vmcall_monitor_interface_method_tuple. Converting it to a #define.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/vmcallinterface.h
From: Erik Arfvidson
This patch removes all the unused pound defines currently in
channel.h.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/channel.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers
From: Alex Curtin
VISOR_VHBA_CHANNEL_SIGNATURE is a redundant definition that points to
VISOR_CHANNEL_SIGNATURE. This replaces that definition with
VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include
From: Sameer Wadgaonkar
Added checks for functions probe, remove, pause and resume in
visorbus_register_visor_driver() and removed these checks from
the individual functions itself.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging
From: David Binder
Adjusts the ordering of function statements, as well as modifies
whitespace usage, in order to create a more uniform coding style.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.c | 28
From: Alex Curtin
VISOR_VNIC_CHANNEL_SIGNATURE is a redundant definition that points to
VISOR_CHANNEL_SIGNATURE. This replaces that definition with
VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include
From: Zohaib
Removed unused #define GPI_ENTRIES_PER_PAGE
Signed-off-by: Zohaib
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/iochannel.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/iochannel.h
b/drivers
From: Sameer Wadgaonkar
The VSWITCH channel is not used in Linux guests, so remove the VERSIONID.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/iochannel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a
From: Zohaib
Leading comment changed to follow surrounding convention.
Signed-off-by: Zohaib
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
From: Zachary Dremann
The name of a visor_device was never freed, which was allocated in
visorbus_configure.
It is expected that visorbus_device_destroy will not be called on the
same visor_device again, or this would be a double free.
Signed-off-by: Zachary Dremann
Signed-off-by: David
From: Sameer Wadgaonkar
Moved the function visor_check_channel() from include/channel.h to
visorbus/visorbus_main.c.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/channel.h | 55 +---
drivers
From: Erik Arfvidson
In the function handle_command, the variable local_addr is always false. So
this patch is getting rid of logic when it is true.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 43
From: Mark Foresta
Moved /* to own line at beginning of struct visor_vbus_deviceinfo to follow
standard.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/vbuschannel.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
From: Erik Arfvidson
This patch simply removes TARGET_HOSTNAME comment that is no
longer relevant.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_private.h | 4
1 file changed, 4 deletions(-)
diff
From: Zohaib
Added a new line before issue_vmcall_io_controlvm_addr() function
definition.
Signed-off-by: Zohaib
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging
From: Mark Foresta
Removed unused #define CURRENT_FILE_PC.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus
From: Mark Foresta
Removed blank line between #defines.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
From: Mark Foresta
Removed 4 unneeded includes netdevice, nls, fs, and ctype.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys
From: Charles Daniels
Fixed incorrect function definition style in visorhba/visorhba_main.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorhba
From: Charles Daniels
Fixed incorrect function declaration style in visornic/visornic_main.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visornic
From: Charles Daniels
Fixed incorrectly styled function definitions in visorbus/visorchipset.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus
From: Charles Daniels
Fixed incorrect function definition style in visorbus/visorchannel.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchannel.c
From: Sameer Wadgaonkar
Cleaned up the in-line comments in the structure and added a
kernel-doc like comment for the structure.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visornic/visornic_main.c | 86
The define CURRENT_FILE_PC was not being used, so just remove it.
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging
From: Charles Daniels
Replaced the one and only call to COVER in iochannel.h.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/channel.h | 4
drivers/staging/unisys/include/iochannel.h | 2 +-
2 files changed, 1
From: Alex Curtin
VISOR_VBUS_CHANNEL_SIGNATURE just pointed to VISOR_CHANNEL_SIGNATURE, so
this replaces the redundant definition with VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus
From: Sameer Wadgaonkar
This patch makes function definitions more consistent by having function
name and return values on the same line.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.c | 131
From: Sameer Wadgaonkar
The VISOR_VNIC_CHANNEL_OK_CLIENT and VISOR_HBA_CHANNEL_OK_CLIENT macros
were not being used. They can be removed.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/iochannel.h | 12
From: Mark Foresta
Placed /* on line 1 alone rather than start comment.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_private.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
From: Sameer Wadgaonkar
Remove check for xbus in typename_show() function in
visorbus_main.c.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Sameer Wadgaonkar
Removed checks for dev->visorchannel in visorbus_release_device()
and visorbus_remove_instance() since it is also checked in the
visorchannel_destroy() function.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
driv
From: Charles Daniels
Fixed incorrect function declaration style in visorinput/visorinput.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorinput/visorinput.c
From: Erik Arfvidson
Rename fix_vbus_dev_info to something clearer: publish_vbus_dev_info.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorbus_main.c | 15 +++
1 file changed, 7 insertions(+), 8
From: Alex Curtin
VISOR_VSWITCH_CHANNEL_SIGNATURE is a redundant definition that points to
VISOR_CHANNEL_SIGNATURE. It wasn't being used, so it has been removed.
Signed-off-by: Alex Curtin
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/include/iochan
From: Stephen Hemminger
Date: Wed, 19 Jul 2017 11:53:11 -0700
> These fix sparse and lockdep warnings from netvsc driver.
> Targeting these at net-next since no actual related failures
> have been observed in non-debug kernels.
Series applied, thanks Stephen.
A few local functions in the pi433 module were getting flagged by Sparse
for missing declarations, so I added static qualifiers to clean up the
warnings.
Signed-off-by: David Wittman
---
drivers/staging/pi433/pi433_if.c | 4 ++--
drivers/staging/pi433/rf69.c | 2 +-
2 files changed, 3
From: kbuild test robot
Date: Sat, 22 Jul 2017 02:54:43 +0800
> drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: 9749fed5d43d ("netv
From: Stephen Hemminger
Date: Mon, 24 Jul 2017 16:21:57 -0700
> On Mon, 24 Jul 2017 16:20:28 -0700 (PDT)
> David Miller wrote:
>
>> From: kbuild test robot
>> Date: Sat, 22 Jul 2017 02:54:43 +0800
>>
>> > drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNIN
From: Stephen Hemminger
Date: Mon, 24 Jul 2017 10:57:24 -0700
> This fixes fallout from previous patch related to RTNL and RCU
> annotaiton. Also one patch sent to wrong list.
Series applied, thanks.
___
devel mailing list
de...@linuxdriverproject.org
From: Stephen Hemminger
Date: Mon, 24 Jul 2017 21:03:19 -0700
> The logic for computing page buffer scatter does not take into
> account the impact of compound pages. Therefore the optimization
> to compute number of slots was incorrect and could cause stack
> corruption a skb was sent with lots
From: Stephen Hemminger
Date: Wed, 26 Jul 2017 16:40:19 -0700
> The next group of patches aims to reduce the driver memory footprint
> by reducing the size of the per-device receive and send buffers, and
> the per-channel receive completion queue.
Sorry Stephen, I have to draw the line with thos
From: Stephen Hemminger
Date: Fri, 28 Jul 2017 08:59:40 -0700
> This is a subset of earlier submission with a few more fixes
> found during testing. The are two small optimizations, one is to
> better manage the receive completion ring, and the other is removing
> one unneeded level of indirectio
From: Zohaib Javed
Added a new line before issue_vmcall_io_controlvm_addr() function
definition.
Signed-off-by: Zohaib Javed
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 1 +
1 file changed, 1 insertion
asterisk from the first line.
Charles Daniels (1):
staging: unisys: visorbus: fix multi-line function definition
David Binder (10):
staging: unisys: visorbus: Merge vmcallinterface.h into visorchipset.c
staging: unisys: visorbus: Remove unnecessary comments
staging: unisys: visorbus
From: Charles Daniels
Fixed incorrectly styled function definitions in visorbus/visorchipset.c
by placing the function names on the same line as the return.
Signed-off-by: Charles Daniels
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging
From: David Binder
Removes comments that do not provide any valuable information.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff
From: David Binder
The contents of vmcallinterface.h are better placed within
visorchipset.c from an organizational perspective. The values are only
used in that file.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus
Cleaned up some #defines to make the beginning of the file read easier.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers
The kernel already provides a min function, we should be using that
instead of creating our own MINNUM.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 3 ---
drivers/staging/unisys/visornic
From: Sameer Wadgaonkar
The functions viosrbus_device_pause_response() and
viosrbus_device_resume_response() are functionally similar.
Merging these functions into a single function called
visorbus_device_changestate_response().
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
The MAXNUM #define was not being used, and it shouldn't be used.
Remove it.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/in
The vdisk task management commands are no longer used by s-Par, this
patch removes the definitions for them.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 32 +---
1 file changed, 32
-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/visorbus/visorbus_private.h
b/drivers/staging/unisys/visorbus/visorbus_private.h
index ef4a987..64b373c 100644
--- a/drivers
From: Mark Foresta
Moved blocked comment on to own line at beginning of struct to follow
standard. Since this is an internal structure, the block comment isn't
actually a kernel-doc so we only start the block with one asterisk.
Signed-off-by: Mark Foresta
Signed-off-by: David Ker
The iochannel.h header file references ETH_HLEN which is defined in
skbuff. Removed it from visorhba since it was no longer needed.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 1 +
drivers/staging
Instead of including it in the global channel.h, move the VNIC GUID to the
visornic module.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h| 7 ---
drivers/staging/unisys/visornic/visornic_main.c | 8
From: Zohaib Javed
The filename was in a comment at the beginning of the file. It is not
needed.
Signed-off-by: Zohaib Javed
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file changed, 1 insertion
From: Sameer Wadgaonkar
This patch fixes two checkpatch warnings in the visornic_main.c
file to avoid multiline dereference.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 9 -
1 file
Visorchipset.c was including unnecessary include files, either included by
other headers or not needed at all.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1 file changed, 2 deletions(-)
diff
From: Sameer Wadgaonkar
Cleaned up the in-line comments in the structure and added a single block
comment for the structure.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c
From: Mark Foresta
Remove the filename in the comment at the beginning of the file.
Signed-off-by: Mark Foresta
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 3 +--
1 file changed, 1 insertion(+), 2
: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 10 ++--
drivers/staging/unisys/visorbus/visorbus_private.h | 5 +--
drivers/staging/unisys/visorbus/visorchipset.c | 41 +--
3 files changed, 10 insertions
The struct visor_device had a forward declaration that was not needed.
Remove it.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include
Don't store it in a local variable but reference it from the
visor_device.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/dr
Cleanups caused us to not need to include a bunch of headers, got rid of
them.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys
, and so using the standard version creates an
unnecessary dependency between the kernel and s-Par.
Signed-off-by: Steven Matthews
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 15 --
drivers/staging/unisys/visorhba
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
We no longer send messages directly to the s-Par event log, so we do not
need the throttling defines anymore.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 17 -
1 file changed, 17 deletions
A bunch of code churn has caused the following include files to not be
needed by visorbus.h:
linux/poll.h
linux/kernel.h
linux/uuid.h
linux/seq_file.h
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 4
1
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include
From: David Binder
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
From: Sameer Wadgaonkar
The function visorchipset_bus_destroy just called viosrbus_remove_instance,
we can just combine it with visorbus_remove_instance.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c
Greg noticed that we were creating our own attribute groups, instead of
using the ATTRIBUTE_GROUPS macro, this patch fixes our mistake.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 33
Do the check with the values in the structure instead of copying them to
local variables.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
From: David Binder
Adds the proper Unisys copyright statement to the top of iochannel.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 18 --
1 file changed, 16 insertions(+), 2 deletions
Referencing a SegmentIndex doesn't make sense in the Linux drivers, get rid
of the comment.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/dr
1401 - 1500 of 1852 matches
Mail list logo
