On 04.09.2018 09:39, Ajay Singh wrote:
> Refactor the wilc_netdev_init() to cleanup the memory for error
> scenario and remove unnecessary 'dev' pointer check.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/linux_wlan.c | 36
> ---
> drivers/st
he workqueue flush and destroy calls.
>
> Detected by CoverityScan, CID#1473305 ("Dereference after null check")
>
> Fixes: b3ee105c332e ("staging: wilc1000: refactor code to move initilization
> in wilc_netdev_init()")
> Signed-off-by: Colin Ian King
Review
Hi Aditya,
My problem is fixed with this patch. WILC1000 connects to AP,
IP is retrieved from DHCP server and ping works. You can add my
Tested-by: Claudiu Beznea
Thanks,
Claudiu
On 03.11.2017 10:56, Aditya Shankar wrote:
> Commit 46949b48568b ("staging: wilc1000: New cfg packet
>
Hi Aditya,
On 01.12.2017 22:27, Aditya Shankar wrote:
> This commit fixes below style problems in multiple lines
> Fix checkpatch WARNING: line over 80 characters
> Fix CHECK: Lines should not end with a '('
You should fix only one issue per patch. Would be better to have
a patch with "line over 8
For this series:
Reviewed-by: Claudiu Beznea
On 26.06.2018 09:07, Ajay Singh wrote:
> The current patch series contains changes to address TODO item [1].
>
> [1]. Move handling for each individual members of 'union message_body' out
> into a separate 'struct work_st
Reviewed-by: Claudiu Beznea
On 19.06.2018 21:44, Thibaut Robert wrote:
> Use structs ethhdr, iphdr and tcphdr instead of manual parsing in
> tcp_process.
> This commit fix handling of ip packets containing options.
> It also fixes the following sparse warning:
>
> driver
Reviewed-by: Claudiu Beznea
On 19.07.2018 01:44, Ajay Singh wrote:
> This patch series contains modification to follow Linux coding style &
> cleanup change to remove unused variables and enums.
> Few patches also contain changes to remove unnecessary typecast.
>
> Ajay Sing
Reviewed-by: Claudiu Beznea
On 20.07.2018 15:01, Ajay Singh wrote:
> This patch series contains changes mainly related to make use of
> descriptor-based interface instead of integer-based interface for GPIO.
> Modified the compatible string to use 'microchip' instead of &#x
Hi Ajay,
Few comments on this series. See per patch replies.
Thank you,
Claudiu Beznea
On 14.08.2018 09:49, Ajay Singh wrote:
> This patch set mainly contains changes to avoid the use of static
> and global variables. Also contains few patch to avoid the checkpatch
> warning arise du
On 14.08.2018 09:50, Ajay Singh wrote:
> Avoid use of static variable 'clients_count' and move it part of 'wilc'
> structure.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 9 -
> drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
> 2 files cha
On 14.08.2018 09:49, Ajay Singh wrote:
> Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' to
> 'wilc_vif' structure.
>
> Rename these variables like below
>
> wilc_during_ip_timer -> during_ip_timer
> wilc_optaining_ip -> obtaining_ip.
Is there any reason you choose to have
On 14.08.2018 09:50, Ajay Singh wrote:
> Instead of using 'wilc_multicast_mac_addr_list' as global variable move
> it part of wilc_vif struct. Rename 'wilc_multicast_mac_addr_list'
> variable to 'mc_mac_addr_list' as its now part of 'wilc_vif' struct.
>
> Signed-off-by: Ajay Singh
> ---
> dri
On 14.08.2018 09:50, Ajay Singh wrote:
> Avoid use of static variable and move it in 'wilc' structure related to
> hif and added NULL before accessing hif_workqueue in wilc_enqueue_work().
>
> Below variables are moved to 'wilc' struct:
> struct workqueue_struct *hif_workqueue;
> struct mutex
On 14.08.2018 09:50, Ajay Singh wrote:
> Remove the use of static variable 'terminated_handle' and instead move
> in wilc_vif struct.
> After moving this variable to wilc_vif struct its not required to keep
> 'terminated_handle', so changed it to boolean type.
You can remove it at all and use w
On 14.08.2018 09:50, Ajay Singh wrote:
> Cleanup patch to avoid line over 80 chars checkpatch issue introduced in
> previous code refactor commit.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wlan.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
On 14.08.2018 09:50, Ajay Singh wrote:
> Cleanup patch to avoid line over 80 chars issue reported by
> checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wlan.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/stagi
On 14.08.2018 09:50, Ajay Singh wrote:
> Move static variable 'wilc_connecting' as part of 'wilc_vif' private
> struct. Remove "wilc_" prefix from name as its already part of wilc_vif
> struct.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 4 ++--
>
On 14.08.2018 09:50, Ajay Singh wrote:
> Remove the use of unnecessary static variable 'p2p_listen_state'.
> Already 'p2p_listen_state' is present in 'wilc_priv' struct. So making
> use of that variable as its getting set in channel ready and
> remain on channel expired callback.
>
> Signed-off
On 23.08.2018 17:36, Ajay Singh wrote:
> On Thu, 23 Aug 2018 11:11:18 +0300
> Claudiu Beznea wrote:
>
>> On 14.08.2018 09:50, Ajay Singh wrote:
>>> Remove the use of static variable 'terminated_handle' and instead
>>> move in wilc_vif struct.
>&g
On 23.08.2018 13:09, Ajay Singh wrote:
> On Thu, 23 Aug 2018 11:11:09 +0300
> Claudiu Beznea wrote:
>
>> On 14.08.2018 09:50, Ajay Singh wrote:
>>> Avoid use of static variable and move it in 'wilc' structure
>>> related to hif and a
On 23.08.2018 12:43, Ajay Singh wrote:
> The idea was to keep private data related to 'wiphy priv'
> in 'wilc_priv' struct and 'netdev priv' related data in 'wilc_vif'
> struct.
OK, I see, agree!
___
devel mailing list
de...@linuxdriverproject.org
htt
On 23.08.2018 13:00, Ajay Singh wrote:
> Unless ndo_set_rx_mode() gets called quickly I don't think there is any
> issue here.
I don't agree with this.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailma
On 23.08.2018 13:33, Ajay Singh wrote:
> On Thu, 23 Aug 2018 11:12:08 +0300
> Claudiu Beznea wrote:
>
>> On 14.08.2018 09:50, Ajay Singh wrote:
>>> Cleanup patch to avoid line over 80 chars issue reported by
>>> checkpatch.pl script.
>>>
>>&
On 10.04.2018 17:49, Eyal Ilsar wrote:
> Remove unnecessary braces {} around an 'if' statement block with a single
> statement. Issue found by checkpatch.
You should add an empty line before "Signed-off" line as stated in [1]. I
would also add a space b/w your name and your email in Signed-off
On 12.04.2018 10:59, Eyal Ilsar wrote:
> Remove unnecessary braces {} around an 'if' statement block with a single
> statement. Issue found by checkpatch.
>
> Signed-off-by: Eyal Ilsar
Reviewed-by: Claudiu Beznea
> ---
> Added an empty line before the
Reviewed-by: Claudiu Beznea
On 12.04.2018 10:21, Ajay Singh wrote:
> Commit fe014d4e6b55 (staging: wilc1000: free memory allocated for general info
> message from firmware) introduced a bug by using wrong source address in
> kmemdup(). 'conn_info.req_ies' is used for source
Hi Ajay,
You can add:
Reviewed-by: Claudiu Beznea
On 23.04.2018 16:01, Ajay Singh wrote:
> On Mon, 23 Apr 2018 15:45:38 +0200
> Greg KH wrote:
>
>> On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote:
>>> This patch series is based on top of
>>> &quo
Reviewed-by: Claudiu Beznea
On 24.04.2018 19:07, Ajay Singh wrote:
> Updated the TODO list by removing items, which are already addressed.
> Also remove the code to handle IOCTL(SIOCSIWPRIV) as Wext support is
> not present in the driver.
>
> Ajay Singh (2):
> staging
Could you, please, change the "return 0;"s inside wilc_mac_xmit() with
"return NETDEV_TX_OK" ?
Thank you,
Claudiu
On 24.04.2018 15:18, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in
Hi Luc,
I'm resending this since last time I only send it to staging ml.
Could you, please, change the "return 0;"s inside wilc_mac_xmit() with
"return NETDEV_TX_OK" ?
Thank you,
Claudiu
On 24.04.2018 15:18, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'net
patch
"staging/wilc1000: fix wilc_mac_xmit()'s return type" so I will send a new
patch with only the "return NETDEV_TX_OK" changes.
And you can also add:
Reviewed-by: Claudiu Beznea
> {
> struct wilc_vif *vif;
> struct tx_complete_data *tx_data = NUL
On 07.05.2018 11:43, Ajay Singh wrote:
> Cleanup patch to have variable names as per linux coding style.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host
On 07.05.2018 11:43, Ajay Singh wrote:
> Added comments for mutex and spinlock_t to avoid checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.h | 2 +-
> drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++--
> 2 files changed, 4 insertions
On 07.05.2018 11:43, Ajay Singh wrote:
> Fix line over 80 characters issue reported by checkpatch in
> add_network_to_shadow() by using temporary variable.
I, personally, don't like this way of fixing line over 80. From my
point of view this introduces a new future patch. Maybe, in future,
someb
On 07.05.2018 11:43, Ajay Singh wrote:
> Fix line over 80 characters issues reported by checkpatch.pl script in
> wilc_wfi_cfg_tx_vendor_spec() by using temporary variable. Simplified
> 'if else' condition with 'if'.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgop
On 07.05.2018 11:43, Ajay Singh wrote:
> Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow().
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wil
On 07.05.2018 11:43, Ajay Singh wrote:
> Fix line over 80 characters issue in host_int_parse_assoc_resp_info() by
> using shorter name for the local variable.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 9 +
> 1 file changed, 5 insertions(+), 4 del
On 07.05.2018 11:43, Ajay Singh wrote:
> Split host_int_parse_join_bss_param() to avoid the line over 80
> character issue reported by checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 247
> --
> 1 file changed
On 07.05.2018 11:43, Ajay Singh wrote:
> Rename clear_duringIP() function to avoid camelCase issue reported by
> checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -
On 07.05.2018 11:43, Ajay Singh wrote:
> Fix line over 80 char issue in host_int_handle_disconnect() by using
> temp variable to hold the 'wilc_connect_result' function pointer.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 8
> 1 file changed, 4 in
On 07.05.2018 11:43, Ajay Singh wrote:
> Fix line over 80 characters issue reported by checkpatch.pl in
> host_int_parse_assoc_resp_info().
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 37
> ++-
> 1 file changed, 21 insertions(+
On 07.05.2018 11:43, Ajay Singh wrote:
> Fix checkpatch reported issue of line over 80 char in handle_key().
> Introduced new functions by spliting existing function to address the
> checkpatch issue.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 59
> +
On 09.05.2018 21:36, Ajay Singh wrote:
> On Wed, 9 May 2018 16:44:47 +0300
> Claudiu Beznea wrote:
>
>> On 07.05.2018 11:43, Ajay Singh wrote:
>>> Fix checkpatch reported issue of line over 80 char in handle_key().
>>> Introduced new functions by spliting exi
On 09.05.2018 21:42, Ajay Singh wrote:
> On Wed, 9 May 2018 16:43:14 +0300
> Claudiu Beznea wrote:
>
>> On 07.05.2018 11:43, Ajay Singh wrote:
>>> Fix line over 80 characters issue reported by checkpatch in
>>> add_network_to_shadow() by using temporary varia
On 09.05.2018 22:17, Ajay Singh wrote:
> On Wed, 9 May 2018 16:42:59 +0300
> Claudiu Beznea wrote:
>
>> On 07.05.2018 11:43, Ajay Singh wrote:
>>> Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow().
>>>
>>> Signed-off-by: Aja
Hi Ajay,
On 10.05.2018 08:27, Claudiu Beznea wrote:
>
>
> On 09.05.2018 21:42, Ajay Singh wrote:
>> On Wed, 9 May 2018 16:43:14 +0300
>> Claudiu Beznea wrote:
>>
>>> On 07.05.2018 11:43, Ajay Singh wrote:
>>>> Fix line ov
On 22.05.2018 19:49, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in netdev_err error message
>
> Signed-off-by: Colin Ian King
Reviewed-by: Claudiu Beznea
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file ch
Reviewed-by: Claudiu Beznea
On 04.06.2018 08:29, Ajay Singh wrote:
> Instead of having own linked list implementation to maintain buffer queue
> change
> to use list_head. Also removed the few elements from 'wilc' struct as it's not
> required to be part of '
This patch removes unnecessary "if (true)" check in update_BCNTIM()
from core/rtw_ap.c file. After this remove the code alignment was
necessary.
Signed-off-by: Claudiu Beznea
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 131
1 file changed, 64 inserti
This patch changes byVT3253InitTab_RFMD[] and byVT3253B0_RFMD[]
arrays in const arrays since these are not changed anywhere in the
code.
Signed-off-by: Claudiu Beznea
---
drivers/staging/vt6655/baseband.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
This patch defines oui_rfc1042[] and oui_8021h[] arrays from
p80211conv.c as const arrays since these are not changed
anywhere in code.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211conv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
This patch switch p80211_stt_findproto() to inline
function.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211conv.c | 2 +-
drivers/staging/wlan-ng/p80211conv.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211conv.c
b/drivers
This patch convert p80211_stt_findproto() to "static inline"
since it is used only in p80211conv.c file and also has
few instructins. After the scope was changed to static
the function definition was moved at the beginning of the
file to avoid undefined references.
Signed-off-by: Clau
This patch removes the prototype of p80211_stt_findproto()
from p80211conv.h since global scope is not necessary.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211conv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211conv.h
b/drivers/staging
This patch moves memset() calls from p80211netdev_ethtool()
after copy_from_user() call in order to avoid unnecessary
instruction in case copy_from_user() fails.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
This patch removes "goto " instructions which do only
a return. In this way, aditional instructions were removed.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/cfg80211.c | 112 +
1 file changed, 39 insertions(+), 73 deletions(-)
di
This patch covers wiphy_register() failures in wlan_create_wiphy()
from cfg80211.c by calling wiphy_free() for the correspondent
struct wiphy allocated structure.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/cfg80211.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
This patch removes the memcpy() for two variables which were
previously tested with memcmp(). The result of memcmp() was
zero which means that the previously tested variables were
already equal.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211conv.c | 1 -
1 file changed, 1
This patch convert usb_prism_tbl[] into a const array
since it is not modified anywhere in prism2usb.c file.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/prism2usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/prism2usb.c
b/drivers
This patch removes "next" member of wlandevice_t since it
is not used anywhere in the wlan-ng code.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211netdev.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.h
b/drivers/stagi
two.
Signed-off-by: Claudiu Beznea
---
drivers/staging/vt6655/baseband.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c
b/drivers/staging/vt6655/baseband.c
index 1e6c0c4..ff43393 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b
This patch defines region_configs[] array as const array since it
is not changed anywhere in code.
Signed-off-by: Claudiu Beznea
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b
done, in order to use the same return path,
"return x" instuctions were replaced with "goto" instuctions.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/prism2fw.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/
done, in order to use the same return path,
"return x" instuctions were replaced with "goto" instuctions.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/prism2fw.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/
This patch frees memory allocated inside wilc_wlan_txq_add_cfg_pkt()
in case wilc_wlan_txq_add_to_head() fails.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wilc1000/wilc_wlan.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b
Hi all,
I'm new to this mailing list. I'm a programmer who wants to start
doing stuff in kernel side of the world. I have read LDD and research
over the internet for understanding of linux kernel concepts. I
want to ask a question: are there any driver projects here, opened or
new, in which a begi
This is a patch to the octeon-hcd.c file that fixes up block comments
warning found by checkpatch.pl tool
Signed-off-by: Claudiu Beznea
---
drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b
This patch tries to improve a part of the code from
rtl8712_led.c by removing duplicates condition checks.
Signed-off-by: Claudiu Beznea
---
drivers/staging/rtl8712/rtl8712_led.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers
This patch fix "line over 80 characters" checkpatch.pl
warnings. In cfg80211.c file some of these warnings
were fixed by adding duplicate code in a separate
function.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/cfg80211.c | 148 ---
This patch removes unused code from wlan-ng driver.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211types.h | 43 ---
1 file changed, 43 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211types.h
b/drivers/staging/wlan-ng/p80211types.h
This patch improves code from p80211req.c file by removing
duplicate code, by keeping count of returning code of
the called functions and also aesthetically.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211req.c | 163 +++-
1 file changed, 84
s bits representing
the DID item number. To get this item number use P80211DID_ITEM().
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211req.c | 28 +---
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211req.c
b/drivers/s
This patch removes duplicate code in p80211req_mibset_mibget()
by adding p80211req_handle_action() function.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211req.c | 41 +++--
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers
This patch removes duplicate code in p80211req_mibset_mibget()
by adding p80211req_handle_action() function.
Changes since v1:
Removed prototype of p80211req_handle_action() from the prototype
list and add directly the function definition.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan
This patch removes multiple switch-case statements
with a new macro. The macro will generate the
corresponding bit mask based on the key index
received as input.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/cfg80211.c | 85 ++---
drivers/staging
This patch removes multiple switch-case statements
with a new macro. The macro will generate the
corresponding bit mask based on the key index
received as input.
Chances since v1:
Corrected patch title
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/cfg80211.c | 85
I will do it soon.
Thanks,
Claudiu
On Fri, Aug 26, 2016 at 9:07 PM, Joe Perches wrote:
> On Fri, 2016-08-26 at 20:58 +0300, Claudiu Beznea wrote:
>> This patch removes multiple switch-case statements
>> with a new macro. The macro will generate the
>> corresponding bit
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey2
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers
This patchset removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey<#>
and uses the new macro DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Claudiu Beznea (5):
Staging: wlan-ng: uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
macro inst
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey0
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers
This patch changes definition of
DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable instead of
using directly (P80211DID_MKSECTION(1) | P80211DID_MKGROUP(4)).
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 3 +--
1
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey1
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey3
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers
: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211req.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211req.c
b/drivers/staging/wlan-ng/p80211req.c
index 5c2b801..fe5bf4b 100644
--- a/drivers/staging/wlan-ng
Hi Ajay,
Just a little note for your future patches: all changes history would
be good to be kept here, something like this:
changes in v3: this, this and this
changes in v2: this and this
Thanks,
Claudiu
On 11.01.2018 16:12, Ajay Singh wrote:
> Changes since v2: Removed v2 patch number 3,4,5
On 18.01.2018 15:17, Ajay Singh wrote:
> fix "Avoid camelCase" issue found by checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 104
> ++
> 1 file changed, 49 insertions(+), 55 deletions(-)
>
> diff --git a/dri
It is hard to review this. Anyway, Reviewed-by: Claudiu Beznea
On 18.01.2018 15:17, Ajay Singh wrote:
> fix "Avoid CamelCase:" issue reported by checkpatch.pl script
> Rename host_int_ParseJoinBssParam() & its variables name using
> camelCase.
>
> Signed-off-by:
On 18.01.2018 15:17, Ajay Singh wrote:
> fix "Avoid camelCase" issue reported by checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 78
> +++
> 1 file changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/
On 18.01.2018 15:17, Ajay Singh wrote:
> fix "Avoid camelCase" issue reported by checkpatch.pl script.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/st
All series Reviewed-by: Claudiu Beznea
with the inline comments.
Ajay, one general remark, please use Capital letters when beginning new
sentences (I'm talking about commit descriptions).
Thanks,
Claudiu Beznea
On 18.01.2018 15:16, Ajay Singh wrote:
> This patch series contains change
On 19.01.2018 14:44, Dan Carpenter wrote:
> On Fri, Jan 19, 2018 at 01:20:00PM +0200, Claudiu Beznea wrote:
>> It is hard to review this. Anyway, Reviewed-by: Claudiu Beznea
>>
>>
>
> I have a script I use. It's sort of hacky, but it's a time saver. I&
On 22.01.2018 12:22, Ajay Singh wrote:
> Fix "Avoid camelCase" issue reported by checkpatch.pl
> script.
Same here as in patch 02 of this series.
>
> Signed-off-by: Ajay Singh
> Reviewed-by: Claudiu Beznea
> ---
> drivers/staging/wilc1000/host_interface.c
On 22.01.2018 12:22, Ajay Singh wrote:
> Fix "Avoid CamelCase:" issue reported by checkpatch.pl script
Forgot a dot here?
> Rename host_int_ParseJoinBssParam() & its variables name using
> camelCase.
>
> Signed-off-by: Ajay Singh
> Reviewed-by: Claudiu Beznea
&
le line instead of using two lines.
> * Patch0010: Used "bss_param" for variable name instead of j_bss_param.
> * Added "Reviewed-by: Claudiu Beznea " for
> commit description.
> * Modify the commit description to start with capital letter for all patch.
You
On 22.01.2018 13:10, Claudiu Beznea wrote:
>
>
> On 22.01.2018 12:22, Ajay Singh wrote:
>> This patch series contains changes to fix issues reported by checkpatch.pl
>> script.
>>
>> Changes since v1:
>> * Patch0004: Used "host_int_parse_join_bss_p
olumns.
> Signed-off-by: Ajay Singh
> Reviewed-by: Claudiu Beznea
> ---
> drivers/staging/wilc1000/wilc_wlan_if.h | 72
> -
> 1 file changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
&g
On 22.01.2018 12:22, Ajay Singh wrote:
> Fix "Avoid camelcase" issue found by checkpatch.pl
> script.
>
Same here as in patch 02 of this series.
> Signed-off-by: Ajay Singh
> Reviewed-by: Claudiu Beznea
> ---
> drivers/staging/wilc1000/host_interface.
On 22.01.2018 13:22, Dan Carpenter wrote:
> On Mon, Jan 22, 2018 at 01:06:59PM +0200, Claudiu Beznea wrote:
>>
>>
>> On 22.01.2018 12:22, Ajay Singh wrote:
>>> Fix the "do not add new typedefs" issue found by checkpatch.pl
>>> script
>>
My comments to this series were only notes to be taken
into account for future patches.
Thank you,
Claudiu Beznea
On 22.01.2018 12:22, Ajay Singh wrote:
> This patch series contains changes to fix issues reported by checkpatch.pl
> script.
>
> Changes since v1:
> *
Hi Ajay,
Even I cannot locate something in Documentation/CodingStyle related to single
line comment, I prefer to use:
/* comment */
instead of:
/*
* comment
*/
Do as you wish!
Thank you,
Claudiu
On 14.02.2018 13:10, Ajay Singh wrote:
> diff --git a/drivers/staging/wilc1000/wilc_spi.c
> b/dr
1 - 100 of 118 matches
Mail list logo
