Okash Khawaja writes:
> Finally there is an issue where text in output buffer sometimes gets
> garbled on SMP systems, but we can continue working on it after the
> driver is moved out of staging, if that's okay. Basically we need a
> reproducer of this issue.
What kind of reproducer do you need
Gregory Nowak writes:
> keymap
> I believe this is the currently active kernel keymap. I'm not sure of
> the format, probably what dumpkeys(1) and showkey(1) use. Echoing
> different values here should allow for remapping speakup's review
> commands besides remapping the keyboard as a whole.
AFA
ngs.
> synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are
> however added to put 16bit characters and strings.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Looks good to me.
___
devel m
e Linux only supports 16bit characters,
> we can just hardcode the UTF-8 encoding.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Looks good to me.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject
t; VC. This fixes by just turning the use_unicode parameter to 1.
>
> Signed-off-by: Samuel Thibault
> Tested-by: Zahari Yurukov
Reviewed-by: Chris Brannon
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Samuel Thibault writes:
> This supports spelling unicode characters by just passing them to
> the speech synthesis in direct mode.
>
> Signed-off-by: Samuel Thibault
>
> Index: linux-4.10/drivers/staging/speakup/main.c
> ===
> --- l
Samuel Thibault writes:
> commit 33590c185299 ("speakup: Support spelling unicode characters")
> mistakenly passed unicode characters to IS_CHAR(), which only
> supports latin1. Let's assume non-latin1 is lower case, like is done
> in spell_word().
Samuel Thibault writes:
> This supports spelling unicode characters by just passing them to
> the speech synthesis in direct mode.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
___
devel mailing list
de...@linuxdriverproj
Markus Mayer writes:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
> Acked-by: Samuel Thibault
Acked-by: Chris Brannon
Haven't looked at much kernel code in a while, but this l
Walt Feasel writes:
> Modified email address per the TODO file in
> speakup's email listing, also verified email
> address from speakup's website
NAK. The website needs updating, because it has Kirk's old addresses.
k...@reisers.ca is correct.
___
dev
Walt Feasel writes:
> Make email correction for k...@reisers.ca
>
> Signed-off-by: Walt Feasel
Acked-by: Chris Brannon
> ---
> v2 makes changes to correct for email format patch submission
>
> drivers/staging/speakup/TODO | 2 +-
> 1 file changed, 1 insertion(+)
Aleksei Fedotov writes:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Aleksey Fedotov
Acked-by: Chris Brannon
Seems fine t
Raphael S Carvalho writes:
> Wouldn't the following code (right before the statement: if
> (param->var_id == VOICE))
> check if value is out of range?
>
> value = simple_strtol(cp, NULL, 10);
> ret = spk_set_num_var(value, param, len);
> if (ret == -ERANGE) {
> var_data = param->data;
> pr_warn(
"Raphael S.Carvalho" writes:
> + /*
> + * If voice was just changed, we might need to reset our default
> + * pitch and volume.
> + */
> + if (param->var_id == VOICE) {
> + spk_reset_default_value("pitch", synth->defa
Dan Carpenter writes:
> Good eye for spotting the memory corruption bug!
>
> This is a bug fix, so the fix should go in a separate patch and not
> merged with a code cleanup patch. Ordinary users can trigger this so
> it's a security bug and separating it out is extra important.
Ok. I just sen
15 matches
Mail list logo
