[PATCH v2 11/15] staging: iio: isl29028: remove unnecessary parenthesis

isl29028_write_raw() contains unnecessary parenthesis when checking to see if the passed in lux scale is valid. This patch removes the unnecessary parenthesis. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 14/15] staging: iio: isl29028: only set ALS scale when ALS/IR sensing is enabled

stage for faster resume times from runtime power management if the user is only querying the proximity sensor. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b

[PATCH v2 15/15] staging: iio: isl29028: add runtime power management support

renames that function to isl29028_clear_configure_reg() since it is now used in several places. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 118 --- 1 file changed, 110 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/light

[PATCH v2 13/15] staging: iio: isl29028: only set proximity sampling rate when proximity is enabled

stage for faster resume times from the runtime power management if the user is only querying the ALS/IR sensor. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b

[PATCH v2 10/15] staging: iio: isl29028: remove out of memory log message

ssary. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index be1fc4a..e93077b 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/dr

[PATCH v2 04/15] staging: iio: isl29028: change newlines to improve readability

Add and remove newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH v2 05/15] staging: iio: isl29028: remove unused define ISL29028_DEV_ATTR

The #define ISL29028_DEV_ATTR was not used so this patch removes the unnecessary code. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index

Re: [PATCH v2 15/15] staging: iio: isl29028: add runtime power management support

On Sat, Jan 21, 2017 at 02:58:12PM +, Jonathan Cameron wrote: > On 17/01/17 09:25, Brian Masney wrote: > > This patch adds runtime power management support to the isl29028 driver. > > It defaults to powering off the device after two second

[PATCH 4/7] staging: iio: isl29028: use the runtime power management for system sleep

resume to go through the runtime power management. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index b63fdf70..ddd604d 10

[PATCH 3/7] staging: iio: isl29028: fix incorrect sampling frequency value

instead of the expected 400ms value. This patch changes the 3 supported sampling frequency to 2 so that the proximity sleep time of 400ms can be used. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/7] staging: iio: isl29028: fix incorrect sleep time when taking initial proximity reading

When proximity is enabled in isl29028_enable_proximity(), the function msleep() is called with the sampling frequency, which is not correct. This patch changes the code to sleep the specified amount of time listed in the datasheet instead. Signed-off-by: Brian Masney --- drivers/staging/iio

[PATCH 1/7] staging: iio: isl29028: change mdelay() to msleep()

This driver in some cases can busy wait for upwards of 100 ms. Since the kernel at this point is not running in atomic context, and is running in process context, we can safely use msleep() instead. This patch changes the two occurrences of mdelay() to msleep(). Signed-off-by: Brian Masney

[PATCH 7/7] staging: iio: isl29028: move out of staging

Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. Signed-off-by: Brian Masney --- drivers/iio/light/Kconfig | 10 ++ drivers/iio/light/Makefile | 1 + drivers/{staging => }/iio/light/isl29028.c | 0 drivers/staging/iio/li

[PATCH 5/7] staging: iio: isl29028: add copyright

Add Brian Masney's copyright to the header for the several rounds of staging cleanups that has been done to this driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/light/isl29028.c b/dr

[PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available

Add entry for the in_proximity_sampling_frequency_available sysfs entry to the existing sampling_frequency_available ABI documentation. Signed-off-by: Brian Masney --- Documentation/ABI/testing/sysfs-bus-iio | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/ABI/testing/sysfs-bus

[PATCH 0/7] iio: isl29028: move out of staging

creen that the IR LED turns on for two seconds when the proximity sensing feature is enabled. Brian Masney (7): staging: iio: isl29028: change mdelay() to msleep() staging: iio: isl29028: fix incorrect sleep time when taking proximity reading staging: iio: isl29028: fix incorrect sam

[PATCH v2 0/2] staging: iio: isl29028: move out of staging

This is hopefully the last of the changes that are needed to move this driver out of staging. Datasheet: http://www.intersil.com/content/dam/Intersil/documents/isl2/isl29028.pdf Changes since v1: - in_proximity_sampling_frequency_available sysfs attribute now shows decimals. Brian Masney (2

[PATCH v2 2/2] staging: iio: isl29028: move out of staging

Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. Signed-off-by: Brian Masney --- drivers/iio/light/Kconfig | 10 ++ drivers/iio/light/Makefile | 1 + drivers/{staging => }/iio/light/isl29028.c | 0 drivers/staging/iio/li

[PATCH v2 1/2] staging: iio: isl29028: change sampling frequencies available to use decimals

will still be selected. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 5375e7a..c1d6540 100644 --- a/drivers/staging/iio

Re: [PATCH v2 2/2] staging: iio: isl29028: move out of staging

On Sun, Feb 12, 2017 at 05:55:34AM -0500, Brian Masney wrote: > Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. > > Signed-off-by: Brian Masney Sorry, Jonathan, I forgot to run git format-patch with --no-renames and didn't realize until the emails went out.

[PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

Address warning from checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light

[PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address

Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian M

[PATCH 2/3] staging: iio: isl29018: made error handling consistent

function. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c index ad282f1..0a35588 100644 --- a/drivers/staging/iio/light

[PATCH 1/3] staging: iio: isl29018: remove unused variable and defines

Removes unused variable and associated #defines that was found using make W=1. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c index

[PATCH 3/3] staging: iio: isl29018: fix comparison between signed and unsigned integers

Fixes warning found by make W=2: warning: comparison between signed and unsigned integer expressions Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b

[PATCH 1/2] include: linux: iio: add IIO_DEVICE_ATTR_{RO, WO, RW} macros

: Brian Masney --- include/linux/iio/sysfs.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/iio/sysfs.h b/include/linux/iio/sysfs.h index 9cd8f74..f7c6431 100644 --- a/include/linux/iio/sysfs.h +++ b/include/linux/iio/sysfs.h @@ -59,6 +59,19 @@ struct iio_const_attr

[PATCH 2/2] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, RW} macros

Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to create the device attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/light

[PATCH v2 2/2] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, RW} macros

Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to create the device attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/light

[PATCH v2 1/2] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros

include/linux/sysfs.h. Signed-off-by: Brian Masney --- include/linux/iio/sysfs.h | 24 1 file changed, 24 insertions(+) diff --git a/include/linux/iio/sysfs.h b/include/linux/iio/sysfs.h index 9cd8f74..ce9426c 100644 --- a/include/linux/iio/sysfs.h +++ b/include/linux/iio

[PATCH v3 4/5] staging: iio: isl29018: change isl29018_read_raw() to only have one exit point

When the chip is in a suspended state, isl29018_read_raw() will return -EBUSY. Change the function so that it only has a single exit point. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 1/5] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros

include/linux/sysfs.h. Signed-off-by: Brian Masney --- This is the same version of this patch that I sent out on Sunday. I am resending the patch set since my the second patch in that series would not apply cleanly to iio.git/testing. include/linux/iio/sysfs.h | 24 1 file

[PATCH v3 5/5] staging: iio: isl29018: check if the chip is in a suspended state

Add a check to isl29018_write_raw() to ensure that the chip is not in a suspended state. This makes the code consistent with what is present in isl29018_read_raw(). Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH v3 2/5] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, RW} macros

Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to create the device attributes. Signed-off-by: Brian Masney --- This version of the patch now applies cleanly to the iio.git/testing branch. drivers/staging/iio/light/isl29018.c | 33 +++-- 1 file changed, 15

[PATCH v3 3/5] staging: iio: isl29018: fixed race condition in in_illuminance_scale_available_show()

raw() locks a mutex specific to this driver when the integration time variable is updated. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c index 19f2

Re: [PATCH v3 5/5] staging: iio: isl29018: check if the chip is in a suspended state

On Sat, Oct 01, 2016 at 02:59:49PM +0100, Jonathan Cameron wrote: > On 27/09/16 01:20, Brian Masney wrote: > > Add a check to isl29018_write_raw() to ensure that the chip is not in a > > suspended state. This makes the code consistent with what is present > >

[PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression

Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012) about the infrared suppression that can be controlled with the proximity_on_chip_ambient_infrared_suppression sysfs attribute. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 18 ++ 1

[PATCH 3/4] staging: iio: isl29018: rename Kconfig variable to match existing light drivers in mainline.

Rename CONFIG_SENSORS_ISL29018 to CONFIG_ISL29018 for consistency with the other light drivers in mainline. Signed-off-by: Brian Masney --- drivers/staging/iio/light/Kconfig | 2 +- drivers/staging/iio/light/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 4/4] staging: iio: isl29018: move out of staging

Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. Signed-off-by: Brian Masney --- drivers/iio/light/Kconfig| 12 + drivers/iio/light/Makefile | 1 + drivers/iio/light/isl29018.c | 847 +++ drivers/staging/iio

[PATCH 2/4] staging: iio: isl29018: document device tree bindings

RNING: DT compatible string "isil,isl29035" appears un-documented -- check ./Documentation/devicetree/bindings/ Signed-off-by: Brian Masney --- .../devicetree/bindings/iio/light/isl29018.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

On Sun, Oct 09, 2016 at 10:45:12AM +0100, Jonathan Cameron wrote: > On 07/10/16 01:48, Brian Masney wrote: > > Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. > > > > Signed-off-by: Brian Masney > Time for a nitpick tastic review ;) > > The n

[PATCH v2 1/8] staging: iio: isl29018: add newlines to improve readability

Add newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018

[PATCH v2 4/8] staging: iio: isl29018: combine two return statements into one

Use the return value from isl29018_set_integration_time() as the return value for isl29018_chip_init() since this is the last piece of work inside that function. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH v2 3/8] staging: iio: isl29018: fix multiline comment syntax

Change multiline comments from: /* line1 * line2 * ... */ to /* * line1 * line2 * ... */ Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers

[PATCH v2 0/8] staging: iio: isl29018: move out of staging

This is a series of cleanup patches to the ISL29018/ISL29023/ISL29035 driver to move it out of staging based on feedback from Jonathan Cameron. Brian Masney (8): staging: iio: isl29018: add newlines to improve readability staging: iio: isl29018: remove poorly named function staging: iio

[PATCH v2 2/8] staging: iio: isl29018: fix poorly named function

isl29035_detect() did not do chip detection. Move functionality directly into isl29018_chip_init() to avoid naming confusion. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 44 1 file changed, 19 insertions(+), 25 deletions(-) diff

[PATCH v2 6/8] staging: iio: isl29018: rename description in Kconfig for consistency

Rename description from "ISL 29018" to "Intersil 29018" in Kconfig for consistency with other drivers in mainline. Signed-off-by: Brian Masney --- drivers/staging/iio/light/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/ligh

[PATCH v2 8/8] staging: iio: isl29018: move out of staging

Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. Signed-off-by: Brian Masney --- drivers/iio/light/Kconfig| 12 + drivers/iio/light/Makefile | 1 + drivers/iio/light/isl29018.c | 847 +++ drivers/staging/iio

[PATCH v2 5/8] staging: iio: isl29018: remove blank line for consistency

Remove blank line between MODULE_DEVICE_TABLE() and its corresponding structure for consistency with the other device table entries. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29018.c b

[PATCH v2 7/8] staging: iio: isl29018: add ABI documentation for infrared suppression

Add ABI documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012) about the infrared suppression that can be controlled with the proximity_on_chip_ambient_infrared_suppression sysfs attribute. Signed-off-by: Brian Masney --- .../ABI/testing/sysfs-bus-iio-light-isl29018 | 19

Re: [PATCH v2 8/8] staging: iio: isl29018: move out of staging

On Sat, Oct 15, 2016 at 04:15:57PM +0100, Jonathan Cameron wrote: > On 10/10/16 08:20, Brian Masney wrote: > > Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. > > > > Signed-off-by: Brian Masney > Applied to the togreg branch of iio.git and pushed

[PATCH 7/7] iio: light: tsl2583: fix concurrency issue in taos_get_lux()

ith mutex_lock(). Signed-off-by: Brian Masney --- This is the most controversial change in my patch set. There are two other possible solutions that I could envision to work around this issue: 1) Return -EBUSY and make the caller responsible for backing off 2) Change this driver to use RCU instead

[PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

The return values from taos_chip_on() and taos_chip_off() was not checked in several places. This patch adds proper error checking to these function calls. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 25 ++--- 1 file changed, 18 insertions(+), 7

[PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

The sysfs attributes modifies variables that are accessed elsewhere when a mutex is locked. Add locking to the sysfs *_store() functions to avoid a possible race condition when measurements are taken. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 24

[PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

Change the following functions to only have a single exit point: taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), taos_gain_store(), taos_gain_available_show(), taos_luxtable_store() and taos_probe(). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 96

[PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO macros to create the device attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 117 ++-- 1 file changed, 57 insertions(+), 60 deletions(-) diff --git a/drivers

[PATCH 1/7] iio: light: tsl2583: return proper error code

taos_gain_store() and taos_als_calibrate() both have a code path where -1 was returned. This patch changes the code so that a proper error code is returned to make the code consistent with the error paths that are present within those same functions. Signed-off-by: Brian Masney --- drivers

[PATCH 4/7] iio: light: tsl2583: return proper error code in sysfs store functions

. This patch changes these three functions to return -EINVAL when invalid input is passed in. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers

Re: [PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote: > > Change the following functions to only have a single exit point: > > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), >

Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

On Wed, Oct 19, 2016 at 02:22:49PM +0300, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote: > > @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct > > device *dev, > > goto luxable_store_done; > >

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

On Wed, Oct 19, 2016 at 12:47:13PM +0200, Peter Meerwald-Stadler wrote: > > > Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO > > macros to create the device attributes. > > great that you work on cleaning this up! > > the patch does a bit more than is claimed, it also renames

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote: > What does illuminance0_ mean? Can we remove that? I left the names of the existing sysfs attributes intact to not break any existing users of the driver. I'm not sure why the original author named it that way. Brian __

[PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support

Add device tree support for the tsl2583 IIO driver with no custom properties. Signed-off-by: Brian Masney --- .../devicetree/bindings/iio/light/tsl2583.txt | 26 ++ drivers/staging/iio/light/tsl2583.c| 13 +++ 2 files changed, 39 insertions

[PATCH 02/10] staging: iio: tsl2583: check for error code from i2c_smbus_read_byte()

taos_i2c_read() and taos_als_calibrate() does not check to see if the value returned by i2c_smbus_read_byte() was an error code. This patch adds the appropriate error handling. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 22 +- 1 file changed, 21

[PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1

taos_als_calibrate() has a code path where -1 is returned. This patch changes the code so that a proper error code is returned. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light

[PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

change, this sysfs entry will have its prefix changed from illuminance0_ to in_illuminance_. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 89 +++-- 1 file changed, 25 insertions(+), 64 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583

[PATCH 05/10] staging: iio: tsl2583: check return values from taos_chip_{on, off}

The return value from taos_chip_on() and taos_chip_off() was not checked in taos_luxtable_store() and taos_probe(). This patch adds proper error checking to these function calls. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 26 ++ 1 file changed

[PATCH 04/10] staging: iio: tsl2583: remove redundant power_state sysfs attribute

. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 47fd373..f8ccb4d 100644 --- a/drivers/staging/iio/light/tsl2583.c

[PATCH 06/10] staging: iio: tsl2583: convert to use iio_chan_spec and {read, write}_raw

in_illuminance_. This is deemed to be acceptable since none of the IIO light drivers in mainline use the illuminance0_ prefix, however 8 of the IIO light drivers in mainline use the in_illuminance_ prefix. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 236

[PATCH 00/10] staging: iio: tsl2583: staging cleanups

22:29 of_node -> ../../../../../../../firmware/devicetree/base/soc/i2c@7e804000/tsl2581@29/ drwxr-xr-x 2 root root0 Oct 27 22:29 power/ lrwxrwxrwx 1 root root0 Oct 27 22:29 subsystem -> ../../../../../../../bus/iio/ -rw-r--r-- 1 root root 4096 Oct 27 22:23 uevent Brian Masney (10):

[PATCH 09/10] staging: iio: tsl2583: add error code to sysfs store functions

-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 1462374..98afa5b 100644 --- a/drivers/staging/iio/light/tsl2583.c +++ b

[PATCH 10/10] staging: iio: tsl2583: add locking to sysfs attributes

locking to these sysfs attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 98afa5b..49b19f5 100644 --- a

[PATCH 08/10] staging: iio: tsl2583: use IIO_*_ATTR* macros to create sysfs entries

entries were prefixed with illuminance0_, however they are now prefixed with in_illuminance_ to make these sysfs entries consistent with how the IIO core is creating the other sysfs entries. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 73

Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

On Sun, Oct 30, 2016 at 06:37:40PM +, Jonathan Cameron wrote: > On 28/10/16 11:00, Brian Masney wrote: > > The illuminance0_calibscale sysfs attribute is not currently created by > > the IIO core. This patch adds the appropriate mask to iio_chan_spec, > > along with

[PATCH 4/9] staging: iio: tsl2583: remove redundant power off sequence in taos_chip_on()

Raspberry Pi 2. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 709f446..7fb09c6 100644 --- a/drivers/staging/iio/light

[PATCH 8/9] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

in_illuminance_calibrate_store() did not check to see if the chip is suspended. This patch adds the proper check. The return value from taos_als_calibrate() was also not checked in this function, so the proper check was also added while changes are being made here. Signed-off-by: Brian Masney

[PATCH 3/9] staging: iio: tsl2583: fixed ordering of comments

in taos_defaults() The comments in taos_defaults() appear after the line of code that they apply to. This patch moves the comments so that they appear before the code. Some of the comments were updated to be more informative. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c

[PATCH 5/9] staging: iio: tsl2583: don't shutdown chip when updating the lux table

the calls to taos_chip_off() and taos_chip_on() in in_illuminance_lux_table_store(). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index

[PATCH 2/9] staging: iio: tsl2583: removed unused code from device probing

ing a TSL2581 hooked up to a Raspberry Pi 2. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c

[PATCH 6/9] staging: iio: tsl2583: remove redudant i2c call in taos_als_calibrate()

still functions correctly using a TSL2581 hooked up to a Raspberry Pi 2. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c

[PATCH 1/9] staging: iio: tsl2583: i2c_smbus_write_byte() / i2c_smbus_read_byte() migration

ING: Unsigned expression compared with zero: reg_val < 0 drivers/staging/iio/light/tsl2583.c:388:5-12: WARNING: Unsigned expression compared with zero: reg_val < 0 This also removes the need for the taos_i2c_read() function since all callers were only calling the function with a length of 1. S

[PATCH 0/9] staging: iio: tsl2583: i2c cleanups

. Brian Masney (9): staging: iio: tsl2583: i2c_smbus_write_byte() / i2c_smbus_read_byte() migration staging: iio: tsl2583: removed unused code from device probing staging: iio: tsl2583: fixed ordering of comments staging: iio: tsl2583: remove redundant power off sequence in

[PATCH 9/9] staging: iio: tsl2583: remove redundant write to the control register in taos_probe()

. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 8c8361d..e80c027 100644 --- a/drivers/staging/iio/light/tsl2583.c +++ b/drivers/staging/iio

[PATCH 7/9] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

the new functions mentioned above. Previously, the current chip state was represented as a tristate (working, suspended, and unknown). The unknown state was not used. The chip state is now represented with a single boolean value (suspended). Signed-off-by: Brian Masney --- drivers/staging/iio

Re: [PATCH 7/9] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

On Sun, Nov 06, 2016 at 12:03:53PM +, Jonathan Cameron wrote: > On 03/11/16 12:56, Brian Masney wrote: > > When updating the in_illuminance_calibscale and > > in_illuminance_integration_time sysfs attributes, these values were not > > actually written to the chip. The c

[PATCH v2 13/23] staging: iio: tsl2583: change newlines to improve readability

Add and remove newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b

[PATCH v2 11/23] staging: iio: tsl2583: fix alignment of #define values

Most of the values in the #defines have their values aligned on a single column, but some do not. This changes the remaining defines to use consistent alignment with the majority to improve code readability. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 10 +- 1

[PATCH v2 02/23] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

when these sysfs attributes are updated. The chip initialization also calls these these new functions. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 85 +++-- 1 file changed, 52 insertions(+), 33 deletions(-) diff --git a/drivers/staging/iio

[PATCH v2 00/23] staging: iio: tsl2583: move out of staging

to a per device lux table. - Combined redundant sysfs ABI documentation - Made log messages clearer - Code style and formatting cleanups - Staging graduation I verified that the driver functions correctly using a TSL2581 hooked up to a Raspberry Pi 2. Brian Masney (23): staging: iio: tsl2583

[PATCH v2 07/23] staging: iio: tsl2583: remove redundant write to the control register in taos_probe()

. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 9880e41..0f5f544 100644 --- a/drivers/staging/iio/light/tsl2583.c +++ b/drivers/staging

[PATCH v2 08/23] staging: iio: tsl2583: remove the FSF's mailing address

Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian M

[PATCH v2 04/23] staging: iio: tsl2583: remove unnecessary chip status check in taos_get_lux

taos_get_lux checks to see if the chip is in a working state. This check is not necessary since it is only called from tsl2583_read_raw and in_illuminance_calibrate_store (via taos_als_calibrate). The chip state is already checked by these functions. Signed-off-by: Brian Masney --- drivers

[PATCH v2 03/23] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

in_illuminance_calibrate_store() did not check to see if the chip is suspended. This patch adds the proper check. The return value from taos_als_calibrate() was also not checked in this function, so the proper check was also added while changes are being made here. Signed-off-by: Brian Masney

[PATCH v2 09/23] staging: iio: tsl2583: cleaned up logging

changed. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 51 ++--- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index a03f845..c797ab0 100644 --- a

[PATCH v2 05/23] staging: iio: tsl2583: remove unnecessary chip status checks in suspend/resume

already powered on. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 2a3db3f..3be2213 100644 --- a/drivers/staging

[PATCH v2 12/23] staging: iio: tsl2583: fix comparison between signed and unsigned integers

Fixed warning found by make W=2: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583

[PATCH v2 01/23] staging: iio: tsl2583: split out functionality of taos_chip_on()

part of a larger refactor that was split up to make the code review easier. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 122 +--- 1 file changed, 58 insertions(+), 64 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/dr

[PATCH v2 22/23] staging: iio: tsl2583: updated copyright and MODULE_AUTHOR

Added Brian Masney's copyright to the header and to the MODULE_AUTHOR for all of the staging cleanups that has been done to this driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/stagin

[PATCH v2 20/23] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

in_illuminance_lux_table_store assumes that an unsigned int is 32 bits. Replace this with sizeof(unsigned int). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers

[PATCH v2 14/23] staging: iio: tsl2583: combine sysfs documentation

There are two separate files describing the tsl2583 sysfs attributes. Combine the two files into one. Updated the name of the sysfs attributes to match the current ABI. Signed-off-by: Brian Masney Suggested-by: Peter Meerwald-Stadler --- .../Documentation/light/sysfs-bus-iio-light-tsl2583

[PATCH v2 10/23] staging: iio: tsl2583: unify function and variable prefix to tsl2583_

Some functions and variables were prefixed with either taos, tsl258x or tsl2583. Change everything to use the tsl2583 prefix since that is the name of the .c file. The taos_settings member inside the taos_settings struct was renamed to als_settings. Signed-off-by: Brian Masney --- drivers

<    1   2   3   4   >