[PATCH v10 1/9] media: hevc: Add fields and flags for hevc PPS

2021-04-20 Thread Benjamin Gaignard
Add fields and flags as they are defined in 7.4.3.3.1 "General picture parameter set RBSP semantics of the H.265 ITU specification. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- .../userspace-api/media/v4l/ext-ctrls-codec.rst| 14 ++ include/media

[PATCH v10 2/9] media: hevc: Add decode params control

2021-04-20 Thread Benjamin Gaignard
Add decode params control and the associated structure to group all the information that are needed to decode a reference frame as is described in ITU-T Rec. H.265 section "8.3.2 Decoding process for reference picture set". Adapt Cedrus driver to these changes. Signed-off-by: Benjami

[PATCH v10 3/9] media: hantro: change hantro_codec_ops run prototype to return errors

2021-04-20 Thread Benjamin Gaignard
Change hantro_codec_ops run prototype from 'void' to 'int'. This allows the driver to cancel the job if an error occurs while configuring the hardware. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro_drv.c | 4 +++

[PATCH v10 4/9] media: hantro: Define HEVC codec profiles and supported features

2021-04-20 Thread Benjamin Gaignard
Define which HEVC profiles (up to level 5.1) and features (no scaling, no 10 bits) are supported by the driver. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro.h | 3 ++ drivers/staging/media/hantro/hantro_drv.c | 58

[PATCH v10 5/9] media: hantro: Only use postproc when post processed formats are defined

2021-04-20 Thread Benjamin Gaignard
If the variant doesn't support postprocessed formats make sure it will be ok. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro.h | 8 ++-- drivers/staging/media/hantro/hantro_postproc.c | 14 ++ drivers/st

[PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-04-20 Thread Benjamin Gaignard
The HEVC HANTRO driver needs to know the number of bits to skip at the beginning of the slice header. That is a hardware specific requirement so create a dedicated control for this purpose. Signed-off-by: Benjamin Gaignard --- .../userspace-api/media/drivers/hantro.rst| 19

[PATCH v10 7/9] media: hantro: handle V4L2_PIX_FMT_HEVC_SLICE control

2021-04-20 Thread Benjamin Gaignard
Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handled by the driver. Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro_v4l2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers

[PATCH v10 8/9] media: hantro: Introduce G2/HEVC decoder

2021-04-20 Thread Benjamin Gaignard
re so can't go into uapi structures. Computing the needed value is complex and requires information from the stream that only the userland knows so let it provide the correct value to the driver. Signed-off-by: Benjamin Gaignard Co-developed-by: Adrian Ratiu Signed-off-by: Adrian Ratiu Co

[PATCH v10 9/9] media: hantro: IMX8M: add variant for G2/HEVC codec

2021-04-20 Thread Benjamin Gaignard
Add variant to IMX8M to enable G2/HEVC codec. Define the capabilities for the hardware up to 3840x2160. G2 doesn't have a postprocessor, uses the same clocks and has it own interrupt. Signed-off-by: Benjamin Gaignard Reviewed-by: Philipp Zabel Reviewed-by: Ezequiel Garcia --- drivers/st

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-05 Thread Benjamin Gaignard
Le 05/05/2021 à 16:55, Hans Verkuil a écrit : On 20/04/2021 14:10, Benjamin Gaignard wrote: The HEVC HANTRO driver needs to know the number of bits to skip at the beginning of the slice header. That is a hardware specific requirement so create a dedicated control for this purpose. Signed-off

Re: [PATCH v10 0/9] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-05-25 Thread Benjamin Gaignard
Le 25/05/2021 à 17:39, Hans Verkuil a écrit : On 05/05/2021 16:42, Hans Verkuil wrote: Hi Benjamin, On 20/04/2021 14:10, Benjamin Gaignard wrote: The IMX8MQ got two VPUs but until now only G1 has been enabled. This series aim to add the second VPU (aka G2) and provide basic HEVC decoding

Re: [PATCH v9 03/13] media: hantro: Use syscon instead of 'ctrl' register

2021-06-28 Thread Benjamin Gaignard
Le 16/04/2021 à 12:54, Lucas Stach a écrit : Am Mittwoch, dem 07.04.2021 um 09:35 +0200 schrieb Benjamin Gaignard: In order to be able to share the control hardware block between VPUs use a syscon instead a ioremap it in the driver. To keep the compatibility with older DT if 'nxp,imx8m

Re: [PATCH v9 02/13] dt-bindings: media: nxp, imx8mq-vpu: Update the bindings for G2 support

2021-11-30 Thread Benjamin Gaignard
Le 29/11/2021 à 21:13, Adam Ford a écrit : On Wed, Apr 7, 2021 at 2:37 AM Benjamin Gaignard wrote: Introducing the G2 hevc video decoder requires modifications of the bindings to allow one node per VPU. VPUs share one hardware control block which is provided as a phandle on a syscon. Each

[PATCH] staging: ion: create one device entry per heap

2017-09-18 Thread Benjamin Gaignard
if the mask_id match with device minor. Query request could be done on any of the devices. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 9 +++-- drivers/staging/android/ion/ion.c | 20 ++-- drivers/staging/android/ion/ion.h | 10

Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
2017-09-19 11:40 GMT+02:00 Dan Carpenter : > On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote: >> -static int validate_ioctl_arg(unsigned int cmd, union ion_ioctl_arg *arg) >> +static int validate_ioctl_arg(struct file *filp, >> + un

Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
2017-09-19 12:15 GMT+02:00 Tomas Winkler : > On Tue, Sep 19, 2017 at 1:07 PM, Benjamin Gaignard > wrote: >> 2017-09-19 11:40 GMT+02:00 Dan Carpenter : >>> On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote: >>>> -static int validate_ioctl_arg(unsi

[PATCH v2 0/2] staging: ion: get one device per heap

2017-09-19 Thread Benjamin Gaignard
r heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id match with device minor. Query request could be done on any of the devices. Benjamin Gaignard (2): staging: ion: simplify ioctl args checking function stagin

[PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
if the mask_id match with device minor. Query request could be done on any of the devices. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- drivers/staging/android/ion/ion.c | 23 +-- drivers/staging/android/ion/ion.h | 10

[PATCH v2 1/2] staging: ion: simplify ioctl args checking function

2017-09-19 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
2017-09-19 13:02 GMT+02:00 Greg KH : > On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: >> Instead a getting one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. >&g

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-20 Thread Benjamin Gaignard
2017-09-20 3:01 GMT+02:00 Laura Abbott : > On 09/19/2017 04:55 AM, Benjamin Gaignard wrote: >> >> 2017-09-19 13:02 GMT+02:00 Greg KH : >>> >>> On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: >>>> >>>> Instead a getting

[PATCH v3 1/2] staging: ion: simplify ioctl args checking function

2017-09-20 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index

[PATCH v3 0/2] staging: ion: get one device per heap

2017-09-20 Thread Benjamin Gaignard
list this must be agreed by a larger audience because it is (again) an ion ABI bing bang. Hopefully that could be discussed at next XDC to get a decission on this particular point. Benjamin Gaignard (2): staging: ion: simplify ioctl args checking function staging: ion: create one device entry per

[PATCH v3 2/2] staging: ion: create one device entry per heap

2017-09-20 Thread Benjamin Gaignard
if the mask_id match with device minor. Query request could be done on any of the devices. Deivce node major will also change and that may impact init scripts. Signed-off-by: Benjamin Gaignard --- version 3: - change ion_device_add_heap prototype to return a possible error version 2: - simplify ioct

[PATCH v4 1/2] staging: ion: simplify ioctl args checking function

2017-09-26 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index

[PATCH v4 0/2] staging: ion: get one device per heap

2017-09-26 Thread Benjamin Gaignard
allocation must be done on the correct device/heap. - device major number will not be the same and that could impact init scripts. Benjamin Gaignard (2): staging: ion: simplify ioctl args checking function staging: ion: create one device entry per heap drivers/staging/android/TODO

[PATCH v4 2/2] staging: ion: create one device entry per heap

2017-09-26 Thread Benjamin Gaignard
if the mask_id match with device minor. Query request could be done on any of the devices. Signed-off-by: Benjamin Gaignard --- version 4: - add a configuration flag to switch between legacy Ion misc device and one device per heap version. version 3: - change ion_device_add_heap prototype to ret

[PATCH v5 0/2] staging: ion: get one device per heap

2017-09-27 Thread Benjamin Gaignard
isc device is still by setting ION_LEGACY_DEVICE_API configuration flag. Benjamin Gaignard (2): staging: ion: simplify ioctl args checking function staging: ion: create one device entry per heap drivers/staging/android/TODO| 1 - drivers/staging/android/ion/Kconfig | 7 +++ d

[PATCH v5 1/2] staging: ion: simplify ioctl args checking function

2017-09-27 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index

[PATCH v5 2/2] staging: ion: create one device entry per heap

2017-09-27 Thread Benjamin Gaignard
lowed if the mask_id match with device minor. Query request could be done on any of the devices. Signed-off-by: Benjamin Gaignard --- version 5: - create a configuration flag to keep legacy Ion misc device version 4: - add a configuration flag to switch between legacy Ion misc device and one dev

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-05 Thread Benjamin Gaignard
2017-10-04 12:17 GMT+02:00 Mark Brown : > On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote: > >> It is entirely possible and easy in android/ueventd to create those nodes >> under "/dev/ion/". (assuming the heap 'subsystem' for these new devices will >> point to 'ion'). I think it is

Re: [PATCH v5 1/2] staging: ion: simplify ioctl args checking function

2017-10-09 Thread Benjamin Gaignard
2017-09-27 15:20 GMT+02:00 Benjamin Gaignard : > Make arguments checking more easy to read. > Hi Laura, Even if we don't have found a solution for the second patch I believe this one could be useful. May I ask you your point of view on those few lines ? Benjamin > Signed-of

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-17 Thread Benjamin Gaignard
2017-10-17 0:09 GMT+02:00 Laura Abbott : > On 10/10/2017 02:11 AM, Mark Brown wrote: >> On Mon, Oct 09, 2017 at 05:10:37PM -0700, Laura Abbott wrote: >>> On 10/09/2017 03:08 PM, Mark Brown wrote: On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: >> > Anyway, to move this forwar

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-23 Thread Benjamin Gaignard
2017-10-18 22:07 GMT+02:00 Laura Abbott : > On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: >> diff --git a/drivers/staging/android/ion/ion.c >> b/drivers/staging/android/ion/ion.c >> index 93e2c90..092b24c 100644 >> --- a/drivers/staging/android/ion/ion.c >>

[PATCH v6 0/2] staging: ion: get one device per heap

2017-10-23 Thread Benjamin Gaignard
informations will be possible on each device node but allocation request will only be possible if heap_mask_id match with device minor number. Using legacy Ion misc device is still by setting ION_LEGACY_DEVICE_API configuration flag. Benjamin Gaignard (2): staging: ion: simplify ioctl args ch

[PATCH v6 1/2] staging: ion: simplify ioctl args checking function

2017-10-23 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard Acked-by: Laura Abbott --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion

[PATCH v6 2/2] staging: ion: create one device entry per heap

2017-10-23 Thread Benjamin Gaignard
ude files weren't in alphabetic order so I reorder them correctly. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/TODO| 1 - drivers/staging/android/ion/Kconfig | 7 + drivers/staging/android/ion/ion-ioctl.c | 18 +-- drivers/staging/and

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-06 Thread Benjamin Gaignard
2017-11-02 12:10 GMT+01:00 Mark Brown : > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > >> > There was a discussion a while ago in the context of I2C/SPI MFDs >> > which concluded that if you need a bus and it's going to be

[PATCH v6 0/2] staging: ion: get one device per heap

2017-11-06 Thread Benjamin Gaignard
ave one device "/dev/ionX" per heap. Query heaps informations will be possible on each device node but allocation request will only be possible if heap_mask_id match with device minor number. Using legacy Ion misc device is still by setting ION_LEGACY_DEVICE_API configuration flag. Benjami

[PATCH v6 1/2] staging: ion: reorder include

2017-11-06 Thread Benjamin Gaignard
Put include in alphabetic order Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index a7d9b0e..fda9756 100644 --- a

[PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-06 Thread Benjamin Gaignard
lowed if the mask_id match with device minor. Query request could be done on any of the devices. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/TODO| 1 - drivers/staging/android/ion/Kconfig | 7 drivers/staging/android/ion/ion-ioctl.c | 18 -- drivers

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Benjamin Gaignard
2017-11-09 22:17 GMT+01:00 Laura Abbott : > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: >> >> Instead a getting only one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap.

Re: [PATCH v6 1/2] staging: ion: reorder include

2017-11-28 Thread Benjamin Gaignard
2017-11-28 14:20 GMT+01:00 Greg KH : > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: >> Put include in alphabetic order > > Why??? Mainly because the next patch in the series adds new includes and I have decide to split clean-up and new feature patches >

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-29 Thread Benjamin Gaignard
2017-11-28 14:32 GMT+01:00 Greg KH : > On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: >> Instead a getting only one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. &g

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-03 Thread Benjamin Gaignard
2017-03-03 11:27 GMT+01:00 Daniel Vetter : > On Fri, Mar 03, 2017 at 11:04:33AM +0100, Daniel Vetter wrote: >> On Thu, Mar 02, 2017 at 01:44:32PM -0800, Laura Abbott wrote: >> > Hi, >> > >> > There's been some recent discussions[1] about Ion-like frameworks. There's >> > apparently interest in just

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-09 Thread Benjamin Gaignard
2017-03-06 17:04 GMT+01:00 Daniel Vetter : > On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >> >> > No one gave a thing about android in upstream, so Greg KH just dumped it >> > all into staging/android/. We've discussed

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-12 Thread Benjamin Gaignard
2017-03-09 18:38 GMT+01:00 Laura Abbott : > On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: >> 2017-03-06 17:04 GMT+01:00 Daniel Vetter : >>> On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >>>> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter w

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-14 Thread Benjamin Gaignard
2017-03-13 22:09 GMT+01:00 Laura Abbott : > On 03/12/2017 12:05 PM, Daniel Vetter wrote: >> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard >> wrote: >>> 2017-03-09 18:38 GMT+01:00 Laura Abbott : >>>> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: >

Re: [RFC PATCHv2 02/21] cma: Introduce cma_for_each_area

2017-03-29 Thread Benjamin Gaignard
2017-03-18 1:54 GMT+01:00 Laura Abbott : > > Frameworks (e.g. Ion) may want to iterate over each possible CMA area to > allow for enumeration. Introduce a function to allow a callback. even outside ION rework that could be useful Reviewed-by: Benjamin Gaignard > > Signed-off-b

Re: [RFC PATCHv2 00/21] Ion clean in preparation for moving out of staging

2017-03-29 Thread Benjamin Gaignard
/staging/android/ion/ion_of.c > delete mode 100644 drivers/staging/android/ion/ion_of.h > delete mode 100644 drivers/staging/android/ion/ion_priv.h > delete mode 100644 drivers/staging/android/ion/ion_test.c > delete mode 100644 drivers/staging/android/ion/tegra/Makefile > del

Re: [Linaro-mm-sig] [RESEND][PATCH 0/5] Ion cleanup

2016-08-14 Thread Benjamin Gaignard
This series of patches look good for me, thanks for the clean up Reviewed-by: Benjamin Gaignard 2016-08-08 18:52 GMT+02:00 Laura Abbott : > I never saw any feedback or action on these patches so this is a resend. > Probably hit the window when everyone was busy/traveling. > >

Re: [PATCH -next] staging: media: stih-cec: remove unused including

2016-09-28 Thread Benjamin Gaignard
Acked-by: Benjamin Gaignard 2016-09-28 17:13 GMT+02:00 Wei Yongjun : > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun > --- > drivers/staging/media/st-cec/stih-cec.c | 1 - > 1 file changed, 1 deletion(-) > > di

Re: [PATCH 5/5] [media] st-cec: Fix module autoload

2016-10-18 Thread Benjamin Gaignard
Thanks, Acked-by: Benjamin Gaignard 2016-10-17 17:44 GMT+02:00 Javier Martinez Canillas : > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding

Re: [PATCH] staging: st-cec: add parentheses around complex macros

2016-11-04 Thread Benjamin Gaignard
Thanks, Acked-by: Benjamin Gaignard 2016-11-04 8:58 GMT+01:00 Maninder Singh : > This patch fixes the following checkpatch.pl error: > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Maninder Singh > --- > drivers/staging/media/st-cec

Re: [Linaro-mm-sig] Follow up on Ion from LPC

2016-11-25 Thread Benjamin Gaignard
e for tracking/discussion I can see about setting > that up as well. > > Thanks, > Laura > > ___ > Linaro-mm-sig mailing list > linaro-mm-...@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-mm-sig -- Be

<    1   2