On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
wrote:
>
> Warning found by checkpatch.pl script.
That doesn't tell what you did or why you did it. Please write an
appropriate commit description and resend the patch.
karthik
___
devel mailing list
de.
showing this warning.
Signed-off-by: B K Karthik
---
drivers/staging/greybus/audio_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_helper.c
b/drivers/staging/greybus/audio_helper.c
index 3011b8abce38..1ed4772d2771 100644
--- a/drivers
Signed-off-by: B K Karthik
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..16afbe1dfdeb 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
yle problem
"Alignment should match open parenthesis" by adding tab spaces in line 1270.
Signed-off-by: B K Karthik
---
drivers/staging/media/soc_camera/soc_camera.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.
soc_camera.c:
fixing ERROR: Macros with complex values must be enclused within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/media/soc_camera/soc_camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.c
b
fixing ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: B K Karthik
---
drivers/staging/media/usbvision/usbvision-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c
b/drivers/staging/media
fbtft-bus.c:
fixing ERROR: space prohibited before that close parenthesis ')' by removing
that space and ',' in line 65 and 67.
Signed-off-by: B K Karthik
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
fbtft-bus.c:
fixing ERROR: space prohibited before that close parenthesis ')' by removing
that space and ',' in line 65 and 67.
Signed-off-by: B K Karthik
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Signed-off-by: B K Karthik
---
drivers/staging/qlge/qlge.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
index fc8c5ca8935d..0b971a633001 100644
--- a/drivers/staging/qlge/qlge.h
+++ b/drivers/staging/qlge/qlge.h
@@ -2224,6 +2224,7
Removing unnecessary blank line
Signed-off-by: B K Karthik
---
drivers/staging/rtl8712/rtl8712_recv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.h
b/drivers/staging/rtl8712/rtl8712_recv.h
index 3e385b2242d8..69d3d5b287d3 100644
--- a/drivers/staging
h a bad thing?
> > > A: Top-posting.
> > > Q: What is the most annoying thing in e-mail?
> > >
> > > A: No.
> > > Q: Should I include quotations after my reply?
> > >
> > > http://daringfireball.net/2007/07/on_top
> > >
> >
Fixed a coding style issue.
Signed-off-by: B K Karthik
---
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
index
added blank space around arithmetic operators to improve readability
Signed-off-by: B K Karthik
---
.../rtl8188eu/include/hal8188e_rate_adaptive.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/hal8188e_rate_adaptive.h
b
added blank space and enclosed a complex valued macro within parentheses for
improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/odm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/odm.h
b/drivers
removed multiple blank lines to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h
b/drivers/staging/rtl8188eu/include/ieee80211.h
index
, B K Karthik wrote:
> Fixed a coding style issue.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
&
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers/staging/rtl8188eu
add blank spaces for improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index
add parentheses since complex valued macros must be enclosed within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers
add blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
added blank spaces to improve code readability. (coding style issue)
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers
add parentheses since complex valued macros must be enclosed within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers
add blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
added blank spaces to improve code readability. (coding style issue)
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers
add blank spaces for improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
add parentheses since complex valued macros must be enclosed within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers
add blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES,
N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they
were not declared earlier.
Signed-off-by: B K Karthik
---
.../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8
1 file changed, 4 insertions
changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES,
N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they
were not declared earlier.
Signed-off-by: B K Karthik
---
.../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8
1 file changed, 4 insertions
fixed a sparse warning by changing the type in
assignment from void [noderef] __user * to unsigned int *
(different address space)
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi
On Wed, Jul 15, 2020 at 3:08 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 12:48:13AM -0400, B K Karthik wrote:
> > fixed a sparse warning by changing the type in
> > assignment from void [noderef] __user * to unsigned int *
> > (different address space)
&g
On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote:
> > On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman <
> > gre...@linuxfoundation.org> wrote:
> >
> > > On Wed, Jul 15, 2020
On Wed, Jul 15, 2020 at 4:41 AM B K Karthik wrote:
>
> On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
> wrote:
> >
> > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote:
> > > On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman <
> &
On Wed, Jul 15, 2020 at 5:14 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 04:41:52AM -0400, B K Karthik wrote:
> > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wro
On Wed, Jul 15, 2020 at 5:19 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 04:47:48AM -0400, B K Karthik wrote:
> > On Wed, Jul 15, 2020 at 4:41 AM B K Karthik wrote:
> > >
> > > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
> > > wrote:
On Wed, Jul 15, 2020 at 5:29 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 05:21:01AM -0400, B K Karthik wrote:
> > On Wed, Jul 15, 2020 at 5:14 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Wed, Jul 15, 2020 at 04:41:52AM -0400, B K Karthik wrot
On Wed, Jul 15, 2020 at 7:19 AM Ian Abbott wrote:
>
> On 15/07/2020 05:48, B K Karthik wrote:
> > fixed a sparse warning by changing the type in
> > assignment from void [noderef] __user * to unsigned int *
> > (different address space)
> >
> > Signed-off-by
fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
void [noderef] __user * to unsigned int __user * .
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2
fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
unsigned int * to unsigned int __user * .
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions
On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman
wrote:
>
> On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> > fixed sparse warnings by adding a cast in assignment from
> > void [noderef] __user * to unsigned int __force *
> > and a reverse cast in argume
ott
v3 -> v4:
- Add versioning information in commit description
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 3f7
fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
unsigned int * to unsigned int __user * .
Signed-off-by: B K Karthik
Reviewed-by: Ian Abbott
---
v1 -> v2:
- Added a reverse cast in argument
v2 -&
fixed multiple blank space coding style issues
reported by checkpatch
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 +-
drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2 +-
drivers/staging
fixed multiple parentheses coding style issues reported by checkpatch.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 4 +--
.../staging/rtl8188eu/include/osdep_service.h | 4 +--
drivers/staging/rtl8188eu/include/wifi.h | 34 +--
3 files
enclosed macros starting with if inside do-while loops to
avoid possible if-else logic defects
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/odm_debug.h | 28 +++
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
placed constant on the right side of the test
to fix warnings issued by checkpatch
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 4 ++--
drivers/staging/rtl8188eu/include/wifi.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
On Sat, Jul 18, 2020 at 9:17 AM Joe Perches wrote:
>
> On Sat, 2020-07-18 at 05:18 -0400, B K Karthik wrote:
> > placed constant on the right side of the test
> > to fix warnings issued by checkpatch
> []
> > diff --git a/drivers/staging/rtl8188eu/include/wifi.h
>
On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman
wrote:
>
> On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote:
> > fixed multiple parentheses coding style issues reported by checkpatch.
> >
> > Signed-off-by: B K Karthik
> > ---
> > drivers/stagin
reg's patch-bot, or the driver
is scheduled for removal.
Please do think about adding a file that lists all drivers scheduled
for removal.
I apologize if my message was hurtful or disrespectful in any way.
Thank you for reading this message,
Karthik
On Fri, Jun 26, 2020 at 10:32 AM B K Karthi
51 matches
Mail list logo
