This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
drivers/staging/rtl8192e/dot11d.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/dot11d.h
b/drivers/staging/rtl8192e/dot11d.h
index aac395f26652
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
drivers/staging/speakup/fakekey.c| 10 +-
drivers/staging/speakup/i18n.c | 14 +++---
drivers/staging/speakup/main.c | 2 +-
drivers/staging
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
drivers/staging/speakup/fakekey.c| 10 +-
drivers/staging/speakup/i18n.c | 14 +++---
drivers/staging/speakup/main.c | 2 +-
drivers/staging
This patch fixes the issue by aligning the * on each line in block comments.
[Patch v1] is rejected as the changes done is not following the linux
coding style and [Patch v2] is rejected because forgot to mention the
cause of rejection of [Patch v1].
Signed-off-by: Arushi
--
Changes done from
mention of the cause was not in the correct format.
Signed-off-by: Arushi
---
In the [patch v1] to allign the * on each line in block was not correct
as it is also not following the correct coding style of kernel so it got
rejected and the details of all the other patch versions is given above
mention of the cause was not in the correct format.
Signed-off-by: Arushi
---
In the [patch v1] to allign the * on each line in block was not correct
as it is also not following the correct coding style of kernel so it got
rejected and the details of all the other patch versions is given above
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
[Patch v1] is rejected as the changes done is not correct and is not following
the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c
as * on each line in block was not
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
[Patch v1] is rejected as the changes done is not correct and is not following
the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c
as * on each line in block was not
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi Singhal
---
[Patch v1] is rejected as the changes done is not correct and is not following
the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c
as * on each line in block
Function definitions arguments should also have an identifier name as reported
by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6655/baseband.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.h
b/drivers
This patch fixes the issue by aligning the * on each line in block
comments.
Signed-off-by: Arushi Singhal
---
---
drivers/staging/speakup/fakekey.c| 10 +-
drivers/staging/speakup/i18n.c | 14 +++---
drivers/staging/speakup/main.c | 2 +-
drivers
Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct
serio)...) as reported by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/nvec/nvec_ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec
Macro argument 'a' may be better as '(a)' to avoid precedence issues as
reported by checkpatch.pl
Signed-off-by: Arushi Singhal
---
drivers/staging/fwserial/fwserial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fwserial/fwserial.
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6656/firmware.c | 34 +-
drivers/staging/vt6656/key.h | 2 +-
drivers/staging/vt6656/rf.c | 12 ++--
drive
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6656/rxtx.c | 54 +--
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c
function definition argument 'struct vb_device_info *' should also have
an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb
Some of the block comments styles are not encouraged:
for example:
/*
block comment without introductory *
*/
and
/*
* block comment with line terminating */
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks7010_sdio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
Unnecessary parentheses as reported by checkpatch.pl
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index
The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the
start of a line
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010
Unnecessary parentheses should be avoided as reported by checkpatch.pl
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 22 insertions(+), 22 deletions(-)
diff
Unnecessary parentheses should be avoided as reported by checkpatch.pl
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 22 insertions(+), 22 deletions(-)
diff
Unnecessary parentheses should be avoided as reported by checkpatch.pl
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 22 insertions(+), 22 deletions(-)
diff
>bssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 22 insertions(+), 22 deletions(-)
diff -
>bssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/k
>bssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/sta
>bssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 20 insertions(+), 20 deletions(-)
diff -
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
Changes in v2:
- Make the commit message more clearer.
- And correct the error on line number 116
in file drivers/staging/ks7010/ks_hostif.c
changes:-
ap = priv->current_ap;
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/k
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drive
Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
if there is boolean operator then it is fixed by Splitting line at
boolean operator.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/XGI_main_26.c | 15 +--
drivers/staging/xgifb/vb_setmode.c
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_setmode.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/d
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
---
drivers/staging/xgi
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal
---
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
- write the changes done
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
Changes in v3:
- By mistake one irrelevant line was added which is removed in this
patch.
- write the changes done in
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
Changes in v3:
- Commit message made more accurate and as per the changes.
- previously versions were not marked.
---
drivers/staging/ks7010/ks_hostif.c | 24
1 file
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
Changes in v3:
- Commit message made more accurate and as per the changes.
- previously versions were not marked.
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
drivers/stag
function prototype argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
changes in v3
-make the subject title more relevant.
-change the identifier of struct vb_device_info to XGI_Pr.
---
drivers/sta
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in thos patch codes in the comments are removed.
Signed-off-by: Arushi Singhal
line exceeding 80 characters length.
Signed-off-by: Arushi Singhal
---
changes in v2
- changes done such that no other errors can generate.
---
drivers/staging/xgifb/XGI_main_26.c | 21 +
drivers/staging/xgifb/vb_setmode.c | 14 +++---
2 files changed, 16 insertions
Error was reported by checkpatch.pl as "Avoid multiple line
dereference".And If there is boolean operator then it is
fixed by Splitting line at boolean operator to satisfy coding
style.
Signed-off-by: Arushi Singhal
---
changes in v3
- changes done such that no other errors ca
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line
dereference".And If there is boolean operator then it is
fixed by Splitting line at boolean operator to satisfy coding
style.
Signed-off-by: Arushi Singhal
---
changes in v4
- changes done such that no other errors ca
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
Changes in v4:
- Commit message made more accurate and as per the changes.
drivers/staging/ks7010/ks_hostif.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
H_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
Changes in v4:
- Commit message made more accurate and as per the changes.
- previously versions were not marked.
drivers/staging/ks7010/ks_hostif.c | 44 ++-
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable and also to
correct about mentioned error as by itroducing new variables line is
not exceeding 80 characters.
Signed-off-by: Arushi Singhal
---
changes in v5
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable and also to
correct about mentioned error as by itroducing new variables line is
not exceeding 80 characters.
Signed-off-by: Arushi Singhal
---
changes in v6
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable.
Signed-off-by: Arushi Singhal
---
changes in v7
- Improve the coding style.
- Introduced new variables.
drivers/staging/xgifb/XGI_main
mcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index a533
mcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal
---
drivers/staging/ks7010/ks_hostif.c | 23 +++
drivers/staging/ks7010/ks_wlan_net.c | 18 +-
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/
New variable is added to make the code more readable.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/XGI_main_26.c | 29 ++---
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26
The contents of the header file are used only by this single
source file. Move content into .c and remove .h.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/frequency/ad9832.c | 100 +-
drivers/staging/iio/frequency/ad9832.h | 128
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup/kobjects.c | 2 +-
drivers/staging/speakup/main.c | 38
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index 1a3e34880ac1..11f1418b4006 100644
--- a
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/i18n.c | 2 +-
drivers/staging/speakup/kobjects.c | 38 +++---
2 files changed, 20 insertions(+), 20 deletions(-)
di
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
changes in v2
- fixed coding style error and upto the coding style.
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
changes in v2
- Aligned the lines which are not aligned in previous patch.
drivers/staging/speakup/i18n.c | 2 +-
drivers/staging/speakup/kobje
Placed Logical continuations on the previous line as reported by
checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
b/drivers/staging/speakup/speakup_dtlk.h
index
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 16
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/stagi
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (4):
staging: speakup: Placed Logical on the previous line
staging: speakup: spaces preferred around operator
staging: speakup: identation should use tabs
staging: speakup: Alignment should match
Placed Logical continuations on the previous line as reported by
checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
b/drivers/staging/speakup/speakup_dtlk.h
index
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 16
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/stagi
fixed checkpatch.pl warning: else is not generally useful after a break
or return.
Removed the else without affecting the logic.
Dead code is also eliminated.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/keyhelp.c | 53 ++-
1 file changed, 19
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/serialio.c | 1 +
drivers/staging/speakup/speakup_dtlk.c
This patch fixes "simple_strtoul is obsolete, use kstrtoul instead"
warning.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c| 4 ++--
drivers/staging/speakup/main.c| 2 +-
drivers/staging/speakup/varhandlers.c | 2 +-
3 files changed, 4 insert
This patch fixes the checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/speakup
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (6):
staging: speakup: Add blank line after function/struct/union/enum
declarations
staging: speakup: simple_strtoul is replaced with kstrtoul
staging: speakup: Logical continuations should be
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/staging
Blank lines aren't necessary after an open brace '{' as reported by
Checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
ind
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/stagi
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (6):
staging: speakup: Add blank line after function/struct/union/enum
declarations
staging: speakup: Logical continuations should be on the previous line
staging: speakup: Blank lines removed
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/serialio.c | 1 +
drivers/staging/speakup/speakup_dtlk.c
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/varhandlers.c | 6 +++---
2 files changed, 4 insertions(+), 4
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/stagi
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/drivers
Blank lines aren't necessary after an open brace '{' as reported by
Checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
ind
This patch fixes the checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/speakup
Improve readability by fixing multiple checkpatch.pl
issues.
Arushi Singhal (6):
staging: speakup: fixes braces {} should be used on all arms of this statement
staging: speakup: Avoid multiple assignments on same line
staging: speakup: identation should use tabs
staging: wilc1000
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
drivers/staging/speakup/speakup_decext.c | 6 +++---
drivers/staging/speakup/speakup_decpc.c
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/ma
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_spi.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperati
function prototype argument should have an identifier name as reported
by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/wilc1000/wilc_wlan.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.h
b/drivers/staging
This patch fixes the checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/wilc1000/wilc_spi.c | 4 ++--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++--
2 files changed, 8 insertions
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_decpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/speakup_decpc.c
b/drivers/staging/speakup/speakup_decpc.c
index
Improve readability by fixing multiple checkpatch.pl
issues in sm750fb driver.
Arushi Singhal (3):
staging: sm750fb: fixes add blank line after function/struct/union/enum
declarations
staging: sm750fb: function prototype argument should have an identifier name
staging: sm750fb: Alignment
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/ddk750_mode.h| 2 +-
drivers/staging/sm750fb/
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_display.h | 1 +
drivers/staging/sm750fb/ddk750_mode.h| 2 ++
drivers/staging/sm750fb
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 69 +--
1 file changed, 34 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singhal
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (4):
staging: speakup: Comparison to NULL could be written
staging: speakup:indentation should use tabs
staging: speakup: Alignment match open parenthesis
staging: speakup: Placed Logical on the
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
changes in v2
- fixed coding style error and upto the coding style.
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index 1a3e34880ac1..11f1418b4006 100644
--- a
1 - 100 of 311 matches
Mail list logo
