Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: > On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: > [...] > > score should set HAS_IOMEM and doesn't > > even have public compilers > > This begs an interesting question. Sh

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 17:29:31 Chen Gang wrote: > > > > COMPILE_TEST is a great tool in general, but it has its limits. > > In particular, the case for !CONFIG_IOMEM is completely obscure > > and we won't find any bugs by allowing more drivers to be built > > in those configurations, but attemp

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote: > On 07/17/2014 11:20 AM, Arnd Bergmann wrote: > > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: > >> gfp_t gfp_mask, unsigned int > >> order); > >>

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 12:58:55 Richard Weinberger wrote: > > This is what I got upon trying earlier. I have not attempted to look into > > why this is happening. Note this is on linux-next from yesterday, > > not mainline as I incorrectly stated above. > > > > In file included from ../arch/um/i

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote: > On 7/17/2014 7:28 AM, Chen Gang wrote: > > On 07/17/2014 06:48 PM, Arnd Bergmann wrote: > >> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take > >> a shortcut here and make COMPILE_TEST dep

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-22 Thread Arnd Bergmann
On Sunday 20 July 2014 17:45:40 Chen Gang wrote: > > > > Next, I shall: > > > > - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly. > > > > - Try to make dummy IOMEM functions for score architecture. > > > > - Continue discussing with UML for it. > > > > Oh, sorry, I forgot, after remove

[PATCH] staging: ccree: fix type mismatch warning

2017-12-21 Thread Arnd Bergmann
nd the format string to match the argument. Fixes: 3f268f5d6669 ("staging: ccree: turn compile time debug log to params") Signed-off-by: Arnd Bergmann --- drivers/staging/ccree/ssi_driver.c | 2 +- drivers/staging/ccree/ssi_driver.h | 4 ++-- 2 files changed, 3 insertions(+), 3 dele

[PATCH] staging: ccree: mark debug_regs[] as static

2018-01-03 Thread Arnd Bergmann
from the global namespace. Fixes: 9bdd203b4dc8 ("s3cmci: add debugfs support for examining driver and hardware state") Fixes: b3ec9a6736f2 ("staging: ccree: staging: ccree: replace sysfs by debugfs interface") Signed-off-by: Arnd Bergmann --- drivers/staging/ccree/cc_debugfs

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2018-01-03 Thread Arnd Bergmann
On Sun, Dec 24, 2017 at 9:55 AM, christophe leroy wrote: > Le 23/12/2017 à 16:57, Guenter Roeck a écrit : >> >> On 12/23/2017 05:48 AM, Greg KH wrote: >>> >>> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: Hi all, When I tried to use devm_ioremap function and revi

[PATCH] media: staging: tegra-vde: select DMA_SHARED_BUFFER

2018-01-05 Thread Arnd Bergmann
ers/staging/media/tegra-vde/tegra-vde.ko] undefined! Signed-off-by: Arnd Bergmann --- drivers/staging/media/tegra-vde/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/tegra-vde/Kconfig b/drivers/staging/media/tegra-vde/Kconfig index ec3ebdaa..5c491467446

[PATCH] uio_hv_generic: fix type mismatch warnings

2018-01-10 Thread Arnd Bergmann
rces") Signed-off-by: Arnd Bergmann --- drivers/uio/uio_hv_generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index a0c4c07a907f..c740984506f7 100644 --- a/drivers/uio/uio_hv_generic.c +++ b/dri

Re: [PATCH] uio_hv_generic: fix type mismatch warnings

2018-01-10 Thread Arnd Bergmann
On Wed, Jan 10, 2018 at 5:57 PM, Stephen Hemminger wrote: > On Wed, 10 Jan 2018 17:42:38 +0100 > Arnd Bergmann wrote: > >> I moved the virt_to_phys() conversion into hv_uio_probe() as part of >> a warning fix. Stephen's cleanup to remove the private mmap() function >

[PATCH] uio_hv_generic: fix new type mismatch warnings

2018-01-12 Thread Arnd Bergmann
ot;uio_hv_generic: create send and receive buffers") Signed-off-by: Arnd Bergmann --- drivers/uio/uio_hv_generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index 787598ad933d..8ca549032c27 100644 ---

[PATCH] staging: lustre: lnet: avoid uninitialized return value

2018-01-16 Thread Arnd Bergmann
ng: lustre: lnet: convert selftest to use workqueues") Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/selftest/module.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selfte

Re: [PATCH v3 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 3:18 AM, Deepa Dinamani wrote: > The series is a preparation series for individual architectures > to use 64 bit time_t syscalls in compat and 32 bit emulation modes. > > This is a follow up to the series Arnd Bergmann posted: > https://sourceware.org/ml/lib

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

2018-01-25 Thread Arnd Bergmann
g/imx: remove confusing IS_ERR_OR_NULL > usage") > Signed-off-by: Gustavo A. R. Silva good catch! Acked-by: Arnd Bergmann ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: vc04_services: merge vchiq_kern_lib.c into vchiq_arm.c

2018-02-02 Thread Arnd Bergmann
ing the structure definition into a shared header first, but ended up running into too many interdependencies that way. Signed-off-by: Arnd Bergmann --- drivers/staging/vc04_services/Makefile | 1 - .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 369

[PATCH] staging: media: atomisp: remove pointless string copy

2018-02-02 Thread Arnd Bergmann
ring_support.h:158:2: include/linux/string.h:253:9: error: '__builtin_strncpy' source argument is the same as destination [-Werror=restrict] return __builtin_strncpy(p, q, size); ^ This removes the bogus code, leaving the behavior otherwise unchanged.

[PATCH] staging: fsl-mc: fix build testing on x86

2018-02-16 Thread Arnd Bergmann
an get the PCI_MSI_IRQ_DOMAIN symbol. Cc: sta...@vger.kernel.org Signed-off-by: Arnd Bergmann --- drivers/staging/fsl-mc/bus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/Kconfig b/drivers/staging/fsl-mc/bus/Kconfig index 504c987447f2..ee

[PATCH 2/2] staging: rts5208: rename SG_END macro

2018-03-01 Thread Arnd Bergmann
ror] This changes one instance of the driver to prefix SG_END and related constants. Fixes: 723fbf563a6a ("lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings") Cc: Anshuman Khandual Cc: Jens Axboe Signed-off-by: Arnd Bergmann --- drivers/staging/rts5208/r

Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-06 Thread Arnd Bergmann
On Mon, Mar 5, 2018 at 10:30 AM, Christian Borntraeger wrote: > On 01/16/2018 03:18 AM, Deepa Dinamani wrote: >> All the current architecture specific defines for these >> are the same. Refactor these common defines to a common >> header file. >> >> The new common linux/compat_time.h is also usefu

[PATCH] staging: lustre: use module_name() macro for debug printf

2018-03-13 Thread Arnd Bergmann
printing the name of a module in all configurations. Cc: NeilBrown Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/obdclass/lu_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lu

[PATCH] staging: lustre: fid: avoid false-positive uninitialized variable warning

2018-03-13 Thread Arnd Bergmann
ect, and I could not come up with a good way to simplify it further, so this adds a fake initialization to shut up that warning. Cc: NeilBrown Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/fid/fid_request.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

[PATCH] media: imx: work around false-positive warning

2018-03-13 Thread Arnd Bergmann
no good way to rewrite this function, as a last resort, this adds an explicit zero-intialization of the structure. Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used") Signed-off-by: Arnd Bergmann --- drivers/staging/media/imx/imx-media-csi.c | 2 +- 1 fi

[PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Arnd Bergmann
The blackfin architecture is getting removed, so this driver is now obsolete. Signed-off-by: Arnd Bergmann --- drivers/staging/irda/drivers/Kconfig| 45 -- drivers/staging/irda/drivers/Makefile | 1 - drivers/staging/irda/drivers/bfin_sir.c | 819

[PATCH 47/47] staging: iio: remove iio-trig-bfin-timer driver

2018-03-14 Thread Arnd Bergmann
es devices like this one. They are likely used along with blackfin SoCs, but could easily be used on any others as well. It might be time to consider whether they should be removed, but it doesn't feel like a decision that I should be making. Signed-off-by: Arnd Bergmann -

Re: [PATCH v5 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 5:03 AM, Deepa Dinamani wrote: > The series is a preparation series for individual architectures > to use 64 bit time_t syscalls in compat and 32 bit emulation modes. > > This is a follow up to the series Arnd Bergmann posted: > https://sourceware.org/ml/lib

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 5:32 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: >> The blackfin architecture is getting removed, so this >> driver is now obsolete. >> >> Signed-off-by: Arnd Bergmann >> --- >>

Re: [PATCH 47/47] staging: iio: remove iio-trig-bfin-timer driver

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 6:06 PM, Jonathan Cameron wrote: > On Wed, 14 Mar 2018 17:32:07 +0100 > Greg Kroah-Hartman wrote: >> On Wed, Mar 14, 2018 at 04:36:00PM +0100, Arnd Bergmann wrote: >> > I'm not sure about the other staging iio drivers though: almost >> >

Re: [Y2038] [PATCH v4 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-14 Thread Arnd Bergmann
ng in two more files during randconfig testing on arm64 now, adding this fixup on top for the moment, but maybe there is a better way: commit 4f3e9e1211799a79b201a1af309a1ec3864147ec Author: Arnd Bergmann Date: Wed Mar 14 18:23:16 2018 +0100 arm64: fix perf_regs.c arch/arm64/kern

Re: [Y2038] [PATCH v4 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-15 Thread Arnd Bergmann
On Thu, Mar 15, 2018 at 3:51 AM, Deepa Dinamani wrote: > On Wed, Mar 14, 2018 at 1:52 PM, Arnd Bergmann wrote: >> On Wed, Mar 14, 2018 at 4:50 AM, Deepa Dinamani >> wrote: >>> The file arch/arm64/kernel/process.c needs asm/compat.h also to be >>> include

[PATCH] staging: tegra-video: fix V4L2 dependency

2020-05-27 Thread Arnd Bergmann
edia: tegra-video: Add Tegra210 Video input driver") Signed-off-by: Arnd Bergmann --- drivers/staging/media/tegra-video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig index

[PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults()

2020-05-29 Thread Arnd Bergmann
; [-Werror,-Wframe-larger-than=] Use constantly-allocated variables plus an explicit memcpy() to avoid that. Fixes: 6dc9a2568f84 ("media: atomisp: convert default struct values to use compound-literals with designated initializers") Signed-off-by: Arnd Bergmann --- drivers/staging/media/

[PATCH 3/9] staging: media: atomisp: annotate an unused function

2020-05-29 Thread Arnd Bergmann
ll be used again in the future and should not just be removed. Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency

2020-05-29 Thread Arnd Bergmann
Without that driver, there is a link failure in ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element" [drivers/staging/media/atomisp/pci/atomisp_gmin_platform.ko] undefined! Add an explicit Kconfig dependency. Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/K

[PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it

2020-05-29 Thread Arnd Bergmann
a function that uses it as an argument. Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/pci/sh_css_firmware.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/pci/sh_css_f

[PATCH 4/9] staging: media: atomisp: fix a type conversion warning

2020-05-29 Thread Arnd Bergmann
int') changes value from 18446744073709543424 to -8192 [-Werror,-Wconstant-conversion] As the conversion is clearly intended here, use an explicit cast. Fixes: 9a0d7fb5ece6 ("media: atomisp: simplify math_support.h") Signed-off-by: Arnd Bergmann --- .../atomisp/pci/isp/kernels/xnr/x

[PATCH 6/9] staging: media: atomisp: fix type mismatch

2020-05-29 Thread Arnd Bergmann
ume that the last patch was correct and change the other caller as well. Fixes: 0116b8df1c9e ("media: staging: atomisp: stop duplicating input format types") Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c | 2 +- 1 file changed, 1 insertio

[PATCH 7/9] staging: media: atomisp: fix enum type mixups

2020-05-29 Thread Arnd Bergmann
onfig.input_switch_cfg); ^~~~ INPUT_SYSTEM0_ID is zero, so use the corresponding zero-value of the expected types instead. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann --- .../pci/hive_isp_css

[PATCH 8/9] staging: media: atomisp: disable all custom formats

2020-05-29 Thread Arnd Bergmann
been tested. Disable all the ones that cause a warning. Fixes: cb02ae3d71ea ("media: staging: atomisp: Disable custom format for now") Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/pci/atomisp_subdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/sta

[PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Arnd Bergmann
cessary here, but makes a little more sense. Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 2 +- drivers/staging/media/atomisp/pci/sh_css.c | 4 ++-- drivers/staging/media/atom

Re: [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 10:04 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > See also Nathan's 7 patch series. > https://lore.kernel.org/lkml/20200527071150.3381228-1-natechancel...@gmail.com/ > > Might be some overlap between series? > Probably. I really should have checked when I saw th

Re: [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 10:23 PM Arnd Bergmann wrote: > > On Fri, May 29, 2020 at 10:04 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > See also Nathan's 7 patch series. > > https://lore.kernel.org/lkml/20200527071150.3381228-1-natechancel..

<    2   3   4   5   6   7