ep().
Reviewed-by: Noralf Trønnes
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index bbe89c9c4fb9..300a1e4505b9 10064
alf's ACKs
- rebased on top of v4.10-rc4
Since v2:
- fix kbuild bot warning
- remove duplication of might_sleep() (Noralf)
- re-do DMA appoach based on Noralf's suggestion
- append Noralf's tags
Andy Shevchenko (5):
staging: fbtft: convert fbtft_reset() to be non-atomic
staging: fbtft:
On Thu, 2017-01-19 at 10:49 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote:
> > First of all, fbtft in current state doesn't allow to override GPIOs
> > to be
> > optional, like "reset" one. It might be a
This patch converts code to use %pM specifier instead of placing each
byte on stack.
Signed-off-by: Andy Shevchenko
---
drivers/staging/unisys/virtpci/virtpci.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers
This patch converts code to use %pM specifier instead of placing each
byte on stack.
Signed-off-by: Andy Shevchenko
---
drivers/staging/unisys/virtpci/virtpci.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers
On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:
Put here few words _why_ you are doing this.
Perhaps, add output of sparse static analyzer.
> Signed-off-by: Luca Ceresoli
> Cc: Greg Kroah-Hartman
> Cc: Bhaktipriya Shridhar
> Cc: Andy Shevchenko
> Cc: Geliang Ta
if (pkt_copy) {
> - pkt_copy->dev = adapt->pnetdev;
> precvframe->pkt = pkt_copy;
> precvframe->rx_head = pkt_copy->data;
> p
On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote:
> On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote:
> >
> > netdev_alloc_skb function
> > already set dev member of pkt_copy.
>
> It might be one line.
>
> Some special references:
> functions: fu
?
> + mutex_unlock(&tty_mutex);
> + tty_driver_kref_put(driver);
I'm not sure I understand locking model here:
Above
1. take mutex
2. take reference
Here:
1. give mutex back
2. give reference back
I think we usually see symmetrical calls, i.e.
1. give refer
On Mon, Jul 10, 2017 at 11:31 AM, Okash Khawaja wrote:
> On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
>> On Sun, Jul 9, 2017 at 2:41 PM, Okash Khawaja
>> wrote:
>>
>> > +struct tty_struct *tty_kopen(dev_t device)
>> >
e TLB flush\n");
You may define pr_fmt() at the beginning of this file.
Like
#define pr_fmt(fmt) "Hyper-V: " ## fmt
> + pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
> + setup_clear_cpu_cap(X86_FEATURE_PCID);
> + }
>
There is no more users for uapi/uuid.h. Remove it for good.
Anyone needs it in user space better to use libuuid.
Signed-off-by: Andy Shevchenko
---
include/linux/uuid.h | 20 +++-
include/uapi/linux/uuid.h | 42 --
scripts/mod
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: Tomas Winkler
Cc: Guenter Roeck
Cc: Samuel Ortiz
Signed-off-by: Andy Shevchenko
---
drivers/misc/mei/bus-fixup.c| 35
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: Matt Fleming
Cc: Ard Biesheuvel
Signed-off-by: Andy Shevchenko
---
drivers/firmware/efi/cper.c | 10 ++---
include/linux/cper.h
amuel Ortiz
Cc: Guenter Roeck
Cc: David Kershner
Cc: Greg Kroah-Hartman
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Cc: "Rafael J. Wysocki"
Cc: Len Brown
Andy Shevchenko (6):
efi: Switch to use new generic UUID API
mei: Switch to use new g
...@unisys.com
Cc: de...@driverdev.osuosl.org
Signed-off-by: Andy Shevchenko
---
drivers/staging/unisys/Documentation/overview.txt | 14 +++
drivers/staging/unisys/include/channel.h | 45 ++--
drivers/staging/unisys/include/iochannel.h | 14 +--
drivers/staging/unisys
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: "Rafael J. Wysocki"
Cc: Mika Westerberg
Cc: linux-a...@vger.kernel.org
Signed-off-by: Andy Shevchenko
---
dr
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Cc: de...@linuxdriverproject.org
Signed-off-by: Andy
are kernel internal types mistakenly put to UAPI in the
first place.
Consistency here is how we treat those types in user space, starting
from v4.13 uuid_be gone from that header. uuid_le is luckily will be
gone soon.
> This file is also used by our kernel
> mode code.
It will work
On Thu, 2017-07-20 at 13:18 +0100, Ard Biesheuvel wrote:
> On 19 July 2017 at 19:28, Andy Shevchenko
> wrote:
> > There are new types and helpers that are supposed to be used in new
> > code.
> >
> > As a preparation to get rid of legacy types and API functi
On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki wrote:
> On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote:
>> On Wed, Jul 19, 2017 at 09:28:57PM +0300, Andy Shevchenko wrote:
>> > There are new types and helpers that are supposed to be used in new code.
>> &g
On Wed, 2017-07-19 at 21:28 +0300, Andy Shevchenko wrote:
> There are new types and helpers that are supposed to be used in new
> code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
>
> While here, re-indent couple of lines to
On Wed, 2017-07-26 at 02:27 +0200, Rafael J. Wysocki wrote:
> On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote:
> > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki > t> wrote:
> > > Andy, do you want me to apply this?
> >
> > If you woul
gt; help
> Support for Intel Classmate PC ACPI devices, including some
> @@ -1000,6 +1001,7 @@ config SAMSUNG_Q10
> tristate "Samsung Q10 Extras"
> depends on ACPI
> select BACKLIGHT_CLASS_DEVICE
> + select BACKLIGHT
On Sun, Jul 30, 2017 at 6:32 PM, Greg Kroah-Hartman
wrote:
> On Wed, Jul 26, 2017 at 01:01:41PM +0300, Andy Shevchenko wrote:
>> On Wed, 2017-07-19 at 21:28 +0300, Andy Shevchenko wrote:
>> > There are new types and helpers that are supposed to be used in new
>> > code.
...@unisys.com
Cc: de...@driverdev.osuosl.org
Signed-off-by: Andy Shevchenko
---
drivers/staging/unisys/Documentation/overview.txt | 14 +++
drivers/staging/unisys/include/channel.h | 29 ++
drivers/staging/unisys/include/iochannel.h | 2 +-
drivers/staging/unisys/include
On Sun, 2017-07-30 at 10:37 -0700, Greg Kroah-Hartman wrote:
> On Sun, Jul 30, 2017 at 08:26:48PM +0300, Andy Shevchenko wrote:
> > On Sun, Jul 30, 2017 at 6:32 PM, Greg Kroah-Hartman
> > wrote:
> > > Doesn't apply to the staging tree at all :(
> >
> >
ID.
> Since I had the same concern I've done a web search and I've been unable
> to find any other devices which seem to use a Whiskey Cove PMIC, but that
> does not mean that there aren't any.
--
With Best Regards,
Andy Shevchenko
include/uapi/linux/hyperv.h is a part of Hyper-V support.
Cc: K. Y. Srinivasan
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Signed-off-by: Andy Shevchenko
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index acf95f158b97..ab96ea3003ef 100644
--- a
ivasan
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Signed-off-by: Andy Shevchenko
---
include/uapi/linux/hyperv.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
index 7560c0aa60e3..aaf32131b556 100644
--- a/include/uapi/linux/hyperv.h
+++
On Sun, 2017-08-13 at 16:34 +0300, Andy Shevchenko wrote:
> The commit 2ffd9e33ce4a
>
> ("x86/hyper-v: Use hypercall for remote TLB flush")
>
> introduced a new C-file where uapi/linux/hyperv.h is included first.
>
> This makes build failed since UAPI h
On Wed, 2017-08-30 at 14:38 +0200, Christoph Hellwig wrote:
> On Mon, Jul 31, 2017 at 08:20:25PM +0300, Andy Shevchenko wrote:
> > Yep! There are so many conflicts that would be better just to push
> > through your tree.
> >
> > I have just sent a v2 of this patch sep
sig_data_offset(struct channel_header *chan_hdr, int q,
> - struct signal_queue_header *sig_hdr, int slot)
> +static int sig_data_offset(struct channel_header *chan_hdr, int q,
> + struct signal_queue_header *sig_hdr, int
> slot)
> {
>
intel_mid_msgbus_*_raw*() are not used anywhere.
Signed-off-by: Andy Shevchenko
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 4 --
.../platform/intel-mid/intel_mid_pcihelpers.c | 58 --
2 files changed, 62 deletions(-)
diff --git a/drivers/staging/media
The d3_delay parameter is set by arch/x86/pci/intel_mid_pci.c and
drivers/pci/quirks.c.
No need to override that settings in unrelated driver.
Signed-off-by: Andy Shevchenko
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 8 --
.../platform/intel-mid/intel_mid_pcihelpers.c
Since we switched to upstream IOSF MBI API the custom code become not in
use anymore.
Signed-off-by: Andy Shevchenko
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 22 -
.../media/atomisp/pci/atomisp2/atomisp_internal.h | 1 -
.../media/atomisp/platform/intel-mid/Makefile
Remove dead code. If someone needs it the P-Unit semaphore is handled by
I2C DesignWare driver (drivers/i2c/busses/i2c-designware-baytrail.c).
Signed-off-by: Andy Shevchenko
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 2 -
.../platform/intel-mid/intel_mid_pcihelpers.c | 101
In many files in the driver the intel-mid.h header inclusion is redundant.
Signed-off-by: Andy Shevchenko
---
drivers/staging/media/atomisp/i2c/imx/drv201.c| 1 -
drivers/staging/media/atomisp/i2c/imx/dw9714.c| 1 -
drivers/staging/media/atomisp
intel_mid_soc_stepping() is not used anywhere.
Signed-off-by: Andy Shevchenko
---
drivers/staging/media/atomisp/include/asm/intel_mid_pcihelpers.h | 1 -
.../media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c| 7 ---
2 files changed, 8 deletions(-)
diff --git a/drivers
There is a common for x86 IOSF MBI API. Move atomisp code to use it.
Signed-off-by: Andy Shevchenko
---
drivers/staging/media/atomisp/pci/Kconfig | 1 +
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 20 +++-
.../media/atomisp/pci/atomisp2/atomisp_v4l2.c | 38
would put OR'ed bits higher.
Like allocate 4 (8) bits for states and start special flagst from bit
8 and so on.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;
> + struct mux_chip *mux_chip;
> + struct resource *res;
> + resource_size_t size;
> + int i, ret;
Ditto.
> + for (i = 0 ; i < ARRAY_SIZE(vbus_providers); i++) {
> + if (!acpi_dev_present(vbus_providers[i].hid, NULL,
> + vbus_providers[i].hrv))
> + continue;
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
container_of(work, struct int3496_data, work.work);
> - int id = gpiod_get_value_cansleep(data->gpio_usb_id);
> + int ret, id = gpiod_get_value_cansleep(data->gpio_usb_id);
Better to keep them on separate lines.
--
With Best Regards,
Andy Shevchenko
___
t PDx86 tree, so
Acked-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
> drivers/platform/x86/Kconfig | 1 +
> drivers/platform/x86/intel_cht_int33fe.c | 23 +++
> 2 files changed, 24 insertions(+)
>
> diff --git a/drivers/platfo
...instead of custom approach
Cc: Joshua Clayton
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 28 +--
1 file changed, 1 insertion(+), 27 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
b/drivers/staging
de(bus)) {
Isn't it the same to
if (!d && pci_fwnode(bus))
d = ...
?
> + d = irq_find_matching_fwnode(pci_fwnode(bus),
> +DOMAIN_BUS_PCI_MSI);
> + }
&
" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nstead of custom raw buffer.
>>
>
> Thanks. I was just following the form of all the others in this file. I
> think that this was done to match up with the representation that's coming
> across the VM boundary from Windows.
Perhaps a separate patch to move to uuid.h
t;
> Yes; I am about to send out a patch to use the UUID_LE macro for all of the
> Hyper-V guids.
And switching to struct uuid_le ?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
glance and now noticed that you call
pci_root_bus_fwnode() twice. So, it actually might be more readable
like your first but modified variant:
if (!d) {
void *fwnode = pci_fwnode(bus);
if (fwnode)
d = irq_find_matching_fwnode(fwnode, DOMAIN_BUS_PCI_MSI);
}
> + }
>
t the same time. I wouldn't change the
current definitions.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
256 - 1));
>
Run checkpatch.pl.
256 looks like sizeof(…).
> psecnetwork->IELength = 0;
> /* Added by Albert 2009/02/18 */
> --
> 2.4.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message t
; + return -ENOMEM;
> + memset(param, 0, param_len);
> + param->cmd = IEEE_CMD_SET_ENCRYPTION;
> + memset(param->sta_addr, 0xff, ETH_ALEN);
> +
> strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN);
> if (pext->
On Wed, 2014-05-07 at 11:55 +0300, Dan Carpenter wrote:
> On Wed, May 07, 2014 at 09:55:47AM +0300, Andy Shevchenko wrote:
> > > @@ -1824,6 +1817,15 @@ static int r871x_wx_set_enc_ext(struct net_device
> > > *dev,
> > > default:
pxmitpriv->pallocated_frame_buf = kmalloc(NR_XMITFRAME * sizeof(struct
> xmit_frame) + 4,
> + GFP_ATOMIC);
> if (pxmitpriv->pallocated_frame_buf == NULL) {
> pxmitpriv->pxmit_frame_buf = NULL;
> return _FAIL;
> @@ -126,8 +126,8 @@ sint _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
> /*init xmit_buf*/
> _init_queue(&pxmitpriv->free_xmitbuf_queue);
> _init_queue(&pxmitpriv->pending_xmitbuf_queue);
> - pxmitpriv->pallocated_xmitbuf = _malloc(NR_XMITBUFF *
> - sizeof(struct xmit_buf) + 4);
> + pxmitpriv->pallocated_xmitbuf = kmalloc(NR_XMITBUFF * sizeof(struct
> xmit_buf) + 4,
> + GFP_ATOMIC);
> if (pxmitpriv->pallocated_xmitbuf == NULL)
> return _FAIL;
> pxmitpriv->pxmitbuf = pxmitpriv->pallocated_xmitbuf + 4 -
> @@ -135,8 +135,8 @@ sint _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
> pxmitbuf = (struct xmit_buf *)pxmitpriv->pxmitbuf;
> for (i = 0; i < NR_XMITBUFF; i++) {
> _init_listhead(&pxmitbuf->list);
> - pxmitbuf->pallocated_buf = _malloc(MAX_XMITBUF_SZ +
> -XMITBUF_ALIGN_SZ);
> + pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ +
> XMITBUF_ALIGN_SZ,
> +GFP_ATOMIC);
> if (pxmitbuf->pallocated_buf == NULL)
> return _FAIL;
> pxmitbuf->pbuf = pxmitbuf->pallocated_buf + XMITBUF_ALIGN_SZ -
> @@ -955,8 +955,8 @@ static void alloc_hwxmits(struct _adapter *padapter)
> struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
>
> pxmitpriv->hwxmit_entry = HWXMIT_ENTRY;
> - pxmitpriv->hwxmits = (struct hw_xmit *)_malloc(sizeof(struct hw_xmit) *
> - pxmitpriv->hwxmit_entry);
> + pxmitpriv->hwxmits = kmalloc(sizeof(struct hw_xmit) *
> pxmitpriv->hwxmit_entry,
> + GFP_ATOMIC);
> if (pxmitpriv->hwxmits == NULL)
> return;
> hwxmits = pxmitpriv->hwxmits;
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c
> b/drivers/staging/rtl8712/usb_ops_linux.c
> index dca398a..064dc10 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -495,7 +495,7 @@ int r8712_usbctrl_vendorreq(struct intf_priv *pintfpriv,
> u8 request, u16 value,
>*/
> u8 *palloc_buf, *pIo_buf;
>
> - palloc_buf = _malloc((u32) len + 16);
> + palloc_buf = kmalloc((u32)len + 16, GFP_ATOMIC);
> if (palloc_buf == NULL) {
> dev_err(&udev->dev, "%s: Can't alloc memory for vendor
> request\n",
> __func__);
--
Andy Shevchenko
Intel Finland Oy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
validates the input.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 33 +
drivers/staging/rtl8188eu/include/wlan_bssdef.h | 4 -
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 153 ++--
3 files changed, 66 insertions(+), 124 deletions
Braswell SoC has two DMA controllers for LPSS. This patch adds them to
supported list in the PCI driver.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw/pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/dma/dw/pci.c b/drivers/dma/dw/pci.c
index 2006ff8..e71bd2e 100644
Instead of using custom code to convert hexdecinal strings to their binary
represantation let's use kernel's library function.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 5 ---
drivers/staging/rtl8188eu/include/wlan_bssdef.h | 1 -
drive
The helper mac_pton() validates and converts MAC address from string format to
a number. Originally code uses simple code to do that. With mac_pton() the
driver now validates input as well.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 11 ++-
drivers
hex_to_bin could be used to convert hexdecimal digit to its binary
representation.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 17 -
drivers/staging/rtl8188eu/include/wlan_bssdef.h | 3 ---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
On Mon, 2014-06-30 at 13:02 +0300, Andy Shevchenko wrote:
Please, ignore this one.
--
Andy Shevchenko
Intel Finland Oy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
f, \v, \a, and \e are escaped to their alphabetic
representation. It's safe to do since the print_ssid() is currently used for
messaging only.
Signed-off-by: Andy Shevchenko
---
net/wireless/lib80211.c | 24 ++--
1 file changed, 2 insertions(+), 22 deletions(-)
diff -
This is almost the opposite function to string_unescape(). Nevertheless it
handles \0 and could be used for any byte buffer.
The documentation is supplied together with the function prototype.
The test cases covers most of the scenarios and would be expanded later on.
Signed-off-by: Andy
Let's use kernel's library function to escape a buffer.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8192e/rtllib.h | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
ind
potential use cases.
Andy Shevchenko (6):
lib / string_helpers: clean up test suite
lib / string_helpers: introduce string_escape_mem()
lib80211: re-use string_escape_mem_any_np()
staging: wlan-ng: re-use string_escape_mem()
staging: rtl8192e: re-use string_escape_mem()
staging: rtl8192u
This patch prepares test suite for a following update. It introduces
test_string_check_buf() helper which checks the result and dumps an error.
Signed-off-by: Andy Shevchenko
---
lib/test-string_helpers.c | 39 +++
1 file changed, 27 insertions(+), 12
This is a generic function to escape strings by given criteria. Let's use it
instead of custom approach.
Signed-off-by: Andy Shevchenko
---
drivers/staging/wlan-ng/prism2sta.c | 29 ++---
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/drivers/staging
Let's use kernel's library function to escape a buffer instead of custom code.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee
On Wed, 2014-07-02 at 06:43 -0700, Joe Perches wrote:
> On Wed, 2014-07-02 at 16:20 +0300, Andy Shevchenko wrote:
> > In kernel we have function to escape a given string. Let's use it instead of
> > custom approach.
> >
> > This fixes a bug. The current implementat
On Wed, 2014-07-02 at 06:35 -0700, Joe Perches wrote:
> On Wed, 2014-07-02 at 16:20 +0300, Andy Shevchenko wrote:
> > Let's use kernel's library function to escape a buffer.
[]
> > @@ -2965,15 +2965,8 @@ static inline const char *escape_essid(const char
On Wed, 2014-07-02 at 14:54 -0700, Andrew Morton wrote:
> On Wed, 2 Jul 2014 16:20:24 +0300 Andy Shevchenko
> wrote:
[]
> > + pr_err("Test '%s' failed: flags = %u\n", name, flags);
> > +
> > + print_hex_dump(KERN_WARNING, "Input: ",
On Wed, 2014-07-02 at 15:01 -0700, Andrew Morton wrote:
> On Wed, 2 Jul 2014 16:20:25 +0300 Andy Shevchenko
> wrote:
>
> > This is almost the opposite function to string_unescape(). Nevertheless it
> > handles \0 and could be used for any byte buffer.
> >
> &
On Wed, 2014-07-02 at 09:30 -0700, Joe Perches wrote:
> On Wed, 2014-07-02 at 17:06 +0300, Andy Shevchenko wrote:
> > On Wed, 2014-07-02 at 06:43 -0700, Joe Perches wrote:
> > > On Wed, 2014-07-02 at 16:20 +0300, Andy Shevchenko wrote:
> > > > In kernel we have fun
On Thu, Aug 28, 2014 at 10:08 PM, Andrew Morton
wrote:
> On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville"
> wrote:
>
>> On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevchenko wrote:
>> > The introduced function is a kind of opposite to string_unescape.
On Fri, Aug 29, 2014 at 12:06 AM, Andrew Morton
wrote:
> On Thu, 28 Aug 2014 23:58:45 +0300 Andy Shevchenko
> wrote:
[]
>> For now (so far no more comments) it is only couple of trivia fixes
>> (removing useless comments). Would you like to resend whole series or
>> ju
On Wed, 2014-08-20 at 12:42 +0300, Andy Shevchenko wrote:
> Instead of substituting non-printable characters by '_' let's print SSID
> properly escaped by using recently added %*pE specifier.
Here is kbuild robot fixup.
>From f88ff364a1b117d3c86186206eeaa54ff906147a Mon S
patch 1/10
- kernel documentation moved to c-file
- when test case fails the necessary messages are printed on KERN_WARNING
level
Andy Shevchenko (10):
lib / string_helpers: move documentation to c-file
lib / string_helpers: refactoring the test suite
lib / string_helpers: introduce string_
This is almost the opposite function to string_unescape(). Nevertheless it
handles \0 and could be used for any byte buffer.
The documentation is supplied together with the function prototype.
The test cases covers most of the scenarios and would be expanded later on.
Signed-off-by: Andy
Let's use kernel's native specifier to escape a buffer.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8192e/rtllib.h | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
ind
.
Additionally by default the \f, \v, \a, and \e are escaped to their alphabetic
representation. It's safe to do since it is currently used for messaging only.
Signed-off-by: Andy Shevchenko
---
include/net/lib80211.h | 5 -
net/wireless/lib80211.c | 32
2
This patch prepares test suite for a following update. It introduces
test_string_check_buf() helper which checks the result and dumps an error.
Signed-off-by: Andy Shevchenko
---
lib/test-string_helpers.c | 39 +++
1 file changed, 27 insertions(+), 12
uot;\220\r]"
%*pEhp "\x1bb \C\x07"\x90\x0d]"
%*pEa "\e\142\040\\\103\a\042\220\r\135"
Please, read Documentation/printk-formats.txt and lib/string_helpers.c kernel
documentation to get further information.
Signed-off-by: An
Instead of custom approach this allows to print escaped strings via recently
added kernel extension: %*pE.
Signed-off-by: Andy Shevchenko
---
drivers/net/wireless/libertas/cfg.c | 8 ++--
drivers/net/wireless/libertas/mesh.c | 7 +++
2 files changed, 5 insertions(+), 10 deletions
This is a generic specifier to print an escaped buffer by given criteria. Let's
use it instead of custom approach.
Signed-off-by: Andy Shevchenko
---
drivers/staging/wlan-ng/prism2sta.c | 28 ++--
1 file changed, 2 insertions(+), 26 deletions(-)
diff --git a/dr
Instead of custom approach this allows to print escaped strings via recently
added kernel extension: %*pE.
Signed-off-by: Andy Shevchenko
---
drivers/net/wireless/ipw2x00/ipw2100.c | 22 +--
drivers/net/wireless/ipw2x00/ipw2200.c | 270 ++-
drivers/net/wireless
The documentation of API belongs to c-file. This patch moves it accordingly.
There is no functional change.
Signed-off-by: Andy Shevchenko
---
include/linux/string_helpers.h | 34 --
lib/string_helpers.c | 38 ++
2
Let's use kernel's native specifier to escape a buffer.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
b/drivers/stagin
On Mon, 2014-07-07 at 09:50 -0700, Joe Perches wrote:
> On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote:
>
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> []
> > static noinline_for_stack
> > +char *escaped_string(char *buf, char *end, u8 *addr, s
On Mon, 2014-07-07 at 09:25 -0700, Joe Perches wrote:
> [trivial notes]
Thanks! Fixed locally, though am waiting for few more days if any other
comment comes.
>
> On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote:
> > This allows user to print a given buffer as esaped st
This is almost the opposite function to string_unescape(). Nevertheless it
handles \0 and could be used for any byte buffer.
The documentation is supplied together with the function prototype.
The test cases covers most of the scenarios and would be expanded later on.
Signed-off-by: Andy
Let's use kernel's native specifier to escape a buffer.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8192e/rtllib.h | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
ind
Instead of substituting non-printable characters by '_' let's print SSID
properly escaped by using recently added %*pE specifier.
Signed-off-by: Andy Shevchenko
---
drivers/net/wireless/hostap/hostap_proc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --gi
This is a generic specifier to print an escaped buffer by given criteria. Let's
use it instead of custom approach.
Signed-off-by: Andy Shevchenko
---
drivers/staging/wlan-ng/prism2sta.c | 28 ++--
1 file changed, 2 insertions(+), 26 deletions(-)
diff --git a/dr
This patch prepares test suite for a following update. It introduces
test_string_check_buf() helper which checks the result and dumps an error.
Signed-off-by: Andy Shevchenko
---
lib/test-string_helpers.c | 39 +++
1 file changed, 27 insertions(+), 12
.
Additionally by default the \f, \v, \a, and \e are escaped to their alphabetic
representation. It's safe to do since it is currently used for messaging only.
Signed-off-by: Andy Shevchenko
---
include/net/lib80211.h | 5 -
net/wireless/lib80211.c | 32
2
t;\eb \C\a"\220\r]"
%*pEhp "\x1bb \C\x07"\x90\x0d]"
%*pEa "\e\142\040\\\103\a\042\220\r\135"
Please, read Documentation/printk-formats.txt and lib/string_helpers.c kernel
documentation to get further information.
Signed-of
The documentation of API belongs to c-file. This patch moves it accordingly.
There is no functional change.
Signed-off-by: Andy Shevchenko
---
include/linux/string_helpers.h | 34 --
lib/string_helpers.c | 38 ++
2
Instead of custom approach this allows to print escaped strings via recently
added kernel extension: %*pE.
Signed-off-by: Andy Shevchenko
---
drivers/net/wireless/libertas/cfg.c | 8 ++--
drivers/net/wireless/libertas/mesh.c | 7 +++
2 files changed, 5 insertions(+), 10 deletions
Let's use kernel's native specifier to escape a buffer.
Signed-off-by: Andy Shevchenko
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
b/drivers/stagin
instead of direct string_escape_mem call,
as a result the series and code looks cleaner
- address few of Andrew's comments:
- added patch 1/10
- kernel documentation moved to c-file
- when test case fails the necessary messages are printed on KERN_WARNING
level
Andy Shevche
201 - 300 of 359 matches
Mail list logo
