break;
> case POWER_SUPPLY_PROP_CHARGE_COUNTER:
> ret = olpc_ec_cmd(EC_BAT_ACR, NULL, 0, (void *)&ec_word, 2);
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
e
> #include
> -#include
> +#include
> #include
> #include
> #include
> @@ -328,4 +326,8 @@ static int __init olpc_ec_init_module(void)
> {
> return platform_driver_register(&olpc_ec_plat_driver);
> }
> +
> arch_initcall(olpc_e
-15,7 +15,6 @@
> #include
> #include
> #include
> -#include
>
> struct ec_cmd_desc {
> u8 cmd;
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ARM
depends on OLPC && ARM // or ARM64 or whatever it's called
thus, above would look like
depends on MOUSE_PS2
depends on OLPC && X86
and
depends on FB
depends on OLPC && X86
respectively.
--
With Best Regards,
Andy Shevchenko
___
registered. */
> + if (!ec_driver)
> + return -ENODEV;
Why -ENODEV is preferred over -EPROBE_DEFER?
> +
> + if (WARN_ON(!ec_driver->ec_cmd))
> return -ENODEV;
>
> if (!ec)
> --
> 2.19.0
>
--
With
0x40
> +#define EC_SCI_SRC_BATCRIT 0x80
> +#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
BIT() ?
> +#define EC_SCI_SRC_ALL 0x1FF
GENMASK()?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
defined as boolean, supplied an int. Not good.
> + return olpc_ec_set_dcon_power(ec, 0);
Ditto.
> +static int dcon_regulator_is_enabled(struct regulator_dev *rdev)
> + return ec->dcon_enabled;
Ditto.
--
With Best Regards,
Andy Shevchenko
"\" /pci/display@1\" find-device"
> " new-device"
> " \" dcon\" device-name \" olpc,xo1-dcon\"
> +compatible"
> " finish-device device-end");
.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
> #include
Keep it sorted, otherwise the change is good!
Reviewed-by: Andy Shevchenko
>
>
> @@ -622,11 +623,13 @@ static int olpc_battery_probe(struct platform_device
> *pdev)
>
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> The global variables for private data are not too nice. I'd like some
> more, and that would clutter the global name space even further.
>
Good change!
Reviewed-by: Andy Shevchenko
> Signed-off-by: Lubomir Rintel
&g
tocol, supported by 0x44 and
> above.
> +*/
> printk(KERN_NOTICE "OLPC EC version 0x%02x too old for "
> - "battery driver.\n", olpc_platform_info.ecver);
> + "battery driver.\n", ecver[0]);
> return -ENXIO;
> }
>
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
@ static int olpc_battery_probe(struct platform_device
> *pdev)
> if (ecver[0] > 0x44) {
> /* XO 1 or 1.5 with a new EC firmware. */
> data->new_proto = 1;
> + } else if (of_find_compatible_node(NULL, NULL, "
I'm about to review the patch 6, otherwise read my comments for the
rest and consider addressing them.
>
> Lubo
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;
> + if (!priv->pwrbtn)
> + return -ENOMEM;
> + priv->pwrbtn->name = "Power Button";
> + priv->pwrbtn->dev.parent = &spi->dev;
> + input_set_capability(priv->pwrbtn, EV_KEY, KEY_POWER);
> + ret = input_registe
that change the same line or
> function for example. Order them with cleanups / non-functional-changes
> first, followed by functional changes.
>
> >
> > Basically all of the above is based on the review by Andy Shevchenko.
>
> Andy, what was your intent for Lubomir here?
's PM tree,
Note, atomisp change is tagged by Sakari on behalf of media tree maintainers.
Andy Shevchenko (9):
media: atomisp: Remove unused header
cpufreq: sfi-cpufreq: Remove driver for deprecated firmware
sfi: Remove framework for deprecated firmware
x86/PCI: Get rid of custom x86 m
Switch the platform code to use x86_id_table and accompanying API
instead of custom comparison against x86 CPU model.
This is one of the last users of custom API for that and following
changes will remove it for the good.
Signed-off-by: Andy Shevchenko
---
arch/x86/pci/intel_mid_pci.c | 17
SFI-based platforms are gone. So does this driver.
Signed-off-by: Andy Shevchenko
Acked-by: Linus Walleij
---
drivers/cpufreq/Kconfig.x86 | 10 ---
drivers/cpufreq/Makefile | 1 -
drivers/cpufreq/sfi-cpufreq.c | 127 --
3 files changed, 138 deletions
sfi.h is not anyhow used by the driver. Remove it.
Signed-off-by: Andy Shevchenko
Acked-by: Sakari Ailus
Acked-by: Linus Walleij
---
drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/include/linux
Update Copyright year and drop file names from files themselves.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h| 4 ++--
arch/x86/platform/intel-mid/intel-mid.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/intel-mid.h
'reg'
not described in 'type1_access_ok'
Signed-off-by: Andy Shevchenko
---
arch/x86/pci/intel_mid_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 938a8b7bfe7f..8edd62206604 100644
--- a/arch/x86/pci/inte
Since there is no more user of this global variable and associated custom API,
we may safely drop this legacy reinvented a wheel from the kernel sources.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h| 23 ---
arch/x86/platform/intel-mid/intel
The header is used by a single user. Move header content to that user.
Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
---
arch/x86/include/asm/intel_scu_ipc.h| 2 --
arch/x86/include/asm/intel_scu_ipc_legacy.h | 18 --
arch/x86/platform/intel-mid/intel
After the commit f1be6cdaf57c ("x86/platform/intel-mid: Make
intel_scu_device_register() static") the platform_device.h is not being
used anymore by intel-mid.h. Remove it.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h | 1 -
1 file changed, 1 deletion(-)
di
SFI-based platforms are gone. So does this framework.
This removes mention of SFI through the drivers and other code as well.
Signed-off-by: Andy Shevchenko
Reviewed-by: Hans de Goede
Acked-by: Linus Walleij
---
Documentation/ABI/testing/sysfs-firmware-sfi | 15 -
Documentation/ABI/testing
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote:
> On Mon, 1 Feb 2021 19:40:21 +0200
> Andy Shevchenko wrote:
>
> > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> > > On Fri, 29 Jan 2021 16:26:12 +0200
> > > Andy Shevchenko wrote:
> > > > On Fri,
y using the smaller v4l2_pix_format structure
> directly. This reduces the stack usage to 612 bytes, and it could
> be reduced further by only storing the three members that are used.
Good to me!
Reviewed-by: Andy Shevchenko
> Signed-off-by: Arnd Bergmann
> ---
> .../staging/me
linux.o(.data+0x1a8948): Section mismatch in
> > reference from the variable qede_forced_speed_maps to the variable
> > .init.rodata:__setup_str_initcall_blacklist
> Barry, can I get a fix for this?
Max already pointed out, but I guess you were not in Cc list, that
it's a GCC bug in his opinion, but GCC people don't ack it.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
quest/direction_output fail");
> - goto fail2;
> + goto fail3;
> }
> return atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH);
> -fail2:
> +fail3:
> media_entity_cleanup(&flash->sd.entity);
> v4l2_ctrl_handler_fr
s.
> +static int __attribute__((format (printf, 1, 0)))
> +atomisp_css2_dbg_ftrace_print(const char *fmt, va_list args)
> {
> ftrace_vprintk(fmt, args);
> return 0;
> }
>
Why not to drop it completely as well?
> -static int atomisp_css2_err_print(const char *fmt, va_list args)
> -{
ty much unsigned int i.
> There are very few times where raising the type maximum from 2 billion
> to 4 billion fixes anything.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ree(buffer.pointer);
> >> + return status;
> >> +}
> >> +static int get_acpi_ssdb_sensor_data(struct device *dev,
> >> + struct sensor_bios_data *sensor)
> >> +{
> >> + struct sensor_bios_data_
rs/media/pci/intel
IPU3 from Freescale (IIRC) is a different story.
> Hopefully with more users of the IPU3 brought in by this cio2-bridge,
> that will help gather momentum to get the IPU3 developments required
> completed and moved into drivers/media.
--
With Best Regards,
Andy Shevc
On Thu, Sep 17, 2020 at 4:53 PM Dan Scally wrote:
>
> Hi Andy, thanks for input (as always)
You're welcome! I'm really impressed by your activity in this area.
> On 17/09/2020 13:45, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
On Thu, Sep 17, 2020 at 5:19 PM Kieran Bingham
wrote:
> On 17/09/2020 15:08, Andy Shevchenko wrote:
...
> Ayee, ok so we have 'half' the driver for IPU3 out of staging.
Correct. And your below analysis is correct.
> From my understanding, the IPU3 consists of two component
On Thu, Sep 17, 2020 at 02:36:22PM +0100, Dan Scally wrote:
> On 17/09/2020 13:45, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
> >> On 17/09/2020 11:33, Sakari Ailus wrote:
> > I will do better review for next version, assuming y
On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote:
> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
> > > On 17/09/2020 11:33, Sakari Ailus wrote:
> > > > a module and not
On Mon, Sep 21, 2020 at 02:33:57PM +0100, Dan Scally wrote:
> On 18/09/2020 14:07, Andy Shevchenko wrote:
> > On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote:
> >> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote:
> >>> On Thu, Sep 17,
prim_out_info,
> @@ -6009,6 +6014,9 @@ static int load_primary_binaries(
> online = pipe->stream->config.online;
> #ifdef ISP2401
> sensor = (pipe->stream->config.mode == IA_CSS_INPUT_MODE_SENSOR);
> +#else
> + memory = pipe->stream->con
On Thu, Oct 1, 2020 at 6:55 PM Mauro Carvalho Chehab
wrote:
> Em Thu, 1 Oct 2020 18:50:12 +0300
> Andy Shevchenko escreveu:
>
> > On Thu, Oct 1, 2020 at 2:17 PM Mauro Carvalho Chehab
> > wrote:
> > >
> > > A temporary var needed for building with ISP
omisp_compat_ioctl32"), nothing in this file is actually getting used
> as the only reference has been stubbed out.
>
> Remove the entire file -- anyone willing to restore the functionality
> can equally well just look up the contents in the git history if needed.
Good one!
Reviewed-by:
and make sure they all finished
> unbinding before we do.
Wait, if it's a device, why do we need all these?
get_device() / put_device() along with module_get() / module_put()
should be sufficient, no?
--
With Best Regards,
Andy Shevchenko
__
rpi_firmware_put(rpipwm->firmware);
> +
> + return ret;
Can't you use the usual pattern?
ret = ...
if (ret)
return ret;
...
return 0;
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko
---
v2: dropped struct removal (Sven), rebased on top of v5.10-rc1
drivers/staging/fieldbus/anybuss/hms-profinet.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss
On Wed, Oct 28, 2020 at 07:39:58PM -0400, Sven Van Asbroeck wrote:
> On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko
> wrote:
> >
> > + return snprintf(buf, max_size, "%pM\n", response.addr);
>
> Judging from a few Outreachy patches that have hit my inbox,
if (!kref_get_unless_zero(&fw->consumers))
> + return NULL;
Don't we have a more traditional way of doing this, i.e.
try_module_get() coupled with get_device() ?
> + return fw;
> }
--
With Best Regards,
Andy Shevchenko
___
OCs and make code easier to read and understand.
> + for (i = 0; i < to_copy; i++)
> + txbuf16[i] = cpu_to_be16(vmem16[i]);
If both of them are 16-bit wide, consider moving this to a helper
which somebody can move to byteorder/generic.h in the future.
> + vmem16 = vmem16 + to_copy;
> + ret = par->fbtftops.write(par, par->txbuf.buf,
> +startbyte_size + to_copy * 2);
> + if (ret < 0)
> + return ret;
> + remain -= to_copy;
> + }
> +
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Jan 28, 2021 at 4:33 PM Andy Shevchenko
wrote:
> On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
...
> Taking all together you probably need to create a helper and use it
> inside init_display(), like
>
> static int init_tearing_effect_line(struct fbtft_par *par)
> {
On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> On Thu, 28 Jan 2021 16:33:02 +0200
> Andy Shevchenko wrote:
> > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
> >
> > Thanks for your contribution, my comments below.
> >
> > > From: zhangxuezhi
> >
&
On Fri, Jan 29, 2021 at 2:47 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
> > > > On Thu, Jan
On Fri, Jan 29, 2021 at 2:54 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
...
> > This one is not like
On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
We are almost there, I have no idea what Noralf or others are going to
say though.
...
> Hi, I apologize for what I said in the previous two emails. I missed
> one email you
On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> On Fri, 29 Jan 2021 16:26:12 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> > > On Fri, 29 Jan 2021 12:23:08 +0200
> > > Andy Shevchenko wrote:
...
> > > Hi, I apolog
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Cc: de...@linuxdriverproject.org
Signed-off-by: Andy
mote_port_parent.
>
May I ask if it's going to be used outside of v4l2?
Any user in mind?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t;> ld: drivers/iio/common/hid-sensors/hid-sensor-attributes.c:314: undefined
> >> reference to `__umoddi3'
> >> ld: drivers/iio/common/hid-sensors/hid-sensor-attributes.c:324: undefined
> >> reference to `__udivdi3'
propriate.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 61f0286fb157..2122c4407bdb 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/s
E conversion.
> I'll post the patches I made for that later, as they need more
> testing and review from the scsi maintainers.
>
> I hope you can still take these for the coming merge window, unless
> new problems come up.
> drivers/platform/x86/wmi.c
decs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -1405,7 +1405,7 @@ static int max98088_get_channel(struct
> snd_soc_component *component, const char
> {
> int ret;
>
> - ret = __match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name);
> + ret = match_s
tl8723bs/os_dep/ioctl_linux.c| 12 +++-
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
flag here.
Second, Devid, please answer to the following:
is it an official BIOS which is available in the wild?
If it's so, please, add a paragraph to the commit message explaining how do you
get this and point to the DSDT excerpt.
Put an
nd without -D implied?)
Other than that - nice clean up!
Reviewed-by: Andy Shevchenko
> Tested-by: Carlo Caione
> Signed-off-by: Pierre-Louis Bossart com>
> ---
> drivers/staging/media/atomisp/Kconfig | 1 +
> drivers/staging/media/atomisp/platform/Makefile| 1
On Wed, 2017-09-20 at 12:01 -0500, Pierre-Louis Bossart wrote:
>
> On 09/20/2017 04:12 AM, Andy Shevchenko wrote:
> > On Tue, 2017-09-19 at 15:45 -0500, Pierre-Louis Bossart wrote:
> > > The Atom ISP driver initializes and configures PMC clocks which
> > > are
>
int ret;
+ empty line.
Please check all functions.
> + dev_dbg(&client->dev, "@%s:\n", __func__);
Noise. Remove.
Do this for all similar cases.
> + mutex_lock(&dev->input_lock);
> +
> + ret = ov5648_write_reg(client, OV5648_8
converting to smbus calls and regulator
framework) would be a material for future changes.
Other than that, please, address the rest of comments and we will be fine.
You may also refer to my last patch series WRT atomisp driver where I
tried to address my own comments to the rest of the code.
--
Name (_CID, "INT5648") // _CID: Compatible ID
> Name (_SUB, "INTL") // _SUB: Subsystem ID
> Name (_DDN, "ov5648") // _DDN: DOS Device Name
> ...
>
> I was not able to properly test this patch on my Lenovo Miix 310 due
> to ot
(u32)DELAY_MAX_PER_STEP_NS));
Since you are touching this, it might make sense to convert to
min_t(u32, ...)
...and locate lines something like:
ktime_t timeday = ns_to_ktime(min_t(u32,
param1,
param2));
>From my pov will make reada
case of ov2680, we don't seem to use the timestamp at
> all, so I just remove it.
>
Yep,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Arnd Bergmann
> ---
> v2: use min_t() as suggested by Andy Shevchenko
> ---
> drivers/staging/media/atomisp/i2c/ov2680.h|
On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore wrote:
> Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
>
Suggested-by ?
> Signed-off-by: John Whitmore
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +
> 1 file changed,
uffer, sizeof(tmp)))
> return -EFAULT;
> tmp[sizeof(tmp) - 1] = '\0';
>
> if (sscanf(tmp, "%u", &g_wait_hiq_empty) != 1)
> return -EINVAL;
>
> return count;
Shouldn't this be
kstrtouint_from_user()
instead of all those lines?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t; eth_random_addr(mac_addr);
>
>> If yes, I'm not sure how to proceed as these are the very first patches I
>> send.
>> Should I send a v2 patch with both changes or just a v2 with "np" removed and
>> another one for adding 'i
dress from efuse error, assign random
> one !!!\n");
> }
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
memcpy(mac_addr, mac, ETH_ALEN);
> - DBG_871X("MAC Address from efuse error, assign
> default one !!!\n");
> + eth_random_addr(mac_addr);
> + DBG_871X("MAC Address from efuse error, assign random
> one !!!\n");
> }
> }
>
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
DBG_871X("MAC Address from efuse error, assign random
> one !!!\n");
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
put since mac_pton()
> returns false if the string is not valid.
>
FWIW,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Michael Straube
> ---
> .../staging/rtl8723bs/core/rtw_ieee80211.c| 30 +++
> .../staging/rtl8723bs/os_dep/ioctl_linux.c| 3 --
> 2 files
On Mon, Jun 25, 2018 at 3:24 PM, Dan Carpenter wrote:
> On Mon, Jun 25, 2018 at 12:47:44PM +0300, Andy Shevchenko wrote:
>> On Fri, Jun 22, 2018 at 1:28 PM, Dan Carpenter
>> wrote:
>> > On Thu, Jun 21, 2018 at 08:21:55PM +0200, Michael Straube wrote:
>> >&g
On Wed, Jun 27, 2018 at 4:11 PM, Dan Carpenter wrote:
> On Wed, Jun 27, 2018 at 02:56:00PM +0200, Michael Straube wrote:
>> Should I add a thanks line to the commit message:
>>
>> Thanks to Dan Carpenter, Joe Perches and Andy Shevchenko.
>>
>> Or would that b
kernel source tree.
Something like `git grep -n rtw_ioctl_rtl.h` in this case.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He wrote:
> On 06/12/18 at 05:24pm, Andy Shevchenko wrote:
>> On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
>> wrote:
>> > I briefly looked at the code and error codes we have, so, my proposal
>> > is one of the followi
On Wed, Jul 4, 2018 at 7:10 AM, Baoquan He wrote:
> reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c
> and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c
> so that it's shared.
With couple of comments below,
Reviewed-by: Andy Shevchenko
pci_mem2
>> 73b4390f Ralf Baechle 2008-07-16 58 };
>> 73b4390f Ralf Baechle 2008-07-16 59
>>
>> :: The code at line 57 was first introduced by commit
>> :: 73b4390fb23456964201abda79f1210fe337d01a [MIPS] Routerboard 532:
>> Suppo
;,
> +p->name, p, res->name);
Now, PCI is a bit confusing here.
> + }
> + return 0;
> +}
> +EXPORT_SYMBOL(reparent_resources);
> +
> static void __init __reserve_region_with_split(struct resource *root,
> resource_size_t start, resource_size_t end,
> const char *name)
> --
> 2.13.6
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jul 18, 2018 at 7:36 PM, Andy Shevchenko
wrote:
> On Wed, Jul 18, 2018 at 5:49 AM, Baoquan He wrote:
>> reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c
>> and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c
>> so that it'
udelay(20);
> gpio_set_value(par->gpio.reset, 1);
> - mdelay(120);
> + msleep(120);
I didn't look to the rest, but this one will be inconsistent after your patch.
The question here is why udelay() is needed, while mdelay() changed?
--
ect (linuxtesting.org).
Have you based your change on staging-next?
Seems not. You need to rebase and resend.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
alking for himself :-)
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ral shape of the code), and the
> > original
> > ccp-platform.c is no longer built.
> >
> > Shouldn't ccp-platform.c be deleted by this patch?
> >
>
> Good catch. Both ccp-platform.c and ccp-pci.c should have been
> deletedÂ
> by this p
0x2B00);
> write_reg(par, 0x1E, 0x00B7);
> write_reg(par, 0x01,
> - (1 << 13) | (par->bgr << 11) | (1 << 9) | (HEIGHT - 1));
> + (BIT(13)) | (par->bgr << 11) | (BIT(9)) | (HEIGHT - 1));
> write_reg(par, 0x02, 0x0600);
> write_reg(par, 0x10, 0x);
> write_reg(par, 0x05, 0x);
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Mar 22, 2017 at 6:18 PM, Andy Shevchenko
wrote:
> On Wed, Mar 22, 2017 at 4:37 AM, Arushi Singhal
> wrote:
>> This patch replaces bit shifting on 1 with the BIT(x) macro.
>> This was done with coccinelle:
>> @@
>> constant c;
>> @@
>>
>> -
On Thu, 2018-04-19 at 10:41 +0200, Linus Walleij wrote:
> To make sure that these drivers do not leave staging before they
> are properly converted to use the new GPIO descriptor API,
> augment the TODO file with this work item.
Fine by me.
Acked-by: Andy Shevchenko
> Cc: Alan Cox
f-by: Kirill Marinushkin
> Cc: Eric Anholt
> Cc: Stefan Wahren
> Cc: Greg Kroah-Hartman
> Cc: Florian Fainelli
> Cc: Ray Jui
> Cc: Scott Branden
> Cc: Andy Shevchenko
> Cc: bcm-kernel-feedback-l...@broadcom.com
> Cc: linux-rpi-ker...@lists.infradead.org
> Cc: lin
t before.
Ah, okay, send new version as a separate thread and if I have time I
would review it.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t;
> - if (!atomisp_subdev_get_rect(sd, cfg, which, pad, target))
> + p = atomisp_subdev_get_rect(sd, cfg, which, pad, target);
> + if (!p)
> return -EINVAL;
> - *r = *atomisp_subdev_get_rect(sd, cfg, which,
tty->driver->driver_name);
It looks like DRIVER_STRING should be converted to const * const.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
to use well established patterns, i.e.
if (ret)
return ret;
> + if (!ret)
> + ret = wait_for_response(hdev, &comp_pkt.host_event);
Here it looks okay on the first glance, but better to think about it
again and refactor.
--
With
if it's false positive. At which circumstances that may happen?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
/* not completely contained */
Usually we are expecting real eeror codes.
> + if (firstpp == NULL)
> + firstpp = pp;
> + }
> + if (firstpp == NULL)
> + return -1; /* didn&#x
On Tue, Jun 12, 2018 at 12:38 PM, Baoquan He wrote:
> On 06/12/18 at 11:29am, Andy Shevchenko wrote:
>> On Tue, Jun 12, 2018 at 6:28 AM, Baoquan He wrote:
>> > +{
>>
>> > + for (pp = &parent->child; (p = *pp) != NULL; pp = &p->sibling)
On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
wrote:
> On Tue, Jun 12, 2018 at 12:38 PM, Baoquan He wrote:
>> On 06/12/18 at 11:29am, Andy Shevchenko wrote:
>>> On Tue, Jun 12, 2018 at 6:28 AM, Baoquan He wrote:
>
>>> > +{
>>>
>>> > +
t; }
>
> #ifdef VERBOSE_DEBUG
> - print_hex_dump_bytes("rtllib_rx_DELBA(): ", DUMP_PREFIX_NONE,
> skb->data,
> + print_hex_dump_bytes("%s():", __func__, DUMP_PREFIX_NONE, skb->data,
> skb->len);
> #endif
> delba = (struct rtllib_hdr_3addr *)skb->data;
> --
> 1.9.1
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
1 - 100 of 359 matches
Mail list logo
