Thanks for the detailed review
Laura Abbott писал 30.06.2015 20:56:
On 06/30/2015 08:34 AM, Andrew Andrianov wrote:
if (!idev)
+ return -ENOMEM;
+ }
Yeah this is a bit messy as your comments note. Since there can only be
one Ion
device in the system, it
Laura Abbott писал 30.06.2015 20:54:
(adding devicetree mailing list since I didn't see it cc-ed)
Please also remember to cc the staging list since Ion is
still a staging framework.
On 06/30/2015 08:34 AM, Andrew Andrianov wrote:
Signed-off-by: Andrew Andrianov
---
Documentation/devic
lper utils? I had to call it liblinuxion, since libion is
something
already present in repositories.
--
Regards,
Andrew
RC Module
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
properties.
Signed-off-by: Laura Abbott
Signed-off-by: Andrew Andrianov
---
drivers/staging/android/ion/devicetree.txt | 53
++
I have no issue with this going in here, but I do have lots of issues
with this binding.
1 file changed, 53 insertions(+)
create mode
On 2015-10-07 21:36, Rob Herring wrote:
On Wed, Oct 7, 2015 at 5:36 AM, Andrew wrote:
On 2015-10-07 02:01, Laura Abbott wrote:
On 10/6/15 3:35 PM, Rob Herring wrote:
On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott
wrote:
From: Laura Abbott
This adds a base set of devicetree bindings
3.14#n53
[2]
https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.14/tree/drivers/staging/android/ion/msm/msm_ion.c?h=msm-3.14#n398
-Mitch
--
Regards,
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
20 октября 2015 г., 19:34, "Mitchel Humpherys"
написал:
> On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote:
>
>> On 2015-10-12 21:39, Mitchel Humpherys wrote:
>>> On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring
>>> wrote:
>>>> On T
unused. rtc.c
does nothing with interrupts for example. Do you plan to make use of
this extra code? Or can it be removed leaving just what is needed?
struct dprtc_cmd_get_irq - Putting pad at the beginning of a struct
seems very odd. And it is not the only example.
Andrew
___
se the space. But you have to be sure the
current code is correctly ignoring it and setting it to zero.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
p; ETHERNET
With the move out of staging, i don't think these two are required.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, 11 Oct 2018 09:55:03 +0200 Michal Hocko wrote:
> > > > > This is now not called anymore, although the xen/hv variants still do
> > > > > it. The function seems empty these days, maybe remove it as a followup
> > > > > cleanup?
> > > > >
> > > > > > - __online_page_increment_counters(pag
On Mon, 05 Nov 2018 15:12:27 +0530 Arun KS wrote:
> On 2018-10-22 16:03, Arun KS wrote:
> > On 2018-10-19 13:37, Michal Hocko wrote:
> >> On Thu 18-10-18 19:18:25, Andrew Morton wrote:
> >> [...]
> >>> So this patch needs more work, yes?
> >>
&g
On Mon, 29 Oct 2018 06:18:11 + chouryzhou(周威)
wrote:
> We are working for running android in container, but we found that binder is
> not isolated by ipc namespace. Since binder is a form of IPC and therefore
> should
> be tied to ipc namespace. With this patch, we can run more than one a
On Wed, 7 Nov 2018 01:48:12 + chouryzhou(周威) wrote:
> > > --- a/ipc/namespace.c
> > > +++ b/ipc/namespace.c
> > > @@ -56,6 +56,9 @@ static struct ipc_namespace *create_ipc_ns(struct
> > user_namespace *user_ns,
> > > ns->ucounts = ucounts;
> > >
> > > err = mq_init_ns(ns);
> >
, it's mainly an android patch so I suggest this be taken via the
android tree.
Acked-by: Andrew Morton
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Good Day,
I have a business proposal for you and it's 100% legal.
Barrister Andrew Tochaile.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Good Day,
I have a business proposal for you and it's 100% legal.
Barrister Andrew Tochaile.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
dev_ops) {
> free_netdev(dev);
Setting dev->netdev_ops to NULL to indicate an error is pretty
odd. But this is staging. How about cleaning this
up. of_phy_register_fixed_link() returns an -errno which you should
return.
Andrew
_
}
> + }
> +
> if (!dev->netdev_ops) {
> free_netdev(dev);
> } else if (register_netdev(dev) < 0) {
> --
> 2.10.2
I would also expect a call to of_phy_der
match a destination MAC address of xD:XX:XX:XX:XX:XX.
> /* Port received 0xd preamble */
> work->packet_ptr.s.addr += i;
> work->word1.len -= i + 4;
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Fixed a coding style issue.
Signed-off-by: Andrew Bridges
---
drivers/android/binder.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index b5117576792b..3241d233a12d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
be removed?
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi
I would like to make use of an ISA card which generates IRQ 5
preferably using user-space code only, if possible.
Does anybody know of any example code using uio_pdrv_genirq
which could be adapted for this purpose?
Or, does anyone have a simple example kernel module?
Thanks!
Andrew
; + msg[1].len = len;
> + msg[1].buf = val;
You potentially have the same issue with val.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ksz9897: ksz9897@0 {
Hi Sergio
You should use a generic name here. Plus the @X needs to be the same as the reg
value.
So switch: ksz9897@5f.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> I'll change these two to to get memory from kernel allocators instead
> of using the stack. Thanks for let me know this.
There appear to be other cases as well. Please review the whole
driver.
Thanks
Andrew
___
de
.read8 = ksz_i2c_read8,
> + .read16 = ksz_i2c_read16,
> + .read24 = ksz_i2c_read24,
> + .read32 = ksz_i2c_read32,
> + .write8 = ksz_i2c_write8,
> + .write16 = ksz_i2c_write16,
> + .write24 = ksz_i2c_write24,
> + .write32 = ksz_i2c_write32,
> +
etting the devicetree GIT tree or something like that.
>
> Actually, this was rebased onto linux-next. Which tree do you want me
> to rebase onto?
Hi Sergio
It should be based on net-next. However, that is closed now, so please
wait until it reopens in about two wee
"GPL v2" [GNU Public License v2]
So the SPDX string probably does not match the MODULE_LICENSE.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> See the patch about all of this from Thomas on lkml yesterday for
> why this is the case.
Hi Greg
Thanks for the info. I had not seen this, and i guess other have not
as well. So here is a link to the patch.
https://lkml.org/lkml/2019/1/28/1975
On Wed, 27 Feb 2019 13:32:14 +0800 Dave Young wrote:
> This series have been in -next for some days, could we get this in
> mainline?
It's been in -next for two months?
> Andrew, do you have plan about them, maybe next release?
They're all reviewed except for "xe
else
> + priv->phy_mode = PHY_INTERFACE_MODE_RGMII;
Humm, that is unique, as far as i know. Every other MAC driver uses
of_get_phy_mode() to get the value out of device tree. The proprietary
delay values can then be used to fine tune the basic delay setting
read from DT.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
to various patches, however for all the patches
you can add:
Reviewed-by: Andrew Murray
>
> Changes in v3:
> - Updated commits description.
> - Refactored "< PCI_ROM_RESOURCE" with "< PCI_STD_NUM_BARS" in loops.
> - Refactored "<= BAR_5"
he machine. A WARN() and a return of -EINVAL would be
better.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
this is a switch driver, please
ensure you Cc: the usual suspects for switch drivers.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
e going away.
The mmdrop_async stuff should be moved into fork.c (and maybe made
static) as well. It's pointless having this stuff global and inlined,
especially mmdrop_async_fn().
Something like the below, not yet tested...
From: Andrew Morton
Subject: include/linux/sched/mm.h: un
ver
> can be found in the associated README file.
Hi Razvan
You should probably Cc: netdev with these patches, if you want people
who have written switch drivers to review you code. You can also drop
linux-arm-kernel, since there is nothing ARM specific in these
patches.
or a DSA driver.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
> + strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version));
Software driver versions are mostly useless. I would suggest you
remove this.
Andrew
__
On Tue, Oct 03, 2017 at 10:07:41AM +, Razvan Stefanescu wrote:
> > -Original Message-
> > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org]
> > On Behalf Of Andrew Lunn
> > Sent: Tuesday, September 19, 2017 3:18 PM
> > To:
> + case PORT_MODE_40G_KR4:
> + priv->get_link = bgx_port_get_xaui_link;
> + priv->set_link = bgx_port_set_xaui_link;
> + break;
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
priv->phydev->duplex == DUPLEX_FULL ?
> + "Full" : "Half");
> + } else {
> + netdev_info(netdev, "Link is down\n");
> + }
phy_print_status
-driver.c
> rename to drivers/bus/fsl-mc/dprc-driver.c
Hi Laurentiu
It is hard to review code when we don't see it.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
";
> + reg = <0x00011800 0xe000 0x 0x0100>;
Hi David
In the probe function we have:
+ reg = of_get_property(pdev->dev.of_node, "reg", NULL);
+ addr = of_translate_address(pdev->dev.of_node, reg);
+ interface = (addr >&
clear. Cut the rest.
Thanks
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;s fine.
There are also :
uapi/linux/ethtool.h:#define SPEED_10 10
uapi/linux/ethtool.h:#define SPEED_100 100
uapi/linux/ethtool.h:#define SPEED_1000 1000
uapi/linux/ethtool.h:#define SPEED_11
uapi/linux/ethtool.h:#define SPEED_10 10
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_change_mtu(struct net_device *netdev, int new_mtu)
> +{
> + struct bgx_port_priv *priv = bgx_port_netdev2priv(netdev);
> + int max_frame;
> +
> + if (new_mtu < 60 || new_mtu > 65392) {
See dev_set_mtu(). If you have done your initialisation correctly, this
won't happen.
&
On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote:
> For kexec_file loading, if kexec_buf.top_down is 'true', the memory which
> is used to load kernel/initrd/purgatory is supposed to be allocated from
> top to down. This is what we have been doing all along in the old kexec
> loading interface
On Thu, 19 Jul 2018 23:17:53 +0800 Baoquan He wrote:
> Hi Andrew,
>
> On 07/18/18 at 03:33pm, Andrew Morton wrote:
> > On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote:
> >
> > > For kexec_file loading, if kexec_buf.top_down is 'true', the memory w
, "Failed to set link interrupt, fall back
> to polling\n");
> + priv->poll_thread = kthread_run(poll_link_state, priv,
> + "%s_poll_link", net_dev->name);
> + if (IS_ERR(priv->poll_thread)) {
> + netdev_err(net_dev, "Error starting polling thread\n");
> + goto err_poll_thread;
> + }
> + priv->do_link_poll = true;
> + }
Probably the correct place to register the netdev is here.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ality.
If the patch just lists a rename, not actually code, i cannot review
it, so i will just NACK it. We need to see the code.
Once the code has been reviewed and has all the needed Acked-by:, then
-M could be used. But this driver is not that far yet.
Thanks
Andrew
_
On Tue, 24 Apr 2018 16:23:04 +0200 Christoph Hellwig wrote:
> On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote:
> > > git://git.infradead.org/users/hch/misc.git proc_create
> >
> >
> > I want to ask if it is time to start using poorman function overloading
> > with _b_c_e().
1 cards, and an
E1 card which is not part of DAHDI.
Given how much of this is out of tree, i would understand if you
eventually decide to remove this HDLC code.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
rchitecture support, you might want to look at how the dpaa2
drivers have evolved, what they got wrong, what they got right. How is
your hardware similar and different. And look at what parts of dpaa2
have moved out of staging, and maybe consider that code as a good
model to follow.
Andrew
___
On Wed, Mar 5, 2014 at 10:14 PM, Valentina Manea
wrote:
> On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote:
>> On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote:
>>> -AC_INIT([usbip-utils], [1.1.1], [linux-...@vger.kernel.org])
>>> +AC_INIT([usbip-utils], [2.0], [linux-...@vger.kernel.
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> Networking prefers this style, so warn when it's not used.
>
> Networking uses:
>
> void foo(int bar)
> {
> int baz;
>
> code...
> }
>
> not
>
> void foo(int bar)
> {
> int baz;
> code...
> }
>
> There are a lim
On Thu, 06 Mar 2014 15:42:30 -0800 Joe Perches wrote:
> On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote:
> > On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> > > Networking prefers this style, so warn when it's not used.
> > > void foo(
On Wed, 12 Feb 2014 18:00:38 +0800 wrote:
> From: Roger Tseng
>
> Realtek USB memstick host driver provides memstick host support based on the
> Realtek USB card reader MFD driver.
>
> ...
>
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
On Thu, 20 Mar 2014 16:38:03 +0800 Roger wrote:
> On 02/12/2014 06:00 PM, rogera...@realtek.com wrote:
> > From: Roger Tseng
> >
> > Realtek USB memstick host driver provides memstick host support based on the
> > Realtek USB card reader MFD driver.
> >
> &g
> > > + uint32_t hbstlen:4;
> > > + uint32_t glblintrmsk:1;
> > > } s;
> > The warning here is:
> > ERROR: spaces prohibited around that ':' (ctx:WxW)
> > I have done a kernel wide search for these warnings
>
> Really?
rtions(+)
> > create mode 100644 drivers/memstick/host/rtsx_usb_ms.c
> Hi Andrew,
>
> Since I'll have to send next revision(v6, to modify patch 1/3) and
> you've commented v4, would you also comment or Ack the 3/3 of this one?
> This should save one revision for me to
Dr.Richard Anderson,
No 15 Alfateh St Damascus Syria
Hello Friend,
My name is Dr.Richard Anderson, a citizen of France a doctor
and personal adviser to the Syrian deputy defense minister,
late Assef Shawkat; who was killed on the 18th of July 2012,
we are all moving our money out of Syria I need
Sorry for the mass forward, I was instructed to email more than just the
linux-wireless mailing list.
Any help would be appreciated.
Thanks!
-Andrew
Forwarded Message
Subject: Re: wilc1000 staging driver initialization failure
Date: Thu, 4 Feb 2016 13:26:04 -0500
record-keeping mechanisms.
Signed-off-by: Andrew Bradford
---
drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h | 2 +-
drivers/staging/rtl8188eu/include/odm_HWConfig.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h
b
Hi Larry,
On 02/13 13:50, Larry Finger wrote:
> On 02/11/2016 07:38 PM, Andrew Bradford wrote:
> >RTL8188E can only have a maximum of 2 chains so match that in the actual
> >phy_rx_agc_info structure within phy_status_rpt. This will cause the
> >other data received from th
RTL8188EE has a maximum of 2 RF paths (chains) so paths C and D are not
needed to support this part.
Signed-off-by: Andrew Bradford
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 26 --
drivers/staging/rtl8188eu/hal/phy.c| 26
On Wed, 11 Feb 2015 16:44:20 +0100 Vitaly Kuznetsov wrote:
> add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise
> it can race with e.g. device_online(). Allow external modules (hv_balloon for
> now) to lock device hotplug.
>
> ...
>
> --- a/drivers/base/core.c
> +++ b
> > not in the users of
> > the hot_add API. Both my solution and the one proposed by David
> > https://lkml.org/lkml/2015/2/12/57
> > address this issue. You can select either patch and check it in. I just
> > want the is
This adds support for reporting the combined channels count of the
hv_netvsc driver via 'ethtool --show-channels'.
Signed-off-by: Andrew Schwartzmeyer
---
drivers/net/hyperv/netvsc_drv.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/net/hyperv/ne
w we can access
the combined maximum channel count via 'struct netvsc_device' in the
ethtool callback.
Signed-off-by: Andrew Schwartzmeyer
---
drivers/net/hyperv/hyperv_net.h | 1 +
drivers/net/hyperv/netvsc_drv.c | 14 ++
drivers/net/hyperv/rndis_filter.c | 5 -
3
r_device_add'. Now we can access
the combined maximum channel count via 'struct netvsc_device' in the
ethtool callback.
Signed-off-by: Andrew Schwartzmeyer
---
drivers/net/hyperv/hyperv_net.h | 1 +
drivers/net/hyperv/netvsc_drv.c | 14 ++
drivers/net/hyperv/rndi
Signed-off-by: Andrew Kanner
---
drivers/staging/vme/devices/vme_pio2_core.c | 12 ++--
drivers/staging/vme/devices/vme_user.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_pio2_core.c
b/drivers/staging/vme/devices
Thanks, I understood my fault, but haven't done this changes yet. I can't
understand if I should reply to original message with v2 patch or send a new
email with it?
Исходное сообщение
От: Markus Böhme
Отправлено: среда, 14 сентября 2016 г., 15:56
Кому: Andrew K
Ran checkpatch.pl -f vme_pio2_core.c
Fixed: WARNING: Symbolic permissions are not preferred. Consider using
octal permissions (0444)
Signed-off-by: Andrew Kanner
---
drivers/staging/vme/devices/vme_pio2_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
> Andrew, are you happy with this implementation?
Sorry, been to busy with other things to follow the discussion.
What would be nice to see is a comment about how the link to LEDs in
the PHYs is made. Often there is a couple of LEDs in the RJ45 socket
driven by the PHY. They can show link, sp
> Do you have suggestions on how to better handle the choice of the array size
> and the speeds?
phydev->supported lists the speeds this phy supports.
Andrew
___
devel mailing list
de...@linuxdriverproject
t it could also support the
PHY driven 'automatic' link status indication trigger. Do we want two
triggers for the same or similar information?
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Changed variable 'tx' name in local scope
Fixed: sparse warning:
socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
socklnd_cb.c:2435:25: originally declared here
Signed-off-by: Andrew Kanner
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++-
2016-11-04 1:12 GMT+03:00 Dilger, Andreas :
> On Nov 3, 2016, at 15:54, Andrew Kanner wrote:
>>
>> Changed variable 'tx' name in local scope
>> Fixed: sparse warning:
>> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
>> sockl
Removed redundant declaration of variable 'tx' in local scope
Fixed: sparse warning:
socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
socklnd_cb.c:2435:25: originally declared here
Signed-off-by: Andrew Kanner
---
drivers/staging/lustre/lnet/klnds/sock
val = MII_BMCR << 16 | SLIC_PCR_AUTONEG |
> + SLIC_PCR_AUTONEG_RST;
> + slic_write(sdev, SLIC_REG_WPHY, val);
> + }
> + }
> + sdev->autoneg = true;
> +}
Could this be pulled out into a standard PHY driver? All the SLIC
SLIC_PCR_ defines seems to be the same as those in mii.h. This could
be a standard PHY hidden behind a single register.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
y used (the comments in the code mention Marvell and Cicada
> but this is
> not very specific).
If you can get the read working look at registers 2 and 3. Compare
what you get with the values at the end of marvell.c.
Andrew
___
devel mail
and
> is actually possible).
It seems odd you have a nice simple way to do writes, but reads are
very complex. There might be a simple read method hiding somewhere.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
s moved out of
staging.
You might want to look at ethtool -d. That will be accepted.
Andrew
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Aug 25, 2017 at 08:47:00AM -0500, Larry Finger wrote:
> On 08/24/2017 08:54 PM, Andrew Lunn wrote:
> >netdev frowns upon debugfs. You should try to keep this altogether,
> >making it easy to throw away before the driver is moved out of
> >staging.
> >
> >
On Wed, 30 Oct 2013 14:40:16 +0800 wrote:
> unlike mspro card, ms card use normal read/write mode for DMA
> data transfer.
What are the user-visible effects of this bug?
Please always include this information when fixing bugs so that others
can decide whether they (or their customers) need the
On Wed, 6 Nov 2013 09:14:59 +0800 micky wrote:
> On 11/06/2013 05:10 AM, Andrew Morton wrote:
> > On Wed, 30 Oct 2013 14:40:16 +0800 wrote:
> >
> >> unlike mspro card, ms card use normal read/write mode for DMA
> >> data transfer.
> > What a
On Mon, 05 May 2014 13:12:16 -0700 Joe Perches wrote:
> A couple more modifications to the declarations tests.
>
> o Declarations can also be bitfields so exclude things with a colon
> o Make sure the current and previous lines are indented the same
> to avoid matching some macro where a struc
On Mon, 05 May 2014 15:35:43 -0700 Joe Perches wrote:
> > @@ -67,6 +68,7 @@ long vfs_truncate(struct path *path, lof
> > {
> > struct inode *inode;
> > long error;
> > + wobble();
> >
> > inode = path->dentry->d_inode;
>
> Patch content can be a bit odd when lines are
> both add
On Fri, 6 Jun 2014 10:22:51 -0700 "Paul E. McKenney"
wrote:
> On Fri, Jun 06, 2014 at 03:56:52PM +, David Laight wrote:
> > From: Behalf Of Ken Helias
> > > All other add functions for lists have the new item as first argument and
> > > the
> > > position where it is added as second argumen
On Wed, 2 Jul 2014 16:20:24 +0300 Andy Shevchenko
wrote:
> This patch prepares test suite for a following update. It introduces
> test_string_check_buf() helper which checks the result and dumps an error.
>
> ...
>
> --- a/lib/test-string_helpers.c
> +++ b/lib/test-string_helpers.c
> @@ -10,6
On Wed, 2 Jul 2014 16:20:25 +0300 Andy Shevchenko
wrote:
> This is almost the opposite function to string_unescape(). Nevertheless it
> handles \0 and could be used for any byte buffer.
>
> The documentation is supplied together with the function prototype.
>
> The test cases covers most of t
On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville"
wrote:
> On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevchenko wrote:
> > The introduced function is a kind of opposite to string_unescape. We have
> > several users of such functionality each of them created custom
> > implementation.
>
On Thu, 28 Aug 2014 23:58:45 +0300 Andy Shevchenko
wrote:
> On Thu, Aug 28, 2014 at 10:08 PM, Andrew Morton
> wrote:
> > On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville"
> > wrote:
> >
> >> On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevc
Remove insignificant spaces before tabs in comments.
Signed-off-by: Andrew Plummer
---
drivers/staging/bcm/LeakyBucket.c | 81 ---
1 file changed, 33 insertions(+), 48 deletions(-)
diff --git a/drivers/staging/bcm/LeakyBucket.c
b/drivers/staging/bcm
Remove empty return at end of function.
Signed-off-by: Andrew Plummer
---
drivers/staging/nokia_h4p/nokia_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/nokia_h4p/nokia_fw.c
b/drivers/staging/nokia_h4p/nokia_fw.c
index 14ba219..18953ae 100644
--- a/drivers/staging
Remove spaces before semicolons to remove checkpatch warnings.
Signed-off-by: Andrew Plummer
---
drivers/staging/emxx_udc/emxx_udc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index
; power off the system. There may be other poweroff handlers.
I would prefer to keep the warning traceback. We found on some
hardware the GPIO transitions were too fast and it failed to power
off. Seeing the traceback gives an idea where to go look for the
problem.
Other than that,
Acked-by: And
already been registered when the driver is loaded.
>
> Cc: Sebastian Reichel
> Cc: Dmitry Eremin-Solenikov
> Cc: David Woodhouse
> Signed-off-by: Guenter Roeck
Acked-by: Andrew Lunn
Thanks
Andrew
> ---
> drivers/power/reset/qnap-poweroff.c | 28 ++---
say last resort, this is how it is designed to work. There
is no way to turn the power off from with linux, it is designed that
u-boot will put the hardware into minimal power consumption until the
"power" button is pressed.
Other than that,
Acked-by: Andrew Lunn
Thanks
Andrew
1 - 100 of 166 matches
Mail list logo
