Re: [PATCH] staging: olpc_dcon: provide detailed FB_OLPC_DCON help section

2013-07-30 Thread Andres Salomon
Acked-by: Andres Salomon On Tue, 30 Jul 2013 20:11:34 +0200 Jens Frederich wrote: > The FB_OLPC_DCON help section is to short according to checkpatch.pl. > We want more information about the controller type, its task, its > video pipeline position and so on. > > There are

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Andres Salomon
Please Cc Daniel on these. Cjb and myself are no longer at olpc. On Sat, 3 Aug 2013 22:44:35 +0200 Jens Frederich wrote: > This patch replace some magic numbers. I believe it makes > the driver more readable. > > The magic number 0x26 is the XO system embedded controller > (EC) command 'DC

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Andres Salomon
On Sat, 3 Aug 2013 23:36:15 +0200 Jens Frederich wrote: > On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon > wrote: > > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > > > > Do you know what's with Jon Nettleton? He is also on the TODO list?