> +
> + return err;
> +}
> +
> static const struct tegra_ehci_soc_config tegra30_soc_config = {
> .has_hostpc = true,
> };
> @@ -431,6 +505,11 @@ static int tegra_ehci_probe(struct platform_device *pdev)
> goto cleanup_hcd_create;
> }
wake_up(&mhcd.waitq);
> +
> + return ret;
> +}
> +
> +/**
> + * Dequeues an URB.
> + */
> +static int mausb_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int
> status)
> +{
> + int ret = 0;
> + struct mausb_host_ep*ep = usb_to_ma_endpoint(urb->ep);
> + struct mausb_urb*maurb = usb_urb_to_mausb_urb(urb);
> + unsigned long irq_flags;
> +
> + /* For debugging - we want to know who initiated URB dequeue. */
> + dump_stack();
Debugging things like this should be removed before a patch is submitted.
That's enough for now. Obviously there are a lot of issues in this
driver which need to be fixed up.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
gt; >
> > Endianness bug.
> >
>
> Could you elaborate?
> It was my understanding that this buffer was host-endian.
> Is this an unacceptable way to clear the buffer?
I don't understand Oliver's objection here. The buffer is
little-endian, just as it is for real hubs. The code seems correct.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, 12 Nov 2014, Sean O. Stalley wrote:
> On Tue, Nov 11, 2014 at 10:54:30AM -0500, Alan Stern wrote:
> > On Mon, 10 Nov 2014, Stephanie Wallick wrote:
> >
> > > +static struct mausb_hcd mhcd;
> >
> > Only one statically-allocated structure? What if s
ot sure why we can't make our hcd a platform device,
> especially since dummy_hcd & the usbip's hcd are both platform devices.
A platform device is the right way to go.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
c_pending;
> + struct list_head async_completed;
> + wait_queue_head_t wait; /* wake up if a request completed */
> + unsigned int discsignr;
> + struct pid *disc_pid;
> + const struct cred *cred;
> + void __user *disccontext;
> + unsigned long
-off-by: Valentina Manea
> ---
> Changes since v1:
> * add commit description
> * move struct dev_state definition back to usb/core/devio.c
For the changes to the USB core:
Acked-by: Alan Stern
___
devel mailing list
de.
ontrollers write whole words.)
No doubt it would be simpler. The problem is that octeon-hcd doesn't
make these allocations; they are carried out by other parts of the
kernel.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ly bind to their
normal drivers on the host. You probably don't want that to happen.
(Although, at the moment, I don't see how you can prevent it.)
Also, in your patch, stub_probe() calls usb_choose_configuration().
Shouldn't that be done by the client, since the client no
at we
> can stash somewhere for it to look up later. Perhaps someone more
> familiar with the USB stack can help with that.
The correct solution is to set
qh = ep->hcpriv;
udev = qh->udev;
However, the driver doesn't store udev in qh (dwc2_qh_init
it is first
loaded, there probably is no device around at that time. However, in
most cases there _is_ an associated device.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ma_set_coherent_mask or
dma_coerce_mask_and_coherent unconditionally, this patch (and the next)
would overwrite those initial settings.
I don't know to what extent the same may be true for the other,
platform-specific, drivers changed by this patch. But it's something
to
f how
this patch version is different from all the earlier versions. Do that
and submit it as [PATCH v4], and make sure you explain how it is
different from versions 1, 2, and 3.
There are lots of examples of patches like this in the mailing list
archives. Look at some of them to see what they do
13 matches
Mail list logo
