[PATCH] staging: wilc1000: update wilc1000 driver maintainer ids

From: Ajay Singh We would like to update the maintainer email id's for wilc1000 driver. Signed-off-by: Ajay Singh Signed-off-by: Adham Abozaeid --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7c7af53..9647ec7 100644 --- a

[PATCH 7/8] staging: wilc1000: remove coreconfigurator.c file

From: Ajay Singh After use of framework API's most of the redundant functions are removed in coreconfigurator.c file. Now moved left over function to host_interface file and deleted the coreconfigurator.c file. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/Makefile | 3 +-

[PATCH 2/8] staging: wilc1000: remove unused code in coreconfigurator

From: Ajay Singh After refactoring of wilc_parse_network_info(), some of the functions and macro are not required, so removed the unused code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 157 drivers/staging/wilc1000/coreconfigurator

[PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

From: Ajay Singh Use shorter name for 'network_info' variable to avoid line over 80 chars issue. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 53 ++--- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/drivers/staging/wilc100

[PATCH 5/8] staging: wilc1000: refactor wilc_parse_assoc_resp_info()

From: Ajay Singh Refactor wilc_parse_assoc_resp_info() function by removing the use of get_asoc_status() API. For parsing assoc response use the struct and avoided the use of offset macros to extract the ies information. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c

[PATCH 3/8] staging: wilc1000: refactor get_bssid() function

From: Ajay Singh Refactor get_bssid() by making use of 'ieee80211_mgmt' struct. Instead of passing the memory offset now using structure element to fetch the bssid information. Returning the pointer to bssid from get_bssid() instead of filing the input argument. Signed-off-by: Ajay Singh --- d

[PATCH 0/8] staging: wilc1000: make use of cfg80211 provided API's

From: Ajay Singh This series mainly contains the changes to make use of cfg80211 and framework provided API's instead of having own implementation. After refactoring of coreconfigurator functions, most of the redundant code is removed, hence deleted the extra file. Ajay Singh (8): staging: wil

[PATCH 1/8] staging: wilc1000: refactor wilc_parse_network_info() using kernel framework api's

From: Ajay Singh Refactor wilc_parse_network_info() by making use of cfg80211.h provided API. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 90 ++--- 1 file changed, 55 insertions(+), 35 deletions(-) diff --git a/drivers/staging/wilc1000/c

[PATCH 8/8] staging: wilc1000: remove coreconfigurator.h file

From: Ajay Singh Remove the coreconfigurator header file, as its source file is deleted after code refactor. Moved the required structure and prototypes to hostinterface header. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.h | 70 - driver

[PATCH 6/8] staging: wilc1000: remove unnecessary MAX_STRING_LEN macro

From: Ajay Singh Cleanup patch to remove the use of unnecessary 'MAX_STRING_LEN' macro. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging

Re: [PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

Hi Joe, On 11/5/2018 12:47 AM, Joe Perches wrote: > On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote: >> From: Ajay Singh >> >> Use shorter name for 'network_info' variable to avoid line over 80 chars >> issue. > This seems completely unnecessary as patch 7/8 and 8/8 > removes t

Re: [PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

Hi Joe, On 11/5/2018 4:27 PM, Joe Perches wrote: > On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote: >> From: Ajay Singh >> >> Use shorter name for 'network_info' variable to avoid line over 80 chars >> issue. > > I suppose this is OK, though perhaps unnecessary. > > As well, pe

Re: [PATCH] staging: wilc1000: update wilc1000 driver maintainer ids

Hi Greg, On 11/5/2018 7:46 PM, Greg KH wrote: > On Tue, Oct 30, 2018 at 05:53:40AM +, ajay.kat...@microchip.com wrote: >> From: Ajay Singh >> >> We would like to update the maintainer email id's for wilc1000 driver. >> >> Signed-off-by: Ajay Singh >> Signed-off-by: Adham Abozaeid > It would

Re: [PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

On 11/5/2018 9:27 PM, Joe Perches wrote: > On Mon, 2018-11-05 at 12:18 +, ajay.kat...@microchip.com wrote: >> Hi Joe, >> >> On 11/5/2018 4:27 PM, Joe Perches wrote: >>> On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote: From: Ajay Singh Use shorter name for 'n

[PATCH v2] staging: wilc1000: update wilc1000 driver maintainer ids

From: Ajay Singh We would like to update the maintainer email id's for wilc1000 driver. Signed-off-by: Aditya Shankar Signed-off-by: Ganesh Krishna Signed-off-by: Adham Abozaeid Signed-off-by: Ajay Singh --- Changes in v2: - added sob of current wilc1000 maintainers --- MAINTAINERS

[PATCH 02/12] staging: wilc1000: use WLAN_PMKID_LEN macro from ieee80211.h header

From: Ajay Singh Make use of WLAN_PMKID_LEN macro provided by ieee80211.h header instead of PMKID_LEN. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgopera

[PATCH 00/12] staging: wilc1000: better namespace for constants and cleanup

From: Ajay Singh This patch series contains changes to address the review feedback comments [1]. It mainly contains the changes to have clear names for the constants. Most of the constants names are taken care, few are left unchanged in hope with another cleanup those macros might be deleted. Aft

[PATCH 03/12] staging: wilc1000: remove unused macros and struct members in host_interface.h

From: Ajay Singh Cleanup patch to remove the unused macros and struct members in host_interface.h header file. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/dr

[PATCH 04/12] staging: wilc1000: move sdio_cmd52 & sdio_cmd53 struct to source file

From: Ajay Singh Moved sdio_cmd52 & sdio_cmd53 struct from wilc_wlan_if.h, as its used in wilc_sdio.cfile. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c| 19 +++ drivers/staging/wilc1000/wilc_wlan_if.h | 19 --- 2 files changed, 19 inser

[PATCH 07/12] staging: wilc1000: use proper namespace for macros in wilc_wlan_if.h header

From: Ajay Singh Rename the macros defined in wilc_wlan_if.h header to have clear namespace. As convention used 'WILC_FW_' prefix for constants defined for firmware and 'WILC_' prefix for driver constants. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +-

[PATCH 01/12] staging: wilc1000: use macro from ieee80211.h in register frame api's

From: Ajay Singh Make use of ieee80211.h provided macros and removed the extra macro defined for the same purpose. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 3 --- drivers/staging/wilc1000/wilc_

[PATCH 08/12] staging: wilc1000: move current_tx_rate enum to wilc_wlan_if.h file

From: Ajay Singh Move 'current_tx_rate' enum to wilc_wlan_if.h, to have it along with the other FW related to constants. Also added prefix to have a better namespace. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 16 drivers/staging/wilc1000/linux_w

[PATCH 12/12] staging: wilc1000: rename tsf_hi element of network_info struct

From: Ajay Singh Rename 'tsf_hi' element in network_info struct as it's not used to store only the higher 32-bit value but the complete 64-bit tsf value. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h

[PATCH 09/12] staging: wilc1000: rename firmware related constants to follow better namespace

From: Ajay Singh Rename the firmware related macro by prefix with 'WILC_FW_' prefix for a better namespace. Also, move them to wilc_wlan_if.h file along with other FW related macros. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc

[PATCH 11/12] staging: wilc1000: use ENOBUFS error code instead of WILC_TX_ERR_NO_BUF macro

From: Ajay Singh Make use of 'ENOBUFS' instead of WILC_TX_ERR_NO_BUF macro. The value of WILC_TX_ERR_NO_BUF is -2, which is confusing with ENOENT error code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c| 2 +- drivers/st

[PATCH 05/12] staging: wilc1000: use enum contants for mac status & added 'WILC_' prefix

From: Ajay Singh Clubbed mac status constants inside the enum constant and also added 'WILC_' prefix to have better namespace. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- driv

[PATCH 06/12] staging: wilc1000: restructure macros used to handle security type

From: Ajay Singh Restructure the code to have a proper namespace for macro defined to handle the security types. Move them as part of wilc_wlan_if.h header as along with other macro defined for firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- d

[PATCH 10/12] staging: wilc1000: added 'WILC_' prefix for constants to have clear namespace

From: Ajay Singh For better namespace added 'WILC_' prefix for driver specific constants. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 162 +++--- drivers/staging/wilc1000/host_interface.h | 59 drivers/staging/wilc1000/lin

[PATCH 00/29] staging: wilc1000: avoid deferring of cfg80211 operation callback

From: Ajay Singh This patch series mainly contains the change to handle the cfg80211 operation from its context. Now the WID commands are sent to firmware directly from the caller context. Also added few more patches to address the review comment received earlier in series[1]. [1]. https://www.s

[PATCH 05/29] staging: wilc1000: handle tx power related callback from cfg80211 context

From: Ajay Singh Avoid the use of internal work queue to defer the handling of tx power related cfg operations callback. Now issuing the wid command to firmware directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 85 +-

[PATCH 11/29] staging: wilc1000: handle delete beacon cfg ops from cfg80211 context()

From: Ajay Singh Refactor the code to handle delete beacon cfg operation from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 39 --- 1 file changed, 10 insertions(+), 29 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 09/29] staging: wilc1000: handle delete station related callback ops from cfg80211 context

From: Ajay Singh Refactor the code to handle delete/delete_all station operation callback from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 147 +++--- 1 file changed, 33 insertions(+), 114 deletions(-) diff --git a/driver

[PATCH 12/29] staging: wilc1000: handle add beacon operation callback from cfg80211 context

From: Ajay Singh Refactor add/change beacon cfg80211 operation callback to handle from cfg context. Also avoided extra copy of information by packing directly in firmware expected format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 128 +---

[PATCH 06/29] staging: wilc1000: handle setting power management from cfg80211 context

From: Ajay Singh Refactor the code to handle the power management cfg operation from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 56 +++ 1 file changed, 13 insertions(+), 43 deletions(-) diff --git a/drivers/staging

[PATCH 08/29] staging: wilc1000: use void return for wilc_hif_pack_sta_param()

From: Ajay Singh Change the return type from u32 to void for wilc_hif_pack_sta_param() as its value is not used. Also remove the use of extra pointer as it's not required now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 14 -- 1 file changed, 4 inserti

[PATCH 01/29] staging: wilc1000: remove unnecessary checks in wilc_mac_close()

From: Ajay Singh Remove unnecessary 'if' check in wilc_mac_close() as those conditions will not happen. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/wilc1000/linux_

[PATCH 03/29] staging: wilc1000: avoid the use of the static variable to configure wiphy struct

From: Ajay Singh Refactor code to avoid the use of static variables to configure the 'wiphy' structure. Now move static variables as part of 'priv' data so it helped to maintain this information per interface. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 92

[PATCH 04/29] staging: wilc1000: use mutex lock to synchronized sending 'wid' cmd to firmware

From: Ajay Singh Use mutex lock to protect the issuing of wid cmd to the firmware. Currently the wid commands are synchronized by use of hif_workqueue work queue. Now, these changes are required to synchronize the access to wid command, so the commands can be issued directly from cfg80211 context

[PATCH 07/29] staging: wilc1000: handle add and edit station from the cfg80211 context

From: Ajay Singh Refactor the code to avoid handling of add/edit stations using work queue and now set the wid value from caller context. Avoid making an extra copy of buffer and directly copy the data in firmware expected format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_int

[PATCH 14/29] staging: wilc1000: refactor wilc_set_mac_chnl_num() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 46 ++- 1 file cha

[PATCH 10/29] staging: wilc1000: use is_zero_ether_addr() API to check mac address

From: Ajay Singh Use is_zero_ether_addr() API to check if mac address value is zero. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 3 +-- drivers/staging/wilc1000/linux_wlan.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH 02/29] staging: wilc1000: make use of put_unaligned_le32 in handle_set_wfi_drv_handler()

From: Ajay Singh Make use of put_unaligned_le32() function to pack the wid command buffer for firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 10 ++ drivers/staging/wilc1000/host_interface.h | 1 - 2 files changed, 2 insertions(+), 9 deletions(-) d

[PATCH 17/29] staging: wilc1000: refactor wilc_set_operation_mode() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach. Instead of posting the wid to work queue now handle directly from the caller context. Use structure to fill in the firmware specific format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_inte

[PATCH 20/29] staging: wilc1000: handle key related cfg operation from cfg80211 context

From: Ajay Singh Refactor add/delete key operation to handle directly from cfg80211 context. Also, avoid an extra copy of the information in hif layer and directly fill the buffer in firmware format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 691 ++--

[PATCH 16/29] staging: wilc1000: handle station dump cfg ops from cfg80211 context

From: Ajay Singh Refactor code to handle dump_station() callback from cfg80211 context. Instead of deferring issue of wid command now send it directly from cfg context. Also making use of wilc_get_rssi() error status in case there is a failure to post the wid command to the firmware. Signed-off-

[PATCH 13/29] staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context

From: Ajay Singh Avoid handling of mgmt_frame_register operation callback in a deferred manner. Now set the wid command to firmware directly from caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 70 ++- drivers/staging/wilc10

[PATCH 15/29] staging: wilc1000: refactor wilc_hif_set_cfg() to avoid deferred handling

From: Ajay Singh Avoid handling configuration params wid command in deferred approach. Instead of posting to workqueue now handle directly from the caller context. Reduce the size of wid array from 32 to 4 as maximum only 4 wid used at a time. Signed-off-by: Ajay Singh --- drivers/staging/wilc

[PATCH 26/29] staging: wilc1000: avoid deferred handling of cfg80211 disconnect callback

From: Ajay Singh Refactor disconnect operation callback to handle from the cfg80211 context. The reason code is not required to pass as parameter to the function, so remove it. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 39 +++ drivers

[PATCH 19/29] staging: wilc1000: refactor wilc_get_inactive_time() to avoid deferred handling

From: Ajay Singh Avoid handling of inactive time related wid command in deferred manner. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 91 --- 1 file cha

[PATCH 18/29] staging: wilc1000: refactor wilc_set_wfi_drv_handler() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_SET_DRV_HANDLER wid command in deferred approach. Instead of posting the wid to work queue now handle directly from the caller context. Remove 'is_sync' parameter from the API as it's not required anymore. Signed-off-by: Ajay Singh --- drivers/staging/wil

[PATCH 22/29] staging: wilc1000: refactor wilc_get_mac_address() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_MAC_ADDR wid command in deferred approach. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 43 ++- drivers/staging/w

[PATCH 27/29] staging: wilc1000: handle connect ops callback from cfg80211 context

From: Ajay Singh Refactor the connect related cfg callback to be called from cfg80211 context. No need to post connect command internally in case scan is in progress instead simply return the error status in connect ops callback. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_inte

[PATCH 23/29] staging: wilc1000: use correct 'struct remain_ch' variable in scan complete

From: Ajay Singh Use the correct reference to remain_ch variable in scan complete. Passing 'msg->body.remain_on_ch' to handle_remain_on_chan is not correct. So used the correct reference used to store roc related information during the scan. Signed-off-by: Ajay Singh --- drivers/staging/wilc10

[PATCH 21/29] staging: wilc1000: delete the unused code after code refactor

From: Ajay Singh After code refactor some of the macro and variables are not required any more, so deleted the unused code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 31 --- drivers/staging/wilc1000/host_interface.h | 27 -

[PATCH 24/29] staging: wilc1000: handle remain on channel cfg ops from cfg80211 context

From: Ajay Singh Refactor wilc_remain_on_channel() to handle remain_on_channel callback from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 36 ++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git a/drivers/s

[PATCH 25/29] staging: wilc1000: handle get_station() ops callback in cfg80211 context

From: Ajay Singh Refactor code to handle the get_station() callback from cfg80211 context. Provided different API's to fetch the station statistics information in sync or async call. From cfg80211 get_station() ops callback calls the sync version of API. Signed-off-by: Ajay Singh --- drivers/s

[PATCH 29/29] staging: wilc1000: handle scan operation callback from cfg80211 context

From: Ajay Singh Refactor code to handle scan operation callback from cfg80211 context. No need to maintain 'scan_attr' struct as the wid command is directly sent to firmware from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 143 --

[PATCH 28/29] staging: wilc1000: avoid extra buffer copy while connect cfg ops

From: Ajay Singh Refactor the code to avoid the use of an extra buffer to store the connection related parameter. No need to call cfg80211_disconnected in case of failure to send the wid command to firmware, an error status is directly returned in cfg80211 connect callback. Signed-off-by: Ajay S

[PATCH] staging: wilc1000: fix NULL dereference inside wilc_scan()

From: Ajay Singh Added NULL check before accessing 'hidden_net' pointer inside wilc_scan() to fix the issue found by static code checker. Fixes: 8f1a0ac1eba7 ("staging: wilc1000: handle scan operation callback from cfg80211 context") Reported-by: Dan Carpenter Signed-off-by: Ajay Singh --- d

Re: [PATCH] staging: wilc1000: fix missing read_write setting when reading data

On 12/19/2018 10:00 PM, Colin King wrote: > From: Colin Ian King > > Currently the cmd.read_write setting is not initialized so it contains > garbage from the stack. Fix this by setting it to 0 to indicate a > read is required. > > Detected by CoverityScan, CID#1357925 ("Uninitialized scalar

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

Hi Julius, On 1/6/2019 12:48 PM, Július Milan wrote: >> Before you send V3, are you sure this is the correct fix? As "frame_type" is >> input as u16, it seems to me that the frame_type member of struct >> wilc_reg_frame >> should be __le16, not __le32. > > Yes, I am confident about it. > The fra

Re: [PATCH v4] staging: wilc1000: fix registration frame size

On 1/7/2019 8:13 PM, Július Milan wrote: > Fixes the following sparse warnings: > > drivers/staging/wilc1000/host_interface.c:2360:30: warning: > incorrect type in assignment (different base types) > expected restricted __le32 [addressable] [assigned] [usertype] frame_type > got restric

[PATCH 10/13] staging: wilc1000: refactor information message parsing logic

From: Ajay Singh Refactor code to avoid maintaining an unnecessary buffer to keep the information type message ('I' msg type). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 66 --- 1 file changed, 16 insertions(+), 50 deletions(-) diff -

[PATCH 06/13] staging: wilc1000: corrected order to pack join param buffer

From: Ajay Singh Modified packing order for join param as expected by firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/

[PATCH 01/13] staging: wilc1000: make use of get_unaligned_le16/le32 to pack data

From: Ajay Singh Make use of get_unaligned_le16/le32 framework api's to pack data. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++ drivers/staging/wilc1000/wilc_wlan_cfg.c | 27 +-- 2 files changed, 16 insertions(+), 26 del

[PATCH 09/13] staging: wilc1000: use single struct for 'connect' related parameters

From: Ajay Singh Use single structure to store the connect request and response information. It helped in avoiding unnecessary buffer allocation to handle request and response flow. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 217 ++ dr

[PATCH 05/13] staging: wilc1000: make use of cfg80211_inform_bss_frame()

From: Ajay Singh Use cfg80211_inform_bss_frame() api instead of cfg80211_inform_bss() to inform cfg80211 about the BSS frame, to avoid unnecessary parsing of frame in driver. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 144 +- drivers/s

[PATCH 04/13] staging: wilc1000: remove the use of scan shadow buffer

From: Ajay Singh Remove scan shadow buffer, which is used to store a copy of scan results. Instead, use cfg80211 provided API's to retrieve required info. Remove the helper functions which are operating on shadow buffer, as it's not require now. Signed-off-by: Ajay Singh --- drivers/staging/wi

[PATCH 13/13] staging: wilc1000: avoid the use of typedef for function pointers

From: Ajay Singh Remove typedef for function pointers. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 13 +++-- drivers/staging/wilc1000/host_interface.h | 24 ++-- drivers/staging/wilc1000/wilc_wlan.c | 10 ++ drivers/staging

[PATCH 08/13] staging: wilc1000: rename hidden_network related data structure

From: Ajay Singh Rename hidden_network related data structure to have more appropriate names, as it's used to keep search network SSID details. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 40 +++ drivers/staging/wilc1000/host_interface.

[PATCH 07/13] staging: wilc1000: use struct to pack join parameters for FW

From: Ajay Singh Refactor code to use struct to construct the join parameters. Avoid use of extra buffer before sending to FW instead directly pass the struct pointer. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 404 -- drivers/staging/

[PATCH 11/13] staging: wilc1000: remove 'disconnect_info' structure

From: Ajay Singh Remove 'disconnect_info' struct use because its passed values are not required in cfg_connect_result(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 24 +-- drivers/staging/wilc1000/host_interface.h | 9 +---

[PATCH 00/13] staging: wilc1000: address few mainline review

From: Ajay Singh This series contains changes to address few of the review comments[1]. It mainly has the modification to remove the use of scan shadow buffer, make use of kernel provided API, avoid typedef's and few changes to simplify the logic. [1]. https://www.spinics.net/lists/linux-wireles

[PATCH 12/13] staging: wilc1000: refactor handle_set_mcast_filter()

From: Ajay Singh Refactor handle_set_mcast_filter() by making use of put_unaligned32() to pack the data instead of byte operation. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 37 +-- drivers/staging/wilc1000/host_interface.h | 2 +- dr

[PATCH 02/13] staging: wilc1000: refactor wilc_wlan_set_bssid()

From: Ajay Singh Refactor code by making use of eth_zero_addr() to clear the mac address value in wilc_wlan_set_bssid(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 6 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +--- 2 files

[PATCH 03/13] staging: wilc1000: use 'struct' to pack cfg header frame in wilc_wlan_cfg_commit()

From: Ajay Singh Make use of 'struct' to pack cfg header in wilc_wlan_cfg_commit() instead of byte by byte filling. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.c | 25 ++--- drivers/staging

[PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

From: Ajay Singh The value of 'vif_num'(interface count) starts with 0, so modified the loop conditions to execute for all interface. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 8 2 files changed, 5 inser

[PATCH 11/15] staging: wilc1000: refactor code to use cookie information

From: Ajay Singh Make use of cookie information to pass to wpa_s and handle cookie value received in the cfg80211_ops callbacks. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 72 +++ drivers/staging/wilc1000/host_interface.h | 13

[PATCH 07/15] staging: wilc1000: refactor scan() cfg80211 ops callback

From: Ajay Singh Refactor scan() cfg80211 callback function and use correct value for valid channel number limit. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 55 +++ 2 files cha

[PATCH 04/15] staging: wilc1000: remove unnecessary debug log messages

From: Ajay Singh Remove unnecessary debug log messages. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index b

[PATCH 03/15] staging: wilc1000: remove redundant macros for radiotap

From: Ajay Singh Remove macro define which are already present in the included header. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index 32d

[PATCH 12/15] staging: wilc1000: use random number for cookie instead of pointer

From: Ajay Singh Use random number to assign to cookie value. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_w

[PATCH 02/15] staging: wilc1000: remove conditional lock in wilc_wfi_deinit_mon_interface()

From: Ajay Singh wilc_wfi_deinit_mon_interface() calls unregister_netdev() which requires the rtnl lock again. Now move wilc_wfi_deinit_mon_interface() out of wilc_mac_close(). Also remove explicit call to wilc_mac_close() because unregister_netdev() takes care of calling wilc_mac_close(). Signe

[PATCH 09/15] staging: wilc1000: remove use of 'terminated_handle' static variable

From: Ajay Singh Remove use of 'terminated_handle' variable and set the 'hif_drv' to NULL once it's free. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_in

[PATCH 10/15] staging: wilc1000: refactor linux_wlan_init_test_config()

From: Ajay Singh Refactor linux_wlan_init_test_config() to use correct endianness for wid values and remove unnecessary code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 200 +--- drivers/staging/wilc1000/wilc_wlan_if.h | 1 - 2 files c

[PATCH 01/15] staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable

From: Ajay Singh Avoid use of static variable for monitor net_device and move it inside wilc structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 52 +++ drivers/staging/wilc1000/linux_wlan.c | 4 +- drivers/staging/wilc1

[PATCH 14/15] staging: wilc1000: add check before performing operation on net_device

From: Ajay Singh Before calling an operation on net_device check if that interface is available. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers

[PATCH 15/15] staging: wilc1000: remove unused struct 'add_sta_param'

From: Ajay Singh Remove 'add_sta_param' structure as its not used now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h

[PATCH 13/15] staging: wilc1000: avoid use of interface names for validation

From: Ajay Singh Avoid use of interface name i.e 'wlan0' & 'p2p0' to check the interface type in dev_state_ev_handler(). Now making use of netdev_ops and iface type to know interface. Reorder the functions to avoid the forward declaration after the above changes Signed-off-by: Ajay Singh --- d

[PATCH 00/15] staging: wilc1000: cleanup patches & handle review comments

From: Ajay Singh This series contains cleanup patches and modification to handle few mainline review comments mentioned below: - avoid static variable for monitor net_device. - remove conditional locking in wilc_wfi_deinit_mon_interface(). - avoid use of interface name('wlan0' & 'p2p0') string

[PATCH 05/15] staging: wilc1000: rename timeout related macros

From: Ajay Singh Rename timeout related macros to have their unit clear from their name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c |

[PATCH 06/15] staging: wilc1000: make use of iface type to identify p2p interface

From: Ajay Singh Remove SSID string compare instead use interface type check for p2p client interface. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 1 - drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 ++- 2 files changed, 6 insertio

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

On 2/4/2019 1:43 PM, Dan Carpenter wrote: > On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat...@microchip.com wrote: >> From: Ajay Singh >> >> The value of 'vif_num'(interface count) starts with 0, so modified the >> loop conditions to execute for all interface. >> >> Signed-off-by: Ajay Sing

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

Hi Greg, On 2/4/2019 5:09 PM, Greg KH wrote: > On Mon, Feb 04, 2019 at 12:47:23PM +0300, Dan Carpenter wrote: >> On Mon, Feb 04, 2019 at 09:42:36AM +, ajay.kat...@microchip.com wrote: >>> >>> >>> On 2/4/2019 1:43 PM, Dan Carpenter wrote: On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat.

Re: [PATCH 01/15] staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable

Hi Kalle, On 2/4/2019 7:08 PM, Kalle Valo wrote: > writes: > >> From: Ajay Singh >> >> Avoid use of static variable for monitor net_device and move it inside >> wilc structure. >> >> Signed-off-by: Ajay Singh > > [...] > >> --- a/drivers/staging/wilc1000/linux_mon.c >> +++ b/drivers/staging/

[PATCH 01/12] staging: wilc1000: remove use of 'terminated_handle' static variable

From: Ajay Singh Remove use of 'terminated_handle' variable and set the 'hif_drv' to NULL once it's free. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_in

[PATCH 09/12] staging: wilc1000: avoid use of static variable in linux_mon.c

From: Ajay Singh Define local variable for 'srcadd' & 'bssid' static variables and use ether_addr_copy() to copy value into them. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc

[PATCH 12/12] staging: wilc1000: define p2p related static variable as constants

From: Ajay Singh Add constant qualifer for 'p2p_vendor_spec' & 'p2p_oui' static variable because they are treated like constant values. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 06/12] staging: wilc1000: add check before performing operation on net_device

From: Ajay Singh Before calling an operation on net_device check if that interface is available. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers

[PATCH 08/12] staging: wilc1000: avoid use of 'hif_deinit_lock' static variable

From: Ajay Singh Avoid use of static variable 'hif_deinit_lock' and move it as part of wilc struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 20 +--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 ++ 2 files changed, 11 insertions(+), 1

  1   2   3   4   >