Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue

2017-02-17 Thread Adan Hawthorn
Thank you, Joe. Please remove this patch at this time; it was sent in error. On Fri, Feb 17, 2017 at 6:04 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: >> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is >> usually wrong: see Documentation/pro

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

2017-02-17 Thread Adan Hawthorn
Thanks, Joe. Is this to say that scripts/checkpatch.pl should be updated to some higher column limit? I have made these cleanup changes before in a like manner. On Fri, Feb 17, 2017 at 8:17 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: >> Fix checkpatch.pl war

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

2017-02-17 Thread Adan Hawthorn
Ok, I personally like that better anyhow. Also, there was mention of the line limit even exceeding 100 characters (130ish?) and that was being tossed around at one point (if I remember correctly). On Fri, Feb 17, 2017 at 8:38 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 20:32 -0500, A