[PATCH 36/44] staging: unisys: visorbus: add error handling to initiate_chipset_device_pause_resume

2017-03-28 Thread David Kershner
Clean up the function to remove some if statments that should be done in the calling function. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 74 +++--- 1 file changed, 32 insertions(+), 42 deletions(-) diff

[PATCH] staging: unisys: visorbus: fix kernel BUG discovered by day0 testing

2017-03-30 Thread David Kershner
rivers: visorhba, visornic, or visorinput. This reverts commit 5b6f9b95f7ae ("staging: unisys: visorbus: get rid of create_bus_type.") Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 32 ++--- 1 file ch

[PATCH v2] staging: unisys: visorbus: fix kernel BUG discovered by day0 testing

2017-03-31 Thread David Kershner
rivers: visorhba, visornic, or visorinput. Checked to see if we have called bus_register, if not do not call driver_register. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- - Changes from v1 - Made changes suggested by GregKH. Instead of reverting patch, just added the check fo

[PATCH v3] staging: unisys: visorbus: fix kernel BUG discovered by day0 testing

2017-03-31 Thread David Kershner
rivers: visorhba, visornic, or visorinput. Checked to see if we have called bus_register, if not do not call driver_register. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reviewed-by: David Binder --- - Changes from v1 - Made changes suggested by GregKH. Instead of reverting patch, just

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

2018-04-05 Thread David Miller
From: Haiyang Zhang Date: Thu, 5 Apr 2018 11:42:22 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 message structures, and includes this > version into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang Zhang The net-next tree is closed, please resubmit this

Re: [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

2018-04-05 Thread David Miller
From: Mohammed Gamal Date: Thu, 5 Apr 2018 21:09:17 +0200 > Guests running on WS2012 hosts would not shutdown when changing network > interface setting (e.g. Number of channels, MTU ... etc). > > This patch series addresses these shutdown issues we enecountered with WS2012 > hosts. It's essent

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

2018-04-11 Thread David Miller
From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 > Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Also, all of your networking submissions have been dropped because the net-next tree i

[PATCH RFC 3/8] mm: use PG_offline in online/offlining code

2018-04-13 Thread David Hildenbrand
Let's mark all offline pages with PG_offline. We'll continue to mark them reserved. Signed-off-by: David Hildenbrand --- drivers/hv/hv_balloon.c | 2 +- mm/memory_hotplug.c | 10 ++ mm/page_alloc.c | 5 - 3 files changed, 11 insertions(+), 6 deletions(-) di

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 and v6.1 into version negotiation

2018-04-18 Thread David Miller
From: Haiyang Zhang Date: Tue, 17 Apr 2018 15:31:47 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 and 6.1 message structures, and includes > these versions into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang Zhang Applied to net-next, thank you. ___

Re: [PATCH 20/39] afs: simplify procfs code

2018-04-19 Thread David Howells
e the network namespace over automount using the new fs_context to do it. David ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 00/13] staging: iio: ad2s1200: Driver clean up

2018-04-20 Thread David Veenstra
Hennerich opinion. Since Michael didn't weigh in, I have left this how it was. Best regards, David Veenstra [1] https://marc.info/?l=linux-iio&m=152137920426820&w=2 [2] https://marc.info/?l=linux-iio&m=152181140619243&w=2 David Veenstra (13): staging: iio: ad2s1200: Remove unnee

[PATCH v2 02/13] staging: iio: ad2s1200: Sort includes alphabetically

2018-04-20 Thread David Veenstra
This patches sorts all the includes in alphabetic order. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c

[PATCH v2 03/13] staging: iio: ad2s1200: Reverse Christmas tree ordering

2018-04-20 Thread David Veenstra
Reorders the variable declarations to prefer a reverse Christmas tree order to improve readability. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b

[PATCH v2 01/13] staging: iio: ad2s1200: Remove unneeded include

2018-04-20 Thread David Veenstra
This patches removes unneeded slab.h header. Signed-off-by: David Veenstra --- Changes in v2: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver

[PATCH v2 04/13] staging: iio: ad2s1200: Add blank lines

2018-04-20 Thread David Veenstra
Add blank lines to improve readability. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index b6c3a3c8f7fe..357fe3c382b3 100644

[PATCH v2 05/13] staging: iio: ad2s1200: Add kernel docs to driver state

2018-04-20 Thread David Veenstra
Add missing kernel docs to the ad2s1200 driver state. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index 357fe3c382b3

[PATCH v2 06/13] staging: iio: ad2s1200: Introduce variable for repeated value

2018-04-20 Thread David Veenstra
Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly used in ad2s1200_probe. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2

[PATCH v2 07/13] staging: iio: ad2s1200: Improve readability with be16_to_cpup

2018-04-20 Thread David Veenstra
expressions that use be16_to_cpup. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index 0a5fc9917e32..11ed9c7332e6

[PATCH v2 10/13] staging: iio: ad2s1200: Add scaling factor for angular velocity channel

2018-04-20 Thread David Veenstra
scaling factor of the angle channel. Signed-off-by: David Veenstra --- Changes in v2: - Move explanation of Pi approximation to top of switch statement, as this will also be relevant to angle channel. - Replaced 33102 / 2 with 16551 on line 84. drivers/staging/iio/resolver/ad2s1200.c

[PATCH v2 11/13] staging: iio: Documentation: Add missing sysfs docs for angle channel

2018-04-20 Thread David Veenstra
d-off-by: David Veenstra --- Change in v2: - Introduces in this version. Documentation/ABI/testing/sysfs-bus-iio | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio index 6a5f34b4d5b9..8ad0e55f99e

[PATCH v2 09/13] staging: iio: ad2s1200: Add documentation for device tree binding

2018-04-20 Thread David Veenstra
Add documentation for the added device tree bindings. Signed-off-by: David Veenstra --- Changes in v2: - Introduced in this version. .../bindings/staging/iio/resolver/ad2s1200.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 08/13] staging: iio: ad2s1200: Replace legacy gpio API with modern API

2018-04-20 Thread David Veenstra
The legacy, integer based gpio API is replaced with the descriptor based API. For compatibility, it is first tried to use the platform data to request the gpio's. Otherwise, it looks for the "sample" and "rdvel" gpio function. Signed-off-by: David Veenstra --- dri

[PATCH v2 13/13] staging: iio: ad2s1200: Move driver out of staging

2018-04-20 Thread David Veenstra
Move the iio driver for the ad2s1200 resolver-to-digital converter out of staging, into mainline iio subsystems. Signed-off-by: David Veenstra --- Changes in v2: - Added commit message. - Also move device tree binding documentation out of staging. - Disabled move detection

[PATCH v2 12/13] staging: iio: ad2s1200: Add scaling factor for angle channel

2018-04-20 Thread David Veenstra
A fractional scaling factor of approximately 2 * Pi / (2^12 -1) is added, to scale the 12-bits angular position to radians. Signed-off-by: David Veenstra --- Changes in v2: - This patch replaces the patch that changed the the channel for angular position to inclination channel

[PATCH v3 0/9] staging: iio: ad2s1200: Driver clean up

2018-04-22 Thread David Veenstra
folder. - Change return type of scale for angle and angular velocity channel. - Remove axis modifier from documentation of angle channel. - Add missing references to ad2s1205. Best regards, David Veenstra [1] https://marc.info/?l=linux-iio&m=152137920426820&w=2 [2] https://marc.info/?l=lin

[PATCH v3 2/9] staging: iio: ad2s1200: Improve readability with be16_to_cpup

2018-04-22 Thread David Veenstra
expressions that use be16_to_cpup. Signed-off-by: David Veenstra --- Changes in v3: - change type of rx to __be16. - remove unneeded variable vel. - remove unneeded type cast to s16 (patch line 79). drivers/staging/iio/resolver/ad2s1200.c | 11 --- 1 file changed, 4 insertions(+), 7

[PATCH v3 1/9] staging: iio: ad2s1200: Add kernel docs to driver state

2018-04-22 Thread David Veenstra
Add missing kernel docs to the ad2s1200 driver state. Signed-off-by: David Veenstra --- Changes in v3: - Added more explanation to mutex lock. drivers/staging/iio/resolver/ad2s1200.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b

[PATCH v3 4/9] staging: iio: ad2s1200: Replace platform data with dt bindings

2018-04-22 Thread David Veenstra
Remove usage of platform data, and replace it with device tree facilities. Signed-off-by: David Veenstra --- Changes in v3: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff

[PATCH v3 7/9] staging: iio: Documentation: Add missing sysfs docs for angle channel

2018-04-22 Thread David Veenstra
d-off-by: David Veenstra --- Changes in v3: - Remove axis modifier on in_angle. Documentation/ABI/testing/sysfs-bus-iio | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio index 6a5f34b4d5b9..240287e2343

[PATCH v3 6/9] staging: iio: ad2s1200: Add scaling factor for angular velocity channel

2018-04-22 Thread David Veenstra
The sysfs iio ABI states radians per second is expected as the unit for angular velocity, but the 12-bit angular velocity register has rps as its unit. So a scaling factor of approximately 2 * Pi is added to the angular velocity channel. Signed-off-by: David Veenstra --- Changes in v3: - A

[PATCH v3 3/9] staging: iio: ad2s1200: Replace legacy gpio API with modern API

2018-04-22 Thread David Veenstra
The legacy, integer based gpio API is replaced with the modern descriptor based API. Signed-off-by: David Veenstra --- Changes in v3: - This patch no longer deals with dt bindings. See the next patch. drivers/staging/iio/resolver/ad2s1200.c | 15 --- 1 file changed, 8

[PATCH v3 5/9] staging: iio: ad2s1200: Add documentation for device tree binding

2018-04-22 Thread David Veenstra
Add documentation for the added device tree bindings. Signed-off-by: David Veenstra --- Changes in v3: - Documentation is added to Documentation/devicetree/bindings/iio/resolver instead of staging directory. - Add mention to ad2s1205 device. .../devicetree/bindings/iio/resolver/ad2s1200

[PATCH v3 8/9] staging: iio: ad2s1200: Add scaling factor for angle channel

2018-04-22 Thread David Veenstra
A scaling factor of approximately 2 * Pi / (2^12 -1) is added, to scale the 12-bits angular position to radians. A return type of IIO_VAL_INT_PLUS_NANO is used, so that the scale of both the angle channel and angular velocity channel has 7 significant digits. Signed-off-by: David Veenstra

[PATCH v3 9/9] staging: iio: ad2s1200: Move driver out of staging

2018-04-22 Thread David Veenstra
Move the iio driver for the ad2s1200 and ad2s1205 resolver-to-digital converter out of staging, into mainline iio subsystems. Signed-off-by: David Veenstra --- Changes in v3: - Add mention of ad2s1205 in commit message. drivers/iio/Kconfig | 1 + drivers/iio/Makefile

Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data}

2018-04-30 Thread David Howells
ase add documentation comments to exported functions when you add them. David ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: simplify procfs code for seq_file instances V2

2018-04-30 Thread David Howells
ere: https://groups.google.com/forum/#!msg/syzkaller-bugs/sJC3Y3hOM08/aO3z9JXoAgAJ David ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 1/4] staging: lustre: obdclass: change spinlock of key to rwlock

2018-05-03 Thread David Laight
u need to hold any kind of lock over an atomic_inc(). If this is just ensuring that no code holds the lock then it would need to request the write_lock(). (and would need a comment) David ___ devel mailing list de...@linuxdriverproject.org http:/

Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-10 Thread David Miller
From: Mohammed Gamal Date: Wed, 9 May 2018 10:17:34 +0200 > On older windows hosts the net_device instance is returned to > the caller of rndis_filter_device_add() without having the presence > bit set first. This would cause any subsequent calls to network device > operations (e.g. MTU change,

[PATCH v4 01/12] staging: iio: ad2s1200: Remove unneeded newline in license

2018-05-18 Thread David Veenstra
Remove unneeded newline in license, as it does not improve readability. Signed-off-by: David Veenstra --- Changes in v4: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers

[PATCH v4 03/12] staging: iio: ad2s1200: Add kernel docs to driver state

2018-05-18 Thread David Veenstra
Add missing kernel docs to the ad2s1200 driver state. Signed-off-by: David Veenstra --- Changes in v4: - Simplified explanation of lock. drivers/staging/iio/resolver/ad2s1200.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers

[PATCH v4 02/12] staging: iio: ad2s1200: Remove unneeded initializations

2018-05-18 Thread David Veenstra
Remove 2 initializations which are unneeded, because the initialized values are never used. Signed-off-by: David Veenstra --- Changes in v4: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v4 00/12] iio: ad2s1200: Driver clean up

2018-05-18 Thread David Veenstra
documentation for device tree binding 6. Move driver to main line. Changes in v4: - Some new minor code style fix ups. - Move spi setup to before iio device registration. - Add vendor prefix to gpios function name, and dt docs. - Add device tree table - Add copyright. Best regards, David Veenstra

[PATCH v4 04/12] staging: iio: ad2s1200: Setup spi before iio device register

2018-05-18 Thread David Veenstra
The spi should be set up before the device is registered as an iio device. This patch moves the setup to before the device registration. Signed-off-by: David Veenstra --- Changes in v4: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 13 +++-- 1 file changed

[PATCH v4 05/12] staging: iio: ad2s1200: Replace legacy gpio API with modern API

2018-05-18 Thread David Veenstra
The legacy, integer based gpio API is replaced with the modern descriptor based API. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers

[PATCH v4 06/12] staging: iio: ad2s1200: Replace platform data with dt bindings

2018-05-18 Thread David Veenstra
Remove usage of platform data, and replace it with device tree facilities. Signed-off-by: David Veenstra --- Changes in v4: - Added vendor prefix to gpio function names. drivers/staging/iio/resolver/ad2s1200.c | 32 - 1 file changed, 15 insertions(+), 17 deletions

[PATCH v4 07/12] staging: iio: ad2s1200: Add dt table

2018-05-18 Thread David Veenstra
Add device tree table for matching with the vendor ID. Signed-off-by: David Veenstra --- Changes in v4: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging

[PATCH v4 08/12] dt-bindings: iio: resolver: Document AD2S1200 bindings

2018-05-18 Thread David Veenstra
Add documentation for the device tree bindings of the AD2S1200 resolver. Signed-off-by: David Veenstra --- Changes in v4: - Added vendor prefix to gpio function name. - Added unit address. - Changed commit subject to be more inline with other dt-bindings commit . .../bindings/iio

[PATCH v4 11/12] staging: iio: ad2s1200: Add copyright

2018-05-18 Thread David Veenstra
Add David Veenstra as a copyright holders and as an author, for all of the staging clean ups of the ad2s1200 driver. Signed-off-by: David Veenstra --- Changes in v4: - Introduced in this version. drivers/staging/iio/resolver/ad2s1200.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v4 09/12] staging: iio: ad2s1200: Add scaling factor for angular velocity channel

2018-05-18 Thread David Veenstra
The sysfs iio ABI states radians per second is expected as the unit for angular velocity, but the 12-bit angular velocity register has revolution per seconds as its unit. So a scaling factor of approximately 2 * Pi is added to the angular velocity channel. Signed-off-by: David Veenstra

[PATCH v4 12/12] staging: iio: ad2s1200: Move driver out of staging

2018-05-18 Thread David Veenstra
Move the iio driver for the ad2s1200 and ad2s1205 resolver-to-digital converter out of staging, into mainline iio subsystems. Signed-off-by: David Veenstra --- drivers/iio/Kconfig | 1 + drivers/iio/Makefile| 1 + drivers/iio/resolver/Kconfig

[PATCH v4 10/12] staging: iio: ad2s1200: Add scaling factor for angle channel

2018-05-18 Thread David Veenstra
A scaling factor of approximately 2 * Pi / (2^12 -1) is added, to scale the 12-bits angular position to radians. A return type of IIO_VAL_INT_PLUS_NANO is used, so that the scale of both the angle channel and angular velocity channel has 7 significant digits. Signed-off-by: David Veenstra

Re: [PATCH net-next] hv_netvsc: Add handlers for ethtool get/set msg level

2018-05-23 Thread David Miller
From: Haiyang Zhang Date: Tue, 22 May 2018 11:29:34 -0700 > From: Haiyang Zhang > > The handlers for ethtool get/set msg level are missing from netvsc. > This patch adds them. > > Signed-off-by: Haiyang Zhang Applied. ___ devel mailing list de...@l

Re: [PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs

2018-05-31 Thread David Miller
From: Petr Machata Date: Wed, 30 May 2018 02:55:34 +0200 > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced by

Re: [PATCH net-next] hv_netvsc: fix error return code in netvsc_probe()

2018-06-03 Thread David Miller
From: Wei Yongjun Date: Thu, 31 May 2018 02:04:43 + > Fix to return a negative error code from the failover register fail > error handling case instead of 0, as done elsewhere in this function. > > Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use > the failover fra

Re: [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup

2018-06-07 Thread David Miller
From: Dexuan Cui Date: Wed, 6 Jun 2018 21:32:51 + > > Recently people reported the NIC stops working after > "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not > enabled, after the refactoring of the common detach logic: when the NIC > has sub-channels, usually we enab

Re: [PATCH] hv_netvsc: Add per-cpu ethtool stats for netvsc

2018-06-07 Thread David Miller
From: Yidong Ren Date: Wed, 6 Jun 2018 15:27:00 -0700 > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters exist in current code. Exposing these > counters will help tr

Re: [PATCH net 0/3] hv_netvsc: notification and namespace fixes

2018-06-12 Thread David Miller
From: Stephen Hemminger Date: Mon, 11 Jun 2018 12:44:53 -0700 > This set of patches addresses two set of fixes. First it backs out > the common callback model which was merged in net-next without > completing all the review feedback or getting maintainer approval. > > Then it fixes the transpare

RE: [PATCH] staging: lustre: add error handling for try_module_get

2018-06-13 Thread David Laight
eater than zero. Similarly module_put(THIS_MODULE) must never be able to release the last reference. Any such calls that aren't in error paths after try_module_get() are probably buggy. David ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

2018-06-14 Thread David Miller
Bug fixes should be targetted at net, not net-next. Furthermore, net-next is closed. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

2018-06-14 Thread David Miller
From: Haiyang Zhang Date: Thu, 14 Jun 2018 18:29:09 -0700 > From: Haiyang Zhang > > These fields in struct ndis_ipsecv2_offload and struct ndis_rsc_offload > are one byte according to the specs. This patch defines them with the > right size. These structs are not in use right now, but will be u

Re: [PATCH net-next,1/3] hv_netvsc: Clean up two unused variables

2015-04-07 Thread David Miller
From: Haiyang Zhang Date: Mon, 6 Apr 2015 15:22:52 -0700 > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-d

Re: [PATCH net-next,2/3] hv_netvsc: Define a macro RNDIS_AND_PPI_SIZE

2015-04-07 Thread David Miller
From: Haiyang Zhang Date: Mon, 6 Apr 2015 15:22:53 -0700 > The sum of RNDIS msg and PPI struct sizes is used in multiple places, so we > define > a macro for them. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel

Re: [PATCH net-next,3/3] hv_netvsc: Fix the packet free when it is in skb headroom

2015-04-07 Thread David Miller
From: Haiyang Zhang Date: Mon, 6 Apr 2015 15:22:54 -0700 > In the two places changed, we now use netvsc_xmit_completion() which properly > frees hv_netvsc_packet in or not in skb headroom. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. _

Re: [PATCH 0/2] hv_netvsc: linearize SKBs bigger than MAX_PAGE_BUFFER_COUNT-2 pages

2015-04-08 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 8 Apr 2015 17:54:04 +0200 > This patch series fixes the same issue which was fixed in Xen with commit > 97a6d1bb2b658ac85ed88205ccd1ab809899884d ("xen-netfront: Fix handling packets > on > compound pages with skb_linearize"). This patch series only applies on

Re: [PATCH net-next] hv_netvsc: Implement partial copy into send buffer

2015-04-14 Thread David Miller
From: Haiyang Zhang Date: Mon, 13 Apr 2015 16:34:35 -0700 > If remaining space in a send buffer slot is too small for the whole message, > we only copy the RNDIS header and PPI data into send buffer, so we can batch > one more packet each time. It reduces the vmbus per-message overhead. > > Sign

Re: [PATCH net-next,1/1] hv_netvsc: call dump_rndis_message() only in netvsc debug mode

2015-04-21 Thread David Miller
From: six...@microsoft.com Date: Tue, 21 Apr 2015 15:58:05 -0700 > From: Simon Xiao > > Signed-off-by: Simon Xiao > Reviewed-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang I just gave you feedback on this patch in response to your original submission, do not ignore it. ___

Re: [PATCH net-next,1/1] hv_netvsc: call dump_rndis_message() only in netvsc debug mode

2015-04-21 Thread David Miller
From: Simon Xiao Date: Tue, 21 Apr 2015 22:14:14 + > In current netvsc driver, for each packet received, it will call > dump_rndis_message() to try to dump the rndis packet information by > netdev_dbg(). In non-debug mode, dump_rndis_message() will not dump > anything but it still initialize

Re: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-25 Thread David Miller
From: six...@microsoft.com Date: Fri, 24 Apr 2015 11:34:48 -0700 > + net_device_ctx->msg_enable = netif_msg_init(debug, default_msg); > + if (netif_msg_probe(net_device_ctx)) > + netdev_dbg(net, "netvsc msg_enable: %d", > +net_device_ctx->msg_enable); >

linux-4.1-rc1/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c:424: bad if test ?

2015-04-27 Thread David Binderman
estRate> 0x0b)     pRaInfo->PTModeSS = 2;     else if (pRaInfo->HighestRate> 0x0b)     pRaInfo->PTModeSS = 1; Regards David Binderman ___ devel mailing list de...

Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-27 Thread David Miller
From: "K. Y. Srinivasan" Date: Mon, 27 Apr 2015 18:14:50 -0700 > Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory > allocation in the packet send path. This commit introduced a bug since it > did not account for the case if the skb was cloned. Fix this bug by > using the p

Re: [PATCH net-next,v3,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-29 Thread David Miller
From: six...@microsoft.com Date: Tue, 28 Apr 2015 01:05:17 -0700 > From: Simon Xiao > > 1. Introduce netif-msg to netvsc to control debug logging output > and keep msg_enable in netvsc_device_context so that it is > kept persistently. > 2. Only call dump_rndis_message() when NETIF_MSG_RX_ERR or

Re: [PATCH V2 net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-29 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 28 Apr 2015 17:59:48 -0700 > Commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory > allocation in the packet send path: > > "hv_netvsc: Eliminate memory allocation in the packet send path > > The network protocol used to communicate with

Re: [PATCH net-next 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-04-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 29 Apr 2015 15:33:42 -0700 > @@ -772,19 +773,21 @@ static inline int netvsc_send_pkt( > if (packet->page_buf_cnt) { > pgbuf = packet->cp_partial ? packet->page_buf + > packet->rmsg_pgcnt : packet->page_buf; > -

Re: [PATCH] hv_netvsc: remove unused variable in netvsc_send()

2015-05-05 Thread David Miller
From: Jerry Snitselaar Date: Mon, 4 May 2015 10:57:16 -0700 > With commit b56fc3c53654 ("hv_netvsc: Fix a bug in netvsc_start_xmit()"), > skb variable is no longer used in netvsc_send. Remove variable and dead > code that depended on it. > > Cc: Haiyang Zhang > Cc: K. Y. Srinivasan > Signed-o

Re: [PATCH V4 net-next 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-05-10 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 6 May 2015 15:29:05 -0700 > - ret = vmbus_sendpacket_pagebuffer(out_channel, > - pgbuf, > - packet->page_buf_cnt, > -

Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-05-11 Thread David Miller
From: KY Srinivasan Date: Mon, 11 May 2015 08:59:53 + > > >> -Original Message- >> From: Joe Perches [mailto:j...@perches.com] >> Sent: Sunday, May 10, 2015 10:58 PM >> To: KY Srinivasan >> Cc: da...@davemloft.net; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; de...@linu

[PATCH] staging: slicoss: remove slic_spinlock wrapper

2015-05-11 Thread David Matlack
As per TODO. This commit introduces no functional changes. Signed-off-by: David Matlack --- drivers/staging/slicoss/TODO | 1 - drivers/staging/slicoss/slic.h| 19 +++--- drivers/staging/slicoss/slicoss.c | 125 ++ 3 files changed, 65 insertions

Re: [PATCH V6 net-next 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-05-12 Thread David Miller
From: "K. Y. Srinivasan" Date: Mon, 11 May 2015 15:39:46 -0700 > Based on the information given to this driver (via the xmit_more skb flag), > we can defer signaling the host if more packets are on the way. This will help > make the host more efficient since it can potentially process a larger ba

Re: [PATCH net-next,1/1] hv_netvsc: use per_cpu stats to calculate TX/RX data

2015-05-13 Thread David Miller
From: six...@microsoft.com Date: Tue, 12 May 2015 15:50:02 -0700 > From: Simon Xiao > > Current code does not lock anything when calculating the TX and RX stats. > As a result, the RX and TX data reported by ifconfig are not accuracy in a > system with high network throughput and multiple CPUs (

Re: [PATCH net-next,v2,1/1] hv_netvsc: use per_cpu stats to calculate TX/RX data

2015-05-14 Thread David Miller
From: Simon Xiao Date: Thu, 14 May 2015 01:00:25 -0700 > Current code does not lock anything when calculating the TX and RX stats. > As a result, the RX and TX data reported by ifconfig are not accuracy in a > system with high network throughput and multiple CPUs (in my test, > RX/TX = 83% betwee

Re: [PATCH net-next,1/1] hv_netvsc: change member name of struct netvsc_stats

2015-05-17 Thread David Miller
From: Simon Xiao Date: Fri, 15 May 2015 02:33:03 -0700 > Currently the struct netvsc_stats has a member s_sync > of type u64_stats_sync. > This definition will break kernel build as the macro > netdev_alloc_pcpu_stats requires this member name to be syncp. > (see netdev_alloc_pcpu_stats definitio

[PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data

2015-05-25 Thread David Decotigny
/selftest/conctl.c:918:30:got char *ioc_pbuf2 Signed-off-by: David Decotigny --- drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 4 ++-- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 +- drivers/staging/lustre/lnet/lnet/api-ni.c | 5 +++-- 3 files

Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 26 May 2015 16:21:09 -0700 > The current algorithm for deciding on the number of VRSS channels is > not optimal since we open up the min of number of CPUs online and the > number of VRSS channels the host is offering. So on a 32 VCPU guest > we could potentiall

Re: [PATCH V2 net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 27 May 2015 13:16:57 -0700 > The current algorithm for deciding on the number of VRSS channels is > not optimal since we open up the min of number of CPUs online and the > number of VRSS channels the host is offering. So on a 32 VCPU guest > we could potentiall

Re: [PATCH net-next 0/2] hv_netvsc: Implement NUMA aware memory allocation

2015-05-31 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 28 May 2015 17:07:44 -0700 > Allocate both receive buffer and send buffer from the NUMA node assigned to > the > primary channel. Series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://dr

Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data

2015-06-01 Thread David Decotigny
7:27 PM, Greg Kroah-Hartman wrote: > On Mon, May 25, 2015 at 09:40:04PM -0700, David Decotigny wrote: >> This fixes the following sparse warnings: >>drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect >> type in argument 1 (different address spaces)

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-06-01 Thread David Miller
icitly included > and that tends to hide places where vmalloc() et al are added to files > but the include of vmalloc.h is forgotten. > ... > Suggested-by: David Miller > Signed-off-by: Stephen Rothwell With the follow-on allnoconfig fixes: Acked-by: David S. Miller

[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-06 Thread David Decotigny
ifferent base types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:expected unsigned short [unsigned] status drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:got restricted __le16 [usertype] Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core/rtw_mlme_e

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues

2015-06-06 Thread David Decotigny
. # Patch Set Summary: David Decotigny (2): staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness staging: rtl8723au: core: remove redundant endianness conversion drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

2015-06-06 Thread David Decotigny
types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:got restricted __le16 [usertype] BA_timeout_value Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core

Re: [PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-07 Thread David Decotigny
This was introduced by kernel bulk commit 5e93f3520 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of th

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues

2015-06-07 Thread David Decotigny
correct recipients, only changed commit descriptions (credits to Dan Carpenter) # Patch Set Summary: David Decotigny (2): staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness staging: rtl8723au: core: remove redundant

[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-07 Thread David Decotigny
93f3520 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of the driver. Signed-off-b

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

2015-06-07 Thread David Decotigny
/rtl8723au/core/rtw_mlme_ext.c:3911:56:expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:got restricted __le16 [usertype] BA_timeout_value Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++-- 1

Re: [PATCH v1] staging: exfat: fix multiple definition error of `rename_file'

2019-12-05 Thread David Gow
um by selecting: > > CONFIG_EXFAT_FS=y > CONFIG_HOSTFS=y > > Add a namespace prefix exfat_* to fix this error. > > Reported-by: Brendan Higgins > Signed-off-by: Brendan Higgins > Cc: Valdis Kletnieks > Cc: Greg Kroah-Hartman Tested-by: David Gow Reviewed-by: David Gow

[PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread Kim, David
d-off-by: David Kim ​ MAINTAINERS |8 + drivers/staging/Kconfig |1 + drivers/staging/Makefile |1 + drivers/staging/ncipher/Kconfig |8 + drivers/staging/ncipher/Makefile |7 + drivers/staging/ncipher/fsl.c |

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread Kim, David
hen I re-submit I can go directly to drivers/crypto instead. Thanks, Dave David Kim Senior Software Engineer Tel: +44 1223 703449 nCipher Security One Station Square Cambridge CB1 2GA United Kingdom From: linux-crypto-ow...@vger.kernel.org on beha

Re: [PATCH 1/2] staging: remove isdn capi drivers

2019-12-09 Thread David Miller
ast one to stop being maintained after Paul Bolle lost access >> to an ISDN network. >> >> The CAPI subsystem remains for now, as it is still required by >> bluetooth/cmtp. >> >> Signed-off-by: Arnd Bergmann > > Nice! You beat me to it :) > > I'l

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

2019-12-09 Thread David Miller
From: Arnd Bergmann Date: Mon, 9 Dec 2019 16:12:56 +0100 > syzbot keeps finding issues in the X.25 implementation that nobody is > interested in fixing. Given that all the x25 patches of the past years > that are not global cleanups tend to fix user-triggered oopses, is it > time to just retire

Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread David Miller
From: Scott Schafer Date: Thu, 12 Dec 2019 09:02:00 -0600 > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: >> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: >> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct >> > mbox_params *mbcp) >>

<    1   2   3   4   5   6   7   8   9   10   >