Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

On Fri, Jul 23, 2021 at 07:22:46PM +0200, Sam Ravnborg wrote: > On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote: > > > From: Chenyang Li > > > > > > This patch adds an initial DRM driver for the Loongson LS7A1000 > > >

Re: [PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c

On Fri, Jul 23, 2021 at 04:27:50PM +0530, Benjamin Philip wrote: > The following few patches remove some blank lines that before or after a > brace. > > To test my changes, I have checked if it compiles (which it does). I also have > checked the patch with checkpatch.pl, which does not pass any w

Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

Hi Chenyang, I browsed the code on lore and noticed a few things and thought it better to bring it to your attention now. The general structure of the drivers seems good and coding style is fine. The feedback is mostly stuff we have decided to do different over time, so likely because you based t

[driver-core:driver-core-next] BUILD SUCCESS bdac4d8abbfc239886103f7c6ee03abb8011a008

defconfig i386 randconfig-c001-20210727 i386 randconfig-c001-20210726 sh urquell_defconfig sh se7712_defconfig arm integrator_defconfig x86_64allnoconfig ia64

[driver-core:debugfs_cleanup] BUILD SUCCESS 4480b40b4fa33664257936f046e207e394a49fcc

allmodconfig i386 randconfig-c001-20210727 i386 randconfig-c001-20210726 sh urquell_defconfig sh se7712_defconfig arm integrator_defconfig riscvallmodconfig

[driver-core:driver-core-linus] BUILD SUCCESS 4d1014c1816c0395eca5d1d480f196a4c63119d0

allmodconfig i386 randconfig-c001-20210727 i386 randconfig-c001-20210726 sh urquell_defconfig sh se7712_defconfig arm integrator_defconfig riscvallmodconfig s390

Reply: Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

Hi Sam, Thank you very much for your attention to our driver. I will consider your opinion, The next version is due in the near future. > -Original Messages- > From: "Sam Ravnborg" > Sent Time: 2021-07-28 01:41:30 (Wednesday) > To: "Daniel Vetter" > Subject: Re: [PATCH v3 1/3] drm/loong

[staging:staging-testing 108/110] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:185:16: warning: result of comparison of constant 419244183493398898 with expression of type 'unsigned i

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 39f9137268ee3df0047706df4e9b7357a40ffc98 commit: 7b9148dcb74a004a4df10df3af9239a46dfc2b2f [108/110] staging: vchiq: Combine vchiq platform code into single file config: powerpc64-randconfig-r011-202

Reply: Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

Hi Daniel, I'm honored to have your attention，and thanks for your advice. I will finish the next version and submit it as soon as possible. > > + > > + lcrtc->ldev = ldev; > > + lcrtc->reg_offset = index * REG_OFFSET; > > + lcrtc->cfg_reg = CFG_RESET; > > + lcrtc->crtc_id = index;