s/stoping/stooping/
s/arragement/arrangement/
s/eralier/earlier/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/rtl8723bs/include/hal_com_reg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h
b/drivers/staging/rtl
Hey Xin,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:33, Xin Ji wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished.
>
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++
From: Arnd Bergmann
This driver has a few disabled diagnostics, which can probably
just get removed, or might still be helpful:
drivers/staging/rtl8192u/r8192U_core.c: In function 'rtl8192_set_rxconf':
drivers/staging/rtl8192u/r8192U_core.c:767:45: error: suggest braces around
empty body in an
From: Arnd Bergmann
This driver has a few disabled diagnostics, which can probably
just get removed, or might still be helpful:
drivers/staging/nvec/nvec_ps2.c: In function 'nvec_ps2_notifier':
drivers/staging/nvec/nvec_ps2.c:94:77: error: suggest braces around empty body
in an 'if' statement [
Hello, Greg.
Thanks for your comments. I'd like to address a couple of them.
First, there's the lockless FIFO that is implemented in the driver:
On 21/03/21 14:23, Greg KH wrote:
+
+static unsigned int fifo_read(struct xillyfifo *fifo,
+ void *data, unsigned int l
On 21/03/21 14:24, Greg KH wrote:
+config XILLYBUS_CLASS
> + tristate
> +
>config XILLYBUS
>tristate "Xillybus generic FPGA interface"
>depends on PCI || OF
>select CRC32
> + select XILLYBUS_CLASS
depends on, do not select.
XILLYBUS and XILLY
On Mon, Mar 22, 2021 at 01:02:04PM +0200, Eli Billauer wrote:
> On 21/03/21 14:24, Greg KH wrote:
> > > +config XILLYBUS_CLASS
> > > > + tristate
> > > > +
> > > >config XILLYBUS
> > > > tristate "Xillybus generic FPGA interface"
> > > > depends on PCI || OF
> > > >
On Mon, Mar 22, 2021 at 01:01:54PM +0200, Eli Billauer wrote:
> Hello, Greg.
>
> Thanks for your comments. I'd like to address a couple of them.
>
> First, there's the lockless FIFO that is implemented in the driver:
>
> On 21/03/21 14:23, Greg KH wrote:
> >
> > > +
> > > +static unsigned int f
On Fri, Mar 12, 2021 at 01:24:54PM +0100, Nicolas Saenz Julienne wrote:
> Adds support to control the PWM bus available in official Raspberry Pi
> PoE HAT. Only RPi's co-processor has access to it, so commands have to
> be sent through RPi's firmware mailbox interface.
>
> Signed-off-by: Nicolas S
On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
wrote:
>
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +
> 1 file changed, 259 insertions(+)
> create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c
Fix extern declaration issues warned by checkpatch
Fabio Aiuto (11):
staging: rtl8723bs: delete extern declarations in core/rtw_ap.c
staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c
staging: rtl8723bs: moved function prototype out of
core/rtw_ioctl_set.c and core/rtw
delete extern declaration in .c file (RTW_WPA_OUI) and
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
14: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:14:
+extern unsigned char WMM_OUI[];
--
WARNING: externs should be avoided in .c files
15: FILE: drivers/stag
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190:
+signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame
*precv_frame);
and then moved all function prototypes but one in include
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35:
+bool
moved two function prototypes in include/rtw_efuse.h
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_efuse.c| 10 --
remove debug_priv argument so function prototype can be
easily moved away
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging/rtl8723b
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40:
+u8 rtw_do_join(struct adapter *padapter);
WARNING: externs should be avoided in .c files
15: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:15:
+exter
move function prototype in include/rtw_recv.h
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_recv.c| 1 -
drivers/staging/rtl8723bs/include/rtw_recv.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
28: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:28:
+extern unsigned char RTW_WPA_OUI[];
--
WARNING: externs should be avoided in .c files
29: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:29:
+exte
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
285: FILE: drivers/staging/rtl8723bs/hal/odm.c:285:
+void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
287: FILE: drivers/staging/rtl8723bs/hal/odm.c:287:
+voi
fix the following checkpatch issues:
WARNING: externs should be avoided in .c files
196: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:196:
+int _netdev_open(struct net_device *pnetdev);
--
WARNING: externs should be avoided in .c files
197: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:19
fix the following checkpatch issue:
WARNING: externs should be avoided in .c files
486: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:486:
+extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal);
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 -
remove unnecessary extern.
The function is defined static in os_dep/os_intfs.c and used only once
in the same file
remove also a blank line
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 -
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 --
2 files changed, 3
De Nederlandse Staatsloterij
Paleisstraat 5
2514 JA The Hague
statel...@mail2netherlands.com
http://www.staatsloterij.nl
INTERNATIONAL PROMOTION / PRIZE AWARD DEPT.
REF Number: FLA2076137
BATCH Number : 03/9364235/03
TICKET Number : 816372
SERIAL Nu
On Mon, Mar 22, 2021 at 12:58:08PM +0530, Bhaskar Chowdhury wrote:
>
> s/stoping/stooping/
Huh?
Are you _sure_ that is the correct replacement? Last I looked it
wasn't...
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
On Mon, Mar 22, 2021 at 03:31:49PM +0100, Fabio Aiuto wrote:
> remove unnecessary extern.
>
> The function is defined static in os_dep/os_intfs.c and used only once
> in the same file
>
> remove also a blank line
That needs to go to a separate patch :(
__
On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35:
> +bool
>
> moved two function prototypes in include/rtw_efuse.h
>
> Signed-off-by: Fa
On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40:
> +u8 rtw_do_join(struct adapter *padapter);
>
> WARNING: externs should be avoided
On Mon, Mar 22, 2021 at 03:31:42PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190:
> +signed int validate_recv_mgnt_frame(struct adapter *padapter, union
> recv_frame
On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote:
> remove debug_priv argument so function prototype can be
> easily moved away
>
> Signed-off-by: Fabio Aiuto
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> dif
A previous cleanup patch removed the usage of the ret var.
So, drop it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
b/drivers/staging/media/atom
Hello Ulf,
On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +
> > 1 file change
On Mon, Mar 22, 2021 at 05:07:53PM +0100, Greg KH wrote:
> On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote:
> > fix the following checkpatch issues:
> >
> > WARNING: externs should be avoided in .c files
> > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35:
> > +bool
> >
> > mo
On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35:
> +bool
>
> moved two function prototypes in include/rtw_efuse.h
Can't you just make t
On 17:05 Mon 22 Mar 2021, Greg KH wrote:
On Mon, Mar 22, 2021 at 12:58:08PM +0530, Bhaskar Chowdhury wrote:
s/stoping/stooping/
Huh?
Are you _sure_ that is the correct replacement? Last I looked it
wasn't...
No it is not. Will correct it. I hope you won't mind V2.
greg k-h
signature.as
s/stoping/stopping/
s/arragement/arrangement/
s/eralier/earlier/
Plus one extra word in the sentence "the" removed.
Signed-off-by: Bhaskar Chowdhury
---
Changes from V1:
Greg,pointed out my mistake of introducing typo to typo , corrected.
drivers/staging/rtl8723bs/include/hal_com_reg.h | 6
-20210322
i386 randconfig-a003-20210322
i386 randconfig-a001-20210322
i386 randconfig-a002-20210322
i386 randconfig-a006-20210322
i386 randconfig-a005-20210322
x86_64 randconfig-a012-20210322
x86_64
On 3/22/21 1:16 PM, Bhaskar Chowdhury wrote:
> s/stoping/stopping/
> s/arragement/arrangement/
> s/eralier/earlier/
>
> Plus one extra word in the sentence "the" removed.
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
> ---
> Changes from V1:
> Greg,pointed out my mistake of
s/procesing/processing/
s/comunication/communication/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/wimax/i2400m/driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/driver.c
b/drivers/staging/wimax/i2400m/driver.c
index f5186458
s/netowrk/network/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c
b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 2c9425e2a1e9..3888d3984ec0 100644
-
普通3%增值6% 微信同步 l388-O474-899
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote:
>
> s/procesing/processing/
> s/comunication/communication/
>
> Signed-off-by: Bhaskar Chowdhury
drivers/staging/wimax/ is in the process of being deleted.
> ---
> drivers/staging/wimax/i2400m/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
On 21:14 Mon 22 Mar 2021, Randy Dunlap wrote:
On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote:
s/procesing/processing/
s/comunication/communication/
Signed-off-by: Bhaskar Chowdhury
drivers/staging/wimax/ is in the process of being deleted.
Yes ...I saw the mail day or two back ...skipped my
i386 randconfig-a004-20210322
i386 randconfig-a003-20210322
i386 randconfig-a001-20210322
i386 randconfig-a002-20210322
i386 randconfig-a006-20210322
i386 randconfig-a005-20210322
x86_64
43 matches
Mail list logo