This set of patches remove 153 useless typedef instructions in the
staging/rtl8723bs source code, as identified by the checkpatch.pl
script. Every patch is purely syntactical: it does not change the
generated machine code. Furthermore, every single patch leaves the
source code fully compilable, so
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#84: FILE: include/rtw_mlme.h:84:
+typedef enum _RT_SCAN_TYPE {
WARNING: do not add new typedefs
#137: FILE: include/rtw_mlme.h:137:
+typedef struct _RT_LINK_DETECT_T {
Signed-off-by:
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#27: FILE: hal/odm_NoiseMonitor.h:27:
+typedef struct _ODM_NOISE_MONITOR_ {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/odm.h | 2 +-
drivers/staging/rtl8723bs/hal/
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#15: FILE: hal/odm_CfoTracking.h:15:
+typedef struct _CFO_TRACKING_ {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/odm.h | 2 +-
drivers/staging/rtl8723bs/hal/odm_Cf
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#42: FILE: hal/odm_interface.h:42:
+typedef enum _ODM_H2C_CMD {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/odm_interface.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#47: FILE: hal/HalBtcOutSrc.h:47:
+typedef enum _BTC_POWERSAVE_TYPE {
WARNING: do not add new typedefs
#54: FILE: hal/HalBtcOutSrc.h:54:
+typedef enum _BTC_BT_REG_TYPE {
WARNING:
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#33: FILE: hal/odm_HWConfig.h:33:
+typedef struct _Phy_Rx_AGC_Info {
WARNING: do not add new typedefs
#41: FILE: hal/odm_HWConfig.h:41:
+typedef struct _Phy_Status_Rpt_8192cd {
WA
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#11: FILE: hal/odm_EdcaTurboCheck.h:11:
+typedef struct _EDCA_TURBO_ {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/odm.h| 2 +-
drivers/staging/rtl8723bs/hal/odm
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#18: FILE: hal/odm_types.h:18:
+typedef enum _HAL_STATUS {
WARNING: do not add new typedefs
#33: FILE: hal/odm_types.h:33:
+typedef enum _RT_SPINLOCK_TYPE {
WARNING: do not add ne
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#45: FILE: include/rtw_eeprom.h:45:
+typedef enum _RT_CUSTOMER_ID {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/rtw_eeprom.h | 4 ++--
1 file changed, 2 insertions(+), 2 del
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#95: FILE: hal/odm.h:95:
+typedef struct _Rate_Adaptive_Table_ {
WARNING: do not add new typedefs
#99: FILE: hal/odm.h:99:
+typedef struct _RX_High_Power_ {
WARNING: do not add ne
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#168: FILE: include/hal_com.h:168:
+typedef enum _RT_MEDIA_STATUS {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 2 +-
drivers/staging/rtl8723bs/hal/hal_btcoex.c
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#374: FILE: include/drv_types.h:374:
+typedef enum _DRIVER_STATE {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/drv_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 delet
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#13: FILE: include/rtw_ioctl_set.h:13:
+typedef struct _BSSIDInfo {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 4 ++--
1 file changed, 2 insertions(+), 2
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#40: FILE: include/rtw_ht.h:40:
+typedef enum AGGRE_SIZE {
WARNING: do not add new typedefs
#51: FILE: include/rtw_ht.h:51:
+typedef enum _RT_HT_INF0_CAP {
WARNING: do not add new
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#130: FILE: include/wlan_bssdef.h:130:
+typedef struct _NDIS_802_11_ASSOCIATION_INFORMATION {
WARNING: do not add new typedefs
#148: FILE: include/wlan_bssdef.h:148:
+typedef struct _N
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#52: FILE: include/rtw_mp.h:52:
+typedef struct _MPT_CONTEXT {
WARNING: do not add new typedefs
#268: FILE: include/rtw_mp.h:268:
+typedef struct _IOCMD_STRUCT_ {
Signed-off-by: Marco
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#83: FILE: include/osdep_service.h:83:
+typedef enum mstat_status {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/osdep_service.h | 4 ++--
1 file changed, 2 insertions(+), 2
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#87: FILE: include/rtw_security.h:87:
+typedef struct _RT_PMKID_LIST {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/rtw_security.h | 6 +++---
drivers/staging/rtl8723bs/os_d
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#62: FILE: include/rtl8723b_xmit.h:62:
+typedef struct txdesc_8723b {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 8
drivers/staging/rtl8723bs/inc
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#251: FILE: include/hal_com_h2c.h:251:
+typedef struct _RSVDPAGE_LOC {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 20 +--
.../staging/rtl8723b
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#11: FILE: include/HalVerDef.h:11:
+typedef enum tag_HAL_IC_Type_Definition {
WARNING: do not add new typedefs
#25: FILE: include/HalVerDef.h:25:
+typedef enum tag_HAL_CHIP_Type_Defini
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#173: FILE: include/rtl8723b_hal.h:173:
+typedef enum _C2H_EVT {
WARNING: do not add new typedefs
#189: FILE: include/rtl8723b_hal.h:189:
+typedef struct _C2H_EVT_HDR {
WARNING: d
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#118: FILE: include/rtw_mlme_ext.h:118:
+typedef enum _RT_CHANNEL_DOMAIN {
WARNING: do not add new typedefs
#186: FILE: include/rtw_mlme_ext.h:186:
+typedef enum _RT_CHANNEL_DOMAIN_2G
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#85: FILE: include/HalPwrSeqCmd.h:85:
+typedef enum _PWRSEQ_CMD_DELAY_UNIT_ {
WARNING: do not add new typedefs
#90: FILE: include/HalPwrSeqCmd.h:90:
+typedef struct _WL_PWR_CFG_ {
Sig
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#128: FILE: include/ieee80211.h:128:
+typedef enum _RATEID_IDX_ {
WARNING: do not add new typedefs
#142: FILE: include/ieee80211.h:142:
+typedef enum _RATR_TABLE_MODE {
WARNING: d
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#34: FILE: include/sta_info.h:34:
+typedef struct _RSSI_STA {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/sta_info.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#60: FILE: include/rtw_efuse.h:60:
+typedef struct PG_PKT_STRUCT_A {
WARNING: do not add new typedefs
#68: FILE: include/rtw_efuse.h:68:
+typedef struct _EFUSE_HAL {
Signed-off-by: Ma
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#16: FILE: include/basic_types.h:16:
+typedefsigned int sint;
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
.../staging/rtl8723bs/core/rtw_ieee80211.c
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#43: FILE: include/osdep_service_linux.h:43:
+ typedef spinlock_t _lock;
WARNING: do not add new typedefs
#44: FILE: include/osdep_service_linux.h:44:
+ typedef struct mutex
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
#11: FILE: hal/odm_DIG.h:11:
+typedef struct _Dynamic_Initial_Gain_Threshold_ {
WARNING: do not add new typedefs
#62: FILE: hal/odm_DIG.h:62:
+typedef struct false_ALARM_STATISTICS {
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#23: FILE: hal/hal_btcoex.c:23:
+typedef struct _btcoexdbginfo {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 +++---
1 file changed, 7 insertions(+), 7
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#14: FILE: include/hal_btcoex.h:14:
+typedef struct _BT_COEXIST {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/include/hal_btcoex.h | 4 ++--
drivers/staging/rtl8723bs/include/hal_da
This commit fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
#11: FILE: hal/odm_DynamicBBPowerSaving.h:11:
+typedef struct _Dynamic_Power_Saving_ {
Signed-off-by: Marco Cesati
---
drivers/staging/rtl8723bs/hal/odm.h | 2 +-
drivers/sta
On Thu, Mar 11, 2021 at 02:38:38PM +0800, Hao Peng wrote:
> Add initial value for some uninitialized variable and array.
>
None of these are ever used uninitialized. It's weird that you would
even think that.
> if (pmlmeext->active_keep_alive_check) {
> -
fix the following checkpatch issues:
WARNING: quoted string split across lines
+ DBG_871X("HT: STA %pM HT Capabilities "
+ "Info: 0x%04x\n", MAC_ARG(psta->hwaddr), ht_capab);
WARNING: quoted string split across lines
+ DBG_871X("%s STA
s/exahusted/exhausted/
s/caleed/called/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/wimax/i2400m/tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/tx.c
b/drivers/staging/wimax/i2400m/tx.c
index e9436212fe54..2d15de653951 100644
When unbinding the firmware device we need to make sure it has no
consumers left. Otherwise we'd leave them with a firmware handle
pointing at freed memory.
Keep a reference count of all consumers and introduce rpi_firmware_put()
which will permit automatically decrease the reference count upon
un
The aim of this series is to add support to the fan found on RPi's PoE
HAT. Some commentary on the design can be found below. But the important
part to the people CC'd here not involved with PWM is that, in order to
achieve this properly, we also have to fix the firmware interface the
driver uses t
It'll simplify the firmware handling for most consumers.
Suggested-by: Bartosz Golaszewski
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Reviewed-by: Bartosz Golaszewski
---
Changes since v4:
- Rearrange function calls for clarity, same functionality
Changes since v2:
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Acked-by: Stephen Boyd
drivers/clk/bcm/clk-raspberrypi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Acked-by: Bartosz Golaszewski
---
drivers/gpio/gpio-raspberrypi-exp.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
drivers/reset/reset-raspberrypi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/res
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
drivers/soc/bcm/raspberrypi-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Reviewed-by: Greg Kroah-Hartman
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
1 file cha
There is no use for the firmware interface after getting the touch
buffer address, so release it.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Dmitry Torokhov
Reviewed-by: Florian Fainelli
---
Changes since v5:
- Correct commit message
Changes since v3:
- Release firmware handle in probe
This is an example on how to enable the fan on top of RPi's official PoE
hat.
Signed-off-by: Nicolas Saenz Julienne
---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++
1 file changed, 54 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
b/arch/arm/boot/dt
The PWM bus controlling the fan in RPi's official PoE hat can only be
controlled by the board's co-processor.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Rob Herring
---
Changes since v4:
- Rename compatible string to be more explicit with the bus' limitations
Changes since v3:
- Fix e
Adds support to control the PWM bus available in official Raspberry Pi
PoE HAT. Only RPi's co-processor has access to it, so commands have to
be sent through RPi's firmware mailbox interface.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v7:
- Remove unwarranted RPI_PWM_DEF_DUTY_REG
This patch set removes unused code blocks as required in
TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Fabio Aiuto (3):
staging: rtl8723bs: remove unused code blocks
staging: rtl8723bs: remove unused code blocks
staging: rtl8723bs: remove unused code blo
Remove conditional code blocks checked by unused CONFIG_PNO_SUPPORT
Cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 --
.../staging/rtl8723bs/core/rtw_wlan_uti
remove conditional code blocks checked by unused CONFIG_WOWLAN
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 -
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
remove conditional code blocks checked by unused CONFIG_TCP_CSUM_OFFLOAD_RX
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_recv.h | 5 -
drivers/staging/rtl8723bs/os_d
On Fri, Mar 12, 2021 at 04:49:40PM +0100, Fabio Aiuto wrote:
> This patch set removes unused code blocks as required in
> TODO file:
>
> find and remove code blocks guarded by never set CONFIG_FOO defines
>
> Fabio Aiuto (3):
> staging: rtl8723bs: remove unused code blocks
> staging: rtl8
On Fri, Mar 12, 2021 at 09:26:05AM +0100, Marco Cesati wrote:
> This set of patches remove 153 useless typedef instructions in the
> staging/rtl8723bs source code, as identified by the checkpatch.pl
> script. Every patch is purely syntactical: it does not change the
> generated machine code. Furthe
On Wed, Mar 10, 2021 at 07:35:03PM +0800, Longji Guo wrote:
> Move operators and spaces before tabs to fix coding style issues.
This change doesn't have anything to do with tabs.
confused,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
ht
On 3/12/21 3:42 AM, Bhaskar Chowdhury wrote:
>
> s/exahusted/exhausted/
> s/caleed/called/
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
> ---
> drivers/staging/wimax/i2400m/tx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wimax
This patch set removes unused code blocks as required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Changes in v2:
- modified sunject lines to make them unique
- added a patch previously excluded (removal of
CONFIG_PNO_SET_DEBU
Remove conditional code block checked by unused CONFIG_PNO_SET_DEBUG
Cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 48
drivers/staging/rtl872
Remove conditional code blocks checked by unused CONFIG_PNO_SUPPORT
Cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 --
.../staging/rtl8723bs/core/rtw_wlan_uti
remove conditional code blocks checked by unused CONFIG_WOWLAN
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 -
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
remove conditional code blocks checked by unused CONFIG_TCP_CSUM_OFFLOAD_RX
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_recv.h | 5 -
drivers/staging/rtl8723bs/os_d
Hello Nicolas,
On Fri, Mar 12, 2021 at 01:24:54PM +0100, Nicolas Saenz Julienne wrote:
> Adds support to control the PWM bus available in official Raspberry Pi
> PoE HAT. Only RPi's co-processor has access to it, so commands have to
> be sent through RPi's firmware mailbox interface.
>
> Signed-o
On Mon, 8 Mar 2021 16:54:52 +0200, Alexandru Ardelean wrote:
> A while back I started the introduction of the 'spi_delay' data type:
>
> https://lore.kernel.org/linux-spi/20190926105147.7839-1-alexandru.ardel...@analog.com/
>
> Users of the 'delay_usecs' were removed from drivers.
>
> Now it's
allnoconfig
i386 randconfig-a001-20210312
i386 randconfig-a005-20210312
i386 randconfig-a002-20210312
i386 randconfig-a003-20210312
i386 randconfig-a004-20210312
i386 randconfig-a006
65 matches
Mail list logo