[PATCH] wimax: attempt to address style issues.

2021-03-02 Thread gabriele . modena
From: Gabriele Modena When running checkpatch.pl on op-msg.c, op-rfkill.c and stack.c I noticed that they contained a few style issues at warning level of severity. This patch is both an attempt to address the warnings, as well as a way for me to familiarise with the linux kernel contribution pro

Re: [PATCH] wimax: attempt to address style issues.

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 10:11:02AM +0100, gabriele.mod...@gmail.com wrote: > From: Gabriele Modena > > When running checkpatch.pl on op-msg.c, op-rfkill.c > and stack.c I noticed that they contained a few style issues > at warning level of severity. This patch is both an attempt to > address the

[PATCH] phy: ralink: phy-mt7621-pci: fix XTAL bitmask

2021-03-02 Thread Sergio Paracuellos
When this was rewriten to get mainlined and start to use 'linux/bitfield.h' headers, XTAL_MASK was wrong. It must mask three bits but only two were used. Hence properly fix it to make things work. Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") Signed-off-by: Sergio Paracue

[PATCH] staging: ks7010: prevent buffer overflow in ks_wlan_set_scan()

2021-03-02 Thread Dan Carpenter
The user can specify a "req->essid_len" of up to 255 but if it's over IW_ESSID_MAX_SIZE (32) that can lead to memory corruption. Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository") Signed-off-by: Dan Carpenter --- drivers/staging/ks7010/ks_wlan_net.c | 6 -- 1

Re: [PATCH] phy: ralink: phy-mt7621-pci: fix XTAL bitmask

2021-03-02 Thread Vinod Koul
On 02-03-21, 11:54, Sergio Paracuellos wrote: > When this was rewriten to get mainlined and start to > use 'linux/bitfield.h' headers, XTAL_MASK was wrong. > It must mask three bits but only two were used. Hence > properly fix it to make things work. Applied, thanks -- ~Vinod ___

Re: [PATCH] This patch fixes the check-patch errors

2021-03-02 Thread Greg KH
On Tue, Mar 02, 2021 at 06:12:54PM +0530, Vikas Kumar Sharma wrote: > Disclaimer:This message is intended only for the designated recipient(s). > It may contain confidential or proprietary information and may be subject > to other confidentiality protections. If you are not a designated > recipi

[PATCH] This patch fixes the check-patch errors

2021-03-02 Thread Vikas Kumar Sharma
ERROR: Macros with complex values should be enclosed in parentheses. Signed-off-by: Vikas Kumar Sharma --- drivers/staging/ks7010/ks_hostif.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks701

[PATCH] staging: rtl8192e: remove redundant variable shadowing

2021-03-02 Thread Nikolay Kyx
In function rtl92e_start_adapter() automatic variable 'i' referenced only within certain loops, used as iteration counter. Control flow can't get into such loop w/o 'i = 0' assignment. It's redundant to shadow this variable by creating scope around loop. This patch fixes the following sparse warn

Re: [PATCH] staging: rtl8192u avoid flex array of flex array

2021-03-02 Thread Greg KH
On Sat, Feb 27, 2021 at 07:06:14PM -0600, Darryl T. Agostinelli wrote: > Undo the flex array in struct ieee80211_info_element. It is used as the flex > array type in other structs (creating a flex array of flex arrays) making > sparse unhappy. This change maintains the intent of the code and sati

Re: [PATCH 2/2] staging: rtl8192e: Change state information from u16 to u8

2021-03-02 Thread Greg KH
On Mon, Feb 22, 2021 at 10:53:30PM +0530, Atul Gopinathan wrote: > On Mon, Feb 22, 2021 at 04:26:33PM +0100, Greg KH wrote: > > On Sun, Feb 21, 2021 at 10:27:21PM +0530, Atul Gopinathan wrote: > > > On Sun, Feb 21, 2021 at 02:08:26PM +0100, Greg KH wrote: > > > > On Sat, Feb 20, 2021 at 11:51:55PM

[PATCH] staging: rtl8192e: remove unnecessary break

2021-03-02 Thread Perrin Smith
From: Perrin Smith removed unnecessary break at end of while loop Signed-off-by: Perrin Smith --- drivers/staging/rtl8192e/rtllib_rx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index b8ab34250e6a..2de6330b7

Re: [PATCH] staging: rtl8192e: remove unnecessary break

2021-03-02 Thread Dan Carpenter
On Tue, Mar 02, 2021 at 11:29:03PM +0800, Perrin Smith wrote: > From: Perrin Smith > > removed unnecessary break at end of while loop > > Signed-off-by: Perrin Smith > --- > drivers/staging/rtl8192e/rtllib_rx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e

Re: [PATCH 2/2] staging: rtl8192e: Change state information from u16 to u8

2021-03-02 Thread Atul Gopinathan
On Tue, Mar 02, 2021 at 03:38:52PM +0100, Greg KH wrote: > On Mon, Feb 22, 2021 at 10:53:30PM +0530, Atul Gopinathan wrote: > > On Mon, Feb 22, 2021 at 04:26:33PM +0100, Greg KH wrote: > > > On Sun, Feb 21, 2021 at 10:27:21PM +0530, Atul Gopinathan wrote: > > > > On Sun, Feb 21, 2021 at 02:08:26PM

Re: [PATCH] staging: wfx: remove unused included header files

2021-03-02 Thread Jérôme Pouiller
Hello Muhammad, Sorry, I am a bit late for the review of this patch. Thank you for your contribution. On Thursday 11 February 2021 15:36:37 CET Muhammad Usama Anjum wrote: > > Many header files have been included, but never used. Those header > files have been removed. > > Signed-off-by: Muham

[staging:staging-linus] BUILD SUCCESS d1a5bd3f875c3a507470ecce1b77e40406e34302

2021-03-02 Thread kernel test robot
-a005-20210302 i386 randconfig-a003-20210302 i386 randconfig-a002-20210302 i386 randconfig-a004-20210302 i386 randconfig-a006-20210302 i386 randconfig-a001-20210302 i386 randconfig-a016-20210302 i386

[staging:staging-testing] BUILD SUCCESS 4e1c5d4c35d8d5a5f861019f1392ebaa0abb490b

2021-03-02 Thread kernel test robot
powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210302 i386 randconfig-a003-20210302 i386 randconfig-a002-20210302 i386