On Sun, Feb 14, 2021 at 03:56:01PM +0530, Shreesh Adiga wrote:
> Cleanup warnings displayed by checkpatch.pl for the
> file rtl8171x_mlme.c for the below warning:
> WARNING: Avoid multiple line dereference
>
> Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
> ---
> drivers/staging/rtl8
On Sun, Feb 14, 2021 at 07:44:52PM +0530, Ashish Vara wrote:
> From: Ashish Vara
>
> removed unnecessary out of memory message to fix coding style warning.
>
> Signed-off-by: Ashish Vara
> ---
> drivers/staging/gasket/gasket_page_table.c | 2 --
> 1 file changed, 2 deletions(-)
Your subject l
On Fri, Feb 19, 2021 at 05:51:59AM +0530, karthik alapati wrote:
> convert le32 types to host byte-order types before
> comparison
>
Already fixed. Please work against staging-next or linux-next.
regards,
dan carpenter
___
devel mailing list
de...@lin
On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote:
> In hi6421-spmi-pmic.c, there are some warnings and Check:
>
> "WARNING: please, no space before tabs" in lines 51,52,53 and 69.
> "CHECK: Alignment should match open parenthesis" in lines 180 and 238.
>
> Signed-off-by: Alaa Emad
That
On Tue, Feb 16, 2021 at 06:28:06PM +0800, Du Cheng wrote:
> use __func__ macro instead of literal function name in RT_TRACE() in
> * phy_set_rf8256_bandwidth()
> * phy_rf8256_config_para_file()
>
> remove unnecessary return at the end of phy_set_rf8256_ofdm_tx_power()
>
> these coding style iss
On Thu, Feb 18, 2021 at 03:58:51PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 del
On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote:
> fwserial.c:
Why is this here?
> fix CHECK: Alignment should match open parenthesis
What does this mean?
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is ne
This patch fixes the following checkpatch.pl warnings:
WARNING: line length of 124 exceeds 100 columns
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikol
On Fri, Feb 19, 2021 at 11:04:51AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: line length of 124 exceeds 100 columns
> CHECK: Alignment should match open parenthesis
That's two different things, please make this two different patches.
thanks,
> It's kind of moot anyway because the patch is outdated. But the reason
> for the ___force is that the same `struct comedi_cmd` is used in both
> user and kernel contexts. In user contexts, the `chanlist` member
> points to user memory and in kernel contexts it points to kernel memory
> (copied
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikolay Kyx
---
v2: Edited changelog, as suggested by Greg KH
drivers
On Fri, Feb 19, 2021 at 09:03:59AM +, David Laight wrote:
> > It's kind of moot anyway because the patch is outdated. But the reason
> > for the ___force is that the same `struct comedi_cmd` is used in both
> > user and kernel contexts. In user contexts, the `chanlist` member
> > points to us
On Fri, Feb 19, 2021 at 12:03:18PM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> in file fwserial.c
>
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
>
Don't put
On 19/02/2021 09:03, David Laight wrote:
>> It's kind of moot anyway because the patch is outdated. But the reason
>> for the ___force is that the same `struct comedi_cmd` is used in both
>> user and kernel contexts. In user contexts, the `chanlist` member
>> points to user memory and in kernel c
From: Dan Carpenter
> Sent: 19 February 2021 09:26
>
> On Fri, Feb 19, 2021 at 09:03:59AM +, David Laight wrote:
> > > It's kind of moot anyway because the patch is outdated. But the reason
> > > for the ___force is that the same `struct comedi_cmd` is used in both
> > > user and kernel conte
This patch renames CamelCase macros uVar and uModulo into u_var and
u_module in device.h
This issue was reported by checkpatch.pl
Signed-off-by: Selvakumar Elangovan
---
drivers/staging/vt6656/device.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/v
checkpatch.pl complains about not having identifiers names in
function declarations . This patch uses the same names as are
used in source file sm750_accel.c , but with snake case.
Signed-off-by: shivang upadhyay
---
drivers/staging/sm750fb/sm750.h | 30 ++
1 file
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8
This patchset fixes the checkpatch issues related to the `ba_param_set`
union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase).
William Durand (6):
staging: rtl8192e: rename charData to char_data in ba_param_set union
staging: rtl8192e: rename shortData to short_data in ba_param_set
un
This change uses lowercase for a field name to be more consistent with
the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 9 -
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl819
This change does not fix a checkpatch issue but it is more consistent
with the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rt
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index b2a784fa051e..4fdff19bb4ae 100644
---
This change fixes a checkpatch warning for "struct file_operations should
normally be const".
Signed-off-by: Amrit Khera
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
i
Fix "WARNING: please, no space before tabs" styling issue in
hi6421-spmi-pmic.c for lines 51,52,53 and 69.
Signed-off-by: Alaa Emad
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmi
On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> I was unable to align it right below the opening parenthesis, just by using
> tabs. And when I did that with spaces, the checkpatch yelled at me for
> using spaces. Any suggestions how to do this without using spaces? I am
>
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
> This patch renames CamelCase macros uVar and uModulo into u_var and
> u_module in device.h
>
> This issue was reported by checkpatch.pl
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/vt6656/device.h | 8 +++
On Fri, Feb 19, 2021 at 03:43:39PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations should
> normally be const".
>
> Signed-off-by: Amrit Khera
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Prakash Dubey
---
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/
use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE()
inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
remove the unnecessary return at the end of function
phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/stag
use MACRO __func__ instead of "phy_set_rf8256_bandwidth" for RT_TRACE()
inside phy_set_rf8256_bandwidth(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v3:
* break up changes into 3 patches
changes v2:
* improve description
changes v1:
* fix coding style
drivers/stag
On Fri, Feb 19, 2021 at 07:07:54PM +0800, Du Cheng wrote:
> use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE()
> inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng
> ---
> drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
>
On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote:
> On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> > I was unable to align it right below the opening parenthesis, just by using
> > tabs. And when I did that with spaces, the checkpatch yelled at me for
> > using spa
remove the unnecessary return at the end of function
phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/stag
use MACRO __func__ instead of the literal names for RT_TRACE()
in phy_set_rf8256_bandwidth() and phy_rf8256_config_para_file(),
as reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v4:
* merge two similar patches into 1
changes v3:
* break up changes into 3 patches
changes
This change fixes a checkpatch warning for "struct file_operations
should normally be const".
Signed-off-by: Amrit Khera
---
Changes in v2:
- Wrapped the commit description
- Build tested
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
It's against the rules to send two patches with the same subject. Also
both subjects are too vague.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations
> should normally be const".
>
> Signed-off-by: Amrit Khera
> ---
> Changes in v2:
> - Wrapped the commit description
> - Build tested
Heh. Nope.
You're not asking the right questions.
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
> This patch renames CamelCase macros uVar and uModulo into u_var and
> u_module in device.h
>
Is "u_var" a good name? What does the "u_" even mean?
> This issue was reported by checkpa
On Fri, Feb 19, 2021 at 02:52:21PM +0300, Dan Carpenter wrote:
> On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote:
> > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> > > I was unable to align it right below the opening parenthesis, just by
> > > using
> > > tabs.
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations
> should normally be const".
>
> Signed-off-by: Amrit Khera
> ---
> Changes in v2:
> - Wrapped the commit description
> - Build tested
If you tested it, what change
Hi Dan Carpenter
Thanks for the feedback, I'll work on the suggestion and come back with a fix.
Regards
Selvakumar Elangovan
On Fri, Feb 19, 2021 at 5:42 PM Dan Carpenter wrote:
>
> You're not asking the right questions.
>
> On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
On Fri, Feb 19, 2021 at 04:21:12PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 del
On Fri, Feb 19, 2021 at 01:12:49PM +0100, Greg KH wrote:
> On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote:
> > This change fixes a checkpatch warning for "struct file_operations
> > should normally be const".
> >
> > Signed-off-by: Amrit Khera
> > ---
> > Changes in v2:
> > - Wrappe
This patch fixes the checkpatch warnings such as:
hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs
Signed-off-by: Lee Gibson
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/hikey9xx/hi6421-sp
This change fixes a checkpatch check for "Please don't use
multiple blank lines".
Signed-off-by: Amrit Khera
---
drivers/staging/greybus/sdio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 0939f4a4c963..37bf04c22dbc 1006
use MACRO __func__ instead of the literal names for RT_TRACE()
in phy_set_rf8256_bandwidth() and phy_rf8256_config_para_file(),
as reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v5:
* fixed subject lines to be distinct and more specific
changes v4:
* merge two similar pat
remove the unnecessary return at the end of function
phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/stag
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3: Move
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by
This patch fixes the following checkpatch.pl warning:
WARNING: line length of 124 exceeds 100 columns
in file kpc2000_i2c.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3:
checkpatch.pl reported issue of unnecessary parentheses for the
expression. It has been removed to fix the report.
Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
---
drivers/staging/octeon/ethernet-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
On Fri, Feb 19, 2021 at 02:50:53PM +, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
>
These comments need to go below the --- cut off line.
> checkpatch gives the follo
From: Mayank Suman
Comparison with NULL is redundant
as pointer will evaluate to true if is non-NULL.
The change was suggested by checkpatch.pl.
Signed-off-by: Mayank Suman
---
drivers/staging/gasket/gasket_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
On Fri, Feb 19, 2021 at 02:50:53PM +, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
This all goes below the --- line please.
Please make a v3.
thanks,
greg k-h
___
changes since previous version:
- change Subject line
- change commit message
- change commit message position to above signed-off-by
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera
---
drivers/staging/wimax/stack.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index 36280c62fa56..de41d2182ff5 100644
---
This patchset fixes the checkpatch issues related to the `delba_param_set`
union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase).
William Durand (5):
staging: rtl8192e: rename charData to char_data in delba_param_set union
staging: rtl8192e: rename shortData to short_data in delba_param_s
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl819
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e
This change uses lowercase for a field name to be more consistent with
the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a
This change uses lowercase for a field name to be more consistent with
the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl81
onfig
i386 randconfig-a005-20210219
i386 randconfig-a003-20210219
i386 randconfig-a002-20210219
i386 randconfig-a004-20210219
i386 randconfig-a001-20210219
i386 randconfig-a006-20210219
x
From: Ashish Vara
removed unnecessary out of memory message to fix coding style warning.
Signed-off-by: Ashish Vara
---
drivers/staging/gasket/gasket_page_table.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c
b/drivers/staging/gasket/gasket_pa
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo
---
changes since previous version:
- put version chatter below the --- cut off line.
thank you very m
commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
Author: Julian Braha
Date: Fri Feb 19 17:02:24 2021 -0500
staging: rtl8192e: fix kconfig dependency on CRYPTO
When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet d
My name is Nicholas Toms, an investment portfolio manage. We offer the right
loan Investment funding with low interest to finance your business or project
ranging from US$1M to US$2BIllion. Kindly contact me for more details as I am
open to questions.
Sincerely,
Nicholas Toms
Spam detection software, running on the system "smtp3.osuosl.org",
has identified this incoming email as possible spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Co
Spam detection software, running on the system "smtp1.osuosl.org",
has identified this incoming email as possible spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Co
On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote:
> commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
> Author: Julian Braha
> Date: Fri Feb 19 17:02:24 2021 -0500
>
> staging: rtl8192e: fix kconfig dependency on CRYPTO
>
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is
ig
powerpc allnoconfig
i386 randconfig-a005-20210219
i386 randconfig-a003-20210219
i386 randconfig-a002-20210219
i386 randconfig-a004-20210219
i386 randconfig-a001-20210219
i386 randconfig-a006-20210
allmodconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a005-20210219
i386 randconfig-a003-20210219
i386 randconfig-a002-20210219
75 matches
Mail list logo
