On Mon, Jan 04, 2021 at 07:26:42PM +, Phil Elwell wrote:
> On 04/01/2021 18:31, Dan Carpenter wrote:
> > On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote:
> > > The addition of the local 'userdata' pointer to
> > > vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING no
On Mon, Dec 28, 2020 at 12:13:00AM -0500, jovin555 wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: jovin555
Your Mama didn't name you "jovin555". You need to use your real name
like signing a legal document. Same for the "From:" header.
regards,
dan carpenter
_
On Tue, 5 Jan 2021 at 11:04, Dan Carpenter wrote:
>
> On Mon, Jan 04, 2021 at 07:26:42PM +, Phil Elwell wrote:
> > On 04/01/2021 18:31, Dan Carpenter wrote:
> > > On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote:
> > > > The addition of the local 'userdata' pointer to
> > > > vchiq_
This comment describes a security problem which was fixed in commit
1c954540c0eb ("staging: vchiq: avoid mixing kernel and user pointers").
The bug is fixed now so the FIXME can be removed.
Signed-off-by: Dan Carpenter
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 ---
1
On Tue, Jan 05, 2021 at 11:53:32AM +, Phil Elwell wrote:
> On Tue, 5 Jan 2021 at 11:04, Dan Carpenter wrote:
> >
> > On Mon, Jan 04, 2021 at 07:26:42PM +, Phil Elwell wrote:
> > > On 04/01/2021 18:31, Dan Carpenter wrote:
> > > > On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote:
From: Arnd Bergmann
Smatch found a local variable that can get copied to another
local variable without an initializion in the error case:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1056
vchiq_get_user_ptr() error: uninitialized symbol 'ptr'.
This seems harmless, as the fun
On Thu, Dec 31, 2020 at 10:22:36AM +0800, Xin Ji wrote:
> static int anx7625_read_ctrl_status_p0(struct anx7625_data *ctx)
> {
> return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, AP_AUX_CTRL_STATUS);
> @@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
>
On Tue, Jan 5, 2021 at 2:19 PM Dan Carpenter wrote:
>
> This comment describes a security problem which was fixed in commit
> 1c954540c0eb ("staging: vchiq: avoid mixing kernel and user pointers").
> The bug is fixed now so the FIXME can be removed.
>
> Signed-off-by: Dan Carpenter
Reviewed-by:
On Tue, Jan 5, 2021 at 12:53 PM Phil Elwell wrote:
> On Tue, 5 Jan 2021 at 11:04, Dan Carpenter wrote:
> >
> > Mixing __user pointers and regular pointers is dangerous and has lead to
> > security problems in this driver in the past. But also mixing mixing
> > tokens with pointers just makes th
The correct user/kernel api for vibrator devices is the Input rumble
api, not a random sysfs file like the greybus vibrator driver currently
uses.
Add support for the correct input api to the vibrator driver so that it
hooks up to the kernel and userspace correctly.
Cc: Johan Hovold
Cc: Alex Eld
No need for a custom sysfs api for the greybus vibrator driver now that
it is hooked up to the kernel's input layer, so rip it out.
Cc: Johan Hovold
Cc: Alex Elder
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/greybus/vibrator.c | 125 ++---
1 file changed, 5 in
The recent batch of vchiq improvements broke bulk transfers in two ways:
1. The userdata associated with a transfer was lost in the case that a
non-blocking mode was used.
2. The 64-bit ioctl compatibility shim for a bulk transfer used the
wrong ioctl command.
This patch set fixes both of
The addition of the local 'userdata' pointer to
vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor
WAITING modes are used, in which case the value provided by the
caller is not returned to them as expected, but instead it is replaced
with a NULL. This lack of a suitable context
Record in the TODO file that the address of "&waiter->bulk_waiter"
should never be returned to userspace.
Signed-off-by: Phil Elwell
---
drivers/staging/vc04_services/interface/TODO | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/TODO
b/drivers/st
The recent change to the bulk transfer compat function missed the fact
the relevant ioctl command is VCHIQ_IOC_QUEUE_BULK_TRANSMIT32, not
VCHIQ_IOC_QUEUE_BULK_TRANSMIT, as any attempt to send a bulk block
to the VPU would have shown.
Fixes: a4367cd2b231 ("staging: vchiq: convert compat bulk transf
Thanks!
Acked-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Dec 17, 2020 at 09:05:50PM +0300, Dmitry Osipenko wrote:
> Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces
> power consumption and heating of the Tegra chips. Tegra SoC has multiple
> hardware units which belong to a core power domain of the SoC and share
> the core
On Tue, Jan 5, 2021 at 5:20 PM Phil Elwell wrote:
>
> The recent change to the bulk transfer compat function missed the fact
> the relevant ioctl command is VCHIQ_IOC_QUEUE_BULK_TRANSMIT32, not
> VCHIQ_IOC_QUEUE_BULK_TRANSMIT, as any attempt to send a bulk block
> to the VPU would have shown.
>
>
Hi Greg,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/staging-greybus-vibrator-use-proper-API-for-vibrator-devices/20210105-232001
base: https://git.kernel.org/pub/scm/linux
There is a debug message using hardcoded function name instead of the
__func__ macro. Replace it.
Report from checkpatch.pl on the file:
WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this
function's name, in a string
+ dev_dbg(&client->dev, "ov2722_remove...\n");
Sig
On Mon, Jan 4, 2021 at 4:06 PM Sergio Paracuellos
wrote:
> According to the binding documentation pinctrl related nodes
> must use '-pins$' and ''^(.*-)?pinmux$'' as names. Change all
> to properly match them. Also default state is for consumer
> nodes and shall be removed from here.
>
> Signed-o
On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
> There is a debug message using hardcoded function name instead of the
> __func__ macro. Replace it.
>
> Report from checkpatch.pl on the file:
>
> WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this
> function's
22 matches
Mail list logo
