[PATCH] staging: Add xillyusb driver (Xillybus variant for USB)

From: Eli Billauer Xillybus is a means for exchanging data between an FPGA and a Linux host, which helps making the task easier on both sides. The already existing driver resides in drivers/char/xillybus/ and it supports communication with the FPGA over the PCIe bus. For Xilinx' Zynq-7000 process

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: Hi Sasha, On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: From: "Andrea Parri (Microsoft)" [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] FYI, we found that this commit introduced a regression and poste

Re: [PATCH] staging: Add xillyusb driver (Xillybus variant for USB)

On Sun, Dec 13, 2020 at 01:59:33PM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > Xillybus is a means for exchanging data between an FPGA and a Linux > host, which helps making the task easier on both sides. The already > existing driver resides in drivers/char/xillybus/ and it sup

[PATCH] staging: spmi: hisi-spmi-controller: Fix some error handling paths

IN the probe function, if an error occurs after calling 'spmi_controller_alloc()', it must be undone by a corresponding 'spmi_controller_put() call. In the remove function, use 'spmi_controller_put(ctrl)' instead of 'kfree(ctrl)'. While a it fix an error message (s/spmi_add_controller/spmi_contro

[PATCH] staging: mt7621-dma: Fix a resource leak in an error handling path

If an error occurs after calling 'mtk_hsdma_init()', it must be undone by a corresponding call to 'mtk_hsdma_uninit()' as already done in the remove function. Fixes: 0853c7a53eb3 ("staging: mt7621-dma: ralink: add rt2880 dma engine") Signed-off-by: Christophe JAILLET --- drivers/staging/mt7621-d

[PATCH 0/8] pinctrl: ralink: rt2880: Some minimal clean ups

After this driver was moved from staging into pinctrl subsytems some reviews for bindigns and driver itself comes from Ron Herring and Dan Carpenter. Get rid of all the comments to properly be in a good shape before merge window. Best regards, Sergio Paracuellos Sergio Paracuellos (8): dt-b

[PATCH 1/8] dt-bindings: pinctrl: rt2880: properly redo bindings

When this bindings where applied there weren't already reviewed and some old hacks was being used to properly pass the schemas checks. This commits fix them up: - Instead of using 'if-then' clause use '-pins$'. - 'groups' and 'function' are included inside a new '^(.*-)?pinmux$' node. - compa

[PATCH 2/8] pinctrl: ralink: rt2880: avoid double pointer to simplify code

Double pointer is being used and assigned in a bit dirty way to assign functions in pinctrl. Instead of doing this just avoid it and use directly 'p->func' instead. Reported-by: Dan Carpenter Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 21 +---

[PATCH 4/8] pinctrl: ralink: rt2880: add missing NULL check

Memory is being requested to the kernel but there is a missing check for NULL. Hence, add it. Reported-by: Dan Carpenter Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b

[PATCH 5/8] pinctrl: ralink: rt2880: delete not needed error message

When '-ENOMEM' is returned there is not need at all to add custom error messages. Hence delete it. Reported-by: Dan Carpenter Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/rali

[PATCH 6/8] pinctrl: ralink: rt2880: preserve error codes

Some paths in probe function are returning '-EINVAL' instead of preserve original code from called functions. Change them to preserve all of them. Reported-by: Dan Carpenter Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 12 1 file changed, 8 insert

[PATCH 8/8] staging: mt7621-dts: properly name pinctrl related nodes

According to the binding documentation pinctrl related nodes must use '-pins$' and ''^(.*-)?pinmux$'' as names. Change all of them to properly match them. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 46 +- 1 file changed, 23 insertions(+

[PATCH 7/8] pinctrl: ralink: rt2880: use 'PTR_ERR_OR_ZERO'

Avoid some boilerplate code using 'PTR_ERR_OR_ZERO' in probe function. Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-

[PATCH 3/8] pinctrl: ralink: rt2880: return proper error code

Check for NULL shall return '-ENOMEM' instead of '-1'. Reported-by: Dan Carpenter Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/

Re: [PATCH] staging: Add xillyusb driver (Xillybus variant for USB)

Hello Greg, There's no TODO file because it would have been empty: There is nothing to do, as far as I know. I submitted this to staging because I failed to push the Xillybus driver to non-staging back in 2013. In the end, the way in was through staging + a review that got it out a year late

[driver-core:driver-core-testing] BUILD SUCCESS 46e85af0cc53f35584e00bb5db7db6893d0e16e5

onfig powerpc allnoconfig i386 randconfig-a001-20201213 i386 randconfig-a004-20201213 i386 randconfig-a003-20201213 i386 randconfig-a002-20201213 i386 randconfig-a005-20201213

Re: [PATCH] staging: Add xillyusb driver (Xillybus variant for USB)

On Sun, Dec 13, 2020 at 06:26:22PM +0200, Eli Billauer wrote: > Hello Greg, > > There's no TODO file because it would have been empty: There is nothing to > do, as far as I know. > > I submitted this to staging because I failed to push the Xillybus driver to > non-staging back in 2013. In the end