Re: [PATCH] staging: mt7621-pinctrl: stop using the deprecated 'pinctrl_add_gpio_range'

On Sun, Dec 6, 2020 at 11:53 AM Sergio Paracuellos wrote: > If the gpio DT node has the 'gpio-ranges' property, the range will be > added by the gpio core and doesn't need to be added by the pinctrl > driver. > > By having the gpio-ranges property, we can map every pin between > gpio node and pin

Re: [PATCH] staging: mt7621-pinctrl: stop using the deprecated 'pinctrl_add_gpio_range'

Hi Linus, On Mon, Dec 7, 2020 at 2:05 PM Linus Walleij wrote: > > On Sun, Dec 6, 2020 at 11:53 AM Sergio Paracuellos > wrote: > > > If the gpio DT node has the 'gpio-ranges' property, the range will be > > added by the gpio core and doesn't need to be added by the pinctrl > > driver. > > > > By

Re: [PATCH 10/10] staging: rtl8723bs: replace unique macros and ELEMENT_ID

On Sat, Dec 05, 2020 at 09:45:17PM -0600, Ross Schmidt wrote: > Replace unique macros and ELEMENT_ID with kernel provided ieee80211_eid > enum. > > In a several cases multiple macros or constants are replaced by one > constant. > > WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability are rep

[PATCH] staging: comedi: mf6x4: Fix AI end-of-conversion detection

I have had reports from two different people that attempts to read the analog input channels of the MF624 board fail with an `ETIMEDOUT` error. After triggering the conversion, the code calls `comedi_timeout()` with `mf6x4_ai_eoc()` as the callback function to check if the conversion is complete.

Re: [PATCH] staging: mt7621-pinctrl: stop using the deprecated 'pinctrl_add_gpio_range'

On Mon, Dec 7, 2020 at 2:57 PM Sergio Paracuellos wrote: > On Mon, Dec 7, 2020 at 2:05 PM Linus Walleij wrote: > > After this I think the driver looks good and can graduate from staging. > > Can you send a patch to move this to drivers/pinctrl next > > > > I think drivers/pinctrl/pinctrl-rt2880.

Re: [PATCH] staging: mt7621-pinctrl: stop using the deprecated 'pinctrl_add_gpio_range'

On Mon, Dec 07, 2020 at 04:40:06PM +0100, Linus Walleij wrote: > On Mon, Dec 7, 2020 at 2:57 PM Sergio Paracuellos > wrote: > > On Mon, Dec 7, 2020 at 2:05 PM Linus Walleij > > wrote: > > > > After this I think the driver looks good and can graduate from staging. > > > Can you send a patch to m

[PATCH] staging: ks7010: Enclose macros in parentheses

Enclose macros in parentheses to ensure correct casting behaviour as suggested by checkpatch. Co-developed-by: Philipp Bruegmann Signed-off-by: Philipp Bruegmann Signed-off-by: Ferdinand Schober --- drivers/staging/ks7010/ks_hostif.h | 24 1 file changed, 12 insertions

Re: [PATCH] staging: ks7010: Enclose macros in parentheses

On Mon, Dec 07, 2020 at 05:56:46PM +0100, Ferdinand Schober wrote: > Enclose macros in parentheses to ensure correct casting behaviour as > suggested by checkpatch. checkpatch is wrong here :) always use your brain when making changes like this, checkpatch is just a perl script, and while it is q

[PATCH 0/3] pinctrl: ralink: pinctrl driver for the rt2880 family

This series adds a pinctrl driver for ralink rt2880 SoC. After last cleanup in staging I was told [0] this driver is ready to be promoted from staging. This series are rebased on the top of staging-testing. Thanks in advance for your time. Best regards, Sergio Paracuellos [0]: http://driv

[PATCH 2/3] pinctrl: ralink: add a pinctrl driver for the rt2880 family

These Socs have 1-3 banks of 8-32 gpios. Rather then setting the muxing of each pin individually, these socs have mux groups that when set will effect 1-N pins. Pin groups have a 2, 4 or 8 different muxes. Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/Kconfig | 6 + drivers/pi

[PATCH 1/3] dt-bindings: pinctrl: rt2880: add binding document

The commit adds rt2880 compatible node in binding document. Signed-off-by: Sergio Paracuellos --- .../pinctrl/ralink,rt2880-pinmux.yaml | 82 +++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml dif

[PATCH 3/3] staging: mt7621-pinctrl: remove driver from staging

Remove this driver from staging because it has been moved into its properly place in the kernel. Signed-off-by: Sergio Paracuellos --- drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - drivers/staging/mt7621-pinctrl/Kconfig| 6

[PATCH 00/12] media: atomisp: Codingstyle

Hello! This series fix some codingstyle errors in the files rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c in the drivers/staging/media area. Best regards Philipp -- media: atomsip: Convert comments to C99 initializ

[PATCH 01/12] media: atomsip: Convert comments to C99 initializers

The struct initalizers have been changed as recommended on https://kernelnewbies.org/KernelJanitors/Todo Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 30 +-- 1 file change

[PATCH 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1 inserti

[PATCH 08/12] media: atomisp: Delete braces

WARNING:BRACES: braces {} are not necessary for single statement blocks Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drive

[PATCH 02/12] media: atomisp: Fix Block Comments

Block comments should use * on subsequent lines and should use a trailing */ on a separate line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++-- 1 file changed, 3 ins

[PATCH 06/12] media: atomisp: Add parentheses

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h| 4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH 04/12] media: atomisp: Fix OPEN_ENDED_LINE

Lines should not end with a '(' Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/ato

[PATCH 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 05/12] media: atomisp: Fix overlong line

Line length of 105 exceeds 100 columns. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/m

[PATCH 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning

Use the automatically defined __func__ macro instead of the function name, so it stays correct when the function is renamed. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c| 8 +++

[PATCH 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE

Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 07/12] media: atomisp: Fix funciton decleration

Write return_type, function_name and parameters in one line because lines should not end with a '(' [OPEN_ENDED_LINE] Write open brace ’{’ on the next line to fix OPEN_BRACE Error Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/st

[PATCH 11/12] media: atomisp: Write function decleration in one line

CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- ...

Re: [PATCH] staging: mt7621-pinctrl: stop using the deprecated 'pinctrl_add_gpio_range'

On Mon, Dec 7, 2020 at 4:49 PM Greg KH wrote: > Sometimes we just do a "add a new driver to the real spot" that goes > through the subsystem tree, and when that is accepted, I delete the > driver in the staging tree. This is most often in networking. That's unnice, it will loose the history, it

Re: [PATCH 1/3] dt-bindings: pinctrl: rt2880: add binding document

Hi Sergio, thanks for driving this! On Mon, Dec 7, 2020 at 8:21 PM Sergio Paracuellos wrote: > The commit adds rt2880 compatible node in binding document. > > Signed-off-by: Sergio Paracuellos (...) > +description: > + The rt2880 pinmux can only set the muxing of pin groups. muxing indiviual

Re: [PATCH 2/3] pinctrl: ralink: add a pinctrl driver for the rt2880 family

Hi Serigio, I dug around some to try to understand the patch I think I get it now :) Squash this with the third patch so it becomes a "move" of this file, preserving history. With that: Acked-by: Linus Walleij I have ideas, but it is better to move the driver out of staging and improve it in pi

[PATCH v2 00/21] replace unique macros and ELEMENT_ID

This patch set replaces many macros and the ELEMENT_ID enum with the ieee80211_eid enum from linux/ieee80211.h. In several cases more than one macro or constant is replaced by one constant. As suggested, each constant replacement is separated into a distinct patch. Changes in v2: - Single patch di

[PATCH v2 03/21] staging: rtl8723bs: use WLAN_EID_RSN

Replace unique _WPA2_IE_ID_, EID_WPA2, and _RSN_IE_2_ with kernel provided WLAN_EID_RSN from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++--- drivers/staging/rtl8723bs/core/r

[PATCH v2 01/21] staging: rtl8723bs: use WLAN_EID_HT_CAPABILITY

Replace unique WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability with kernel provided WLAN_EID_HT_CAPABILITY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 8 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drive

[PATCH v2 02/21] staging: rtl8723bs: use WLAN_EID_VENDOR_SPECIFIC

Replace unique WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and _VENDOR_SPECIFIC_IE_ macros with kernel provided WLAN_EID_VENDOR_SPECIFIC from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- .../staging/rtl8723bs/core/rtw_ieee80211.c

[PATCH v2 05/21] staging: rtl8723bs: replace WLAN_EID_VHT_OP_MODE_NOTIFY

Replace unique WLAN_EID_VHT_OP_MODE_NOFITY macro with kernel provided WLAN_EID_OPMODE_NOTIF from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 1 - 2 files changed, 1 insertion(+), 2 dele

[PATCH v2 09/21] staging: rtl8723bs: replace _TIM_IE_

Replace unique _TIM_IE_ macro with kernel provided WLAN_EID_DS_PARAMS from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 10 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++-- drivers

[PATCH v2 06/21] staging: rtl8723bs: replace _SSID_IE_

Replace unique _SSID_IE_ macro with kernel provided WLAN_EID_SSID from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c| 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 +--

[PATCH v2 04/21] staging: rtl8723bs: use WLAN_EID_HT_OPERATION

Replace unique _HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ macros with kernel provided WLAN_EID_HT_OPERATION from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 10 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging

[PATCH v2 11/21] staging: rtl8723bs: replace _COUNTRY_IE_

Replace unique _COUNTRY_IE_ macro with kernel provided WLAN_EID_COUNTRY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/include/wifi.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH v2 13/21] staging: rtl8723bs: replace _ERPINFO_IE_

Replace unique _ERPINFO_IE_ macro with kernel provided WLAN_EID_ERP_INFO from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 12 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- drivers/staging/rtl8723bs/core/rtw_wlan_u

[PATCH v2 16/21] staging: rtl8723bs: replace _MME_IE_

Replace unique _MME_IE_ macro with kernel provided WLAN_EID_MMIE from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +- drivers/staging/rtl8723bs/include/wifi.h | 1 - 3 files change

[PATCH v2 17/21] staging: rtl8723bs: replace EID_BSSCoexistence

Replace unique EID_BSSCoexistence constant with kernel provided WLAN_EID_BSS_COEX_2040 from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme

[PATCH v2 08/21] staging: rtl8723bs: replace _DSSET_IE_

Replace unique _DSSET_IE_ macro with kernel provdied WLAN_EID_DS_PARAMS from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10

[PATCH v2 10/21] staging: rtl8723bs: replace _IBSS_PARA_IE_

Replace unique _IBSS_PARA_IE_ macro with kernel provided WLAN_EID_IBSS_PARAMS from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2

[PATCH v2 15/21] staging: rtl8723bs: replace _WAPI_IE_

Replace unique _WAPI_IE_ macro with kernel provided WLAN_EID_BSS_AC_ACCESS_DELAY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- drivers/staging/rtl8723bs/include/wifi.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)

[PATCH v2 21/21] staging: rtl8723bs: remove ELEMENT_ID enum

The ELEMENT_ID enum is no longer used, remove it. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/wifi.h | 76 1 file changed, 76 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h index 7f482

[PATCH v2 07/21] staging: rtl8723bs: replace _SUPPORTEDRATES_IE_

Replace unique _SUPPORTEDRATES_IE_ macro with kernel provided WLAN_EID_SUPP_RATES from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.

[PATCH v2 18/21] staging: rtl8723bs: replace EID_BSSIntolerantChlReport

Replace unique EID_BSSIntolerantChlReport constant with kernel provided WLAN_EID_BSS_INTOLERANT_CHL_REPORT from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl

[PATCH v2 12/21] staging: rtl8723bs: replace _CHLGETXT_IE_

Replace unique _CHLGETXT_IE_ macro with kernel provided WLAN_EID_CHALLENGE from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 drivers/staging/rtl8723bs/include/wifi.h | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) di

[PATCH v2 19/21] staging: rtl8723bs: replace EID_EXTCapability

Replace unique EID_EXTCapability constant with kernel provided WLAN_EID_EXT_CAPABILITY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletio

[PATCH v2 14/21] staging: rtl8723bs: replace _EXT_SUPPORTEDRATES_IE_

Replace unique _EXT_SUPPORTEDRATES_IE_ macro with kernel provided WLAN_EID_EXT_SUPP_RATES from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_m

[PATCH v2 20/21] staging: rtl8723bs: remove unused macros

Remove many macros from wifi.h and ieee80211.h because they are unused. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/ieee80211.h | 5 - drivers/staging/rtl8723bs/include/wifi.h | 15 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl

Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang

On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto/return/fal

[staging:staging-testing] BUILD SUCCESS 19cf9d7afc2e7b91f47b8f2638ec08b29de55060

powerpc allnoconfig i386 randconfig-a005-20201207 i386 randconfig-a004-20201207 i386 randconfig-a001-20201207 i386 randconfig-a002-20201207 i386 randconfig-a006-20201207 i386

Re: [PATCH 1/3] dt-bindings: pinctrl: rt2880: add binding document

Hi Linus, Thanks for the review. There weren't too many yaml samples for this so as you had seen this was a bit messy and I really needed this review, especially in the 'if' clause part :). On Mon, Dec 7, 2020 at 11:42 PM Linus Walleij wrote: > > Hi Sergio, > > thanks for driving this! > > On Mo

Re: [PATCH 2/3] pinctrl: ralink: add a pinctrl driver for the rt2880 family

Hi Linus, On Tue, Dec 8, 2020 at 12:00 AM Linus Walleij wrote: > > Hi Serigio, > > I dug around some to try to understand the patch I think I get > it now :) > > Squash this with the third patch so it becomes a > "move" of this file, preserving history. With that: > Acked-by: Linus Walleij Ok,

[PATCH v2 0/2] pinctrl: ralink: pinctrl driver for the rt2880 family

This series adds a pinctrl driver for ralink rt2880 SoC. After last cleanup in staging I was told [0] this driver is ready to be promoted from staging. This series are rebased on the top of staging-testing. Thanks in advance for your time. Changes in v2: - Squash PATCH 2/3 and PATCH 3/3 in

[PATCH v2 1/2] dt-bindings: pinctrl: rt2880: add binding document

The commit adds rt2880 compatible node in binding document. Signed-off-by: Sergio Paracuellos --- .../pinctrl/ralink,rt2880-pinmux.yaml | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml dif

[PATCH v2 2/2] pinctrl: ralink: add a pinctrl driver for the rt2880 family

These Socs have 1-3 banks of 8-32 gpios. Rather then setting the muxing of each pin individually, these socs have mux groups that when set will effect 1-N pins. Pin groups have a 2, 4 or 8 different muxes. Acked-by: Linus Walleij Signed-off-by: Sergio Paracuellos --- drivers/pinctrl/Kconfig