Re: [PATCH 1/8] phy: phy-hi3670-usb3: move driver from staging into phy

2020-11-30 Thread Vinod Koul
On 16-11-20, 13:59, Mauro Carvalho Chehab wrote: > +#define CTRL7_USB2_REFCLKSEL_MASK(3 << 3) > +#define CTRL7_USB2_REFCLKSEL_ABB (3 << 3) > +#define CTRL7_USB2_REFCLKSEL_PAD (2 << 3) This should use GENMASK() > + > +#define CFG50_USB3_PHY_TEST_POWERDOWNBIT(23) > + > +#define

Re: [PATCH v6 0/4] MT7621 PCIe PHY

2020-11-30 Thread Vinod Koul
On 21-11-20, 16:50, Sergio Paracuellos wrote: > This series adds support for the PCIe PHY found in the Mediatek > MT7621 SoC. > > There is also a 'mt7621-pci' driver which is the controller part > which is still in staging and is a client of this phy. > > Both drivers have been tested together in

Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY

2020-11-30 Thread Dan Carpenter
On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 > > > reg) > > > +{ > > > + regmap_write(phy->regmap, reg, val); > > > > Why not use regmap_ calls directly and avoid the dummy wrappers..? > > This

Re: [PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang

2020-11-30 Thread Dan Carpenter
On Wed, Nov 25, 2020 at 01:42:57PM +0900, Benjamin Poirier wrote: > On 2020-11-20 12:39 -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next

Re: [PATCH v6 0/4] MT7621 PCIe PHY

2020-11-30 Thread Sergio Paracuellos
Hi Vinod, On Mon, Nov 30, 2020 at 11:48 AM Vinod Koul wrote: > > On 21-11-20, 16:50, Sergio Paracuellos wrote: > > This series adds support for the PCIe PHY found in the Mediatek > > MT7621 SoC. > > > > There is also a 'mt7621-pci' driver which is the controller part > > which is still in staging

Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY

2020-11-30 Thread Sergio Paracuellos
Hi Dan, On Mon, Nov 30, 2020 at 1:15 PM Dan Carpenter wrote: > > On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 > > > > reg) > > > > +{ > > > > + regmap_write(phy->regmap, reg, val); > > > > >

Re: (subset) [PATCH v6 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399

2020-11-30 Thread Heiko Stuebner
On Tue, 20 Oct 2020 16:38:41 -0300, Helen Koike wrote: > Move the bindings out of drivers/staging and place them in > Documentation/devicetree/bindings instead. > > Also, add DT nodes for RK3399 and verify with make ARCH=arm64 dtbs_check > and make ARCH=arm64 dt_binding_check. > > Tested by verif

[PATCH] staging:media:zoran: Fixed grammar issue

2020-11-30 Thread Travis Carter
Removed repeated word 'in' Signed-off-by: Travis Carter --- drivers/staging/media/zoran/zoran_card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c index dfc60e2e9dd7..c77aa458b6d2 100644 --

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Martin K. Petersen
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering ___ devel

Re: [PATCH] staging:media:zoran: Fixed grammar issue

2020-11-30 Thread LABBE Corentin
On Mon, Nov 30, 2020 at 05:06:59PM -0600, Travis Carter wrote: > Removed repeated word 'in' > > Signed-off-by: Travis Carter > --- > drivers/staging/media/zoran/zoran_card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/zoran/zoran_card.c > b/dr