[PATCH] staging: vchiq: silence an uninitialized variable warning

2020-09-30 Thread Dan Carpenter
Smatch complains that "userdata" can be passed to vchiq_bulk_transfer() without being initialized. Smatch is correct, however, in that situation the "userdata" is not used so it doesn't cause a problem. Passing an uninitialized variable will trigger a UBSan warning at runtime so this warning is wo

Re: [PATCH] staging: vchiq: silence an uninitialized variable warning

2020-09-30 Thread Arnd Bergmann
On Wed, Sep 30, 2020 at 11:02 AM Dan Carpenter wrote: > > Smatch complains that "userdata" can be passed to vchiq_bulk_transfer() > without being initialized. Smatch is correct, however, in that > situation the "userdata" is not used so it doesn't cause a problem. > Passing an uninitialized varia

Re: [PATCH] staging: vchiq: silence an uninitialized variable warning

2020-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2020 at 12:22:37PM +0200, Arnd Bergmann wrote: > On Wed, Sep 30, 2020 at 11:02 AM Dan Carpenter > wrote: > > > > Smatch complains that "userdata" can be passed to vchiq_bulk_transfer() > > without being initialized. Smatch is correct, however, in that > > situation the "userdata"

[PATCH v2] staging: vchiq: Fix an uninitialized variable

2020-09-30 Thread Dan Carpenter
Smatch complains that "userdata" can be passed to vchiq_bulk_transfer() without being initialized. This leads to a potential information leak later on. Fixes: a4367cd2b231 ("staging: vchiq: convert compat bulk transfer") Signed-off-by: Dan Carpenter Acked-by: Arnd Bergmann --- v2: update commit

[PATCH] media: atomisp: fixes a breakage due to a cleanup patch

2020-09-30 Thread Mauro Carvalho Chehab
A temporary var needed for building with ISP2401 was removed by accident on a cleanup patch. Fix the breakage. Fixes: 852a53a02cf0 ("media: atomisp: get rid of unused vars") Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/sh_css.c | 3 +-- 1 file changed, 1 insertion(

[PATCH v2] media: atomisp: fixes a breakage due to a cleanup patch

2020-09-30 Thread Mauro Carvalho Chehab
A temporary var needed for building with ISP2400 was removed by accident on a cleanup patch. Fix the breakage. Fixes: 852a53a02cf0 ("media: atomisp: get rid of unused vars") Signed-off-by: Mauro Carvalho Chehab --- v2: fixed a typo at comment: ISP2401 -> ISP2400 drivers/staging/media/atomisp/