solve this smatch warning:
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c:842
gmin_v1p8_ctrl() warn: variable dereferenced before check 'gs' (see line 832)
By moving the check to happen before its usage.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/atomisp/
There are some duplicated names between the ISP2401 and ISP2400
for the input system, with different meanings.
In order to avoid ubiquity, let's prepend those with the
name of the ISP.
Signed-off-by: Mauro Carvalho Chehab
---
.../pci/css_2401_system/ibuf_ctrl_global.h| 6 +-
.../pci/css_24
As there aren't duplicated names anymore, and the end goal
is to do runtime checks between ISP2400 and ISP2401,
remove the part of the Makefile which changes the include
places based on the compile-time version.
This shouldn't cause any effect, but it will make easier
for further patches meant to
As smatch reports, there are several bad indents:
drivers/staging/media/atomisp/pci/hmm/hmm.c:271 hmm_alloc() warn:
inconsistent indenting
drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c:390
ia_css_bufq_enqueue_psys_event() warn: inconsistent indenting
drivers/staging/media
Replace all occurrences along the atomisp tree for the conditional
compilation macros found at system_global.h, replacing them by
tests wheather ISP2401 is defined or not.
Signed-off-by: Mauro Carvalho Chehab
---
.../pci/css_2401_system/host/isys_irq_local.h | 4 +-
.../css_2401_system/host/is
Changed return type to bool and removed inline specifier. Also added
static specifier.
Signed-off-by: Antoni Przybylik
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/gdm724x/gdm_tty.c
This approach is more elegant and prevents some problems related to
macros such as operator precedence in expanded expression.
Signed-off-by: Antoni Przybylik
---
drivers/staging/gdm724x/gdm_tty.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
On 9/2/20 9:16 AM, Antoni Przybylik wrote:
> Changed return type to bool and removed inline specifier. Also added
> static specifier.
why remove the inline specifier?
thanks.
> Signed-off-by: Antoni Przybylik
> ---
> drivers/staging/gdm724x/gdm_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1
From: Colin Ian King
In the case where the call to lm3554_platform_data_func returns an
error there is a memory leak on the error return path of object
flash. Fix this by adding an error return path that will free
flash and rename labels fail2 to fail3 and fail1 to fail2.
Fixes: 9289cdf39992 ("
On 02.09.2020 18:21, Randy Dunlap wrote:
On 9/2/20 9:16 AM, Antoni Przybylik wrote:
Changed return type to bool and removed inline specifier. Also added
static specifier.
why remove the inline specifier?
Greg KH wrote to me:
And really, no need to make it inline, just make it a normal func
On 9/2/20 10:07 AM, antoni.przyby...@wp.pl wrote:
> On 02.09.2020 18:21, Randy Dunlap wrote:
>> On 9/2/20 9:16 AM, Antoni Przybylik wrote:
>>> Changed return type to bool and removed inline specifier. Also added
>>> static specifier.
>> why remove the inline specifier?
>
> Greg KH wrote to me:
>
On Wed, Sep 2, 2020 at 8:02 PM Colin King wrote:
>
> From: Colin Ian King
>
> In the case where the call to lm3554_platform_data_func returns an
> error there is a memory leak on the error return path of object
> flash. Fix this by adding an error return path that will free
> flash and rename la
The error path for lm3554_probe() contains a number of bugs, including:
* resource leaks
* jumping to error labels out of sequence
* not setting the return value appropriately
Fix it up and give the labels more memorable names.
This issue has existed since the code was originally contributed i
On Tue, Sep 1, 2020 at 4:24 AM Christoph Hellwig wrote:
>
> I've applied this to the dma-mapping tree.
>
> I had to resolve a conflict in drivers/of/address.c with a recent
> mainline commit. I also applied the minor tweaks Andy pointed out
> plus a few more style changes. A real change is that
Fixed a coding style issue by adding a blank line after declarations in
sdio_intf.c to fix a checkpatch warning.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b/driver
-mapping.h | 36 ++
> kernel/dma/coherent.c | 10 +--
> kernel/dma/mapping.c | 66 +
> 23 files changed, 265 insertions(+), 115 deletions(-)
Apologies if this has already been reported or is known but this comm
| 9 ++-
> > > drivers/usb/core/usb.c| 7 +-
> > > include/linux/device.h| 4 +-
> > > include/linux/dma-direct.h| 8 +--
> > > include/linux/dma-mapping.h |
scripts/checkpatch.pl is warning about some lines exceeding 100
charecters. This will cleanup the warnings.
Signed-off-by: Bryan Brattlof
---
drivers/staging/pi433/pi433_if.h | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/pi433/p
On 9/2/2020 3:38 PM, Nathan Chancellor wrote:
[snip]
Hello Nathan,
Can you tell me how much memory your RPI has and if all of it is
This is the 4GB version.
accessible by the PCIe device? Could you also please include the DTS
of the PCIe node? IIRC, the RPI firmware does some mangling o
rnel/git/torvalds/linux.git/tree/arch/arm/boot/dts/bcm2711.dtsi#n264
>
> and the resulting dma-ranges parsing is just not working for reasons to be
> determined.
> --
> Florian
Let me know if you need anything else out of me.
Cheers,
Nathan
device.dtb
Description: Binary dat
; > kernel/dma/coherent.c | 10 +--
> > kernel/dma/mapping.c | 66 +
> > 23 files changed, 265 insertions(+), 115 deletions(-)
>
> Apologies if this has already been reported or is known but this com
On 2020-09-02 22:00 +0800, Coiby Xu wrote:
> This fixes commit 0107635e15ac
> ("staging: qlge: replace pr_err with netdev_err") which introduced an
> build breakage of missing `struct ql_adapter *qdev` for some functions
> and a warning of type mismatch with dumping enabled, i.e.,
>
> $ make CFLAG
Schöne Grüße,
Ich habe Ihre Antwort-E-Mail zu meinem Investitionsvorschlag noch nicht
erhalten.
Wir bieten ein schnelles Darlehen zu einem niedrigen Zinssatz an. Wenn Sie
interessiert sind, antworten Sie bitte an yingchon...@gmail.com, um
weitere Informationen zu erhalten.
Mit freundlichen Grüße
On Tue, 2020-09-01 at 22:16 +0200, Antoni Przybylik wrote:
> This approach is more elegant and prevents some problems related to
> macros such as operator precedence in expanded expression.
[]
> diff --git a/drivers/staging/gdm724x/gdm_tty.c
> b/drivers/staging/gdm724x/gdm_tty.c
[]
> @@ -36,6 +34,
Schöne Grüße,
Ich melde mich bei Ihnen, um in ein lukratives Geschäft in Ihrem Land zu
investieren.
Wir bieten ein schnelles Darlehen zu einem niedrigen Zinssatz an. Wenn
Sie interessiert sind, antworten Sie bitte an yingchon...@naver.com, um
weitere Informationen zu erhalten.
Mit freundlichen G
This approach is more elegant and prevents some problems related to
macros such as operator precedence in expanded expression.
---
Changed return type to bool and removed inline sepcifier.
Signed-off-by: Antoni Przybylik
---
drivers
This approach is more elegant and prevents some problems related to
macros such as operator precedence in expanded expression.
---
Changed return type to bool and removed inline sepcifier.
Signed-off-by: Antoni Przybylik
---
drivers
On Wed, Sep 02, 2020 at 03:25:59PM +0200, Antoni Przybylik wrote:
> This approach is more elegant and prevents some problems related to
> macros such as operator precedence in expanded expression.
> ---
> Changed return type to bool an
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and a warning of type mismatch with dumping enabled, i.e.,
$ make CFLAGS_MODULE="QL_ALL_DUMP=1 QL_OB_DUMP=1 QL_CB_DUMP=1 \
Q
On Thu, Aug 27, 2020 at 09:50:10AM +0900, Benjamin Poirier wrote:
On 2020-08-27 07:27 +0800, Coiby Xu wrote:
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and a warning o
On Wed, Sep 02, 2020 at 03:24:19PM +0200, Antoni Przybylik wrote:
> This approach is more elegant and prevents some problems related to
> macros such as operator precedence in expanded expression.
> ---
> Changed return type to bool an
Ein Vorschlag für Sie
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Sep 02, 2020 at 11:15:47AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: 4c6491a343e91a5a2a699b0b545f8ba1ec1e8c65
> commit: fbcfdfab4a2c4ec5e2195929528506fec39388f3 [62/88] staging: emxx_udc:
> Allo
In a number of places in emxx_udc.c, there are variables which are
assigned to without that value ever being used. Remove these pointless
assignments.
Reported-by: kernel test robot
Fixes: 33aa8d45a4fe ("staging: emxx_udc: Add Emma Mobile USB Gadget driver")
Signed-off-by: Alex Dewar
---
driver
There aren't much on this abstraction. Just move the defines
to isys_dma_private.h and isys_dma_public.h, cleaning up
the includes.
Signed-off-by: Mauro Carvalho Chehab
---
.../pci/css_2401_system/host/isys_dma.c | 10 +---
.../pci/css_2401_system/host/isys_dma_local.h | 21 -
.../
Reorder functions in order to declare before usage.
Signed-off-by: Mauro Carvalho Chehab
---
.../css_2401_system/host/pixelgen_private.h | 73 ++-
1 file changed, 37 insertions(+), 36 deletions(-)
diff --git
a/drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_pr
While I was lately relying on Jenkins to report smatch/sparse issues,
I discovered this week that the reports were missing such warnings
I got it fixed already at builder.linuxtv.org, but there are several new
warnings that got added over time.
This series is meant to solve the ones that are repo
There is a typedef for INPUT errors. This is different between
ISP2401 and ISP2400. Place both at the same struct, at the
global header file.
Signed-off-by: Mauro Carvalho Chehab
---
.../pci/css_2401_system/ibuf_ctrl_global.h| 2 +-
.../hive_isp_css_common/host/input_system.c | 56 +++
Due to that, smatch warns with:
drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:18:11:
warning: symbol 'N_SHORT_PACKET_LUT_ENTRIES' was not declared. Should it be
static?
drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:24:11:
warning: symbol 'N_
Now that there's no duplication between ISP2400 and ISP2401
input system functions, we can include both at the system
global.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/atomisp/pci/input_system_global.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git
There are several warnings reported by sparse with regards to wrong
typecasts:
drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c:73:13: warning:
incorrect type in assignment (different address spaces)
drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c:73:13:
expecte
Don't need to declare those functions with extern:
drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h:51:35:
warning: function 'isys_irqc_state_dump' with external linkage has definition
drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_priva
There are lots of code dependency there. Get rid of most of
them.
We can't remove everything, as there are some structs that
are conditionally built if ISP2401. So, keep ifdefs only
on such cases.
Signed-off-by: Mauro Carvalho Chehab
---
.../runtime/debug/interface/ia_css_debug.h| 6 -
..
Just move the stuff there to the places where this header is
included.
Signed-off-by: Mauro Carvalho Chehab
---
.../css_2401_system/host/ibuf_ctrl_local.h| 1 +
.../css_2401_system/host/ibuf_ctrl_private.h | 268 --
.../host/ibuf_ctrl_public.h | 94 -
Now that the defines which are common for both ISP2400 and ISP2401
are at system_global.h, we can get rid of the code not used by
those versions.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/media/atomisp/pci/ia_css_mipi.h | 2 -
.../staging/media/atomisp/pci/ia_css_stream.h | 4 +-
45 matches
Mail list logo
