Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-22 Thread Tomer Samara
On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > On 8/21/20 8:28 AM, Tomer Samara wrote: > > Remove BUG() from ion_sytem_heap.c > > > > this fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > recovery code ratherthan BUG() or BUG_ON(). > > >

[PATCH] media: staging/intel-ipu3: css: Correctly reset some memory

2020-08-22 Thread Christophe JAILLET
The intent here is to reset the whole 'scaler_coeffs_luma' array, not just the first element. Fixes: e0a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs") Signed-off-by: Christophe JAILLET --- drivers/staging/media/ipu3/ipu3-css-params.c | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-22 Thread Randy Dunlap
On 8/22/20 2:34 AM, Tomer Samara wrote: > On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: >> On 8/21/20 8:28 AM, Tomer Samara wrote: >>> Remove BUG() from ion_sytem_heap.c >>> >>> this fix the following checkpatch issue: >>> Avoid crashing the kernel - try using WARN_ON & >>> recovery

[PATCH v5 0/2] staging: android: Remove BUG/BUG_ON

2020-08-22 Thread Tomer Samara
Remove BUG/BUG_ON from androind/ion -v5: remove WARN_ON from ion_page_pool_free -v4: some changes based on Dan Carpenter review: - Remove error check at ion_page_pool_remove (conditions are impossible) - Remove error check at opn_page_pool_alloc - restore W

[PATCH v5 1/2] staging: android: Remove BUG_ON from ion_page_pool.c

2020-08-22 Thread Tomer Samara
BUG_ON() is removed at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/dri

[PATCH v5 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-22 Thread Tomer Samara
Remove BUG() from ion_sytem_heap.c this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] drivers: staging: comedi: fixed duplicate words from checkpatch

2020-08-22 Thread Ethan Edwards
Fixed various different checkpatch duplicate word warnings, the TODO file said to fix checkpatch warnings. My old email didn't CC the mailing lists, ignore the old one, sorry. Signed-off-by: Ethan Edwards --- drivers/staging/comedi/comedi.h | 4 ++-- drivers/staging/comedi/come

[PATCH] vme: ca91cx42: fix memleak in ca91cx42_dma_list_add

2020-08-22 Thread Dinghao Liu
When we encounter invalid data width or address space, entry should be freed just like what we've done in the previous error paths. Signed-off-by: Dinghao Liu --- drivers/vme/bridges/vme_ca91cx42.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/vme/bridges/vme