[PATCH 0/3] Replac BAG/BAG_ON with WARN/WARN_ON

2020-08-16 Thread Tomer Samara
This series convert BUGs/BUG_ONs to WARNs/WARN_ONs Tomer Samara (3): staging: androind: Replace BUG_ONs with WARN_ONs staging: androind: Add error handling to ion_page_pool_shrink staging: androind: Convert BUG() to WARN() drivers/staging/android/ion/ion_page_pool.c | 14 ++

[PATCH 2/3] staging: androind: Add error handling to ion_page_pool_shrink

2020-08-16 Thread Tomer Samara
Add error check to ion_page_pool_shrink after calling ion_page_pool_remove, due to converting BUG_ON to WARN_ON. Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion_page_pool.c b/driver

[PATCH 3/3] staging: androind: Convert BUG() to WARN()

2020-08-16 Thread Tomer Samara
replace BUG() with WARN() at ion_sytem_heap.c, this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 3 ++- 1 file changed, 2 insertions(

[PATCH 1/3] staging: androind: Replace BUG_ONs with WARN_ONs

2020-08-16 Thread Tomer Samara
BUG_ON() is replaced with WARN_ON at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 12 1 file changed, 8 insertions

Re: [PATCH 3/3] staging: androind: Convert BUG() to WARN()

2020-08-16 Thread Randy Dunlap
On 8/16/20 10:22 AM, Tomer Samara wrote: > replace BUG() with WARN() at ion_sytem_heap.c, this > fix the following checkpatch issue: > Avoid crashing the kernel - try using WARN_ON & > recovery code ratherthan BUG() or BUG_ON(). > > Signed-off-by: Tomer Samara > --- > drivers/staging/android/ion

Re: [PATCH 3/3] staging: androind: Convert BUG() to WARN()

2020-08-16 Thread Tomer Samara
On Sun, Aug 16, 2020 at 10:34:50AM -0700, Randy Dunlap wrote: > On 8/16/20 10:22 AM, Tomer Samara wrote: > > replace BUG() with WARN() at ion_sytem_heap.c, this > > fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > recovery code ratherthan BUG() or BUG_ON()

Re: [PATCH 1/3] staging: androind: Replace BUG_ONs with WARN_ONs

2020-08-16 Thread kernel test robot
Hi Tomer, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[PATCH v2 0/4] Replace BUG/BUG_ON to WARN/WARN_ON

2020-08-16 Thread Tomer Samara
This series convert BUGs/BUG_ONs to WARNs/WARN_ONs Tomer Samara (4): staging: android: Replace BUG_ON with WARN_ON staging: android: Add error handling to ion_page_pool_shrink staging: android: Convert BUG to WARN staging: android: Add error handling to order_to_index callers drivers/s

Re: [PATCH 1/3] staging: androind: Replace BUG_ONs with WARN_ONs

2020-08-16 Thread kernel test robot
Hi Tomer, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON

2020-08-16 Thread Tomer Samara
BUG_ON() is replaced with WARN_ON at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 12 1 file changed, 8 insertions

[PATCH v2 2/4] staging: android: Add error handling to ion_page_pool_shrink

2020-08-16 Thread Tomer Samara
Add error check to ion_page_pool_shrink after calling ion_page_pool_remove, due to converting BUG_ON to WARN_ON. Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion_page_pool.c b/driver

[PATCH v2 3/4] staging: android: Convert BUG to WARN

2020-08-16 Thread Tomer Samara
replace BUG() with WARN() at ion_sytem_heap.c, this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 3 ++- 1 file changed, 2 insertions(

[PATCH v2 4/4] staging: android: Add error handling to order_to_index callers

2020-08-16 Thread Tomer Samara
Add error check to: - free_buffer_page - alloc_buffer_page after calling order_to_index, due to converting BUG to WARN at order_to_index. Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] staging: androind: Replace BUG_ONs with WARN_ONs

2020-08-16 Thread kernel test robot
Hi Tomer, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.9-rc1 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docume

[PATCH] staging: rtl8723bs: fix coding style

2020-08-16 Thread Injae Kang
Fix coding style of core/rtw_cmd.c Signed-off-by: Injae Kang --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 168 +++ 1 file changed, 79 insertions(+), 89 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index bd18